cjdb added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4009-4011
+    if (StringRef(A->getValue()) == "sarif") {
+      D.Diag(diag::warn_drv_sarif_format_unstable);
+    }
----------------
aaron.ballman wrote:
> Do we want to be kind to people who spell it SARIF (given that it's an 
> acronym, some folks may spell it that way reflexively)?
tbh I think it's worth accepting both `sarif` and `SARIF`, if we can.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129886/new/

https://reviews.llvm.org/D129886

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to