erichkeane added a comment. I'll note that I don't "like" the idea, so much as I see this patch as an 'improvement' to unblock efforts with additional value, though not much of one. I suspect as Aaron does that there is a significant problem that needs fixing here with how our serialization works, and that we should be putting effort into fixing that.
As far as THIS patch, I would be OK with 'holding my nose' and accepting it short-term so we can get Module-ized versions of the STL into clang-15, but only if someone was still actively working ot figure out our serialization problem, and only if Tom/Aaron are OK holding their nose as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129748/new/ https://reviews.llvm.org/D129748 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
