[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

ChuanqiXu added a comment. @iains may I ask what's the issue to not land this? It looks like you're waiting for the behavior to be consistency with GCC? Since this patch could fix https://github.com/llvm/llvm-project/issues/51873, which breaks the users to compile a hello world example. Repos

[clang] b646f09 - [clang-format] Fix misplacement of `*` in declaration of pointer to struct

Author: Huang Zhen-Hong Date: 2022-06-29T15:21:02+08:00 New Revision: b646f0955574c6ad4c156c9db522e46f597cfda9 URL: https://github.com/llvm/llvm-project/commit/b646f0955574c6ad4c156c9db522e46f597cfda9 DIFF: https://github.com/llvm/llvm-project/commit/b646f0955574c6ad4c156c9db522e46f597cfda9.dif

[PATCH] D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb646f0955574: [clang-format] Fix misplacement of `*` in declaration of pointer to struct (authored by Huang Zhen-Hong , com

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

iains added a comment. In D126189#3617850 , @ChuanqiXu wrote: > @iains may I ask what's the issue to not land this? It looks like you're > waiting for the behavior to be consistency with GCC? > > Since this patch could fix https://github.com/llvm/llvm-pr

[PATCH] D128612: RISC-V big-endian support implementation

jhenderson added a comment. Objcopy aspects look good, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128612/new/ https://reviews.llvm.org/D128612 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang] b405407 - [clang][flang] Disable defaulting to `-fpie` for LLVM Flang

Author: Andrzej Warzynski Date: 2022-06-29T07:53:06Z New Revision: b405407a489902c0acfcf936bfda9821a1deb170 URL: https://github.com/llvm/llvm-project/commit/b405407a489902c0acfcf936bfda9821a1deb170 DIFF: https://github.com/llvm/llvm-project/commit/b405407a489902c0acfcf936bfda9821a1deb170.diff

[PATCH] D128333: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang

This revision was automatically updated to reflect the committed changes. Closed by commit rGb405407a4899: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang (authored by awarzynski). Changed prior to commit: https://reviews.llvm.org/D128333?vs=440874&id=440884#toc Repository: rG LL

[PATCH] D128783: Check for more -fsanitize=array-bounds regressions

MaskRay added a comment. Do we need a C test (just add a `-x c` RUN line)? @serge-sans-paille Do you think we may likely make C++ stricter than C? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128783/new/ https://reviews.llvm.org/D128783

[PATCH] D128645: Update developer policy.

vext01 added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:88 +#. Patches should be unified diffs with "infinite context" (i.e. using something + like `git diff -U99 main`). + hubert.reinterpretcast wrote: > Using `git diff` like this, there a

[PATCH] D128645: Update developer policy.

vext01 updated this revision to Diff 440887. vext01 added a comment. Fixed grammar bits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128645/new/ https://reviews.llvm.org/D128645 Files: llvm/docs/DeveloperPolicy.rst Index: llvm/docs/DeveloperPolicy.rst

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

nemanjai added a comment. I am ok with this change overall, I just have a couple of questions about naming of the option. 1. Is there any precedent for options that start with `-maix` or `-m` for any other OS? 2. Is `quadword` the best word to use? There is no type information and this is rest

[PATCH] D128612: RISC-V big-endian support implementation

MaskRay added a comment. lld/ELF change should be dropped from this change. Don't use `config->endianness`. I feel sad that for little-endian users who don't use big-endian, every write now is slightly slower due to a check ;-) Comment at: clang/lib/Basic/Targets/RISCV.cpp:12

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

lkail added a comment. > Is there any precedent for options that start with -maix or -m for any > other OS? There is `-maix-struct-return`. > Is quadword the best word to use? There is no type information and this is > restricted to integers. Would something like -maix-i128-atomics be a better

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo added a comment. In D105584#3617666 , @clementval wrote: > In D105584#3617456 , > @abidmalikwaterloo wrote: > >> // CHECK-LABEL: omp_DistributeOp >> func.func @omp_DistributeOp(%lb : index,

[PATCH] D128679: [pseudo] Define a clangPseudoCLI library.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/pseudo/benchmarks/Benchmark.cpp:51 const std::string *SourceText = nullptr; -const Grammar *G = nullptr; +const Language *PLang = nul

[PATCH] D128652: [PowerPC] Finished kill_canary implementation and debugging

nemanjai added a comment. "Made a new phabricator review because of git issues" is not an appropriate description of a review/revision. Hopefully the description you add will describe what this intrinsic is supposed to do. It seems to me that this is a poorly designed feature if it is meant to

[PATCH] D128329: [clangd] Also mark output arguments of operator call expressions

ckandeler added a comment. In D128329#3617172 , @nridge wrote: > I'm going to take the liberty of approving this, as it seems straightforward > and unlikely to be contentious in any way. Thanks! > Please let me know if you need me to commit it. Yes, p

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

sammccall added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:478 bool shouldHintReference(const ParmVarDecl *Param) { -// If the parameter is a non-const reference type, print an inlay hint +// If the parameter is of non-const l-value reference

[PATCH] D128612: RISC-V big-endian support implementation

gbenyei added a comment. In D128612#3617906 , @jhenderson wrote: > Objcopy aspects look good, thanks. Thanks Comment at: llvm/lib/ExecutionEngine/JITLink/ELF_riscv.cpp:554 .buildGraph(); - } else { -assert((*ELFObj)->ge

[PATCH] D128612: RISC-V big-endian support implementation

gbenyei added a comment. In D128612#3617955 , @MaskRay wrote: > lld/ELF change should be dropped from this change. Don't use > `config->endianness`. > I feel sad that for little-endian users who don't use big-endian, every write > now is slightly slower

[PATCH] D124748: [clang-format] Fix whitespace counting stuff

kevcadieux added a comment. @sstwcw @HazardyKnusperkeks : this change introduced a regression in one of the clang format unit tests. I fixed it in the revision below. Could anyone please take a look / approve this revision to unblock Windows debug builds? Thanks! https://reviews.llvm.org/D12878

[PATCH] D128786: [clang-format] Fix incorrect isspace input (NFC)

kevcadieux added a comment. FYI: failure looks like the following: [ RUN ] FormatTest.IncorrectUnbalancedBracesInMacrosWithUnicode Exception Code: 0x8003 #0 0x7ffe4253fc44 (C:\WINDOWS\SYSTEM32\ucrtbased.dll+0x7fc44) #1 0x7ffe4254a379 (C:\WINDOWS\SYSTEM32\ucrtbased.dll+0

[PATCH] D128795: [pseudo] Reimplement hardcoded error handling as a recovery strategy. NFC

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo https://reviews.llvm

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

cor3ntin updated this revision to Diff 440912. cor3ntin added a comment. - fix typo - add decompositions tests for the array and tuuple cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://reviews.llvm.org/D122768 Files: clang

[PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

iains updated this revision to Diff 440915. iains marked an inline comment as done. iains added a comment. rebased after D113545 was landed and removed that as a parent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

iains added inline comments. Comment at: clang/include/clang/AST/DeclBase.h:624 bool isModulePrivate() const { return getModuleOwnershipKind() == ModuleOwnershipKind::ModulePrivate; } ChuanqiXu wrote: > According to the opinion from @rsmith, the discar

[clang] 32aac7b - [NFC] Switch FloatModeKind enum class to use bitmask enums

Author: Jolanta Jensen Date: 2022-06-29T11:02:02+01:00 New Revision: 32aac7babfdd2a7e6d40cb186d676bef93bfc6bb URL: https://github.com/llvm/llvm-project/commit/32aac7babfdd2a7e6d40cb186d676bef93bfc6bb DIFF: https://github.com/llvm/llvm-project/commit/32aac7babfdd2a7e6d40cb186d676bef93bfc6bb.diff

[PATCH] D128182: [NFC] Switch FloatModeKind enum class to use bitmask enums

This revision was automatically updated to reflect the committed changes. Closed by commit rG32aac7babfdd: [NFC] Switch FloatModeKind enum class to use bitmask enums (authored by jolanta.jensen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128182/n

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

upsj updated this revision to Diff 440921. upsj marked 14 inline comments as done. upsj added a comment. - simplify parameter pack detection - improve function naming - make handling of unexpanded packs and varargs more visible - add tests involving template specializations - make documentation mo

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

upsj added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:690 +getPackTemplateParameter(const FunctionDecl *Callee) { + if (const auto *TemplateDecl = Callee->getPrimaryTemplate()) { +auto TemplateParams = TemplateDecl->getTemplateParameters()->asArray();

[clang] 4ee6b78 - [test][RISCV][Driver] Precommit tests for D128625

Author: Anton Afanasyev Date: 2022-06-29T13:25:56+03:00 New Revision: 4ee6b7806bc04e3d037c0679260a54828ce7ad4c URL: https://github.com/llvm/llvm-project/commit/4ee6b7806bc04e3d037c0679260a54828ce7ad4c DIFF: https://github.com/llvm/llvm-project/commit/4ee6b7806bc04e3d037c0679260a54828ce7ad4c.dif

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

iains updated this revision to Diff 440924. iains added a comment. rebased, corrected some spellings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126189/new/ https://reviews.llvm.org/D126189 Files: clang/include/clang/AST/ASTContext.h clang/

[PATCH] D128486: [pseudo] Add error-recovery framework & brace-based recovery

hokein added a comment. the patch looks a good start to me, some initial comments (mostly around the recovery part). Comment at: clang-tools-extra/pseudo/include/clang-pseudo/GLR.h:150 +// OldHeads is the parse state at TokenIndex. +// This function consumes consumes zero or m

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

iains added a comment. In D126189#3598568 , @urnathan wrote: > please sed /initialiser/initializer/, I noticed a few had crept in. should be done now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126189/n

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

sammccall accepted this revision. sammccall added a comment. Thanks for the readability improvements! I've forgotten if you have commit access? This stuff is complicated and I'm definitely going to forget the reasoning, the intuitive explanations are going to help a lot if changes are needed in

[clang] 9d2e830 - [analyzer] Fix BindingDecl evaluation for reference types

Author: isuckatcs Date: 2022-06-29T13:01:19+02:00 New Revision: 9d2e830737bcf8035cf263e4b4cb279b7b07cf24 URL: https://github.com/llvm/llvm-project/commit/9d2e830737bcf8035cf263e4b4cb279b7b07cf24 DIFF: https://github.com/llvm/llvm-project/commit/9d2e830737bcf8035cf263e4b4cb279b7b07cf24.diff LOG

[PATCH] D128716: [analyzer] Fix BindingDecl evaluation for reference types.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d2e830737bc: [analyzer] Fix BindingDecl evaluation for reference types (authored by isuckatcs). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorep

[PATCH] D128679: [pseudo] Define a clangPseudoCLI library.

hokein updated this revision to Diff 440929. hokein marked an inline comment as done. hokein added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128679/new/ https://reviews.llvm.org/D128679 Files: clang-tools-e

[PATCH] D128679: [pseudo] Define a clangPseudoCLI library.

hokein added inline comments. Comment at: clang-tools-extra/pseudo/benchmarks/Benchmark.cpp:51 const std::string *SourceText = nullptr; -const Grammar *G = nullptr; +const Language *PLang = nullptr; sammccall wrote: > nit: still PLang here and in a bunch of pl

[PATCH] D128805: [pseudo] Fix bugs/inconsistencies in forest dump.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. - when printing a shared node for the second time, don't pr

[PATCH] D128679: [pseudo] Define a clangPseudoCLI library.

sammccall accepted this revision. sammccall added a comment. Looks good! Comment at: clang-tools-extra/pseudo/include/clang-pseudo/Language.h:21 + Grammar G; + LRTable Table; + LR might be more distinguishing (and shorter!), up to you Repository: rG LLVM

[clang-tools-extra] 333620d - [clangd] Support multiline semantic tokens

Author: Kadir Cetinkaya Date: 2022-06-29T13:49:03+02:00 New Revision: 333620d37a26949e9f66c823425cf9a2065e3890 URL: https://github.com/llvm/llvm-project/commit/333620d37a26949e9f66c823425cf9a2065e3890 DIFF: https://github.com/llvm/llvm-project/commit/333620d37a26949e9f66c823425cf9a2065e3890.dif

[PATCH] D127856: [clangd] Support multiline semantic tokens

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG333620d37a26: [clangd] Support multiline semantic tokens (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

upsj marked an inline comment as done. upsj added a comment. yes, I have commit access Comment at: clang-tools-extra/clangd/InlayHints.cpp:483 + !Type.getNonReferenceType().isConstQualified() && + !isExpandedParameterPack(Param); } sammcc

[PATCH] D128807: [clang][transformer] Finish plumbing `Note` all the way to the output.

courbet created this revision. courbet added a reviewer: ymandel. Herald added a subscriber: carlosgalvezp. Herald added a project: All. courbet requested review of this revision. Herald added projects: clang, clang-tools-extra. Right now we can only add a single warning, notes are not possible.

[PATCH] D128807: [clang][transformer] Finish plumbing `Note` all the way to the output.

courbet updated this revision to Diff 440948. courbet added a comment. Format patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128807/new/ https://reviews.llvm.org/D128807 Files: clang-tools-extra/clang-tidy/utils/TransformerClangTidyCheck.cp

[PATCH] D128774: [libTooling] Add a comment about comment parsing to getAssociatedRange.

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128774/new/ https://reviews.llvm.org/D128774 ___

[PATCH] D128774: [libTooling] Add a comment about comment parsing to getAssociatedRange.

ymandel added inline comments. Comment at: clang/include/clang/Tooling/Transformer/SourceCode.h:47 +/// range containing associated comments, you may need to invoke the tool with +/// -fparse-all-comments. CharSourceRange getAssociatedRange(const Decl &D, ASTContext &Context); -

[PATCH] D128766: Update references to Discourse instead of the mailing lists.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with some minor corrections. Thank you for this! Comment at: clang/docs/ExternalClangExamples.rst:21 -If you know of (or wrote!) a tool or project using

[PATCH] D128706: [Clang] Disable clang-format entirely for clang/test tree.

aaron.ballman added a comment. Should we also do `llvm/test` and `clang-tools-extra/test` at the same time? The LLVM tests will show up in precommit CI, but I'm not certain that precommit CI actually tests clang-tools-extra (it also notably lacks coverage for libc++ and lldb as well). Reposit

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

serge-sans-paille updated this revision to Diff 440942. serge-sans-paille added a subscriber: chandlerc. serge-sans-paille added a comment. Code updated to take into account two situations: - size resulting from macro expansion. Previous behavior was inconsistent in that situation. I chose to co

[PATCH] D125944: Template instantiation error recovery

Purva-Chaudhari updated this revision to Diff 440959. Purva-Chaudhari added a comment. Added new file for template test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125944/new/ https://reviews.llvm.org/D125944 Files: clang/include/clang/Sema/Sema.h clang/lib/Interpreter/Incrementa

[PATCH] D128747: ISSUE - incorrect -Winfinite-recursion warning on potentially-unevaluated operand #21668

aaron.ballman added a comment. Thank you for this fix, it's coming along well! Can you also add a release note to `clang/docs/ReleaseNotes.rst` mentioning the fix? Comment at: clang/lib/Analysis/CFG.cpp:4062 + // operand. [...] + // We add only potentially evaluated statem

[clang] 64ab2b1 - Improve handling of static assert messages.

Author: Corentin Jabot Date: 2022-06-29T14:57:35+02:00 New Revision: 64ab2b1dcc5136a744fcac21d3d2c59e9cce040a URL: https://github.com/llvm/llvm-project/commit/64ab2b1dcc5136a744fcac21d3d2c59e9cce040a DIFF: https://github.com/llvm/llvm-project/commit/64ab2b1dcc5136a744fcac21d3d2c59e9cce040a.diff

[PATCH] D108469: Improve handling of static assert messages.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG64ab2b1dcc51: Improve handling of static assert messages. (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128812: [pseudo] prototype build syntax-tree from the parse forest.

hokein created this revision. Herald added a subscriber: mgorny. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added projects: clang, clang-tools-extra. WARNING: this is an extremely-hacked prototype. Repository

[PATCH] D128762: [Clang] Rename StringLiteral::isAscii() => isOrdinary() [NFC]

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Expr.h:1789-1886 + enum StringKind { Ordinary, Wide, UTF8, UTF16, UTF32 }; private: unsigned numTrailingObjects(OverloadToken) const { return 1; } unsigned numTrailingObjects(OverloadToken) const {

[PATCH] D128762: [Clang] Rename StringLiteral::isAscii() => isOrdinary() [NFC]

aaron.ballman added a comment. Also, precommit CI pointed out that you need to make some additional changes in clang-tools-extra to avoid build errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128762/new/ https://reviews.llvm.org/D128762 ___

[PATCH] D128814: [Clang][Preprocessor] Fix inconsistent `FLT_EVAL_METHOD` when compiling vs preprocessing

egorzhdan created this revision. egorzhdan added a reviewer: zahiraam. Herald added a project: All. egorzhdan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When running `clang -E -Ofast` on macOS, the `__FLT_EVAL_METHOD__` macro is `0`,

[clang-tools-extra] 1ba7f52 - [pseudo] Update the cxx.bnf path in comments to reflect the new

Author: Haojian Wu Date: 2022-06-29T15:10:39+02:00 New Revision: 1ba7f5218ccdc0b4fd836cb4f0d647866f793c87 URL: https://github.com/llvm/llvm-project/commit/1ba7f5218ccdc0b4fd836cb4f0d647866f793c87 DIFF: https://github.com/llvm/llvm-project/commit/1ba7f5218ccdc0b4fd836cb4f0d647866f793c87.diff LO

[PATCH] D128814: [Clang][Preprocessor] Fix inconsistent `FLT_EVAL_METHOD` when compiling vs preprocessing

egorzhdan updated this revision to Diff 440978. egorzhdan added a comment. Adjust commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128814/new/ https://reviews.llvm.org/D128814 Files: clang/lib/Lex/Preprocessor.cpp clang/lib/Sema/Se

[PATCH] D125944: Template instantiation error recovery

Purva-Chaudhari updated this revision to Diff 440980. Purva-Chaudhari added a comment. File name CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125944/new/ https://reviews.llvm.org/D125944 Files: clang/include/clang/Sema/Sema.h clang/lib/Interpreter/IncrementalParser.cpp clang/tes

[PATCH] D128816: [OpenMP] Add loop tripcount argument to kernel launch and remove push function

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield, ABataev. Herald added subscribers: mattd, asavonic, guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sste

[PATCH] D128783: [test] Check for more -fsanitize=array-bounds regressions

serge-sans-paille added a comment. In D128783#3617924 , @MaskRay wrote: > Do we need a C test (just add a `-x c` RUN line)? @serge-sans-paille Do you > think we may likely make C++ stricter than C? I've started a similar discussion on https://reviews.ll

[PATCH] D128783: [test] Check for more -fsanitize=array-bounds regressions

serge-sans-paille added a comment. And note that with current clang, the behavior I describe here is not uniform across clang code base :-/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128783/new/ https://reviews.llvm.org/D128783 ___

[PATCH] D128805: [pseudo] Fix bugs/inconsistencies in forest dump.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/pseudo/unittests/ForestTest.cpp:138 + + const auto *B = &Arena.createSequence(symbol("B"), ruleFor("B"), {Star}); + const auto *A1 = &Aren

[clang] 56ab966 - [CUDA] Stop adding CUDA features twice

Author: Joseph Huber Date: 2022-06-29T09:34:09-04:00 New Revision: 56ab966a04dd22570fcb18276e2409c94e82c571 URL: https://github.com/llvm/llvm-project/commit/56ab966a04dd22570fcb18276e2409c94e82c571 DIFF: https://github.com/llvm/llvm-project/commit/56ab966a04dd22570fcb18276e2409c94e82c571.diff

[PATCH] D128752: [CUDA] Stop adding CUDA features twice

This revision was automatically updated to reflect the committed changes. Closed by commit rG56ab966a04dd: [CUDA] Stop adding CUDA features twice (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128752/new/ https://reviews.llvm.o

[PATCH] D128795: [pseudo] Reimplement hardcoded error handling as a recovery strategy. NFC

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/grammar/Grammar.h:89 // FIXME: these should be provided as extensions instead. -enum class RecoveryStrategy : u

[PATCH] D128103: Adds AST Matcher for ObjCStringLiteral

aaron.ballman added a comment. The only things left to do are: regenerate the documentation by running clang/docs/tools/dump_ast_matchers.py and add a release note for the new matcher, but otherwise this looks good to me. In D128103#3617156 , @NoQ wrote

[clang] f382545 - [clang-cl] Handle some pragma alloc_text corner cases handled by MSVC

Author: Stephen Long Date: 2022-06-29T06:45:59-07:00 New Revision: f382545b2ba8a39435f7efa02dadc722c429d2cd URL: https://github.com/llvm/llvm-project/commit/f382545b2ba8a39435f7efa02dadc722c429d2cd DIFF: https://github.com/llvm/llvm-project/commit/f382545b2ba8a39435f7efa02dadc722c429d2cd.diff

[PATCH] D128649: [clang-cl] Handle some pragma alloc_text corner cases handled by MSVC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf382545b2ba8: [clang-cl] Handle some pragma alloc_text corner cases handled by MSVC (authored by steplong). Repository: rG LLVM Github Monorepo C

[PATCH] D128726: [RISCV][NFC] Move static global variables into static variable in function.

kito-cheng added a comment. My understanding is the reason why no global variable is because 1. the initialization order and 2. might increase the launch time of programs, moving that into function scope could resolve both issue: 1. initialized in deterministic order[1], 2. Initialized that whe

[PATCH] D123952: [FPEnv] Allow CompoundStmt to keep FP options

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM modulo the rename request. Comment at: clang/lib/AST/Stmt.cpp:370-371 setStmts(Stmts); + if (hasStoredFPFeatures()) +setStoredFPFeatures(FPFeatures

[PATCH] D128726: [RISCV][NFC] Move static global variables into static variable in function.

jrtc27 added a comment. Seems you're right, the C++11 standard does clearly say (9.7p4): > Dynamic initialization of a block-scope variable with static storage duration > (6.6.4.1) or thread storage duration (6.6.4.2) is performed the first time > control passes through its declaration; such a

[PATCH] D128762: [Clang] Rename StringLiteral::isAscii() => isOrdinary() [NFC]

cor3ntin updated this revision to Diff 440994. cor3ntin added a comment. Herald added subscribers: carlosgalvezp, usaxena95, kadircet, arphaman. Herald added a project: clang-tools-extra. - fix clang-tidy build - apply the same change in StringLiteralParser/CharLiteralParser Repository: rG LLV

[PATCH] D128499: [Clang] Fix: Restore warning inadvertently removed by D126061.

miyuki added a comment. Thanks for fixing the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128499/new/ https://reviews.llvm.org/D128499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D128762: [Clang] Rename StringLiteral::isAscii() => isOrdinary() [NFC]

cor3ntin added inline comments. Comment at: clang/include/clang/AST/Expr.h:1789-1886 + enum StringKind { Ordinary, Wide, UTF8, UTF16, UTF32 }; private: unsigned numTrailingObjects(OverloadToken) const { return 1; } unsigned numTrailingObjects(OverloadToken) const {

[PATCH] D128821: [clangd][ObjC] Fix ObjC method definition completion

dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-

[PATCH] D128747: ISSUE - incorrect -Winfinite-recursion warning on potentially-unevaluated operand #21668

appmonster007 updated this revision to Diff 440992. appmonster007 added a comment. inserted bullet point for `-Winfinite-recursion` diagnostics fix, where diagnostic will not warn for unevaluated operands of ``typeid`` expression, under "Improvements to Clang’s diagnostics" in clang/docs/Release

[PATCH] D128747: ISSUE - incorrect -Winfinite-recursion warning on potentially-unevaluated operand #21668

appmonster007 updated this revision to Diff 440997. appmonster007 marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128747/new/ https://reviews.llvm.org/D128747 Files: clang/docs/ReleaseNotes.rst clang/lib/Analysis/

[PATCH] D128747: ISSUE - incorrect -Winfinite-recursion warning on potentially-unevaluated operand #21668

appmonster007 updated this revision to Diff 440999. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128747/new/ https://reviews.llvm.org/D128747 Files: clang/docs/ReleaseNotes.rst clang/lib/Analysis/CFG.cpp clang/test/SemaCXX/warn-infinite-recur

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

sammccall added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:483 + !Type.getNonReferenceType().isConstQualified() && + !isExpandedParameterPack(Param); } upsj wrote: > sammccall wrote: > > upsj wrote: > > > sammccall

[PATCH] D128821: [clangd][ObjC] Fix ObjC method definition completion

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Ah, this is subtle. Thanks! Comment at: clang-tools-extra/clangd/CodeComplete.cpp:866 case CodeCompletionResult::RK_Pattern: - return Result.Pattern->getTyped

[PATCH] D128747: ISSUE - incorrect -Winfinite-recursion warning on potentially-unevaluated operand #21668

appmonster007 updated this revision to Diff 441005. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128747/new/ https://reviews.llvm.org/D128747 Files: clang/docs/ReleaseNotes.rst clang/lib/Analysis/CFG.cpp clang/test/SemaCXX/warn-infinite-recur

[PATCH] D128288: [PowerPC] Fix signatures for vec_replace_unaligned builtin

This revision was automatically updated to reflect the committed changes. Closed by commit rGcaf7243a6b53: [PowerPC] Fix signatures for vec_replace_unaligned builtin (authored by lei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128288/new/ https:

[clang] caf7243 - [PowerPC] Fix signatures for vec_replace_unaligned builtin

Author: Lei Huang Date: 2022-06-29T09:35:52-05:00 New Revision: caf7243a6b53aa16f9fbdfbaa18096defb2eb374 URL: https://github.com/llvm/llvm-project/commit/caf7243a6b53aa16f9fbdfbaa18096defb2eb374 DIFF: https://github.com/llvm/llvm-project/commit/caf7243a6b53aa16f9fbdfbaa18096defb2eb374.diff LOG

[PATCH] D128826: Go-to-type on smart_ptr now also shows Foo

tom-anders created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. tom-anders requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang-tools-extra. Fixes clangd/clangd#1026 Reposito

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

msebor added a comment. In D126864#3616524 , @serge-sans-paille wrote: > GCC and Clang don't have the same behavior wrt. macros-as-abound and > standard-layout-requirement, see https://godbolt.org/z/3vc4TcTYz > I'm fine with keeping the CLang behavior,

[PATCH] D128826: Go-to-type on smart_ptr now also shows Foo

tom-anders added inline comments. Comment at: clang-tools-extra/clangd/HeuristicResolver.h:75 + // could look up the name appearing on the RHS. + const Type *getPointeeType(const Type *T) const; + Not sure if it's the right call to make this public? The documen

[PATCH] D128826: Go-to-type on smart_ptr now also shows Foo

sammccall added a comment. Thanks! I just have a question if this behavior should be even "stronger": In most editors, if you return one result you go straight there, if you return two results you get a menu. A menu is significantly worse than going straight to the right result - the UI is clun

[PATCH] D128826: Go-to-type on smart_ptr now also shows Foo

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/HeuristicResolver.h:75 + // could look up the name appearing on the RHS. + const Type *getPointeeType(const Type *T) const; +

[PATCH] D128826: Go-to-type on smart_ptr now also shows Foo

sammccall requested changes to this revision. sammccall added a comment. This revision now requires changes to proceed. Sorry, I didn't mean to accept yet - wanted some discussion on behavior & probably a unittest for the newly-public function. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

aaron.ballman added a comment. In D127762#3615702 , @sdesmalen wrote: > Thanks for your patience reviewing this patch @aaron.ballman! Happy to help, thank you for your patience with my constant stream of questions about the design. :-) ==

[PATCH] D128747: ISSUE - incorrect -Winfinite-recursion warning on potentially-unevaluated operand #21668

appmonster007 updated this revision to Diff 441014. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128747/new/ https://reviews.llvm.org/D128747 Files: clang/docs/ReleaseNotes.rst clang/lib/Analysis/CFG.cpp clang/test/SemaCXX/warn-infinite-recur

[PATCH] D122255: Meta directive runtime support

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:8859 +/// \code +/// #pragma omp metadirective when(user={consition(N<100)}:parallel for) +/// \endcode condition? Comment at: clang/include/clang/AST/OpenMPClaus

[PATCH] D128704: [clang-extdef-mapping] Directly process .ast files

thieta added inline comments. Comment at: clang/tools/clang-extdef-mapping/ClangExtDefMapGen.cpp:136 + FileManager fm(CI.getFileSystemOpts()); + SmallString<128> absPath(astPath); + fm.makeAbsolutePath(absPath); thieta wrote: > Pretty sure 128 is wrong here -

[PATCH] D128786: [clang-format] Fix incorrect isspace input (NFC)

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128786/new/ https://reviews.llvm.org/D128786 ___

[PATCH] D128762: [Clang] Rename StringLiteral::isAscii() => isOrdinary() [NFC]

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Assuming precommit CI comes back clean, this LGTM! Comment at: clang/include/clang/AST/Expr.h:1789-1886 + enum StringKind { Ordinary, Wide, UTF8, UTF16, UTF32

[PATCH] D126956: [tbaa] Handle base classes in struct tbaa

brunodf updated this revision to Diff 441017. brunodf added a comment. Herald added a subscriber: mgrang. New version that fixes the problem with base classes not appearing in order of increasing offset. This issue was discovered in the multistage build, but the test case has now been extended

  1   2   3   >