jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield, ABataev. Herald added subscribers: mattd, asavonic, guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM.
Previously we added the `push_target_tripcount` function to send the loop tripcount to the device runtime so we knew how to configure the teams / threads for execute the loop for a teams distribute construct. This was implemented as a separate function mostly to avoid changing the interface for backwards compatbility. Now that we've changed it anyway and the new interface can take an arbitrary number of arguments via the struct without changing the ABI, we can move this to the new interface. This will simplify the runtime by removing unnecessary state between calls. Depends on D128550 <https://reviews.llvm.org/D128550> Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D128816 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRuntime.h clang/test/OpenMP/distribute_codegen.cpp clang/test/OpenMP/distribute_firstprivate_codegen.cpp clang/test/OpenMP/distribute_lastprivate_codegen.cpp clang/test/OpenMP/distribute_parallel_for_codegen.cpp clang/test/OpenMP/distribute_parallel_for_firstprivate_codegen.cpp clang/test/OpenMP/distribute_parallel_for_if_codegen.cpp clang/test/OpenMP/distribute_parallel_for_lastprivate_codegen.cpp clang/test/OpenMP/distribute_parallel_for_num_threads_codegen.cpp clang/test/OpenMP/distribute_parallel_for_private_codegen.cpp clang/test/OpenMP/distribute_parallel_for_proc_bind_codegen.cpp clang/test/OpenMP/distribute_parallel_for_simd_codegen.cpp clang/test/OpenMP/distribute_parallel_for_simd_firstprivate_codegen.cpp clang/test/OpenMP/distribute_parallel_for_simd_if_codegen.cpp clang/test/OpenMP/distribute_parallel_for_simd_lastprivate_codegen.cpp clang/test/OpenMP/distribute_parallel_for_simd_num_threads_codegen.cpp clang/test/OpenMP/distribute_parallel_for_simd_private_codegen.cpp clang/test/OpenMP/distribute_parallel_for_simd_proc_bind_codegen.cpp clang/test/OpenMP/distribute_private_codegen.cpp clang/test/OpenMP/distribute_simd_codegen.cpp clang/test/OpenMP/distribute_simd_firstprivate_codegen.cpp clang/test/OpenMP/distribute_simd_lastprivate_codegen.cpp clang/test/OpenMP/distribute_simd_private_codegen.cpp clang/test/OpenMP/distribute_simd_reduction_codegen.cpp clang/test/OpenMP/nvptx_lambda_capturing.cpp clang/test/OpenMP/reduction_implicit_map.cpp clang/test/OpenMP/target_codegen_global_capture.cpp clang/test/OpenMP/target_map_codegen_03.cpp clang/test/OpenMP/target_map_codegen_hold.cpp clang/test/OpenMP/target_offload_mandatory_codegen.cpp clang/test/OpenMP/target_parallel_codegen.cpp clang/test/OpenMP/target_parallel_for_codegen.cpp clang/test/OpenMP/target_parallel_for_simd_codegen.cpp clang/test/OpenMP/target_parallel_if_codegen.cpp clang/test/OpenMP/target_parallel_num_threads_codegen.cpp clang/test/OpenMP/target_teams_codegen.cpp clang/test/OpenMP/target_teams_distribute_codegen.cpp clang/test/OpenMP/target_teams_distribute_collapse_codegen.cpp clang/test/OpenMP/target_teams_distribute_dist_schedule_codegen.cpp clang/test/OpenMP/target_teams_distribute_firstprivate_codegen.cpp clang/test/OpenMP/target_teams_distribute_lastprivate_codegen.cpp clang/test/OpenMP/target_teams_distribute_parallel_for_codegen.cpp clang/test/OpenMP/target_teams_distribute_parallel_for_collapse_codegen.cpp clang/test/OpenMP/target_teams_distribute_parallel_for_dist_schedule_codegen.cpp clang/test/OpenMP/target_teams_distribute_parallel_for_firstprivate_codegen.cpp clang/test/OpenMP/target_teams_distribute_parallel_for_if_codegen.cpp clang/test/OpenMP/target_teams_distribute_parallel_for_lastprivate_codegen.cpp clang/test/OpenMP/target_teams_distribute_parallel_for_order_codegen.cpp clang/test/OpenMP/target_teams_distribute_parallel_for_private_codegen.cpp clang/test/OpenMP/target_teams_distribute_parallel_for_proc_bind_codegen.cpp clang/test/OpenMP/target_teams_distribute_parallel_for_reduction_codegen.cpp clang/test/OpenMP/target_teams_distribute_parallel_for_schedule_codegen.cpp clang/test/OpenMP/target_teams_distribute_parallel_for_simd_codegen.cpp clang/test/OpenMP/target_teams_distribute_parallel_for_simd_collapse_codegen.cpp clang/test/OpenMP/target_teams_distribute_parallel_for_simd_dist_schedule_codegen.cpp clang/test/OpenMP/target_teams_distribute_parallel_for_simd_firstprivate_codegen.cpp clang/test/OpenMP/target_teams_distribute_parallel_for_simd_if_codegen.cpp clang/test/OpenMP/target_teams_distribute_parallel_for_simd_lastprivate_codegen.cpp clang/test/OpenMP/target_teams_distribute_parallel_for_simd_private_codegen.cpp clang/test/OpenMP/target_teams_distribute_parallel_for_simd_proc_bind_codegen.cpp clang/test/OpenMP/target_teams_distribute_parallel_for_simd_reduction_codegen.cpp clang/test/OpenMP/target_teams_distribute_parallel_for_simd_schedule_codegen.cpp clang/test/OpenMP/target_teams_distribute_private_codegen.cpp clang/test/OpenMP/target_teams_distribute_reduction_codegen.cpp clang/test/OpenMP/target_teams_distribute_simd_codegen.cpp clang/test/OpenMP/target_teams_distribute_simd_collapse_codegen.cpp clang/test/OpenMP/target_teams_distribute_simd_dist_schedule_codegen.cpp clang/test/OpenMP/target_teams_distribute_simd_firstprivate_codegen.cpp clang/test/OpenMP/target_teams_distribute_simd_lastprivate_codegen.cpp clang/test/OpenMP/target_teams_distribute_simd_private_codegen.cpp clang/test/OpenMP/target_teams_distribute_simd_reduction_codegen.cpp clang/test/OpenMP/target_teams_map_codegen.cpp clang/test/OpenMP/target_teams_num_teams_codegen.cpp clang/test/OpenMP/target_teams_thread_limit_codegen.cpp clang/test/OpenMP/teams_codegen.cpp clang/test/OpenMP/teams_distribute_codegen.cpp clang/test/OpenMP/teams_distribute_collapse_codegen.cpp clang/test/OpenMP/teams_distribute_dist_schedule_codegen.cpp clang/test/OpenMP/teams_distribute_firstprivate_codegen.cpp clang/test/OpenMP/teams_distribute_lastprivate_codegen.cpp clang/test/OpenMP/teams_distribute_parallel_for_codegen.cpp clang/test/OpenMP/teams_distribute_parallel_for_collapse_codegen.cpp clang/test/OpenMP/teams_distribute_parallel_for_copyin_codegen.cpp clang/test/OpenMP/teams_distribute_parallel_for_dist_schedule_codegen.cpp clang/test/OpenMP/teams_distribute_parallel_for_firstprivate_codegen.cpp clang/test/OpenMP/teams_distribute_parallel_for_if_codegen.cpp clang/test/OpenMP/teams_distribute_parallel_for_lastprivate_codegen.cpp clang/test/OpenMP/teams_distribute_parallel_for_num_threads_codegen.cpp clang/test/OpenMP/teams_distribute_parallel_for_private_codegen.cpp clang/test/OpenMP/teams_distribute_parallel_for_proc_bind_codegen.cpp clang/test/OpenMP/teams_distribute_parallel_for_reduction_codegen.cpp clang/test/OpenMP/teams_distribute_parallel_for_schedule_codegen.cpp clang/test/OpenMP/teams_distribute_parallel_for_simd_codegen.cpp clang/test/OpenMP/teams_distribute_parallel_for_simd_collapse_codegen.cpp clang/test/OpenMP/teams_distribute_parallel_for_simd_dist_schedule_codegen.cpp clang/test/OpenMP/teams_distribute_parallel_for_simd_firstprivate_codegen.cpp clang/test/OpenMP/teams_distribute_parallel_for_simd_if_codegen.cpp clang/test/OpenMP/teams_distribute_parallel_for_simd_lastprivate_codegen.cpp clang/test/OpenMP/teams_distribute_parallel_for_simd_num_threads_codegen.cpp clang/test/OpenMP/teams_distribute_parallel_for_simd_private_codegen.cpp clang/test/OpenMP/teams_distribute_parallel_for_simd_proc_bind_codegen.cpp clang/test/OpenMP/teams_distribute_parallel_for_simd_reduction_codegen.cpp clang/test/OpenMP/teams_distribute_parallel_for_simd_schedule_codegen.cpp clang/test/OpenMP/teams_distribute_private_codegen.cpp clang/test/OpenMP/teams_distribute_reduction_codegen.cpp clang/test/OpenMP/teams_distribute_simd_codegen.cpp clang/test/OpenMP/teams_distribute_simd_collapse_codegen.cpp clang/test/OpenMP/teams_distribute_simd_dist_schedule_codegen.cpp clang/test/OpenMP/teams_distribute_simd_firstprivate_codegen.cpp clang/test/OpenMP/teams_distribute_simd_lastprivate_codegen.cpp clang/test/OpenMP/teams_distribute_simd_private_codegen.cpp clang/test/OpenMP/teams_distribute_simd_reduction_codegen.cpp clang/test/OpenMP/teams_firstprivate_codegen.cpp clang/test/OpenMP/teams_private_codegen.cpp llvm/include/llvm/Frontend/OpenMP/OMPKinds.def _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
