[PATCH] D126158: [MLIR][GPU] Replace fdiv on fp16 with promoted (fp32) multiplication with reciprocal plus one (conditional) Newton iteration.

csigg added a comment. This diff was recommited in 400fef081adbafc358858709861cdb14303de0e9 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126158/new/ https://reviews.llvm.org/D

[PATCH] D127054: [clang-format] Handle attributes for for/while loops

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. Great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127054/new/ https://reviews.llvm.org/D127054 _

[clang-tools-extra] d86a206 - Remove unneeded cl::ZeroOrMore for cl::opt/cl::list options

Author: Fangrui Song Date: 2022-06-05T00:31:44-07:00 New Revision: d86a206f06a51c12a9fcf2c20199f4e819751c0c URL: https://github.com/llvm/llvm-project/commit/d86a206f06a51c12a9fcf2c20199f4e819751c0c DIFF: https://github.com/llvm/llvm-project/commit/d86a206f06a51c12a9fcf2c20199f4e819751c0c.diff

[clang] d86a206 - Remove unneeded cl::ZeroOrMore for cl::opt/cl::list options

Author: Fangrui Song Date: 2022-06-05T00:31:44-07:00 New Revision: d86a206f06a51c12a9fcf2c20199f4e819751c0c URL: https://github.com/llvm/llvm-project/commit/d86a206f06a51c12a9fcf2c20199f4e819751c0c DIFF: https://github.com/llvm/llvm-project/commit/d86a206f06a51c12a9fcf2c20199f4e819751c0c.diff

[clang] 95a1342 - Remove unneeded cl::ZeroOrMore for cl::opt/cl::list options

Author: Fangrui Song Date: 2022-06-05T01:07:51-07:00 New Revision: 95a134254a403750ddfee7c056efdf2359a7dc8c URL: https://github.com/llvm/llvm-project/commit/95a134254a403750ddfee7c056efdf2359a7dc8c DIFF: https://github.com/llvm/llvm-project/commit/95a134254a403750ddfee7c056efdf2359a7dc8c.diff

[PATCH] D127074: [NFC] Add test cases reported in PR54341

mizvekov created this revision. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: Matheus Izvekov Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D127074 Files: clang/

[PATCH] D127074: [NFC] Add test cases reported in PR54341

mizvekov updated this revision to Diff 434334. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127074/new/ https://reviews.llvm.org/D127074 Files: clang/test/CXX/class/class.init/class.copy.elision/p3.cpp Index: clang

[PATCH] D127074: [NFC] Add test cases reported in PR54341

mizvekov updated this revision to Diff 434335. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127074/new/ https://reviews.llvm.org/D127074 Files: clang/test/CXX/class/class.init/class.copy.elision/p3.cpp Index: clang

[PATCH] D127074: [NFC] Add test cases reported in PR54341

mizvekov updated this revision to Diff 434336. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127074/new/ https://reviews.llvm.org/D127074 Files: clang/test/CXX/class/class.init/class.copy.elision/p3.cpp Index: clang

[PATCH] D127074: [NFC] Add test cases reported in PR54341

mizvekov updated this revision to Diff 434337. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127074/new/ https://reviews.llvm.org/D127074 Files: clang/test/CXX/class/class.init/class.copy.elision/p3.cpp Index: clang

[clang] f62433f - [NFC] Add test cases reported in PR54341

Author: Matheus Izvekov Date: 2022-06-05T20:34:28+02:00 New Revision: f62433f17c304a8bd8458a60eb32cd86ecf507a4 URL: https://github.com/llvm/llvm-project/commit/f62433f17c304a8bd8458a60eb32cd86ecf507a4 DIFF: https://github.com/llvm/llvm-project/commit/f62433f17c304a8bd8458a60eb32cd86ecf507a4.dif

[PATCH] D127074: [NFC] Add test cases reported in PR54341

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGf62433f17c30: [NFC] Add test cases reported in PR54341 (authored by mizvekov). Repository: rG LLVM Github Monorepo CHA

[PATCH] D126865: [clang] [Headers] Check __SEH__, when checking if ARM EHABI is implied

mstorsjo added a comment. @MaskRay Thanks for the other reviews! This one is the last one with the same condition added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126865/new/ https://reviews.llvm.org/D126865 __

[PATCH] D126865: [clang] [Headers] Check __SEH__, when checking if ARM EHABI is implied

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126865/new/ https://reviews.llvm.org/D126865 _

[PATCH] D127075: [clang] P2266: apply move elision rules on throw expr nested in function prototypes

mizvekov created this revision. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Our rules to determine if the throw expression are within the variable scope were giving a false negative result in case t

[PATCH] D109977: LLVM Driver Multicall tool

abrachet updated this revision to Diff 434352. abrachet marked an inline comment as done. abrachet edited the summary of this revision. abrachet added a comment. Better handling of names with version, ie `llvm-cxxfilt-15` -> `cxxfilt` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109977/

[PATCH] D109977: LLVM Driver Multicall tool

abrachet marked 5 inline comments as done. abrachet added a comment. In D109977#3558762 , @MaskRay wrote: > Thanks for picking up the change. I confirm that I can build `llvm` without > an error and it appears to work fine. > >> llvm-driver can be disabl

[PATCH] D109977: LLVM Driver Multicall tool

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM from my perspective, but this needs someone else's review. Comment at: llvm/tools/llvm-driver/llvm-driver.cpp:50 + bool ConsumeFirstArg = false; + if (LaunchedTool =

[clang] 8f7b148 - [NFC] Make comment consistent with allow|ignore list renamings

Author: Aditya Kumar Date: 2022-06-05T14:49:01-07:00 New Revision: 8f7b14898fe32f9c41059517a5a3872ef089174b URL: https://github.com/llvm/llvm-project/commit/8f7b14898fe32f9c41059517a5a3872ef089174b DIFF: https://github.com/llvm/llvm-project/commit/8f7b14898fe32f9c41059517a5a3872ef089174b.diff

[PATCH] D123640: [NFC] Make comment consistent with allow|ignore list renamings

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8f7b14898fe3: [NFC] Make comment consistent with allow|ignore list renamings (authored by hiraditya). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

MaskRay added a comment. Having the feature will be useful. `curl -L 'https://reviews.llvm.org/D32199?download=1' | patch -p1` doesn't apply cleanly. This needs a rebase. Comment at: clang/test/Driver/sanitizer-ld.c:250 +// RUN: %clangxx -no-canonical-prefixes %s -### -o %t

[clang] fc1c160 - [clang-format] Handle attributes for for/while loops

Author: owenca Date: 2022-06-05T15:45:25-07:00 New Revision: fc1c160f73304d474198d9a21e857b47df2acd3a URL: https://github.com/llvm/llvm-project/commit/fc1c160f73304d474198d9a21e857b47df2acd3a DIFF: https://github.com/llvm/llvm-project/commit/fc1c160f73304d474198d9a21e857b47df2acd3a.diff LOG: [

[PATCH] D127054: [clang-format] Handle attributes for for/while loops

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc1c160f7330: [clang-format] Handle attributes for for/while loops (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127054/new/ https://

[PATCH] D109977: LLVM Driver Multicall tool

phosek accepted this revision. phosek added a comment. LGTM Comment at: llvm/cmake/modules/AddLLVM.cmake:2030 +string(REPLACE "-" "_" key ${link_name}) +string(REPLACE "+" "p" key ${key}) +string(REPLACE "llvm-" "" tool_name ${link_name}) Alternativ

[clang] d937289 - [clang] Use llvm::is_contained (NFC)

Author: Kazu Hirata Date: 2022-06-05T17:56:40-07:00 New Revision: d93728978b24da15c1a9e2847c36d031aa737f33 URL: https://github.com/llvm/llvm-project/commit/d93728978b24da15c1a9e2847c36d031aa737f33 DIFF: https://github.com/llvm/llvm-project/commit/d93728978b24da15c1a9e2847c36d031aa737f33.diff L

[clang] 52818fd - [Clang][FP16] Add 4 builtins for _Float16

Author: Phoebe Wang Date: 2022-06-06T09:00:26+08:00 New Revision: 52818fd97f0f2b13d12e66de9f06b9f4cbc0be07 URL: https://github.com/llvm/llvm-project/commit/52818fd97f0f2b13d12e66de9f06b9f4cbc0be07 DIFF: https://github.com/llvm/llvm-project/commit/52818fd97f0f2b13d12e66de9f06b9f4cbc0be07.diff L

[PATCH] D127050: [Clang][FP16] Add 4 builtins for _Float16

This revision was automatically updated to reflect the committed changes. Closed by commit rG52818fd97f0f: [Clang][FP16] Add 4 builtins for _Float16 (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127050/new/ https://reviews.llv

[PATCH] D127005: [clang-format][NFC] Clean up the unwrapped line parser

owenpan updated this revision to Diff 434366. owenpan edited the summary of this revision. owenpan added a comment. Restored the return type of `parseLevel()` and reordered the parameters of `parseStructuralElement()`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127005/new/ https://r

[PATCH] D109977: LLVM Driver Multicall tool

abrachet updated this revision to Diff 434370. abrachet marked an inline comment as done. abrachet added a comment. - Fix bazel build, `llvm-driver` can't be built by bazel, but the existing tools which lost their `main` will still work. - Remove `--version` - Fix `dsymutil` not depending on `Dsy

[PATCH] D109977: LLVM Driver Multicall tool

abrachet marked 2 inline comments as done. abrachet added inline comments. Comment at: llvm/cmake/modules/AddLLVM.cmake:2030 +string(REPLACE "-" "_" key ${link_name}) +string(REPLACE "+" "p" key ${key}) +string(REPLACE "llvm-" "" tool_name ${link_name}) --

[PATCH] D126757: Fix clang RecursiveASTVisitor for definition of XXXTemplateSpecializationDecl

nridge added a reviewer: sammccall. nridge added a subscriber: sammccall. nridge added a comment. Thanks, the patch looks good to me, but someone else should probably take a look and approve. Adding @sammccall who has looked at RecursiveASTVisitor recently in D120498

[PATCH] D119646: [clang] Allow consteval functions in default arguments

ChuanqiXu commandeered this revision. ChuanqiXu edited reviewers, added: Izaron; removed: ChuanqiXu. ChuanqiXu added a comment. Given this is close to complete and @Izaron is not active recently, let me take this over. The authority would be remained, of course. Repository: rG LLVM Github Mon

[PATCH] D119646: [clang] Allow consteval functions in default arguments

ChuanqiXu updated this revision to Diff 434373. ChuanqiXu added a comment. Add release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119646/new/ https://reviews.llvm.org/D119646 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/Decl.cpp clang/lib/Sema/SemaExpr.cpp clang/t

[PATCH] D126959: [C++20][Modules] Introduce an implementation module.

ChuanqiXu added inline comments. Comment at: clang/lib/Lex/ModuleMap.cpp:910 + return Result; +} + The implementation looks similar to `createModuleForInterfaceUnit` really. It looks better to refactor it to `createModuleUnits` (or createModuleForCXX20Modules)

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang added a comment. In D125095#3552451 , @shchenz wrote: > Thanks for doing this. I am not familiar with the frontend, so I may be > wrong/stupid in the follow comments : ) > Hope other experts like @hubert.reinterpretcast can give more meaningful

[PATCH] D126959: [C++20][Modules] Introduce an implementation module.

ChuanqiXu added a comment. In D126959#3556115 , @iains wrote: > In D126959#3556074 , @tahonermann > wrote: > >>> Implementation modules are never serialized (-emit-module-interface for an >>> implementation unit

[PATCH] D127082: Add Macro Expansion to Hover

daiyousei-qz created this revision. daiyousei-qz added reviewers: nridge, sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. daiyousei-qz requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commit

[clang] f06abbb - LLVM Driver Multicall tool

Author: Chris Bieneman Date: 2022-06-06T04:27:32Z New Revision: f06abbb393800b0d466c88e283c06f75561c432c URL: https://github.com/llvm/llvm-project/commit/f06abbb393800b0d466c88e283c06f75561c432c DIFF: https://github.com/llvm/llvm-project/commit/f06abbb393800b0d466c88e283c06f75561c432c.diff LOG

[PATCH] D109977: LLVM Driver Multicall tool

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. abrachet marked 2 inline comments as done. Closed by commit rGf06abbb39380: LLVM Driver Multicall tool (authored by beanz, committed by abrachet). Repository: rG LLV

[PATCH] D126757: [AST] Fix clang RecursiveASTVisitor for definition of XXXTemplateSpecializationDecl

nridge added a comment. Thanks Richard for the review! @daiyousei-qz would you like me to commit the patch for you? (If so, I need a name + email for attribution, there doesn't seem to be one in the revision metadata.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[clang] 448995c - [NFC] [Coroutines] Add test for ambiguous allocation functions in

Author: Chuanqi Xu Date: 2022-06-06T14:23:35+08:00 New Revision: 448995c521b5ccef71d063bb80f084138ac9d352 URL: https://github.com/llvm/llvm-project/commit/448995c521b5ccef71d063bb80f084138ac9d352 DIFF: https://github.com/llvm/llvm-project/commit/448995c521b5ccef71d063bb80f084138ac9d352.diff LO

[PATCH] D125517: [Frontend] [Coroutines] Emit error when we found incompatible allocation function in promise_type

ChuanqiXu marked an inline comment as done. ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaCoroutine.cpp:1320 + +return !R.empty() && !R.isAmbiguous(); + }(); rsmith wrote: > I don't see any tests covering the case where the lookup is ambigu

[PATCH] D126757: [AST] Fix clang RecursiveASTVisitor for definition of XXXTemplateSpecializationDecl

daiyousei-qz added a comment. Yes, please do so. I'm using the web interface since the arc tool isn't very friendly to Windows user :( Name: Qingyuan Zheng Email: qyzhe...@outlook.com Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126757/new/ http

[clang-tools-extra] c119a17 - [AST] Fix clang RecursiveASTVisitor for definition of XXXTemplateSpecializationDecl

Author: Qingyuan Zheng Date: 2022-06-06T02:35:34-04:00 New Revision: c119a17e7fd6fb528d8c1e1bbb0ad1fac93f896a URL: https://github.com/llvm/llvm-project/commit/c119a17e7fd6fb528d8c1e1bbb0ad1fac93f896a DIFF: https://github.com/llvm/llvm-project/commit/c119a17e7fd6fb528d8c1e1bbb0ad1fac93f896a.diff

[PATCH] D126757: [AST] Fix clang RecursiveASTVisitor for definition of XXXTemplateSpecializationDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rGc119a17e7fd6: [AST] Fix clang RecursiveASTVisitor for definition of… (authored by daiyousei-qz, committed by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D125863: [clangd] Dont mark terminating PP-directives as skipped

daiyousei-qz added a comment. I have a similar change recently presented in https://github.com/clangd/clangd/issues/1181 that makes all conditional preprocessor lines active. Please refer to the change if that's helpful :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http