MaskRay added a comment.

Having the feature will be useful.

`curl -L 'https://reviews.llvm.org/D32199?download=1' | patch -p1` doesn't 
apply cleanly. This needs a rebase.



================
Comment at: clang/test/Driver/sanitizer-ld.c:250
 
+// RUN: %clangxx -no-canonical-prefixes %s -### -o %t.o 2>&1 \
+// RUN:     -target x86_64-unknown-linux -fuse-ld=ld -stdlib=platform -lstdc++ 
\
----------------
Most `-no-canonical-prefixes` were cargo cult. I have removed them. The test 
needs a rebase.

Avoid legacy `-target `


================
Comment at: clang/test/Driver/sanitizer-ld.c:259
+// CHECK-TYSAN-LINUX-CXX-NOT: stdc++
+// CHECK-TYSAN-LINUX-CXX: "-whole-archive" "{{.*}}libclang_rt.tysan-x86_64.a" 
"-no-whole-archive"
+// CHECK-TYSAN-LINUX-CXX: stdc++
----------------
`{{.*}}libclang_rt.tysan{{[^.]*}}.a"`

LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=on builds use `libclang_rt.tysan-x86_64.a` 
(see D107799)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D32199/new/

https://reviews.llvm.org/D32199

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to