phosek accepted this revision.
phosek added a comment.
LGTM
================
Comment at: llvm/cmake/modules/AddLLVM.cmake:2030
+ string(REPLACE "-" "_" key ${link_name})
+ string(REPLACE "+" "p" key ${key})
+ string(REPLACE "llvm-" "" tool_name ${link_name})
----------------
Alternative substitution for `+` would be `x` which is used elsewhere in LLVM,
for example `libcxx`, `libcxxabi` or `cxxfilt`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109977/new/
https://reviews.llvm.org/D109977
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
