[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

nridge added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:388 +// arguments +auto ForwardedParmMatcher = compoundStmt(forEachDescendant( +invocation( upsj wrote: > sammccall wrote: > > We tend not to use ASTMatchers for the

[PATCH] D124752: [HLSL] clang codeGen for HLSLShaderAttr.

python3kgae created this revision. python3kgae added reviewers: dblaikie, MaskRay, hoy, lebedev.ri. Herald added subscribers: Anastasia, StephenFan. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Tr

[PATCH] D124753: [HLSL] Set main as default entry.

python3kgae created this revision. python3kgae added reviewers: beanz, steven_wu, JonChesterfield, sscalpone, pow2clk, rnk, bogner, MaskRay, dexonsmith. Herald added subscribers: Anastasia, StephenFan. Herald added a project: All. python3kgae requested review of this revision. Herald added a proje

[PATCH] D124359: [clangd] Add inlay hints for mutable reference parameters

upsj updated this revision to Diff 426343. upsj marked 4 inline comments as done. upsj added a comment. address review comments: Move reference hint to the prefix, test type aliases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124359/new/ https://

[PATCH] D124359: [clangd] Add inlay hints for mutable reference parameters

upsj added a comment. Thanks, on second thought moving the hint to the prefix also makes more sense to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124359/new/ https://reviews.llvm.org/D124359 ___

[PATCH] D124736: [CodeGen] Use ABI alignment for placement new

rjmccall added a comment. It should probably be the ABI alignment in all cases; I think the preferred alignment is just supposed to be used to opportunistically over-align things like e.g. local variables, which doesn't seem relevant for the ABI code involving a call to `operator new`. Reposi

[PATCH] D124359: [clangd] Add inlay hints for mutable reference parameters

nridge added a comment. Thanks, the changes here look good. Something is strange about the diff though, it's not letting me see the complete changes relative to the baseline, only the incremental changes relative to a previous version (I think this is also why Phabricator's build status says p

[PATCH] D124359: [clangd] Add inlay hints for mutable reference parameters

upsj updated this revision to Diff 426344. upsj added a comment. right, arcanist doesn't entirely match my git mental model. Here's the (hopefully) complete patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124359/new/ https://reviews.llvm.org/D

[PATCH] D124221: Add new builtin __builtin_reflect_struct.

rsmith updated this revision to Diff 426345. rsmith added a comment. - Reimplement __builtin_dump_struct in Sema. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124221/new/ https://reviews.llvm.org/D124221 Files: clang/docs/LanguageExtensions.rst

[PATCH] D124221: Reimplement `__builtin_dump_struct` in Sema.

rsmith added a comment. In D124221#3469251 , @rsmith wrote: > I think we can address most of my concerns with `__builtin_dump_struct` > without a new builtin, by incorporating things from this implementation Done; this patch now reimplements `__builtin_

[PATCH] D124359: [clangd] Add inlay hints for mutable reference parameters

upsj updated this revision to Diff 426346. upsj marked an inline comment as done. upsj added a comment. add test for const ref inlay hint via type alias Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124359/new/ https://reviews.llvm.org/D124359 Fil

[PATCH] D124221: Reimplement `__builtin_dump_struct` in Sema.

rsmith updated this revision to Diff 426347. rsmith edited the summary of this revision. rsmith added a comment. - Fix example in documentation: the dump is terminated by a newline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124221/new/ https://

[PATCH] D124221: Reimplement `__builtin_dump_struct` in Sema.

rsmith updated this revision to Diff 426348. rsmith added a comment. - Minor doc correction Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124221/new/ https://reviews.llvm.org/D124221 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseN

[PATCH] D124221: Reimplement `__builtin_dump_struct` in Sema.

rsmith updated this revision to Diff 426349. rsmith added a comment. - Update release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124221/new/ https://reviews.llvm.org/D124221 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseN

[PATCH] D124667: [flang][driver] Add support for consuming LLVM IR/BC files

rovka accepted this revision. rovka added a comment. This revision is now accepted and ready to land. A few nits, but otherwise LGTM. Comment at: flang/lib/Frontend/FrontendActions.cpp:86 + + // ... otherwise, generate an MLIR module from the input Fortran source bool res =

[PATCH] D124606: Use `-text` git attribute instead of `text eol=...'

ilya-biryukov added a comment. In D124606#3484740 , @Meinersbur wrote: > In D124606#3479793 , @ilya-biryukov > wrote: > >> LGTM > > This and the commit (@MForster ) was too hasty. There should have been time >

[PATCH] D124221: Reimplement `__builtin_dump_struct` in Sema.

yihanaa added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:427 +llvm::SmallString<32> Indent; +Indent.resize(Depth * 4, ' '); +return getStringLiteral(Indent); What do you think of PrintingPolicy.Indentation here? Co

[PATCH] D124688: [clangd] parse all make_unique-like functions in preamble

sammccall added a comment. In D124688#3485042 , @nridge wrote: > In D124688#3483895 , @sammccall > wrote: > >> Trying this on a few files, this seems like it increases preamble sizes up >> to 1% or so > > Are pr

[clang] 5a2e595 - [analyzer] Fix Static Analyzer g_memdup false-positive

Author: Balazs Benics Date: 2022-05-02T10:35:51+02:00 New Revision: 5a2e595eb8337e6e36da8ec2289b5c4097522f5b URL: https://github.com/llvm/llvm-project/commit/5a2e595eb8337e6e36da8ec2289b5c4097522f5b DIFF: https://github.com/llvm/llvm-project/commit/5a2e595eb8337e6e36da8ec2289b5c4097522f5b.diff

[PATCH] D124436: [analyzer] Fix Static Analyzer g_memdup false-positive

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a2e595eb833: [analyzer] Fix Static Analyzer g_memdup false-positive (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124436/new/ https

[clang] 464c983 - [analyzer][docs] Document alpha.security.cert.pos.34c limitations

Author: Balazs Benics Date: 2022-05-02T10:37:23+02:00 New Revision: 464c9833df8049793232bccb10fea84098499e4a URL: https://github.com/llvm/llvm-project/commit/464c9833df8049793232bccb10fea84098499e4a DIFF: https://github.com/llvm/llvm-project/commit/464c9833df8049793232bccb10fea84098499e4a.diff

[PATCH] D124659: [analyzer][docs] Document alpha.security.cert.pos.34c limitations

This revision was automatically updated to reflect the committed changes. Closed by commit rG464c9833df80: [analyzer][docs] Document alpha.security.cert.pos.34c limitations (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124659/

[clang] c8603db - [clang-format] Fix a bug that misformats Access Specifier after *[]

Author: owenca Date: 2022-05-02T01:39:26-07:00 New Revision: c8603db0711e451cecb75c8e10a12e882d4e0b31 URL: https://github.com/llvm/llvm-project/commit/c8603db0711e451cecb75c8e10a12e882d4e0b31 DIFF: https://github.com/llvm/llvm-project/commit/c8603db0711e451cecb75c8e10a12e882d4e0b31.diff LOG: [

[PATCH] D115187: [clangd] Expose CoawaitExpr's operand in the AST

nridge updated this revision to Diff 426356. nridge added a comment. Handle implicit coawait-exprs properly in RebuildCoawaitExpr, other test fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115187/new/ https://reviews.llvm.org/D115187 Files:

[PATCH] D124589: [clang-format] Fix a bug that misformats Access Specifier after *[]

This revision was automatically updated to reflect the committed changes. Closed by commit rGc8603db0711e: [clang-format] Fix a bug that misformats Access Specifier after *[] (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124589

[PATCH] D124669: [flang][driver] Add support for -save-temps

rovka added inline comments. Comment at: clang/include/clang/Driver/Options.td:4131 def : Flag<["-"], "no-integrated-as">, Alias, - Flags<[CC1Option, NoXarchOption]>; + Flags<[CC1Option,FlangOption,NoXarchOption]>; awarzynski wrote: > unterumarmung w

[PATCH] D115187: [clangd] Expose CoawaitExpr's operand in the AST

nridge added a comment. In D115187#3471261 , @sammccall wrote: > We're not supposed to transform > initial/final suspends, but the code is now doing so. > > This seems to be a consequence of switching from BuildRe

[clang] fd7efe3 - [analyzer] Fix cast evaluation on scoped enums in ExprEngine

Author: Balazs Benics Date: 2022-05-02T10:54:26+02:00 New Revision: fd7efe33f1b2d0dc3bce940154dba27413b72e7a URL: https://github.com/llvm/llvm-project/commit/fd7efe33f1b2d0dc3bce940154dba27413b72e7a DIFF: https://github.com/llvm/llvm-project/commit/fd7efe33f1b2d0dc3bce940154dba27413b72e7a.diff

[PATCH] D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfd7efe33f1b2: [analyzer] Fix cast evaluation on scoped enums in ExprEngine (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D124681: [Analyzer] Minor cleanups in StreamChecker

mantognini created this revision. Herald added subscribers: manas, steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. mantognini added reviewers: NoQ, balazske, Szelethus. mantognini publ

[PATCH] D124359: [clangd] Add inlay hints for mutable reference parameters

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks! Final nit: please update the commit message as it's a bit out of date, and then I'll go ahead and merge Comment at: clang-tools-extra/clangd/unittests/InlayHintTest

[PATCH] D115187: [clangd] Expose CoawaitExpr's operand in the AST

sammccall accepted this revision. sammccall added a comment. Looks good to me - this still seems hairy and abstract to me so I'd "expect the unexpected" in terms of bot or downstream breakage... Comment at: clang/include/clang/Sema/Sema.h:10394 +

[clang] 5ce7050 - [analyzer] Allow exploded graph dumps in release builds

Author: Balazs Benics Date: 2022-05-02T11:42:08+02:00 New Revision: 5ce7050f701c6907cc2522fc43d39a8cbcc119d2 URL: https://github.com/llvm/llvm-project/commit/5ce7050f701c6907cc2522fc43d39a8cbcc119d2 DIFF: https://github.com/llvm/llvm-project/commit/5ce7050f701c6907cc2522fc43d39a8cbcc119d2.diff

[PATCH] D124442: [analyzer] Allow exploded graph dumps in release builds

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ce7050f701c: [analyzer] Allow exploded graph dumps in release builds (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124442/new/ http

[clang] 29dff0d - [analyzer] Allow CFG dumps in release builds

Author: Balazs Benics Date: 2022-05-02T11:48:52+02:00 New Revision: 29dff0d4fb46fe8f1e9774fd5e64d3e07937ff35 URL: https://github.com/llvm/llvm-project/commit/29dff0d4fb46fe8f1e9774fd5e64d3e07937ff35 DIFF: https://github.com/llvm/llvm-project/commit/29dff0d4fb46fe8f1e9774fd5e64d3e07937ff35.diff

[PATCH] D124443: [analyzer] Allow CFG dumps in release builds

This revision was automatically updated to reflect the committed changes. Closed by commit rG29dff0d4fb46: [analyzer] Allow CFG dumps in release builds (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124443/new/ https://reviews

[clang] a23291b - [Clang] Add integer add reduction builtin

Author: Simon Pilgrim Date: 2022-05-02T11:03:25+01:00 New Revision: a23291b7db48670f7c57adcfb45877c826a97f22 URL: https://github.com/llvm/llvm-project/commit/a23291b7db48670f7c57adcfb45877c826a97f22 DIFF: https://github.com/llvm/llvm-project/commit/a23291b7db48670f7c57adcfb45877c826a97f22.diff

[PATCH] D124221: Reimplement `__builtin_dump_struct` in Sema.

yihanaa added inline comments. Comment at: clang/docs/ReleaseNotes.rst:174 - Improve the dump format, dump both bitwidth(if its a bitfield) and field value. - - Remove anonymous tag locations. - - Beautify dump format, add indent for nested struct and struct members. + - R

[PATCH] D124741: [Clang] Add integer add reduction builtin

This revision was automatically updated to reflect the committed changes. Closed by commit rGa23291b7db48: [Clang] Add integer add reduction builtin (authored by RKSimon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124741/new/ https://reviews.llv

[PATCH] D117829: [Clang] Add integer mul reduction builtin

RKSimon updated this revision to Diff 426366. RKSimon retitled this revision from "[Clang] Add integer add/mul reduction builtins" to "[Clang] Add integer mul reduction builtin". RKSimon edited the summary of this revision. RKSimon added a comment. Just handle the mul case now that D124741

[PATCH] D117829: [Clang] Add integer mul reduction builtin

RKSimon updated this revision to Diff 426367. RKSimon added a comment. Add "__builtin_reduce_mul" to the docs listing supported reductions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117829/new/ https://reviews.llvm.org/D117829 Files: clang/do

[PATCH] D124701: [clang] Honor __attribute__((no_builtin("foo"))) on functions

hans added a comment. If I understand correctly, D68028 made it so that LLVM doesn't add any builtin calls (e.g. turning for-loops into memcpy), but Clang could still turn calls into builtins. Maybe the patch description could be expanded to explain this? ==

[PATCH] D109467: [analyzer] check for std::__addressof for inner pointer checker

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109467/new/ https://reviews.llvm.org/D109467 _

[PATCH] D124359: [clangd] Add inlay hints for mutable reference parameters

upsj updated this revision to Diff 426372. upsj marked an inline comment as done. upsj added a comment. remove unnecessary annotation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124359/new/ https://reviews.llvm.org/D124359 Files: clang-tools-e

[PATCH] D124757: [X86] Replace avx512f integer add reduction builtins with generic builtin

RKSimon created this revision. RKSimon added reviewers: pengfei, craig.topper. Herald added a subscriber: StephenFan. Herald added a project: All. RKSimon requested review of this revision. Herald added a project: clang. D124741 added the generic "__builtin_redu

[PATCH] D124681: [Analyzer] Minor cleanups in StreamChecker

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Looks great, thanks. Land it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124681/new/ https://reviews.llvm.org/D124681 __

[PATCH] D124701: [clang] Honor __attribute__((no_builtin("foo"))) on functions

aaron.ballman added a comment. FWIW, it looks like precommit CI found issues in the newly added test which should be addressed. Comment at: clang/test/CodeGen/no-builtin-2.c:3 + +#include + You shouldn't include system headers -- that will pull from whatever

[PATCH] D124758: [analyzer] Implement assume in terms of assumeDual

martong created this revision. martong added reviewers: NoQ, steakhal, ASDenysPetrov. Herald added subscribers: manas, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project:

[PATCH] D92160: [clang] Fix wrong FDs are used for files with same name in Tooling

Kale added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. In D92160#2449507 , @dexonsmith wrote: > But it's possible we don't need this. If it's safe for us to update the tests > and make `FileManager::getFileRef` always ca

[PATCH] D124758: [analyzer] Implement assume in terms of assumeDual

martong added a comment. Although there is a visible slowdown, the new run-times seem promising. My guess is that it is usually not more than 1-2%. F22955239: image.png Full report: F22955251: stats.html Repository: r

[PATCH] D124761: [analyzer] Replace adjacent assumeInBound calls to assumeInBoundDual

martong created this revision. martong added reviewers: NoQ, steakhal, ASDenysPetrov. Herald added subscribers: manas, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project:

[PATCH] D124762: [WinEHPrepare] Avoid truncation of EH funclets with GNUstep ObjC runtime

sgraenitz created this revision. sgraenitz added reviewers: rnk, theraven, DHowett-MSFT. Herald added a subscriber: hiraditya. Herald added a project: All. sgraenitz requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. Unwinding ObjC code w

[PATCH] D124757: [X86] Replace avx512f integer add reduction builtins with generic builtin

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124757/new/ https://reviews.llvm.org/D124757

[PATCH] D124761: [analyzer] Replace adjacent assumeInBound calls to assumeInBoundDual

martong updated this revision to Diff 426382. martong added a comment. - Set parent revision (in the commit message b/c the phab ui 'edit related revisions' is not operational) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124761/new/ https://revi

[PATCH] D124721: [OpenMP] Allow compiling multiple target architectures with OpenMP

jhuber6 added inline comments. Comment at: clang/test/Driver/amdgpu-openmp-toolchain-new.c:6 // RUN: | FileCheck %s +// RUN: %clang -### --target=x86_64-unknown-linux-gnu -fopenmp -fopenmp-targets=amdgcn-amd-amdhsa \ +// RUN: --offload-arch=gfx906 --libomptarget-a

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

aaron.ballman added a comment. In D124500#3483328 , @LegalizeAdulthood wrote: > In D124500#3483224 , @aaron.ballman > wrote: > >> To clarify my previous comments, I'm fine punting on the edge cases until >> use

[PATCH] D124658: [analyzer] Canonicalize SymIntExpr so the RHS is positive when possible

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:204 +// subtraction/addition of the negated value. +if (!RHS.isNegative()) { + ConvertedRHS = &BasicVals.Convert(resultTy, RHS); tomasz-kaminski-sonarsour

[PATCH] D124721: [OpenMP] Allow compiling multiple target architectures with OpenMP

saiislam added inline comments. Comment at: clang/test/Driver/amdgpu-openmp-toolchain-new.c:6 // RUN: | FileCheck %s +// RUN: %clang -### --target=x86_64-unknown-linux-gnu -fopenmp -fopenmp-targets=amdgcn-amd-amdhsa \ +// RUN: --offload-arch=gfx906 --libomptarget-

[PATCH] D124702: [MSVC] Add support for pragma function

hans added a comment. From the MS docs: > Once a function pragma is seen, it takes effect at the first function > definition that contains a specified intrinsic function. The effect continues > to the end of the source file, or to the appearance of an intrinsic pragma > specifying the same int

[PATCH] D124721: [OpenMP] Allow compiling multiple target architectures with OpenMP

saiislam added inline comments. Comment at: clang/test/Driver/amdgpu-openmp-toolchain-new.c:6 // RUN: | FileCheck %s +// RUN: %clang -### --target=x86_64-unknown-linux-gnu -fopenmp -fopenmp-targets=amdgcn-amd-amdhsa \ +// RUN: --offload-arch=gfx906 --libomptarget-

[PATCH] D124762: [WinEHPrepare] Avoid truncation of EH funclets with GNUstep ObjC runtime

sgraenitz added a comment. I guess testing must be split in two: - Clang wants to make sure the "funclet" bundle operand gets emitted for ObjC ARC runtime calls on Windows. Maybe that fits into clang/test/CodeGenObjC/gnu-exceptions.m

[libunwind] 364c502 - [libunwind] Add SystemZ support

Author: Ulrich Weigand Date: 2022-05-02T14:35:29+02:00 New Revision: 364c5023d2ce1617c706b185892ddfaa2fd4d166 URL: https://github.com/llvm/llvm-project/commit/364c5023d2ce1617c706b185892ddfaa2fd4d166 DIFF: https://github.com/llvm/llvm-project/commit/364c5023d2ce1617c706b185892ddfaa2fd4d166.diff

[PATCH] D124721: [OpenMP] Allow compiling multiple target architectures with OpenMP

jhuber6 added inline comments. Comment at: clang/test/Driver/amdgpu-openmp-toolchain-new.c:6 // RUN: | FileCheck %s +// RUN: %clang -### --target=x86_64-unknown-linux-gnu -fopenmp -fopenmp-targets=amdgcn-amd-amdhsa \ +// RUN: --offload-arch=gfx906 --libomptarget-a

[PATCH] D124724: [Clang][OpenMP] Add the support for floating-point variables for specific atomic clauses

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:5936-5939 + CGF.Builder.CreateCast(X.getType()->hasSignedIntegerRepresentation() + ? llvm::Instruction::CastOps::SIToFP +

[PATCH] D124688: [clangd] parse all make_unique-like functions in preamble

upsj updated this revision to Diff 426387. upsj marked 2 inline comments as done. upsj added a comment. Herald added a subscriber: javed.absar. Rewrote detection of forwarding functions in preamble, added `--preamble-parse-forwarding` flag I ran clangd over `bits/stdc++.h`, and it seems like th

[PATCH] D123032: [clang][dataflow] Exclude protobuf types from modeling in the environment.

ymandel updated this revision to Diff 426388. ymandel marked an inline comment as done. ymandel added a comment. added FIXME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123032/new/ https://reviews.llvm.org/D123032 Files: clang/lib/Analysis/Flo

[PATCH] D124688: [clangd] parse all make_unique-like functions in preamble

upsj added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:167 +// ... whose template parameter comes from the function directly +if (FT->getTemplateParameters()->getDepth() == +PackTypePtr->getDepth()) {

[PATCH] D124719: [docs] PCH usage documentation update

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks for improving the docs! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124719/new/ https://reviews.llvm.org/D124719 _

[clang] 4b6c2cd - Deferred Concept Instantiation Implementation

Author: Erich Keane Date: 2022-05-02T05:49:15-07:00 New Revision: 4b6c2cd647e9e5a147954886338f97ffb6a1bcfb URL: https://github.com/llvm/llvm-project/commit/4b6c2cd647e9e5a147954886338f97ffb6a1bcfb DIFF: https://github.com/llvm/llvm-project/commit/4b6c2cd647e9e5a147954886338f97ffb6a1bcfb.diff L

[PATCH] D119544: Deferred Concept Instantiation Implementation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4b6c2cd647e9: Deferred Concept Instantiation Implementation (authored by erichkeane). Herald added a project: clang. Repository: rG LLVM Github Mo

[PATCH] D124767: [Clang] Map .gcda paths according to -fcoverage-prefix-map

vit9696 created this revision. vit9696 added reviewers: keith, phosek. Herald added a project: All. vit9696 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. https://github.com/llvm/llvm-project/issues/54670 Repository: rG LLVM Github Mon

[PATCH] D124534: [clang] Add a diagnostic for line directive of a gnu extension

aaron.ballman added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:1356 + +PP.Diag(FlagTok, diag::ext_pp_gnu_line_directive); } else if (FlagVal == 2) { ken-matsui wrote: > aaron.ballman wrote: > > ken-matsui wrote: > > > aaron.ballman wrote:

[PATCH] D124694: [randstruct] Move initializer check to be more effective

aaron.ballman added a comment. struct t { int a, b, c, d, e; } x = { .a = 2, 4, 5, 6 }; This situation seems like it should be an error, shouldn't it? The user specified one designated initializer (yay, that one is correct), but the rest are positional initializers and so there's no te

[PATCH] D124758: [analyzer] Implement assume in terms of assumeDual

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. The patch looks great. Thanks for the stats. Beyond that, I feel these tests sooo fragile; Although I don't have anything to improve that, so be it. Comment at: clang/t

[PATCH] D124768: update

phyBrackets created this revision. Herald added a project: All. phyBrackets requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D124768 Files: clang/include/clang/AST/ASTImportE

[PATCH] D124761: [analyzer] Replace adjacent assumeInBound calls to assumeInBoundDual

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. LGTM; Although, I missed some doc comments here and there. This is a really important API, it deserves a few words. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[clang] 0c31da4 - Revert "Deferred Concept Instantiation Implementation"

Author: Erich Keane Date: 2022-05-02T06:25:38-07:00 New Revision: 0c31da48389754822dc3eecc4723160c295b9ab2 URL: https://github.com/llvm/llvm-project/commit/0c31da48389754822dc3eecc4723160c295b9ab2 DIFF: https://github.com/llvm/llvm-project/commit/0c31da48389754822dc3eecc4723160c295b9ab2.diff L

[clang] 9a14c36 - [X86] Replace avx512f integer add reduction builtins with generic builtin

Author: Simon Pilgrim Date: 2022-05-02T14:39:17+01:00 New Revision: 9a14c369c422b244db78f1a9f947a891a75d912f URL: https://github.com/llvm/llvm-project/commit/9a14c369c422b244db78f1a9f947a891a75d912f DIFF: https://github.com/llvm/llvm-project/commit/9a14c369c422b244db78f1a9f947a891a75d912f.diff

[PATCH] D124757: [X86] Replace avx512f integer add reduction builtins with generic builtin

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a14c369c422: [X86] Replace avx512f integer add reduction builtins with generic builtin (authored by RKSimon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D124701: [clang] Honor __attribute__((no_builtin("foo"))) on functions

steplong added a comment. In D124701#3485317 , @hans wrote: > If I understand correctly, D68028 made it > so that LLVM doesn't add any builtin calls (e.g. turning for-loops into > memcpy), but Clang could still turn cal

[PATCH] D124721: [OpenMP] Allow compiling multiple target architectures with OpenMP

saiislam added inline comments. Comment at: clang/test/Driver/amdgpu-openmp-toolchain-new.c:6 // RUN: | FileCheck %s +// RUN: %clang -### --target=x86_64-unknown-linux-gnu -fopenmp -fopenmp-targets=amdgcn-amd-amdhsa \ +// RUN: --offload-arch=gfx906 --libomptarget-

[PATCH] D124701: [clang] Honor __attribute__((no_builtin("foo"))) on functions

steplong updated this revision to Diff 426400. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124701/new/ https://reviews.llvm.org/D124701 Files: clang/lib/CodeGen/CGExpr.cpp clang/test/CodeGen/no-builtin-2.c Index: clang/test/CodeGen/no-builti

[PATCH] D124721: [OpenMP] Allow compiling multiple target architectures with OpenMP

jhuber6 added inline comments. Comment at: clang/test/Driver/amdgpu-openmp-toolchain-new.c:6 // RUN: | FileCheck %s +// RUN: %clang -### --target=x86_64-unknown-linux-gnu -fopenmp -fopenmp-targets=amdgcn-amd-amdhsa \ +// RUN: --offload-arch=gfx906 --libomptarget-a

[PATCH] D123471: [CUDA] Create offloading entries when using the new driver

jhuber6 updated this revision to Diff 426404. jhuber6 added a comment. Fix test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123471/new/ https://reviews.llvm.org/D123471 Files: clang/include/clang/Basic/LangOptions.def clang/include/clang/Dr

[PATCH] D124320: [clang-tidy] Add createChecks method that also checks for LangaugeOptions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Just to double-check, this is an NFC change, isn't it (thus there's no tests)? Assuming that's true, this LGTM (though please add NFC to the commit message title). Repository:

[PATCH] D124702: [MSVC] Add support for pragma function

steplong added a comment. In D124702#3485475 , @hans wrote: > From the MS docs: > >> Once a function pragma is seen, it takes effect at the first function >> definition that contains a specified intrinsic function. The effect >> continues to the end of

[PATCH] D124767: [Clang] Map .gcda paths according to -fcoverage-prefix-map

vit9696 updated this revision to Diff 426414. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124767/new/ https://reviews.llvm.org/D124767 Files: clang/lib/CodeGen/CodeGenModule.cpp Index: clang/lib/CodeGen/CodeGenModule.cpp ==

[PATCH] D124687: [Tooling/DependencyScanning & Preprocessor] Refactor dependency scanning to record and use pre-lexed preprocessor directive tokens, instead of minimized sources

tschuett added a comment. Could you split this into smaller patches? Does this support C++20 modules or is it limited to clang header modules? Is there overhead in the non dependency scanning mode? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12468

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

upsj added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:474 +// the parameter names from the wrapped function +if (Args.size() > FixedParamCount && Args.size() == Params.size()) { + auto ForwardedParams = matchForwardedParams(

[clang] a978991 - Re-apply 4b6c2cd642 "Deferred Concept Instantiation Implementation""

Author: Erich Keane Date: 2022-05-02T07:49:26-07:00 New Revision: a97899108e495147985e5e9492e742d51d5cc97a URL: https://github.com/llvm/llvm-project/commit/a97899108e495147985e5e9492e742d51d5cc97a DIFF: https://github.com/llvm/llvm-project/commit/a97899108e495147985e5e9492e742d51d5cc97a.diff L

[PATCH] D124221: Reimplement `__builtin_dump_struct` in Sema.

aaron.ballman added a comment. Thanks for working on this, I like the direction it's going! Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8470-8473 +def err_expected_struct_pointer_argument : Error< + "expected pointer to struct as %ordinal0 argument to %1, foun

[PATCH] D124221: Reimplement `__builtin_dump_struct` in Sema.

erichkeane added a comment. This is a pretty nice seeming interface that I think does a fairly good job at maintaining backwards compat while improving the functionality. A few questions/comments. Comment at: clang/docs/LanguageExtensions.rst:2442 + +This builtin does not ret

[PATCH] D122663: Mark identifier prefixes as substitutable

hvdijk added a comment. In D122663#3471741 , @erichkeane wrote: > Ping me EOW if @rsmith doesn't respond in the meantime. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122663/new/ https://reviews.ll

[PATCH] D124621: [Analyzer] Fix assumptions about const field with member-initializer

mantognini added a comment. In D124621#3482847 , @steakhal wrote: > For the upcoming patches, it would be nice to test the patches on a small set > of open-source projects for exactly this reason. > I think there is a `clang/utils/analyzer/SATest.py` scr

[PATCH] D123810: [Cuda] Add initial support for wrapping CUDA images in the new driver.

jhuber6 updated this revision to Diff 426420. jhuber6 added a comment. Updating to use the `OffloadKind` enum rather than the string. I will also probably simplify some of the logic for handling multiple files here in a later patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[clang] 5a47acc - [Analyzer] Fix clang::ento::taint::dumpTaint definition

Author: Marco Antognini Date: 2022-05-02T17:44:06+02:00 New Revision: 5a47accda88c24d07cc48241be0f0078e8c9dfd0 URL: https://github.com/llvm/llvm-project/commit/5a47accda88c24d07cc48241be0f0078e8c9dfd0 DIFF: https://github.com/llvm/llvm-project/commit/5a47accda88c24d07cc48241be0f0078e8c9dfd0.dif

[PATCH] D124462: [Analyzer] Fix clang::ento::taint::dumpTaint definition

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a47accda88c: [Analyzer] Fix clang::ento::taint::dumpTaint definition (authored by mantognini). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124462/new/ ht

[PATCH] D123763: [randstruct] Enforce using a designated init for a randomized struct

sbc100 added a comment. This new test has been failing on the emscripten builders.. seemingly ever since it landed: https://ci.chromium.org/ui/p/emscripten-releases/builders/ci/linux-test-suites/b8815286583388131569/overview It also fails for me locally: ../llvm-build/bin/llvm-lit clang/test

[clang] f346398 - [Analyzer] Minor cleanups in StreamChecker

Author: Marco Antognini Date: 2022-05-02T17:50:10+02:00 New Revision: f34639828f5a99e6d724c092cc164be0c30a9f71 URL: https://github.com/llvm/llvm-project/commit/f34639828f5a99e6d724c092cc164be0c30a9f71 DIFF: https://github.com/llvm/llvm-project/commit/f34639828f5a99e6d724c092cc164be0c30a9f71.dif

[PATCH] D124681: [Analyzer] Minor cleanups in StreamChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rGf34639828f5a: [Analyzer] Minor cleanups in StreamChecker (authored by mantognini). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124681/new/ https://reviews

  1   2   3   >