yihanaa added inline comments.
================
Comment at: clang/lib/Sema/SemaChecking.cpp:427
+ llvm::SmallString<32> Indent;
+ Indent.resize(Depth * 4, ' ');
+ return getStringLiteral(Indent);
----------------
What do you think of PrintingPolicy.Indentation here?
================
Comment at: clang/lib/Sema/SemaChecking.cpp:433
+
+ llvm::StringRef getFormatSpecifier(QualType T) {
+ if (auto *BT = T->getAs<BuiltinType>()) {
----------------
I think this is better maintained in "clang/AST/FormatString.h". For example
analyze_printf::PrintfSpecifier can get format specifier, what do you all think
about?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124221/new/
https://reviews.llvm.org/D124221
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
