[PATCH] D119296: KCFI sanitizer

2022-04-29 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers requested changes to this revision. nickdesaulniers added a comment. This revision now requires changes to proceed. (tentatively removing my +1 since this patch has changed quite a bit since my initial review) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D122734: [CUDA][HIP] Fix mangling number for local struct

2022-04-29 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:682 +/// Current name mangling is for device name in host compilation. +bool MangleDeviceNameInHostCompilation = false; + } CUDANameMangleCtx; yaxunl wrote: > rnk wrote: > > It d

[PATCH] D124669: [flang][driver] Add support for -save-temps

2022-04-29 Thread Eric Schweitz via Phabricator via cfe-commits
schweitz added inline comments. Comment at: clang/include/clang/Driver/Options.td:3989 Group; -def save_temps_EQ : Joined<["-", "--"], "save-temps=">, Flags<[CC1Option, NoXarchOption]>, +def save_temps_EQ : Joined<["-", "--"], "save-temps=">, Flags<[CC1Option,FlangOpti

[clang] 8bdfc73 - [AMDGPU][clang] Definition of gfx11 subtarget

2022-04-29 Thread Joe Nash via cfe-commits
Author: Joe Nash Date: 2022-04-29T13:55:56-04:00 New Revision: 8bdfc73f633dca9859123b8596bcb521700c6a7f URL: https://github.com/llvm/llvm-project/commit/8bdfc73f633dca9859123b8596bcb521700c6a7f DIFF: https://github.com/llvm/llvm-project/commit/8bdfc73f633dca9859123b8596bcb521700c6a7f.diff LOG:

[PATCH] D124537: [AMDGPU][clang] Definition of gfx11 subtarget

2022-04-29 Thread Joe Nash via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8bdfc73f633d: [AMDGPU][clang] Definition of gfx11 subtarget (authored by Joe_Nash). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

2022-04-29 Thread Manoj Gupta via Phabricator via cfe-commits
manojgupta added a comment. Basically, I'm wondering if you'd be able to enable -fno-knr-function? Thanks. this looks promising. Any ideas when -fno-knr-function support was added? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122895/new/ http

[PATCH] D124534: Add a diagnostic for line directive of a gnu extension

2022-04-29 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:1356 + +PP.Diag(FlagTok, diag::ext_pp_gnu_line_directive); } else if (FlagVal == 2) { ken-matsui wrote: > aaron.ballman wrote: > > I speculate that this change is wrong. > > >

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

2022-04-29 Thread Manoj Gupta via Phabricator via cfe-commits
manojgupta added a comment. Unless I probably mis-interpreted something, -fno-knr-functions does not suppress the warning: https://godbolt.org/z/rbEfbbb33 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122895/new/ https://reviews.llvm.org/D122895

[PATCH] D119296: KCFI sanitizer

2022-04-29 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. In D119296#3481573 , @joaomoreira wrote: > I'm not an expert on LLVM's pipeline, but it just feels a little awkward and > redundant

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

2022-04-29 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D122895#3483163 , @manojgupta wrote: > Basically, I'm wondering if you'd be able to enable -fno-knr-function? > > Thanks. this looks promising. Any ideas when -fno-knr-function support was > added? Oops, I had a sli

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

2022-04-29 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D122895#3483175 , @manojgupta wrote: > Unless I probably mis-interpreted something, -fno-knr-functions does not > suppress the warning: https://godbolt.org/z/rbEfbbb33 Godbolt hasn't had the chance to catch up to ht

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

2022-04-29 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/IntegralLiteralExpressionMatcher.cpp:99 + + if (!Current->isLiteral() || isStringLiteral(Current->getKind()) || + !isIntegralConstant(*Current)) { LegalizeAdulthood wro

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

2022-04-29 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. To clarify my previous comments, I'm fine punting on the edge cases until user reports come in, so don't let them block this review if you feel strongly about not supporting them. But when user reports start coming in, at some point I might start asking to replace

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

2022-04-29 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a reviewer: erichkeane. aaron.ballman added subscribers: rsmith, erichkeane. aaron.ballman added a comment. Adding in @erichkeane just in case he spots anything I've missed. Comment at: clang/test/SemaCXX/annotate-type.cpp:2 +// RUN: %clang_cc1 %s -std=c++17

[PATCH] D124669: [flang][driver] Add support for -save-temps

2022-04-29 Thread Daniil Dudkin via Phabricator via cfe-commits
unterumarmung added inline comments. Comment at: clang/include/clang/Driver/Options.td:4131 def : Flag<["-"], "no-integrated-as">, Alias, - Flags<[CC1Option, NoXarchOption]>; + Flags<[CC1Option,FlangOption,NoXarchOption]>; Why not to add `FC1Option`

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

2022-04-29 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. I don't really know how useful this ends up being, these attributes (since they are part of `AttributedType` end up disappearing pretty quickly/easily. Anything that causes canonicalization will cause these to go away, they don't apply to references to these types,

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

2022-04-29 Thread Richard via Phabricator via cfe-commits
LegalizeAdulthood marked 3 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/IntegralLiteralExpressionMatcher.cpp:99 + + if (!Current->isLiteral() || isStringLiteral(Current->getKind()) || + !isIntegralCons

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

2022-04-29 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added a comment. >> The intent is to allow adding arbitrary annotations to types for use in >> static analysis tools This patch should not land until we see some real use cases to justify new hundreds of lines of code. We should more careful and take maintanence cost really into accou

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

2022-04-29 Thread Richard via Phabricator via cfe-commits
LegalizeAdulthood added a comment. In D124500#3483224 , @aaron.ballman wrote: > To clarify my previous comments, I'm fine punting on the edge cases until > user reports come in, so don't let them block this review if you feel > strongly about not suppo

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

2022-04-29 Thread Richard via Phabricator via cfe-commits
LegalizeAdulthood marked 3 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/unittests/clang-tidy/ModernizeModuleTest.cpp:66 +{false, "1.23"}, +{false, "0x1p3"}, +{false, R"("string")"}, LegalizeAdulthood

[PATCH] D123763: [randstruct] Enforce using a designated init for a randomized struct

2022-04-29 Thread Bill Wendling via Phabricator via cfe-commits
void added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:2171 if (Field == FieldEnd) { // We've run out of fields. We're done. stuij wrote: > @void Unfortunately this end of fields check will break the non-designated > initializer check

[PATCH] D124694: [randstruct] Move initializer check to be more effective

2022-04-29 Thread Bill Wendling via Phabricator via cfe-commits
void created this revision. void added reviewers: stuij, MaskRay, aaron.ballman. Herald added a subscriber: StephenFan. Herald added a project: All. void requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If a randomized structure has an initi

[PATCH] D123471: [CUDA] Create offloading entries when using the new driver

2022-04-29 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 updated this revision to Diff 426150. jhuber6 added a comment. Fixed missing info flag for `--offload-new-driver`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123471/new/ https://reviews.llvm.org/D123471 Files: clang/include/clang/Basi

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

2022-04-29 Thread Richard via Phabricator via cfe-commits
LegalizeAdulthood marked 7 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/IntegralLiteralExpressionMatcher.h:18-20 +// Parses an array of tokens and returns true if they conform to the rules of +// C++ for who

[PATCH] D124534: Add a diagnostic for line directive of a gnu extension

2022-04-29 Thread Ken Matsui via Phabricator via cfe-commits
ken-matsui added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:1356 + +PP.Diag(FlagTok, diag::ext_pp_gnu_line_directive); } else if (FlagVal == 2) { aaron.ballman wrote: > ken-matsui wrote: > > aaron.ballman wrote: > > > I speculate that this

[clang-tools-extra] 5227be8 - [clangd] More precisely enable clang warnings through ClangTidy options

2022-04-29 Thread Sam McCall via cfe-commits
Author: Sam McCall Date: 2022-04-29T22:24:34+02:00 New Revision: 5227be8b6aa0edb2edb0b76e1039a7dd5641c80a URL: https://github.com/llvm/llvm-project/commit/5227be8b6aa0edb2edb0b76e1039a7dd5641c80a DIFF: https://github.com/llvm/llvm-project/commit/5227be8b6aa0edb2edb0b76e1039a7dd5641c80a.diff LO

[PATCH] D124679: [clangd] More precisely enable clang warnings through ClangTidy options

2022-04-29 Thread Sam McCall via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5227be8b6aa0: [clangd] More precisely enable clang warnings through ClangTidy options (authored by sammccall). Changed prior to commit: https://re

[PATCH] D124131: Thread safety analysis: Store capability kind in CapabilityExpr

2022-04-29 Thread Aaron Puchert via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. aaronpuchert marked 2 inline comments as done. Closed by commit rGf8afb8fdedae: Thread safety analysis: Store capability kind in CapabilityExpr (authored by aaronpuchert). Changed prior to commit: https://reviews.llvm.org

[PATCH] D124127: Thread safety analysis: Pack CapabilityExpr using PointerIntPair (NFC)

2022-04-29 Thread Aaron Puchert via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGdd1790cd05ae: Thread safety analysis: Pack CapabilityExpr using PointerIntPair (NFC) (authored by aaronpuchert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D124128: Thread safety analysis: Store CapabilityExprs in ScopedLockableFactEntry (NFC)

2022-04-29 Thread Aaron Puchert via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd65c922450d1: Thread safety analysis: Store CapabilityExprs in ScopedLockableFactEntry (NFC) (authored by aaronpuchert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[clang] dd1790c - Thread safety analysis: Pack CapabilityExpr using PointerIntPair (NFC)

2022-04-29 Thread Aaron Puchert via cfe-commits
Author: Aaron Puchert Date: 2022-04-29T22:30:33+02:00 New Revision: dd1790cd05ae124e9e5d57dfe9279ff54f34b488 URL: https://github.com/llvm/llvm-project/commit/dd1790cd05ae124e9e5d57dfe9279ff54f34b488 DIFF: https://github.com/llvm/llvm-project/commit/dd1790cd05ae124e9e5d57dfe9279ff54f34b488.diff

[clang] d65c922 - Thread safety analysis: Store CapabilityExprs in ScopedLockableFactEntry (NFC)

2022-04-29 Thread Aaron Puchert via cfe-commits
Author: Aaron Puchert Date: 2022-04-29T22:30:33+02:00 New Revision: d65c922450d1fdf0f44f4a10a8f33b11c6c01bf5 URL: https://github.com/llvm/llvm-project/commit/d65c922450d1fdf0f44f4a10a8f33b11c6c01bf5 DIFF: https://github.com/llvm/llvm-project/commit/d65c922450d1fdf0f44f4a10a8f33b11c6c01bf5.diff

[PATCH] D124132: Thread safety analysis: Don't pass capability kind where not needed (NFC)

2022-04-29 Thread Aaron Puchert via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0314dbac026f: Thread safety analysis: Don't pass capability kind where not needed (NFC) (authored by aaronpuchert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang] f8afb8f - Thread safety analysis: Store capability kind in CapabilityExpr

2022-04-29 Thread Aaron Puchert via cfe-commits
Author: Aaron Puchert Date: 2022-04-29T22:30:33+02:00 New Revision: f8afb8fdedae04ad2670857c97925c439d47d862 URL: https://github.com/llvm/llvm-project/commit/f8afb8fdedae04ad2670857c97925c439d47d862 DIFF: https://github.com/llvm/llvm-project/commit/f8afb8fdedae04ad2670857c97925c439d47d862.diff

[clang] 0314dba - Thread safety analysis: Don't pass capability kind where not needed (NFC)

2022-04-29 Thread Aaron Puchert via cfe-commits
Author: Aaron Puchert Date: 2022-04-29T22:30:33+02:00 New Revision: 0314dbac026f58aaaf0a9ee4515f401f0d43ee76 URL: https://github.com/llvm/llvm-project/commit/0314dbac026f58aaaf0a9ee4515f401f0d43ee76 DIFF: https://github.com/llvm/llvm-project/commit/0314dbac026f58aaaf0a9ee4515f401f0d43ee76.diff

[PATCH] D124359: [clangd] Add inlay hints for mutable reference parameters

2022-04-29 Thread Tobias Ribizel via Phabricator via cfe-commits
upsj added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:448-450 +return Type->isReferenceType() && + !Type.getNonReferenceType().isConstQualified() + ? (Type->isLValueReferenceType() ? "&" : "&&") It pro

[PATCH] D124211: Add __builtin_kcfi_call_unchecked

2022-04-29 Thread Sami Tolvanen via Phabricator via cfe-commits
samitolvanen added a comment. LKML RFC: https://lore.kernel.org/lkml/20220429203644.2868448-1-samitolva...@google.com/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124211/new/ https://reviews.llvm.org/D124211

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

2022-04-29 Thread Richard via Phabricator via cfe-commits
LegalizeAdulthood updated this revision to Diff 426160. LegalizeAdulthood marked an inline comment as done. LegalizeAdulthood added a comment. Update from review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124500/new/ https://reviews.llvm.org/D124500 Files: clang-tools-ext

[PATCH] D124650: [clang-tidy] Simplify boolean expressions by DeMorgan's theorem

2022-04-29 Thread Richard via Phabricator via cfe-commits
LegalizeAdulthood added a comment. In D124650#3481514 , @LegalizeAdulthood wrote: > General question: > > There is the question of whether or not the replacement should have `()`s > around the whole > thing because we don't analyze the context to see if

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

2022-04-29 Thread Vang Thao via Phabricator via cfe-commits
vangthao added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:1178-1266 + +void AMDGPUAsmPrinter::emitResourceUsageRemarks( +const MachineFunction &MF, const SIProgramInfo &CurrentProgramInfo, +bool isModuleEntryFunction, bool hasMAIInsts) { + i

[PATCH] D124650: [clang-tidy] Simplify boolean expressions by DeMorgan's theorem

2022-04-29 Thread Richard via Phabricator via cfe-commits
LegalizeAdulthood updated this revision to Diff 426163. LegalizeAdulthood added a comment. Surround replacements with parens CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124650/new/ https://reviews.llvm.org/D124650 Files: clang-tools-extra/clang-tidy/readability/SimplifyBooleanExprC

[PATCH] D124700: [AMDGPU] Add llvm.amdgcn.sched.barrier intrinsic

2022-04-29 Thread Austin Kerbow via Phabricator via cfe-commits
kerbowa created this revision. Herald added subscribers: hsmhsm, foad, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl, arsenm. Herald added a project: All. kerbowa requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, wdng. Herald added proj

[PATCH] D124701: [clang] Honor __attribute__((no_builtin("foo"))) on functions

2022-04-29 Thread Stephen Long via Phabricator via cfe-commits
steplong created this revision. steplong added reviewers: gchatelet, aaron.ballman, courbet, rsmith. Herald added a project: All. steplong requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Support for `__attribute__((no_builtin("foo")))` was

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

2022-04-29 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:1222 + &MF.front()) + << "ScratchSize [bytes/thread]: " + << ore::NV("ScratchSize", CurrentProgramInfo.ScratchSize); -

[PATCH] D124700: [AMDGPU] Add llvm.amdgcn.sched.barrier intrinsic

2022-04-29 Thread Austin Kerbow via Phabricator via cfe-commits
kerbowa updated this revision to Diff 426169. kerbowa added a comment. Add mir tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124700/new/ https://reviews.llvm.org/D124700 Files: clang/include/clang/Basic/BuiltinsAMDGPU.def clang/test/Cod

[PATCH] D124702: [MSVC] Add support for pragma function

2022-04-29 Thread Stephen Long via Phabricator via cfe-commits
steplong created this revision. steplong added reviewers: rnk, rsmith, whunt, hans, thakis. Herald added a project: All. steplong requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. MSVC pragma function tells the compiler to generate calls to f

[PATCH] D124700: [AMDGPU] Add llvm.amdgcn.sched.barrier intrinsic

2022-04-29 Thread Stanislav Mekhanoshin via Phabricator via cfe-commits
rampitec added a comment. You do not handle masks other than 0 yet? Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:219 +// MASK = 0: No instructions may be scheduled across SCHED_BARRIER. +// MASK = 1: Non-memory, non-side-effect producing instructions may be +//

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

2022-04-29 Thread Mitch Phillips via Phabricator via cfe-commits
hctim updated this revision to Diff 426172. hctim marked an inline comment as done. hctim added a comment. Herald added subscribers: rupprecht, MaskRay, emaste. Herald added a reviewer: jhenderson. Update test, rebase off of string debuginfo. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D124688: [clangd] parse all make_unique-like functions in preamble

2022-04-29 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added reviewers: sammccall, kadircet. nridge added a comment. I'll have a proper look at this when I get a chance but meanwhile adding Sam and Kadir who may have thoughts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124688/new/ https://rev

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

2022-04-29 Thread Mitch Phillips via Phabricator via cfe-commits
hctim updated this revision to Diff 426175. hctim added a comment. (restoring after uploading the diff for D123538 here accidentally) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123534/new/ https://reviews.llvm

[PATCH] D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals

2022-04-29 Thread Mitch Phillips via Phabricator via cfe-commits
hctim updated this revision to Diff 426176. hctim added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. (restoring after uploading the diff for D123534 here accidentally) Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals

2022-04-29 Thread Mitch Phillips via Phabricator via cfe-commits
hctim updated this revision to Diff 426177. hctim added a comment. (restoring after uploading the diff for D123534 here accidentally) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123538/new/ https://reviews.llvm

[PATCH] D123884: [HLSL][clang][Driver] Support validator version command line option.

2022-04-29 Thread Chris Bieneman via Phabricator via cfe-commits
beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123884/new/ https://reviews.llvm.org/D123884 ___

[PATCH] D124700: [AMDGPU] Add llvm.amdgcn.sched.barrier intrinsic

2022-04-29 Thread Austin Kerbow via Phabricator via cfe-commits
kerbowa added a comment. In D124700#3483556 , @rampitec wrote: > You do not handle masks other than 0 yet? We handle 0 and 1 only. Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:219 +// MASK = 0: No instructions may be sched

[PATCH] D114115: [Driver] Support for compressed debug info on Fuchsia

2022-04-29 Thread Petr Hosek via Phabricator via cfe-commits
phosek updated this revision to Diff 426182. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114115/new/ https://reviews.llvm.org/D114115 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp clang/test/Driver/compress.c Index: clang/test/Driver/compre

[PATCH] D114115: [Driver] Support for compressed debug info on Fuchsia

2022-04-29 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. In D114115#3477967 , @probinson wrote: > Lit is aware of zlib's presence or absence, you could use `REQUIRES: zlib` > (or you might factor that bit out into its own test with the REQUIRES). I have moved that test to `clang/test/D

[clang] 4bdb505 - [Driver] Support for compressed debug info on Fuchsia

2022-04-29 Thread Petr Hosek via cfe-commits
Author: Petr Hosek Date: 2022-04-29T15:38:51-07:00 New Revision: 4bdb505d62659491b8b935e0c2e19584839eab74 URL: https://github.com/llvm/llvm-project/commit/4bdb505d62659491b8b935e0c2e19584839eab74 DIFF: https://github.com/llvm/llvm-project/commit/4bdb505d62659491b8b935e0c2e19584839eab74.diff LO

[PATCH] D124700: [AMDGPU] Add llvm.amdgcn.sched.barrier intrinsic

2022-04-29 Thread Stanislav Mekhanoshin via Phabricator via cfe-commits
rampitec added a comment. In D124700#3483609 , @kerbowa wrote: > In D124700#3483556 , @rampitec > wrote: > >> You do not handle masks other than 0 yet? > > We handle 0 and 1 only. Do you mean 1 is supported simp

[PATCH] D124534: Add a diagnostic for line directive of a gnu extension

2022-04-29 Thread Ken Matsui via Phabricator via cfe-commits
ken-matsui updated this revision to Diff 426185. ken-matsui added a comment. Add a diagnostic for line directive of a gnu extension Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124534/new/ https://reviews.llvm.org/D124534 Files: clang/include/c

[PATCH] D124348: [RISCV]Add CTZ Intrinsic for ZBB in Clang

2022-04-29 Thread Chang Hu via Phabricator via cfe-commits
joker881 updated this revision to Diff 426187. joker881 added a comment. update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124348/new/ https://reviews.llvm.org/D124348 Files: clang/include/clang/Basic/BuiltinsRISCV.def clang/lib/CodeGe

[PATCH] D124679: [clangd] More precisely enable clang warnings through ClangTidy options

2022-04-29 Thread Kirill Stoimenov via Phabricator via cfe-commits
kstoimenov added inline comments. Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:558 + TU.ClangTidyProvider = addClangArgs({"-Wunused"}, "*"); + EXPECT_THAT(*TU.build().getDiagnostics(), ElementsAre(UnusedFooWarning)); + // And we can explicitly exclude a

[PATCH] D123884: [HLSL][clang][Driver] Support validator version command line option.

2022-04-29 Thread Xiang Li via Phabricator via cfe-commits
python3kgae updated this revision to Diff 426191. python3kgae added a comment. NO change, fix UNKNOWN REVISION when arc land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123884/new/ https://reviews.llvm.org/D123884 Files: clang/include/clang/B

[clang] 73417c5 - [HLSL][clang][Driver] Support validator version command line option.

2022-04-29 Thread via cfe-commits
Author: python3kgae Date: 2022-04-29T16:48:08-07:00 New Revision: 73417c517644db5c419c85c0b3cb6750172fcab5 URL: https://github.com/llvm/llvm-project/commit/73417c517644db5c419c85c0b3cb6750172fcab5 DIFF: https://github.com/llvm/llvm-project/commit/73417c517644db5c419c85c0b3cb6750172fcab5.diff L

[PATCH] D123884: [HLSL][clang][Driver] Support validator version command line option.

2022-04-29 Thread Xiang Li via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG73417c517644: [HLSL][clang][Driver] Support validator version command line option. (authored by python3kgae). Repository: rG LLVM Github Monorepo

[clang] 19978e0 - [RISCV]Add CTZ Intrinsic for ZBB in Clang

2022-04-29 Thread via cfe-commits
Author: joker881 Date: 2022-04-30T08:18:10+08:00 New Revision: 19978e08749f5f68fbd535121c4f2ed7297b3a4f URL: https://github.com/llvm/llvm-project/commit/19978e08749f5f68fbd535121c4f2ed7297b3a4f DIFF: https://github.com/llvm/llvm-project/commit/19978e08749f5f68fbd535121c4f2ed7297b3a4f.diff LOG:

[PATCH] D124348: [RISCV]Add CTZ Intrinsic for ZBB in Clang

2022-04-29 Thread Chang Hu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG19978e08749f: [RISCV]Add CTZ Intrinsic for ZBB in Clang (authored by joker881). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124348/new/ https://reviews.ll

[PATCH] D124700: [AMDGPU] Add llvm.amdgcn.sched.barrier intrinsic

2022-04-29 Thread Austin Kerbow via Phabricator via cfe-commits
kerbowa added a comment. In D124700#3483633 , @rampitec wrote: > In D124700#3483609 , @kerbowa wrote: > >> In D124700#3483556 , @rampitec >> wrote: >> >>> You do not hand

[PATCH] D124700: [AMDGPU] Add llvm.amdgcn.sched.barrier intrinsic

2022-04-29 Thread Stanislav Mekhanoshin via Phabricator via cfe-commits
rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. In D124700#3483715 , @kerbowa wrote: > In D124700#3483633 , @rampitec > wrote: > >> In D124700#3483609 <

[PATCH] D124679: [clangd] More precisely enable clang warnings through ClangTidy options

2022-04-29 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. This broke check-clangd everywhere, e.g.: https://lab.llvm.org/buildbot/#/builders/109/builds/37635 http://45.33.8.238/linux/75019/step_9.txt http://45.33.8.238/macm1/34369/step_9.txt http://45.33.8.238/win/57278/step_9.txt Please run tests before committing, please watch

[clang] 26c82f3 - Revert "[clangd] More precisely enable clang warnings through ClangTidy options"

2022-04-29 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2022-04-29T20:34:10-04:00 New Revision: 26c82f3d1de11cdada57e499b63a05d24e18b656 URL: https://github.com/llvm/llvm-project/commit/26c82f3d1de11cdada57e499b63a05d24e18b656 DIFF: https://github.com/llvm/llvm-project/commit/26c82f3d1de11cdada57e499b63a05d24e18b656.diff LO

[PATCH] D124708: Fix "the the" typo in documentation and user facing strings

2022-04-29 Thread Brian Tracy via Phabricator via cfe-commits
briantracy created this revision. briantracy added a reviewer: echristo. Herald added subscribers: martong, kerbowa, hiraditya, jvesely. Herald added a project: All. briantracy requested review of this revision. Herald added projects: clang, libc++, LLVM. Herald added subscribers: llvm-commits, lib

[clang] 9f7ac52 - [OpenMP] Fix printing commands twice in verbose mode

2022-04-29 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2022-04-29T23:06:22-04:00 New Revision: 9f7ac522ae1cacd954e12f89cd4f3d049251188e URL: https://github.com/llvm/llvm-project/commit/9f7ac522ae1cacd954e12f89cd4f3d049251188e DIFF: https://github.com/llvm/llvm-project/commit/9f7ac522ae1cacd954e12f89cd4f3d049251188e.diff

[clang] 02c7de3 - [RISCV] Precommit test for D124509

2022-04-29 Thread Kito Cheng via cfe-commits
Author: Kito Cheng Date: 2022-04-30T11:09:12+08:00 New Revision: 02c7de3a4c32f2456df09df07e473bb95c85529c URL: https://github.com/llvm/llvm-project/commit/02c7de3a4c32f2456df09df07e473bb95c85529c DIFF: https://github.com/llvm/llvm-project/commit/02c7de3a4c32f2456df09df07e473bb95c85529c.diff LO

[PATCH] D124510: [RISCV] Precommit test for D124509

2022-04-29 Thread Kito Cheng via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG02c7de3a4c32: [RISCV] Precommit test for D124509 (authored by kito-cheng). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[clang] 41b951c - [RISCV] Fix int16 -> __fp16 conversion code gen

2022-04-29 Thread Kito Cheng via cfe-commits
Author: Kito Cheng Date: 2022-04-30T11:10:44+08:00 New Revision: 41b951c92931b65c25485b224901d8cb00163b8e URL: https://github.com/llvm/llvm-project/commit/41b951c92931b65c25485b224901d8cb00163b8e DIFF: https://github.com/llvm/llvm-project/commit/41b951c92931b65c25485b224901d8cb00163b8e.diff LO

[PATCH] D124509: [RISCV] Fix int16 -> __fp16 conversion code gen

2022-04-29 Thread Kito Cheng via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG41b951c92931: [RISCV] Fix int16 -> __fp16 conversion code gen (authored by kito-cheng). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D124700: [AMDGPU] Add llvm.amdgcn.sched.barrier intrinsic

2022-04-29 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. Can you add a test to make sure the hazard recognizer and code size estimate don’t think this is a real instruction Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124700/new/ https://reviews.llvm.org/D124700 ___

<    1   2