[clang] e59335e - [clang][DR] Add test for DR1227 and mark it as complete

Author: Markus Böck Date: 2022-03-30T09:25:52+02:00 New Revision: e59335e891105d75ece5f7f4c40b5eaff6ce2f63 URL: https://github.com/llvm/llvm-project/commit/e59335e891105d75ece5f7f4c40b5eaff6ce2f63 DIFF: https://github.com/llvm/llvm-project/commit/e59335e891105d75ece5f7f4c40b5eaff6ce2f63.diff L

[PATCH] D122682: [clang][DR] Add test for DR1227 and mark it as complete

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe59335e89110: [clang][DR] Add test for DR1227 and mark it as complete (authored by zero9178). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D122471: [IR] Require intrinsic struct return type to be anonymous

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a72391f609f: [IR] Require intrinsic struct return type to be anonymous (authored by nikic). Herald added a project: clang. Herald added a subscriber

[clang] 8a72391 - [IR] Require intrinsic struct return type to be anonymous

Author: Nikita Popov Date: 2022-03-30T09:51:24+02:00 New Revision: 8a72391f609f016b0aef17e728aca65027a80cc4 URL: https://github.com/llvm/llvm-project/commit/8a72391f609f016b0aef17e728aca65027a80cc4 DIFF: https://github.com/llvm/llvm-project/commit/8a72391f609f016b0aef17e728aca65027a80cc4.diff

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:279 + cast_or_null(Env.getValue(*ComparisonExprLoc))) { +Env.setValue(*ComparisonExprLoc, + Env.m

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

arichardson added inline comments. Comment at: clang/CMakeLists.txt:520 + ON "${CMAKE_BUILD_TYPE} MATCHES Debug" OFF) +if(CLANG_CRASH_SAVE_TEMPS) + add_definitions(-DCLANG_CRASH_SAVE_TEMPS) Could you add this to the config.h header instead?

[PATCH] D122659: [clang][preprocessor] Allow calling DumpToken() on annotation tokens

tbaeder updated this revision to Diff 419073. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122659/new/ https://reviews.llvm.org/D122659 Files: clang/lib/Lex/Preprocessor.cpp Index: clang/lib/Lex/Preprocessor.cpp === ---

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

zixuan-wu updated this revision to Diff 419076. zixuan-wu added a comment. Herald added subscribers: StephenFan, dexonsmith, MaskRay. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121445/new/ https://reviews.llvm.org/D121445 Files: clang/lib/Basic/CMakeLists.txt c

[PATCH] D122404: [clang][AArc64][SVE] Add support for comparison operators on SVE types

peterwaller-arm accepted this revision. peterwaller-arm added a comment. This revision is now accepted and ready to land. LGTM, looks like the formatter might have hit some lines you didn't intend to change -- if it's not too invasive perhaps worth a seperate NFC patch to format the file? ===

[PATCH] D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions

martong added a comment. In D103094#3403075 , @ASDenysPetrov wrote: > Ping. I am still interested in this! I am sorry for being inactive with it lately, I hope I'll have time soon to continue the review of this patch stack. CHANGES SINCE LAST ACTION

[PATCH] D122712: Make test case warning more specific for pattern match

rs created this revision. rs added a reviewer: benshi001. Herald added subscribers: Jim, dylanmckay. Herald added a project: All. rs requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It's possible that other compilers based on llvm might prod

[PATCH] D121387: [analyzer] ClangSA should tablegen doc urls refering to the main doc page

whisperity added a comment. (Side note: you should avoid the list-expansion syntax in URLs because browsers do not understand them and result in links that are not leading anywhere.) I like this. We should continue getting to the point where the documentation is having a uniform layout. CHANG

[PATCH] D122587: [clang][NFC] Extract the EmitAssemblyHelper::TargetTriple member

psamolysov-intel added a comment. Thank you @tejohnson for the approve. If there are no objections from someone could you (or another committer) help me with the landing, please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122587/new/ https://re

[PATCH] D120874: [C++20] [Modules] Use '-' as the separator of partitions when searching in filesystems

arames added a comment. I was was asked to chime in to assess whether this patch could be a problem for the prebuilt-implicit clang modules workflow. No problem here. With prebuilt modules, the output file name has to be specified manually. So the mapping does not change the existing requirement o

[PATCH] D122713: [RISCV] [NFC] Add tests for vector load/store overloaded intrinsics of FP16

Chenbing.Zheng created this revision. Chenbing.Zheng added reviewers: craig.topper, HsiangKai, frasercrmck, benshi001. Chenbing.Zheng added a project: LLVM. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benn

[PATCH] D122409: [libclang] Add missing CursorKind enums defined in Index.h.

sighingnow added a comment. Ping @jdoerfert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122409/new/ https://reviews.llvm.org/D122409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D122712: Make test case warning more specific for pattern match

benshi001 added a comment. I do not like this change, since 1. actually there may be many kinds of warnings emitted by the clang-driver-avr depending on different options, and this single line `// NOWARN-NOT: warning:` means non of these possible warnings will be emitted. 2. we may add/delete/

[clang] cf4a67b - Don't diagnostic atomic object access as UB in an unevaluated context

Author: Aaron Ballman Date: 2022-03-30T07:12:49-04:00 New Revision: cf4a67bcbbb109347b1e2d6cedf69bae142a182f URL: https://github.com/llvm/llvm-project/commit/cf4a67bcbbb109347b1e2d6cedf69bae142a182f DIFF: https://github.com/llvm/llvm-project/commit/cf4a67bcbbb109347b1e2d6cedf69bae142a182f.diff

[PATCH] D122681: Don't diagnostic atomic object access as UB in an unevaluated context

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the reviews, I've commit in cf4a67bcbbb109347b1e2d6cedf69bae142a182f . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[clang] cebbfd3 - [RISCV] Add index check for vset/vget

Author: wangpc Date: 2022-03-30T19:29:13+08:00 New Revision: cebbfd3d22b48cb3681a326bcbd23aaca1ec URL: https://github.com/llvm/llvm-project/commit/cebbfd3d22b48cb3681a326bcbd23aaca1ec DIFF: https://github.com/llvm/llvm-project/commit/cebbfd3d22b48cb3681a326bcbd23aaca1ec.diff LOG: [

[PATCH] D122629: [RISCV] Add index check for vset/vget

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcebbfd3d2555: [RISCV] Add index check for vset/vget (authored by pcwang-thead). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D120992: [analyzer] ReverseNull: New checker to warn for pointer value conditions, if the pointer value is unconditionally non-null

Szelethus abandoned this revision. Szelethus added a comment. Very well :) Let's abandon this in its current state, I share this sentiment: In D120992#3368118 , @NoQ wrote: > What I'm trying to say here is, I honestly think re-doing it as CFG-based > sh

[PATCH] D122627: [HLSL] Fix MSFT Attribute parsing, add numthreads

aaron.ballman added inline comments. Comment at: clang/test/SemaHLSL/num_threads.hlsl:48 +#endif + + There are a few test cases that are missing here: 1) Writing the attribute on the wrong subject. 2) Passing no args to the attribute, passing too many args to th

[PATCH] D122699: [HLSL] Add Semantic syntax, and SV_GroupIndex

aaron.ballman added a comment. You should also add parsing test coverage as this is parsing new syntax. Comment at: clang/include/clang/Basic/AttrDocs.td:6386 + let Content = [{ +The `SV_GroupIndex` semantic when applied to an input parameter specifies a data +binding to map

[PATCH] D122659: [clang][preprocessor] Allow calling DumpToken() on annotation tokens

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! I don't think there's a particularly strong need to add test coverage for this as the dump method is a debugging aid. CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr.

cor3ntin updated this revision to Diff 419120. cor3ntin added a comment. - Add a commebt to clarify which diagnostic message is being printed, as per Aaron suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122249/new/ https://reviews.llvm.

[PATCH] D122698: [clangd] Add support to extract method for ExtractFunction Tweak

sammccall added a comment. Thanks for doing this, it looks great! A few comments on: - a few on cases that I think aren't handled quite right - structure of the new code - structure of the *old* code: names etc that no longer fit after these changes There's also the ugliness around merging edit

[PATCH] D116635: Add warning to detect when calls passing arguments are made to functions without prototypes.

aaron.ballman added a comment. FWIW, now that https://discourse.llvm.org/t/rfc-enabling-wstrict-prototypes-by-default-in-c has reached a conclusion, I think this patch may be worth resurrecting, if you're interested. https://discourse.llvm.org/t/rfc-enabling-wstrict-prototypes-by-default-in-c/

[PATCH] D109688: [AMDGPU] ASan Patches for OpenMP

ampandey-AMD abandoned this revision. ampandey-AMD added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. The changes proposed here require hostrpc to be upstreamed first which may not be available for the time begin. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D122712: Make test case warning more specific for pattern match

rs added a comment. In D122712#3416238 , @benshi001 wrote: > I do not like this change, since > > 1. actually there may be many kinds of warnings emitted by the > clang-driver-avr depending on different options, and this single line `// > NOWARN-NOT: wa

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

rengolin added a comment. I just applied this to a recent HEAD and got a few warnings. Please make sure there are no new warnings on changes / new files. /home/rengolin/devel/llvm-project/llvm/lib/Target/CSKY/CSKYInstrFormats.td:658:62: warning: unused template argument: R_Z_2:pattern clas

[PATCH] D122589: Additionally set f32 mode with denormal-fp-math

arsenm added a comment. I think my intent here was to not emit denormal-fp-math-f32 at all if it wasn't specified (i.e. denormal-fp-math-f32 is a special override only really used for AMDGPU) The interaction between the two and the default is supposed to be handled by the backend interpretatio

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp updated this revision to Diff 419126. quinnp added a comment. Moving testcases that require code generation from `clang/test/Sema/ppc-pair-mma-types.c` to `clang/test/CodeGen/PowerPC/ppc-mma-types.c` and `clang/test/CodeGen/PowerPC/builtins-ppc-pair-mma-types.c`. This is because some of

[PATCH] D122471: [IR] Require intrinsic struct return type to be anonymous

uabelho added a comment. Hello, No idea what is happening yet but I've seen some pretty nasty memory consumption by opt that I bisected to this patch. Any idea what could be going on? I'll see if I can see if I can extract some reproducer. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D122627: [HLSL] Fix MSFT Attribute parsing, add numthreads

beanz added inline comments. Comment at: clang/test/SemaHLSL/num_threads.hlsl:48 +#endif + + aaron.ballman wrote: > There are a few test cases that are missing here: > > 1) Writing the attribute on the wrong subject. > 2) Passing no args to the attribute, passin

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp marked an inline comment as done. quinnp added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15208 - for (unsigned i = 0, e = E->getNumArgs(); i != e; i++) { -if (E->getArg(i)->getType()->isArrayType()) - Ops.push_back(EmitArrayToPointerDecay(E->ge

[PATCH] D122704: [Clang][CodeGen]Beautify dump format, add indent for nested struct and struct members

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. This seems fine to me. I won't likely have time to commit this for a while, but you should be able to apply for commit-rights now and do it yourself. Repository: rG LLVM Github Mon

[PATCH] D122699: [HLSL] Add Semantic syntax, and SV_GroupIndex

beanz added a comment. Will try to update today. Thank you! Comment at: clang/lib/Parse/ParseDecl.cpp:6965-6966 // Parse GNU attributes, if present. MaybeParseGNUAttributes(ParmDeclarator); +MaybeParseHLSLSemantics(DS.getAttributes()); aaron.bal

[PATCH] D116597: [analyzer] Don't track function calls as control dependencies

Szelethus updated this revision to Diff 419132. Szelethus marked an inline comment as done. Szelethus added a comment. Herald added a project: All. Fixes according to reviewer comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116597/new/ https://reviews.llvm.org/D116597 Files:

[PATCH] D116597: [analyzer] Don't track function calls as control dependencies

Szelethus marked 2 inline comments as done. Szelethus added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:5908-5909 +void CFG::dump(bool ShowColors) const { dump(LangOptions{}, ShowColors); } + /// print - A simple pretty printer of a CFG that outputs to an ostream.

[PATCH] D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr.

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. This LGTM (with minor comment). Please wait for Aaron to respond re: the handling of template instantiations. Comment at: clang/lib/Sema/Sema

[PATCH] D122471: [IR] Require intrinsic struct return type to be anonymous

uabelho added a comment. In D122471#3416528 , @uabelho wrote: > Hello, > > No idea what is happening yet but I've seen some pretty nasty memory > consumption by opt that I bisected to this patch. > > Any idea what could be going on? > > I'll see if I can

[PATCH] D122728: [OpenCL] opencl-c.h: Add const to get_image_num_samples

svenvh created this revision. svenvh added a reviewer: azabaznov. svenvh added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. Herald added a project: All. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Align with the `-fdeclare-opencl-built

[clang] 5b38292 - [NFC] Use range based loop.

Author: Jun Zhang Date: 2022-03-30T22:44:34+08:00 New Revision: 5b38292d5d776439b54e7cc02c7a20c58717f3d2 URL: https://github.com/llvm/llvm-project/commit/5b38292d5d776439b54e7cc02c7a20c58717f3d2 DIFF: https://github.com/llvm/llvm-project/commit/5b38292d5d776439b54e7cc02c7a20c58717f3d2.diff LOG

[PATCH] D122657: [NFC] Use range based loop.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5b38292d5d77: [NFC] Use range based loop. (authored by junaire).

[PATCH] D122704: [Clang][CodeGen]Beautify dump format, add indent for nested struct and struct members

yihanaa added a comment. In D122704#3416538 , @erichkeane wrote: > This seems fine to me. I won't likely have time to commit this for a while, > but you should be able to apply for commit-rights now and do it yourself. Sorry for taking so long to repl

[PATCH] D122471: [IR] Require intrinsic struct return type to be anonymous

nikic added a comment. @uabelho You shouldn't need to update intrinsic definitions (though you might want to update how you codegen the intrinsics). It sounds like the auto-upgrade code is going into an infinite loop in your case, but it's not really obvious to me how/why that would happen (or

[PATCH] D122471: [IR] Require intrinsic struct return type to be anonymous

nikic added a comment. Oh wait, do I see correctly that your intrinsic returns an overloaded type that happens to be a struct, rather than returning a struct defined in the intrinsic definition? I hadn't considered that case, and it's possible the auto-upgrade code is broken for that. Reposit

[PATCH] D121165: [pseudo] Add crude heuristics to choose taken preprocessor branches.

sammccall marked 6 inline comments as done. sammccall added inline comments. Comment at: clang/lib/Tooling/Syntax/Pseudo/DirectiveMap.cpp:210 +namespace { +class BranchChooser { +public: hokein wrote: > We evaluate each conditional directive *independently*, I wo

[PATCH] D121165: [pseudo] Add crude heuristics to choose taken preprocessor branches.

sammccall updated this revision to Diff 419142. sammccall marked 2 inline comments as done. sammccall added a comment. Herald added a project: clang-tools-extra. Rebase and address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121165/new/

[PATCH] D122069: [Object] Add binary format for bundling offloading metadata

saiislam added a comment. Hey @jhuber6 , as discussed in multi-company meeting, I think that we will need at least an arch field somewhere in this. We would like to create multi-arch binaries so that runtime can load the compatible one on its own. You may even consider using TargetID Format

[PATCH] D116597: [analyzer] Don't track function calls as control dependencies

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. I'm convinced! Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1968 +static const Expr *peelOffOuterExpr(const Expr *Ex, const ExplodedNode *N) { + E

[PATCH] D122069: [Object] Add binary format for bundling offloading metadata

jhuber6 added a comment. In D122069#3416694 , @saiislam wrote: > Hey @jhuber6 , as discussed in multi-company meeting, I think that we will > need at least an arch field somewhere in this. We would like to create > multi-arch binaries so that runtime ca

[PATCH] D122732: [Clang][AArch64][SVE] Allow subscript operator for SVE types

DavidTruby created this revision. Herald added subscribers: psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added a project: All. DavidTruby requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Undefined behaviour is j

[PATCH] D122608: Fix behavior of ifuncs with 'used' extern "C" static functions

erichkeane updated this revision to Diff 419143. erichkeane added a comment. Going through @tahonermann 's comments to attempt to allow multiple ifunc references, I ended up down the rabbit hole. Turns out there are ways for there to be a ConstantExpr bitcast in the way that needs to be correct

[PATCH] D122734: [HIP] Fix mangling number for local struct

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall. Herald added a project: All. yaxunl requested review of this revision. MSVC and Itanium mangling use different mangling numbers for function-scope structs, which causes inconsistent mangled kernel names in device and host compila

[PATCH] D122471: [IR] Require intrinsic struct return type to be anonymous

nikic added a comment. @uabelho Can you please check whether https://github.com/llvm/llvm-project/commit/d6887256c2cae1b1b721bd47459be6d86003db6f fixes the problem you're seeing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122471/new/ https://r

[PATCH] D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr.

cor3ntin updated this revision to Diff 419158. cor3ntin added a comment. Add braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122249/new/ https://reviews.llvm.org/D122249 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Se

[PATCH] D120874: [C++20] [Modules] Use '-' as the separator of partitions when searching in filesystems

iains accepted this revision. iains added a comment. This revision is now accepted and ready to land. In D120874#3416130 , @arames wrote: > I was was asked to chime in to assess whether this patch could be a problem > for > the prebuilt-implicit clang mo

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

abrachet updated this revision to Diff 419165. abrachet marked 2 inline comments as done. abrachet added a comment. - Define `CLANG_CRASH_SAVE_TEMPS` in config.h and not with `add_definitions` - Add `CLANG_CRASH_SAVE_TEMPS` env var to force emitting individual preprocessed sources CHANGES SINCE

[clang] ae4dce8 - [clang][ABI] New C++20 module mangling scheme

Author: Nathan Sidwell Date: 2022-03-30T08:51:27-07:00 New Revision: ae4dce8659f313ca2034782583d31993212fa8bd URL: https://github.com/llvm/llvm-project/commit/ae4dce8659f313ca2034782583d31993212fa8bd DIFF: https://github.com/llvm/llvm-project/commit/ae4dce8659f313ca2034782583d31993212fa8bd.diff

[PATCH] D122256: [clang][ABI] New C++20 module mangling scheme

This revision was automatically updated to reflect the committed changes. Closed by commit rGae4dce8659f3: [clang][ABI] New C++20 module mangling scheme (authored by urnathan). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.o

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

abrachet marked 2 inline comments as done. abrachet added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1434 StringRef AdditionalInformation, CompilationDiagnosticReport *Report) { +#ifdef CLANG_CRASH_SAVE_TEMPS + constexpr bool SaveReproTemps = true; ---

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

abrachet updated this revision to Diff 419170. abrachet marked 2 inline comments as done. abrachet added a comment. reabase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122335/new/ https://reviews.llvm.org/D122335 Files: clang/CMakeLists.txt clang/docs/ReleaseNotes.rst clang/inc

[PATCH] D121271: [C++20] [Modules] Don't generate strong function of a partition in importing modules

iains added a comment. it looks like the first part of the C++20 mangling was just landed, so perhaps you can revisit this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121271/new/ https://reviews.llvm.org/D121271 ___

[clang] 6e33e45 - [ASTMatchers] Output currently matching node on crash

Author: Nathan James Date: 2022-03-30T17:14:00+01:00 New Revision: 6e33e45b943061f79ab6de1b60d04d4c6f32f8f9 URL: https://github.com/llvm/llvm-project/commit/6e33e45b943061f79ab6de1b60d04d4c6f32f8f9 DIFF: https://github.com/llvm/llvm-project/commit/6e33e45b943061f79ab6de1b60d04d4c6f32f8f9.diff

[PATCH] D122529: [ASTMatchers] Output currently matching node on crash

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e33e45b9430: [ASTMatchers] Output currently matching node on crash (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D122529?vs=418473&id=419178#toc Repository: rG LLVM Githu

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

paulkirth updated this revision to Diff 419181. paulkirth added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115907/new/ https://reviews.llvm.org/D115907 Files: clang/docs/MisExpect.rst clang/docs/ReleaseNotes.rst clang/do

[PATCH] D122713: [RISCV] [NFC] Add tests for vector load/store overloaded intrinsics of FP16

craig.topper added a comment. These tests files are already too long and have been timing out in phabricator. @4vtomat has a patch D122370 to split them up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122713/ne

[PATCH] D122471: [IR] Require intrinsic struct return type to be anonymous

uabelho added a comment. In D122471#3416797 , @nikic wrote: > @uabelho Can you please check whether > https://github.com/llvm/llvm-project/commit/d6887256c2cae1b1b721bd47459be6d86003db6f > fixes the problem you're seeing? Hi @nikic Yes, that patch sol

[PATCH] D122589: Additionally set f32 mode with denormal-fp-math

dcandler added a comment. The issue I found was trying to use getDefaultDenormalModeForType during constant folding to account for denormals (https://reviews.llvm.org/D116952). Setting denormal-fp-math to a non-IEEE mode without specifying denormal-fp-math-f32 still results in the denormal-fp-m

[PATCH] D122648: [clang][extractapi] Tie API and serialization to the FrontendAction

dang updated this revision to Diff 419197. dang marked 2 inline comments as done. dang added a comment. Rebase on top of latest changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122648/new/ https://reviews.llvm.org/D122648 Files: clang/inclu

[PATCH] D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM Comment at: clang/lib/Sema/SemaDeclCXX.cpp:1905 +if (SemaRef.LangOpts.CPlusPlus2b) { + if (!VD->getType()->isLiteralType(SemaRef.Context)) +SemaRef.Diag(VD->getLocation(), ---

[clang] 61d67c8 - Revert "[ASTMatchers] Output currently matching node on crash"

Author: Nathan James Date: 2022-03-30T18:10:48+01:00 New Revision: 61d67c8eecd2547bc690f9a6bba61b9ba814c71b URL: https://github.com/llvm/llvm-project/commit/61d67c8eecd2547bc690f9a6bba61b9ba814c71b DIFF: https://github.com/llvm/llvm-project/commit/61d67c8eecd2547bc690f9a6bba61b9ba814c71b.diff

[PATCH] D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum

lenary updated this revision to Diff 419202. lenary added a comment. - Rewrite pass in terms of ReachingDefAnalysis - Split tests into separate commit, for ease of review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119720/new/ https://reviews.ll

[PATCH] D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum

lenary removed a reviewer: kparzysz. lenary added a comment. @kparzysz I have rewritten this to avoid using RDFGraph, so I don't think this needs you to review it any more. Comment at: llvm/test/CodeGen/ARM/aes-erratum-fix.ll:49 + +define <16 x i8> @aese_once_via_val(<16 x i8>

[PATCH] D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum

lenary planned changes to this revision. lenary added inline comments. Comment at: llvm/lib/CodeGen/RDFGraph.cpp:1096 RegisterRef RR = PDA.Addr->getRegRef(*this); -#ifndef NDEBUG -// Assert if the register is defined in two or more unrelated defs. -// This could happ

[PATCH] D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr.

cor3ntin added a comment. I thing to support the template case, we would have to modify `TemplateDeclInstantiator::VisitVarDecl` - which seems the best way to have a diagnostic without running through the whole function AST twice. However, there is currently no check of any sort there so it woul

[clang] 0550601 - [Clang] Add a compatibiliy warning for non-literals in constexpr.

Author: Corentin Jabot Date: 2022-03-30T19:18:53+02:00 New Revision: 0550601d180111a1c48baf170c2e7e9c7fac28c2 URL: https://github.com/llvm/llvm-project/commit/0550601d180111a1c48baf170c2e7e9c7fac28c2 DIFF: https://github.com/llvm/llvm-project/commit/0550601d180111a1c48baf170c2e7e9c7fac28c2.diff

[PATCH] D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0550601d1801: [Clang] Add a compatibiliy warning for non-literals in constexpr. (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D122648: [clang][extractapi] Tie API and serialization to the FrontendAction

dang updated this revision to Diff 419205. dang added a comment. Update using the correct patch this time around. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122648/new/ https://reviews.llvm.org/D122648 Files: clang/include/clang/ExtractAPI/FrontendActions.h clang/lib/ExtractAPI/

[PATCH] D122648: [clang][extractapi] Tie API and serialization to the FrontendAction

dang added inline comments. Comment at: clang/include/clang/ExtractAPI/FrontendActions.h:42-58 /// Prepare to execute the action on the given CompilerInstance. /// /// This is called before executing the action on any inputs. This generates a /// single header that i

[PATCH] D122611: [clang][extract-api] Add support for macros

dang updated this revision to Diff 419207. dang marked 3 inline comments as done. dang added a comment. Update with code review feedback and the rebased code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122611/new/ https://reviews.llvm.org/D12261

[PATCH] D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum

lenary updated this revision to Diff 419208. lenary added a comment. - Remove whitespace change in ARMSubtarget - Remove commented-out debug lines in RDFGraph Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119720/new/ https://reviews.llvm.org/D11972

[PATCH] D122748: [Sema] Don't check bounds for function pointer

ArcsinX created this revision. ArcsinX added reviewers: aaron.ballman, erichkeane, abhinavgaba, chrish_ericsson_atx. Herald added a project: All. ArcsinX requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, clang crashes with i386 ta

[PATCH] D122648: [clang][extractapi] Tie API and serialization to the FrontendAction

zixuw accepted this revision. zixuw added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122648/new/ https://reviews.llvm.org/D122648 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D122611: [clang][extract-api] Add support for macros

zixuw accepted this revision. zixuw added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122611/new/ https://reviews.llvm.org/D122611 ___

[clang] a9909d2 - [clang][extractapi] Tie API and serialization to the FrontendAction

Author: Daniel Grumberg Date: 2022-03-30T18:32:58+01:00 New Revision: a9909d23e9bb8c4649cba1c14d479c28df4ca185 URL: https://github.com/llvm/llvm-project/commit/a9909d23e9bb8c4649cba1c14d479c28df4ca185 DIFF: https://github.com/llvm/llvm-project/commit/a9909d23e9bb8c4649cba1c14d479c28df4ca185.dif

[clang] 529a057 - [clang][extract-api] Add support for macros

Author: Daniel Grumberg Date: 2022-03-30T18:33:10+01:00 New Revision: 529a0570f7e8c5144bd3ad057e43f00e3af58d1b URL: https://github.com/llvm/llvm-project/commit/529a0570f7e8c5144bd3ad057e43f00e3af58d1b DIFF: https://github.com/llvm/llvm-project/commit/529a0570f7e8c5144bd3ad057e43f00e3af58d1b.dif

[PATCH] D122748: [Sema] Don't check bounds for function pointer

erichkeane added a comment. It seems like this entire section of code was added here: https://github.com/llvm/llvm-project/commit/ce44fe199bbfd4b5a44764b678c431fdc117116a @chrish_ericsson_atx should probably take a look at this. That said, we might not want to early-exist here, I think we can

[PATCH] D116490: [clangd] Code action to declare missing move/copy constructor/assignment

sammccall updated this revision to Diff 419213. sammccall marked 3 inline comments as done. sammccall added a comment. Herald added a project: All. Oops, this never got landed! Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116490/n

[clang] 73ab5fd - [clang] Fix shared build. NFC.

Author: Michael Liao Date: 2022-03-30T14:05:14-04:00 New Revision: 73ab5fd17b5726543554621410124ebae953dc6b URL: https://github.com/llvm/llvm-project/commit/73ab5fd17b5726543554621410124ebae953dc6b DIFF: https://github.com/llvm/llvm-project/commit/73ab5fd17b5726543554621410124ebae953dc6b.diff

[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

paulkirth updated this revision to Diff 419222. paulkirth added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119996/new/ https://reviews.llvm.org/D119996 Files: clang/test/Frontend/stack-usage-safestack.c llvm/include/llvm/C

[PATCH] D122549: [VFS] RedirectingFileSystem only replace path if not already mapped

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122549/new/ https://reviews.llvm.org/D122549 __

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

erichkeane added subscribers: Fznamznon, erichkeane. erichkeane added a comment. Attn: @Fznamznon Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119136/new/ https://reviews.llvm.org/D119136 ___ cfe-commit

[PATCH] D116514: [clangd] Add code action to generate a constructor for a C++ class

sammccall updated this revision to Diff 419225. sammccall marked 10 inline comments as done. sammccall added a comment. Herald added a project: All. address comments (sorry for long turnaround) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116514/ne

[PATCH] D122732: [Clang][AArch64][SVE] Allow subscript operator for SVE types

efriedma added a comment. > Subscript on svbool_t is not allowed as this doesn't really have meaningful > semantics. Not sure what you mean by this; LLVM supports extractelement on `` vectors. I guess the fact that it's a "vscale x 16" element vector might not be intuitive? Repository: rG

[PATCH] D122611: [clang][extract-api] Add support for macros

dyung added a comment. This change is causing 9 test failures on a buildbot, can you please take a look and revert if you need time to investigate? https://lab.llvm.org/buildbot/#/builders/139/builds/19441 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D121754: [clang-format] Refactor determineStarAmpUsage NFC

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. I cannot view the diff between the last two revisions: > Unhandled Exception ("Exception") > Found unknown intradiff source line, expected a line beginning with "+", "-", > or " " (space): \ No newline at end of file

[clang] 3fda0ed - [VFS] RedirectingFileSystem only replace path if not already mapped

Author: Ben Barham Date: 2022-03-30T11:52:41-07:00 New Revision: 3fda0edc51fd68192a30e302d45db081bb02d7f9 URL: https://github.com/llvm/llvm-project/commit/3fda0edc51fd68192a30e302d45db081bb02d7f9 DIFF: https://github.com/llvm/llvm-project/commit/3fda0edc51fd68192a30e302d45db081bb02d7f9.diff LO

  1   2   >