peterwaller-arm accepted this revision.
peterwaller-arm added a comment.
This revision is now accepted and ready to land.
LGTM, looks like the formatter might have hit some lines you didn't intend to
change -- if it's not too invasive perhaps worth a seperate NFC patch to format
the file?
================
Comment at: clang/lib/Sema/SemaExpr.cpp:13080-13086
+ << RHS.get()->getSourceRange() << (Opc == BO_LAnd ? "&&" : "||");
// Suggest replacing the logical operator with the bitwise version
Diag(Loc, diag::note_logical_instead_of_bitwise_change_operator)
<< (Opc == BO_LAnd ? "&" : "|")
- << FixItHint::CreateReplacement(SourceRange(
- Loc,
getLocForEndOfToken(Loc)),
- Opc == BO_LAnd ? "&" : "|");
+ << FixItHint::CreateReplacement(
+ SourceRange(Loc, getLocForEndOfToken(Loc)),
+ Opc == BO_LAnd ? "&" : "|");
----------------
Unintended whitespace changes?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122404/new/
https://reviews.llvm.org/D122404
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
