[PATCH] D118619: [clang][CodeGen][NFC] Remove unused CodeGenModule fields

ibookstein created this revision. ibookstein added a reviewer: erichkeane. ibookstein requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: Itay Bookstein Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D118619

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

glaubitz added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:135 } +// LLVM lacks atomics support on 32-bit SPARC, so forcibly link with +// libatomic as a workaround. glaubitz wrote: > ro wrote: > > ro wrote: > > > glaubitz wr

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4202 + // If the first argument is value dependent we delay setting the arguments. + if (AllArgs.size() && AllArgs[0]->isValueDependent()) { +auto *Attr = AnnotateAttr::CreateWithDelayedArgs(

[PATCH] D118552: [clang] [concepts] Correctly(?) handle placeholder types in ExprRequirements.

Quuxplusone added a comment. Gentle ping! (@ChuanqiXu @urnathan perhaps?) I'm hoping to land D118552 followed by a re-land of D117603 , this week and //ideally// tomorrow. :) CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D116545: [OpenMP] Add support for extracting device code in linker wrapper

jdoerfert added a comment. Can we test this, or is it tested with a follow up commit at least? If so, which one (add to commit message as well, e.g., tests contained in D...). Some notes, exclusively on the unused do not strip flag. Everything else looks good reading it. Comm

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

steffenlarsen added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4202 + // If the first argument is value dependent we delay setting the arguments. + if (AllArgs.size() && AllArgs[0]->isValueDependent()) { +auto *Attr = AnnotateAttr::CreateWithDelayedArgs( -

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

Anastasia added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:88 // '__builtin_' prefix. It will be implemented in compiler-rt or libgcc. +// G -> this function uses generic address space (OpenCL). +// P -> this function uses pipes (OpenCL). ---

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4202 + // If the first argument is value dependent we delay setting the arguments. + if (AllArgs.size() && AllArgs[0]->isValueDependent()) { +auto *Attr = AnnotateAttr::CreateWithDelayedArgs(

[PATCH] D116545: [OpenMP] Add support for extracting device code in linker wrapper

jhuber6 added inline comments. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:258 + if (ToBeDeleted.empty()) +return None; + jdoerfert wrote: > if (!StripSections) > return None; Fixed this later, I could rebase it so it applies here i

[clang] 20875fe - [RISCV] Make Zfhmin in march imply F.

Author: Craig Topper Date: 2022-01-31T09:06:43-08:00 New Revision: 20875fe8a5b18b403a6b1a54b6e15afec3694c77 URL: https://github.com/llvm/llvm-project/commit/20875fe8a5b18b403a6b1a54b6e15afec3694c77 DIFF: https://github.com/llvm/llvm-project/commit/20875fe8a5b18b403a6b1a54b6e15afec3694c77.diff

[PATCH] D118578: [RISCV] Make Zfhmin in march imply F.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG20875fe8a5b1: [RISCV] Make Zfhmin in march imply F. (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D118619: [clang][CodeGen][NFC] Remove unused CodeGenModule fields

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Huh, neat! I guess I missed it when I removed the use of these here (https://github.com/llvm/llvm-project/commit/de6480a38c4e6ab1e7c0c11fc7be87a4742d2d45). LGTM! Repository: rG LL

[PATCH] D115523: [OpenCL] Set external linkage for block enqueue kernels

yaxunl added a comment. In D115523#3266584 , @Anastasia wrote: > In D115523#3240870 , @yaxunl wrote: > >> In D115523#3237857 , @Anastasia >> wrote: >> >>> In D115523#3237

[clang] 22cd235 - [OpenMP] Disable rpath test in windows for lack of a libomp.lib stub

Author: Jon Chesterfield Date: 2022-01-31T17:22:50Z New Revision: 22cd2356125ad4e2ade92b91fb0123f9afce182c URL: https://github.com/llvm/llvm-project/commit/22cd2356125ad4e2ade92b91fb0123f9afce182c DIFF: https://github.com/llvm/llvm-project/commit/22cd2356125ad4e2ade92b91fb0123f9afce182c.diff L

[clang-tools-extra] 1307f66 - [clang-tidy] getLambdaProperties - use cast<> instead of dyn_cast<> to avoid dereference of nullptr

Author: Simon Pilgrim Date: 2022-01-31T17:25:16Z New Revision: 1307f66d17e3b63edc27a03c3a64e46d3a7bfa61 URL: https://github.com/llvm/llvm-project/commit/1307f66d17e3b63edc27a03c3a64e46d3a7bfa61 DIFF: https://github.com/llvm/llvm-project/commit/1307f66d17e3b63edc27a03c3a64e46d3a7bfa61.diff LOG:

[PATCH] D116544: [Clang] Introduce Clang Linker Wrapper Tool

saiislam added a comment. Can you please add this tool's doc in clang/docs? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116544/new/ https://reviews.llvm.org/D116544 ___ cfe-commits mailing list cfe-com

[PATCH] D116545: [OpenMP] Add support for extracting device code in linker wrapper

jdoerfert added a comment. what commit contains the tests? Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:435 +Arg = **NewFileOrErr; + } +} jhuber6 wrote: > jdoerfert wrote: > > Does this work with the "do not strip option"

[PATCH] D116545: [OpenMP] Add support for extracting device code in linker wrapper

jhuber6 added a comment. In D116545#3284541 , @jdoerfert wrote: > what commit contains the tests? The previous four have clang tests, showing that we call this tool with the expected arguments. Testing the tool itself requires running it, so I was thin

[PATCH] D118627: [clang-format] Don't break block comments when sorting include.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/34626. Before, the include so

[PATCH] D114903: [clang] Support array placement new in constant expressions

ldionne added subscribers: Quuxplusone, mumbleskates, egorzhdan. ldionne added a comment. Gentle ping -- I suspect this may be too naive, but it's a start. It would be awesome to ship this in LLVM 14, since it would allow us to unblock libc++ work on a couple features. Repository: rG LLVM Gi

[PATCH] D118627: [clang-format] Don't break block comments when sorting includes.

curdeius updated this revision to Diff 404581. curdeius added a comment. Remove commented code. NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118627/new/ https://reviews.llvm.org/D118627 Files: clang/lib/Format/Format.cpp clang/unittests/

[PATCH] D118493: Set rpath on openmp executables

JonChesterfield added a reviewer: kparzysz. JonChesterfield added a subscriber: kparzysz. JonChesterfield added a comment. This test doesn't work on hexagon because hexagon doesn't have a linker (??), emailed @kparzysz asking how to disable tests on hexagon as I can't find a likely looking UNSUP

[PATCH] D116627: [Clang] Initial support for linking offloading code in tool

jdoerfert added a comment. Same as the other commit, where is this tested? Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:425 + ErrorOr NvlinkPath = sys::findProgramByName( + "nvlink", sys::path::parent_path(LinkerExecutable)); + if (!NvlinkPath) ---

[PATCH] D116675: [OpenMP] Search for static libraries in offload linker tool

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, one nit Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:646 +if (Arg.startswith("-L")) + LibraryPaths.push_back(Arg.drop_front(2)); + -

[PATCH] D117937: [VFS] Add a "redirecting-with" field to overlays

bnbarham marked an inline comment as done. bnbarham added a comment. Failures look unrelated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117937/new/ https://reviews.llvm.org/D117937 ___ cfe-commits mai

[PATCH] D116544: [Clang] Introduce Clang Linker Wrapper Tool

jhuber6 updated this revision to Diff 404585. jhuber6 added a comment. Adding documentation for tool. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116544/new/ https://reviews.llvm.org/D116544 Files: clang/docs/ClangLinkerWrapper.rst clang/doc

[PATCH] D116675: [OpenMP] Search for static libraries in offload linker tool

jhuber6 added inline comments. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:646 +if (Arg.startswith("-L")) + LibraryPaths.push_back(Arg.drop_front(2)); + jdoerfert wrote: > This seems to handle `-Lfoo`, what about `-L bar`? at leas

[PATCH] D118493: Set rpath on openmp executables

thakis added a comment. looks like the mac linker doesn't like this test either: http://45.33.8.238/macm1/26834/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118493/new/ https://reviews.llvm.org/D118493

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

zahiraam updated this revision to Diff 404587. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117569/new/ https://reviews.llvm.org/D117569 Files: clang/lib/AST/ExprConstant.cpp clang/test/CodeGenCXX/PR19955.cpp clang/test/CodeGenCXX/dllimport.cpp clang/test/SemaCXX/PR19955.cpp c

[clang-tools-extra] 1ed0b0e - Tweak formatting & wording in clangd release notes

Author: Sam McCall Date: 2022-01-31T19:02:54+01:00 New Revision: 1ed0b0e6570f87f14b0bce74a94703ef2eff40b5 URL: https://github.com/llvm/llvm-project/commit/1ed0b0e6570f87f14b0bce74a94703ef2eff40b5 DIFF: https://github.com/llvm/llvm-project/commit/1ed0b0e6570f87f14b0bce74a94703ef2eff40b5.diff LO

[clang] baee029 - [OpenMP] Disable rpath test on hexagon as no linker available

Author: Jon Chesterfield Date: 2022-01-31T18:03:31Z New Revision: baee02959c3710737efd29ef35203cf9cb800d84 URL: https://github.com/llvm/llvm-project/commit/baee02959c3710737efd29ef35203cf9cb800d84 DIFF: https://github.com/llvm/llvm-project/commit/baee02959c3710737efd29ef35203cf9cb800d84.diff L

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

zahiraam added a comment. @majnemer Any feedback please? thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117569/new/ https://reviews.llvm.org/D117569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D116627: [Clang] Initial support for linking offloading code in tool

jhuber6 added inline comments. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:425 + ErrorOr NvlinkPath = sys::findProgramByName( + "nvlink", sys::path::parent_path(LinkerExecutable)); + if (!NvlinkPath) jdoerfert wrote: > Unsure why we

[PATCH] D118493: Set rpath on openmp executables

JonChesterfield added a comment. In D118493#3284617 , @thakis wrote: > looks like the mac linker doesn't like this test either: > http://45.33.8.238/macm1/26834/step_7.txt Error message is ld: file too small (length=8) file '/Users/thakis/src/llvm-proj

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA updated this revision to Diff 404600. ZarkoCA added a comment. - Warning shouldn't apply to functions that have internal linkage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118350/new/ https://reviews.llvm.org/D118350 Files: clang/incl

[PATCH] D116627: [Clang] Initial support for linking offloading code in tool

jhuber6 updated this revision to Diff 404598. jhuber6 added a comment. Maxing suggested changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116627/new/ https://reviews.llvm.org/D116627 Files: clang/tools/clang-linker-wrapper/ClangLinkerWrappe

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 updated this revision to Diff 404601. tianshilei1992 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116637/new/ https://reviews.llvm.org/D116637 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clan

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA added a comment. In D118350#3282855 , @nemanjai wrote: > Would it make sense (and would it be possible) to check the linkage of the > callee? Presumably calling something like > `static void localfunc(int *)` > with an over-aligned member shouldn

[PATCH] D118552: [clang] [concepts] Correctly(?) handle placeholder types in ExprRequirements.

urnathan added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:3373 ASTContext::getLValueReferenceType(QualType T, bool SpelledAsLValue) const { - assert(getCanonicalType(T) != OverloadTy && - "Unresolved overloaded function type"); + if (T->isPlaceholderType

[PATCH] D118632: [WIP][Clang]OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 created this revision. Herald added subscribers: guansong, yaxunl. tianshilei1992 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Depends on D116637

[PATCH] D118520: [clang-tidy] Output currently processing check and nodes on crash

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. Still LGTM and my comments are just thought experiments, not must haves before pushing. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticCons

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

ABataev added a comment. sema and parsing tests? Comment at: clang/lib/Sema/SemaOpenMP.cpp:10921 +/// Get the node id of the fixed point of an expression \a S. +llvm::FoldingSetNodeID getNodeId(ASTContext &Context, const Expr *S) { + llvm::FoldingSetNodeID Id;

[PATCH] D118493: Set rpath on openmp executables

thakis added a comment. In D118493#3284663 , @JonChesterfield wrote: > In D118493#3284617 , @thakis wrote: > >> looks like the mac linker doesn't like this test either: >> http://45.33.8.238/macm1/26834/step_7.t

[PATCH] D118493: Set rpath on openmp executables

JonChesterfield added a comment. In D118493#3284781 , @thakis wrote: > In D118493#3284663 , > @JonChesterfield wrote: > >> In D118493#3284617 , @thakis wrote: >> >>> look

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-const-correctness-templates.cpp:16 + int value_int = 42; + // CHECK-MESSAGES:[[@LINE-1]]:3: warning: variable 'value_int' of type 'int' can be declared 'const' +}

[PATCH] D118552: [clang] [concepts] Correctly(?) handle placeholder types in ExprRequirements.

Quuxplusone added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:3373 ASTContext::getLValueReferenceType(QualType T, bool SpelledAsLValue) const { - assert(getCanonicalType(T) != OverloadTy && - "Unresolved overloaded function type"); + if (T->isPlaceholderT

[clang] d14897c - [openmp] Delete rpath test, too expensive to get it working across platforms

Author: Jon Chesterfield Date: 2022-01-31T18:43:03Z New Revision: d14897c7dad8c05c003bada019c0b573ace63a1a URL: https://github.com/llvm/llvm-project/commit/d14897c7dad8c05c003bada019c0b573ace63a1a DIFF: https://github.com/llvm/llvm-project/commit/d14897c7dad8c05c003bada019c0b573ace63a1a.diff L

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 added a comment. In D116637#3284773 , @ABataev wrote: > sema and parsing tests? Tests will be in the patch for code gen. Comment at: clang/lib/Sema/SemaOpenMP.cpp:10921 +/// Get the node id of the fixed point of an expr

[clang] 1adfbfc - Add info on PACBTI-M to the Clang release notes

Author: Ties Stuij Date: 2022-01-31T19:01:25Z New Revision: 1adfbfcf39f95106861ebe8a7b4245acb0bc6e69 URL: https://github.com/llvm/llvm-project/commit/1adfbfcf39f95106861ebe8a7b4245acb0bc6e69 DIFF: https://github.com/llvm/llvm-project/commit/1adfbfcf39f95106861ebe8a7b4245acb0bc6e69.diff LOG: Ad

[PATCH] D118380: Add info on PACBTI-M to the Clang release notes

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1adfbfcf39f9: Add info on PACBTI-M to the Clang release notes (aut

[PATCH] D118552: [clang] [concepts] Correctly(?) handle placeholder types in ExprRequirements.

Quuxplusone updated this revision to Diff 404621. Quuxplusone added a comment. Update assert style. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118552/new/ https://reviews.llvm.org/D118552 Files: clang/lib/AST/ASTContext.cpp clang/lib/Sema/SemaOverload.cpp clang/lib/Sema/SemaTe

[PATCH] D118493: Set rpath on openmp executables

thakis added a comment. The behavior change can still be observed by a `-###` test -- just check that `-rpath` gets passed to the linker. Clang tests generally can't rely on running linkers. Linkers tend to be platform-specific. Windows link.exe can't produce elf binaries, macOS's ld64 can't p

[PATCH] D118552: [clang] [concepts] Correctly(?) handle placeholder types in ExprRequirements.

Quuxplusone updated this revision to Diff 404624. Quuxplusone added a comment. Update another single-line `if` too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118552/new/ https://reviews.llvm.org/D118552 Files: clang/lib/AST/ASTContext.cpp clang/lib/Sema/SemaOverload.cpp clang

[PATCH] D115972: [clang-format] Fix AlignConsecutiveAssignments breaking lambda formatting.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Format/FormatTest.cpp:16608 + // "auto b= f(a,\n" + // "

[PATCH] D118552: [clang] [concepts] Correctly(?) handle placeholder types in ExprRequirements.

urnathan accepted this revision. urnathan added a comment. This revision is now accepted and ready to land. thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118552/new/ https://reviews.llvm.org/D118552 ___ cfe-commits mailing list cfe-co

[PATCH] D118609: Remove redundant LLVM_HAS_RVALUE_REFERENCE_THIS and LLVM_LVALUE_FUNCTION defines

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! I had tried doing this once before and had to revert due to MSVC miscompiles, so be sure to watch for fallout (I appreciate you not landing before the branch because of thi

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

efriedma added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:135 } +// LLVM lacks atomics support on 32-bit SPARC, so forcibly link with +// libatomic as a workaround. glaubitz wrote: > glaubitz wrote: > > ro wrote: > > > ro wr

[PATCH] D114903: [clang] Support array placement new in constant expressions

Quuxplusone added a comment. I have no special knowledge of this. Seems like "it can't be that easy," but I don't know. Comment at: clang/test/SemaCXX/cxx2a-constexpr-dynalloc.cpp:138 } static_assert(call_std_construct_at()); I would think you ought to hav

[PATCH] D118297: [clang] add Diag -Wasm-volatile for implied volatile asm stmts

nickdesaulniers updated this revision to Diff 404676. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. - fix volatile location, more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118297/new/ https://review

[clang] 51e188d - [AArch64] Support for memset tagged intrinsic

Author: tyb0807 Date: 2022-01-31T20:49:34Z New Revision: 51e188d079f6ee9d8bc640351f2f772234d809dd URL: https://github.com/llvm/llvm-project/commit/51e188d079f6ee9d8bc640351f2f772234d809dd DIFF: https://github.com/llvm/llvm-project/commit/51e188d079f6ee9d8bc640351f2f772234d809dd.diff LOG: [AArc

[PATCH] D117753: [AArch64] Support for memset tagged intrinsic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG51e188d079f6: [AArch64] Support for memset tagged intrinsic (authored by tyb0807). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 2f9ace9 - [OpenMP] Introduce new flag to change offloading driver pipeline

Author: Joseph Huber Date: 2022-01-31T15:55:58-05:00 New Revision: 2f9ace9e9a5816684b3c19528bd4a3908b2b8ac0 URL: https://github.com/llvm/llvm-project/commit/2f9ace9e9a5816684b3c19528bd4a3908b2b8ac0 DIFF: https://github.com/llvm/llvm-project/commit/2f9ace9e9a5816684b3c19528bd4a3908b2b8ac0.diff

[clang] 551b177 - [OpenMP] Add a flag for embedding a file into the module

Author: Joseph Huber Date: 2022-01-31T15:56:00-05:00 New Revision: 551b1774524428aae5692ed3d41f969288ecd5a2 URL: https://github.com/llvm/llvm-project/commit/551b1774524428aae5692ed3d41f969288ecd5a2 DIFF: https://github.com/llvm/llvm-project/commit/551b1774524428aae5692ed3d41f969288ecd5a2.diff

[clang] 12ae095 - [OpenMP] Embed device files into the host IR

Author: Joseph Huber Date: 2022-01-31T15:56:02-05:00 New Revision: 12ae095bbb639c3dda9607a57487b83ccec9d246 URL: https://github.com/llvm/llvm-project/commit/12ae095bbb639c3dda9607a57487b83ccec9d246 DIFF: https://github.com/llvm/llvm-project/commit/12ae095bbb639c3dda9607a57487b83ccec9d246.diff

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2f9ace9e9a58: [OpenMP] Introduce new flag to change offloading driver pipeline (authored by jhuber6). Changed prior to commit: https://reviews.llv

[clang] 95c8f74 - [Clang] Introduce Clang Linker Wrapper Tool

Author: Joseph Huber Date: 2022-01-31T15:56:04-05:00 New Revision: 95c8f7464092e2ccd45c3ae6dc42da6bd9a037b5 URL: https://github.com/llvm/llvm-project/commit/95c8f7464092e2ccd45c3ae6dc42da6bd9a037b5 DIFF: https://github.com/llvm/llvm-project/commit/95c8f7464092e2ccd45c3ae6dc42da6bd9a037b5.diff

[PATCH] D116542: [OpenMP] Add a flag for embedding a file into the module

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG551b17745244: [OpenMP] Add a flag for embedding a file into the module (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D1

[PATCH] D116543: [OpenMP] Embed device files into the host IR

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG12ae095bbb63: [OpenMP] Embed device files into the host IR (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D116544: [Clang] Introduce Clang Linker Wrapper Tool

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG95c8f7464092: [Clang] Introduce Clang Linker Wrapper Tool (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113793: Comment Sema: Run checks only when appropriate (NFC)

aaronpuchert updated this revision to Diff 404689. aaronpuchert added a comment. Apply `clang-format`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113793/new/ https://reviews.llvm.org/D113793 Files: clang/include/clang/AST/CommentSema.h clan

[PATCH] D118297: [clang] add Diag -Wasm-volatile for implied volatile asm stmts

jyknight added a comment. I agree that's the expected semantics. I think those semantics are unfortunate, but they're not gonna change. IMO it would've been better if you had to opt-in to "no side effects" via `__attribute__((const))` or so. But I wonder why you think we should be discouraging

[PATCH] D116544: [Clang] Introduce Clang Linker Wrapper Tool

jyknight added a comment. "clang-linker-wrapper" seems like a very generic name for a command which is OpenMP offloading specific? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116544/new/ https://reviews.llvm.org/D116544

[PATCH] D116544: [Clang] Introduce Clang Linker Wrapper Tool

jhuber6 added a comment. In D116544#3285369 , @jyknight wrote: > "clang-linker-wrapper" seems like a very generic name for a command which is > OpenMP offloading specific? This could potentially be used to handle CUDA / HIP offloading as well, so I del

[PATCH] D113795: Comment Sema: Eliminate or factor out DeclInfo inspection (NFC)

aaronpuchert updated this revision to Diff 404693. aaronpuchert added a comment. Rename `checkDecl` to `hasDeclThat`, which should hopefully address most issues. We leave `isFunctionPointerVarDecl` inlined for now, since it's probably wrong anyway. (I think we should look for fields.) Reposito

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

thakis added a comment. Looks like this breaks tests on macOS: http://45.33.8.238/macm1/26856/step_7.txt Please take a look and revert for now if it takes a while to fix (maybe just needs an explicit triple?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D118652: Cleanup header dependencies in LLVMCore

serge-sans-paille created this revision. serge-sans-paille added reviewers: RKSimon, lenary, mehdi_amini, MaskRay. Herald added subscribers: jeroen.dobbelaere, ormris, foad, dexonsmith, wenlei, jdoerfert, kerbowa, pengfei, arphaman, steven_wu, hiraditya, nhaehnle, jvesely, arsenm. Herald added a

[PATCH] D118619: [clang][CodeGen][NFC] Remove unused CodeGenModule fields

ibookstein added a comment. Thanks! CI failures seem to be in completely unrelated libarcher, which are shared by other runs in the past few hours; landing this, then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118619/new/ https://reviews.llvm.

[clang] 2a86880 - [clang][CodeGen][NFC] Remove unused CodeGenModule fields

Author: Itay Bookstein Date: 2022-01-31T23:45:53+02:00 New Revision: 2a868802a37261105ea3baeaba405c41cb4b5675 URL: https://github.com/llvm/llvm-project/commit/2a868802a37261105ea3baeaba405c41cb4b5675 DIFF: https://github.com/llvm/llvm-project/commit/2a868802a37261105ea3baeaba405c41cb4b5675.diff

[PATCH] D118619: [clang][CodeGen][NFC] Remove unused CodeGenModule fields

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2a868802a372: [clang][CodeGen][NFC] Remove unused CodeGenModule fields (authored by ibookstein). Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] b79e2a1 - [OpenMP] Remove hard-coded triple in new driver test

Author: Joseph Huber Date: 2022-01-31T16:46:51-05:00 New Revision: b79e2a1ccd3b0c8e388fe35ba162c2db498dd882 URL: https://github.com/llvm/llvm-project/commit/b79e2a1ccd3b0c8e388fe35ba162c2db498dd882 DIFF: https://github.com/llvm/llvm-project/commit/b79e2a1ccd3b0c8e388fe35ba162c2db498dd882.diff

[PATCH] D71966: [Wdocumentation][RFC] Improve identifier's of \param

aaronpuchert added a comment. Herald added a project: clang-tools-extra. @Mordante, do you have plans to get back to this? Otherwise I'd like to pick it up. I'd probably concentrate on multiple parameter support for now, and delegate identifier validation, typo correction for variadic functions

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

jhuber6 added a comment. In D116541#3285455 , @thakis wrote: > Looks like this breaks tests on macOS: > http://45.33.8.238/macm1/26856/step_7.txt > > Please take a look and revert for now if it takes a while to fix (maybe just > needs an explicit triple

[PATCH] D117391: [AST] Ignore implicit nodes in CastExpr::getConversionFunction

davrec added inline comments. Comment at: clang/lib/AST/Expr.cpp:1946-1947 for (const CastExpr *E = this; E; E = dyn_cast(SubExpr)) { SubExpr = skipImplicitTemporary(E->getSubExpr()); +SubExpr = SubExpr->IgnoreImplicit(); aaron.ballman wrote: > `Ign

[PATCH] D118297: [clang] add Diag -Wasm-volatile for implied volatile asm stmts

MaskRay added a comment. The `volatile` qualifier is implied but makes the intention explicit. I agree that the user should not be punished (-Wasm-volatile) by writing `asm volatile("int3")` instead of `asm("int3")`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D118652: Cleanup header dependencies in LLVMCore

MaskRay added a comment. Thanks for working on this. I spot checked some files. In general it looks great. One file replaces a forward declaration with `#include "llvm/IR/BasicBlock.h"`. Some files add `#include "llvm/Support/ToolOutputFile.h"`. One files adds `class FunctionPass;` Would you mi

[PATCH] D118652: Cleanup header dependencies in LLVMCore

MaskRay added a comment. > It is very likely to break downstream code unless they took a lot of care in > avoiding hidden ehader dependencies, something the LLVM codebase doesn't do > that well :-/ release/14.x will branch soon. Will it be useful to deliberately miss the branch point so that d

[PATCH] D118297: [clang] add Diag -Wasm-volatile for implied volatile asm stmts

segher added a comment. In D118297#3285571 , @MaskRay wrote: > The `volatile` qualifier is implied but makes the intention explicit. I agree > that the user should not be punished (-Wasm-volatile) by writing `asm > volatile("int3")` instead of `asm("int

[clang] 45ad346 - [clang][WebAssembly] Imply -fno-threadsafe-static when threading is disabled

Author: Sam Clegg Date: 2022-01-31T14:26:09-08:00 New Revision: 45ad3467b708618841869cb529a814001d2295f9 URL: https://github.com/llvm/llvm-project/commit/45ad3467b708618841869cb529a814001d2295f9 DIFF: https://github.com/llvm/llvm-project/commit/45ad3467b708618841869cb529a814001d2295f9.diff LOG

[PATCH] D118571: [clang][WebAssembly] Imply -fno-threadsafe-static when threading is disabled

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG45ad3467b708: [clang][WebAssembly] Imply -fno-threadsafe-static when threading is disabled (authored by sbc100). Repository: rG LLVM Github Monore

[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.

snehasish added inline comments. Comment at: llvm/include/llvm/ProfileData/InstrProfReader.h:495 + InstrProfKind getProfileKind() const override { +InstrProfKind ProfileKind = InstrProfKind::Unknown; mtrofin wrote: > This looks a lot like line 290, can it

[PATCH] D115960: Revert D109159 "[amdgpu] Enable selection of `s_cselect_b64`."

MaskRay added a comment. Please abandon this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115960/new/ https://reviews.llvm.org/D115960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang] 623b66e - [Clang][NFC] Added testcase from #49549

Author: Dávid Bolvanský Date: 2022-01-31T23:45:56+01:00 New Revision: 623b66eded4b1ab2fbb962d3841899458bac6693 URL: https://github.com/llvm/llvm-project/commit/623b66eded4b1ab2fbb962d3841899458bac6693 DIFF: https://github.com/llvm/llvm-project/commit/623b66eded4b1ab2fbb962d3841899458bac6693.dif

[PATCH] D118596: [clang][dataflow] Enable comparison of distinct values in Environment

sgatev updated this revision to Diff 404743. sgatev added a comment. Reformat code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118596/new/ https://reviews.llvm.org/D118596 Files: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h

[PATCH] D91607: [clang][Sparc] Fix __builtin_extract_return_addr etc.

efriedma added a comment. In D91607#3283350 , @ro wrote: > In D91607#3280808 , @efriedma wrote: > >> Testcase? > > I thought the 3 testcases adjusted in D91608 > to use `__builtin_

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void updated this revision to Diff 404754. void added a comment. Generate the "isGeneralPurposeRegister" and "isFixedRegister" predicates from the .td file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869

[clang] 8a9e4f2 - [Clang][OpenMPIRBuilder] Fix off-by-one error when dividing by stepsize.

Author: Michael Kruse Date: 2022-01-31T17:28:52-06:00 New Revision: 8a9e4f245b66b90839bdf34e91cb0901e3260dad URL: https://github.com/llvm/llvm-project/commit/8a9e4f245b66b90839bdf34e91cb0901e3260dad DIFF: https://github.com/llvm/llvm-project/commit/8a9e4f245b66b90839bdf34e91cb0901e3260dad.diff

[PATCH] D118542: [Clang][OpenMPIRBuilder] Fix off-by-one error when dividing by stepsize.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a9e4f245b66: [Clang][OpenMPIRBuilder] Fix off-by-one error when dividing by stepsize. (authored by Meinersbur). Changed prior to commit: https://

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86RegisterInfo.td:647 +def GeneralPurposeRegisters : RegisterCategory<[GR64, GR32, GR16, GR8]>; +def FixedRegisters : RegisterCategory<[DEBUG_REG, CONTROL_REG, CCR, FPCCR, +

[PATCH] D116542: [OpenMP] Add a flag for embedding a file into the module

cmtice added a comment. This change introduces a circular dependency: BitcodeWriters now depends on TransformUtils, but TransformUtils also depends on BitcodeWriters. This appears to be a layering violation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D116542: [OpenMP] Add a flag for embedding a file into the module

jhuber6 added a comment. In D116542#3285857 , @cmtice wrote: > This change introduces a circular dependency: BitcodeWriters now depends on > TransformUtils, but TransformUtils also depends on BitcodeWriters. This > appears to be a layering violation.

<    1   2   3   >