[PATCH] D111545: [Clang][NFC] Fix multiline comment prefixes in function headers

MyDeveloperDay added a comment. That is more correct, but actually, you normally make the comment match the param name (I think there might even be a clang-tidy check for that?) i.e. /*isBitCodeSDL=*/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D115716: [Analyzer][BugReporter] Replace the example bug report with the one used to generate PathDiagnostic

OikawaKirie updated this revision to Diff 397207. OikawaKirie edited the summary of this revision. OikawaKirie added a comment. In D115716#3217786 , @Szelethus wrote: > First off, your patch is great, and I'm pretty sure we want it! > > I remember working

[PATCH] D116527: [clang-format] Fix indentation for array variables with alignment of consecutive assignments and declarations.

MyDeveloperDay added a comment. This is born out by setting ContinuationIndentWidth: 8 int i = 0; float i2 = 0; auto v = type{ i = 1, // (i = 2), // i = 3// }; So maybe the original test is correct.. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D116527: [clang-format] Fix indentation for array variables with alignment of consecutive assignments and declarations.

MyDeveloperDay added a comment. Could we resolve this with just // Continued braced list. if (Changes[ScopeStart - 2].Tok->isNot(tok::identifier) && Changes[ScopeStart - 1].Tok->is(tok::l_brace) && Changes[i].Tok->isNot(tok::r_brace)) return true; Repository: rG LLVM Githu

[PATCH] D116326: [CodeCompletion] Signature help for aggregate initialization.

kadircet added inline comments. Comment at: clang/include/clang/Sema/CodeCompleteConsumer.h:1085 +const RecordDecl *getAggregate() const { + return getKind() == CK_Aggregate ? AggregateType : nullptr; +} either assert the kind and return `AggregateTy

[PATCH] D91000: [clang-tidy] Add cert-msc24-c checker.

futogergely added a comment. "L129 and L135 are uncovered by tests. The rest of the lines are covered by tests, according to lcov." This happens if __STDC_WANT_LIB_EXT1__ is defined empty (L129) or __STDC_WANT_LIB_EXT1__ is not literal (numeric constant, ...). CHANGES SINCE LAST ACTION https

[PATCH] D115003: [funcattrs] Infer writeonly argument attribute [part 2]

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/lib/Transforms/IPO/FunctionAttrs.cpp:728 + } else if (CB.hasFnAttr(Attribute::WriteOnly) || + CB.dataOperandHasImpliedAttr(UseIndex,

[PATCH] D91000: [clang-tidy] Add cert-msc24-c checker.

futogergely added a comment. "It seems like none of these projects actually use the annex K functions, which is not really a surprise. VLC and lighttpd seems to use it. @futogergely could you please run your check on those projects?" **lighttpd**: the checker issued 386 warnings. The reason is

[PATCH] D116161: [Clang] Extend emitUnaryBuiltin to avoid duplicate logic.

fhahn added a comment. @junaire please let me know if you want me to land this on your behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116161/new/ https://reviews.llvm.org/D116161 ___ cfe-commits m

[clang] af7bc39 - [clang][dataflow] Add transfer function for VarDecl statements

Author: Stanislav Gatev Date: 2022-01-04T09:16:01Z New Revision: af7bc39ba17d8c5250830e96881fb7211c7576bb URL: https://github.com/llvm/llvm-project/commit/af7bc39ba17d8c5250830e96881fb7211c7576bb DIFF: https://github.com/llvm/llvm-project/commit/af7bc39ba17d8c5250830e96881fb7211c7576bb.diff LO

[PATCH] D116368: [clang][dataflow] Add transfer function for VarDecl statements

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf7bc39ba17d: [clang][dataflow] Add transfer function for VarDecl statements (authored by sgatev). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D116167: [clangd] Adjust compile flags so they work when applied to other file(type)s.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/CompileCommands.cpp:287 + if (TransferFrom) { +tooling::CompileCommand TransferCmd; maybe perfo

[PATCH] D116110: Introduce the AttributeMask class

serge-sans-paille updated this revision to Diff 397225. serge-sans-paille added a comment. rebased on main branch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116110/new/ https://reviews.llvm.org/D116110 Files: clang/lib/CodeGen/CodeGenModule.cpp llvm/include/llvm/IR/Argument.h

[PATCH] D116196: [clangd] Add CompileFlags.Compiler option to override argv0

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/clangd/ConfigFragment.h:140 +/// The name can affect how flags are parsed (clang++ vs clang). +/// If the executable name is

[PATCH] D91000: [clang-tidy] Add cert-msc24-c checker.

futogergely added a comment. Maybe we could remove the check for setbuf() and rewind() functions, making this a pure Annex K checker. There is an overlapping with another recommendation (https://wiki.sei.cmu.edu/confluence/display/c/ERR07-C.+Prefer+functions+that+support+error+checking+over+equ

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

curdeius added a comment. @HazardyKnusperkeks, it *seems* as if this commit (or one of others indicated on Changes tab of the link below) provoked failures in ASan. But it could be something else. https://lab.llvm.org/buildbot/#/builders/5/builds/16734 Could you have a look? Repository: rG L

[PATCH] D115716: [Analyzer][BugReporter] Replace the example bug report with the one used to generate PathDiagnostic

Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:76 + std::unique_ptr> { + const BugReport *Report = nullptr; +}; Some comments about this field would be welcome! ===

[PATCH] D116314: [clang-format] Add style to separate definition blocks

MyDeveloperDay added a comment. I'm seeing some odd behaviour here.. void foo() {} /* ABC */ void bar() {} becomes void foo() {} /* ABC */ void bar() {} If the ABC comment is a doxygen style comment it doesn't make sense to separate it from the function below Repository:

[PATCH] D116161: [Clang] Extend emitUnaryBuiltin to avoid duplicate logic.

junaire added a comment. In D116161#3219080 , @fhahn wrote: > @junaire please let me know if you want me to land this on your behalf. Yeah, thanks a lot! You can use: Jun Zhang j...@junz.org Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D116218: [clangd] Fix selection on multi-dimensional array.

hokein updated this revision to Diff 397233. hokein added a comment. refine the patch based on D116536 , and one more test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116218/new/ https://reviews.llvm.org/D11621

[PATCH] D116583: Change the default optimisation level of PTXAS from -O0 to -O3. This makes the optimisation levels of PTXAS and the ptxjitcompiler equal (ptxjitcompiler defaults to -O3).

hdelan created this revision. Herald added a subscriber: asavonic. hdelan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116583 Files: clang/lib/Driver/ToolChains/Cuda.cpp

[PATCH] D116585: Fix wrong JS import linebreak

futuarmo created this revision. futuarmo added a reviewer: djasper. futuarmo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes #52935 Also I could fix it by wrapping 2 if-statements in

[PATCH] D116586: [clangd] Move the selection decltype hack to getSourceRange.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Previously, it was in canSafelySkipNode,

[PATCH] D116196: [clangd] Add CompileFlags.Compiler option to override argv0

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/ConfigFragment.h:140 +/// The name can affect how flags are parsed (clang++ vs clang). +/// If the executable name is in the --query-driver allowlist, then it

[clang-tools-extra] f2b3e25 - [clangd] Add CompileFlags.Compiler option to override argv0

Author: Sam McCall Date: 2022-01-04T11:38:27+01:00 New Revision: f2b3e25f860ed029ddb9d96744a8158ba2a95b23 URL: https://github.com/llvm/llvm-project/commit/f2b3e25f860ed029ddb9d96744a8158ba2a95b23 DIFF: https://github.com/llvm/llvm-project/commit/f2b3e25f860ed029ddb9d96744a8158ba2a95b23.diff LO

[PATCH] D116196: [clangd] Add CompileFlags.Compiler option to override argv0

This revision was automatically updated to reflect the committed changes. sammccall marked 2 inline comments as done. Closed by commit rGf2b3e25f860e: [clangd] Add CompileFlags.Compiler option to override argv0 (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D116196?v

[clang-tools-extra] 20f8f46 - [clangd] Fix selection on multi-dimensional array.

Author: Haojian Wu Date: 2022-01-04T11:53:42+01:00 New Revision: 20f8f46c60b39fb2c6b4371a03e580d0711e8d82 URL: https://github.com/llvm/llvm-project/commit/20f8f46c60b39fb2c6b4371a03e580d0711e8d82 DIFF: https://github.com/llvm/llvm-project/commit/20f8f46c60b39fb2c6b4371a03e580d0711e8d82.diff LO

[PATCH] D116218: [clangd] Fix selection on multi-dimensional array.

This revision was automatically updated to reflect the committed changes. Closed by commit rG20f8f46c60b3: [clangd] Fix selection on multi-dimensional array. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116218/new/ https://rev

[clang] ca044f5 - Revert "[clang-format][NFC] Code Tidies in UnwrappedLineFormatter"

Author: Alexander Belyaev Date: 2022-01-04T12:10:52+01:00 New Revision: ca044f5369c7c156c1c7d35601b09fe610cc73d3 URL: https://github.com/llvm/llvm-project/commit/ca044f5369c7c156c1c7d35601b09fe610cc73d3 DIFF: https://github.com/llvm/llvm-project/commit/ca044f5369c7c156c1c7d35601b09fe610cc73d3.d

[clang-tools-extra] cb9ccd3 - [clangd] Move the selection decltype hack to getSourceRange.

Author: Haojian Wu Date: 2022-01-04T12:11:58+01:00 New Revision: cb9ccd38c55f729a6bd7986bbdcb34755b774240 URL: https://github.com/llvm/llvm-project/commit/cb9ccd38c55f729a6bd7986bbdcb34755b774240 DIFF: https://github.com/llvm/llvm-project/commit/cb9ccd38c55f729a6bd7986bbdcb34755b774240.diff LO

[PATCH] D116586: [clangd] Move the selection decltype hack to getSourceRange.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcb9ccd38c55f: [clangd] Move the selection decltype hack to getSourceRange. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] 30ad174 - [Docs] Document C++ for OpenCL 2021 support in clang.

Author: Anastasia Stulova Date: 2022-01-04T11:18:15Z New Revision: 30ad1742c08315498e5627fc4b01194564494cb3 URL: https://github.com/llvm/llvm-project/commit/30ad1742c08315498e5627fc4b01194564494cb3 DIFF: https://github.com/llvm/llvm-project/commit/30ad1742c08315498e5627fc4b01194564494cb3.diff

[PATCH] D116271: [Docs] Document C++ for OpenCL 2021 support in clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG30ad1742c083: [Docs] Document C++ for OpenCL 2021 support in clang. (authored by Anastasia). Herald added a subscriber: ldrumm. Herald added a projec

[PATCH] D116326: [CodeCompletion] Signature help for aggregate initialization.

sammccall marked 11 inline comments as done. sammccall added inline comments. Comment at: clang/lib/Sema/CodeCompleteConsumer.cpp:568 + + if (const auto *FD = getFunction()) { +if (N < FD->param_size()) kadircet wrote: > this doesn't cover the function(proto

[PATCH] D116326: [CodeCompletion] Signature help for aggregate initialization.

sammccall updated this revision to Diff 397251. sammccall marked 2 inline comments as done. sammccall added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116326/new/ https://reviews.llvm.org/D116326 Files: clang-tools

[clang] 2a92efd - [CodeComplete] drop unused Scope param. NFC

Author: Sam McCall Date: 2022-01-04T12:36:27+01:00 New Revision: 2a92efd0a23984c910f0ce3a6b515cc9e15ba87c URL: https://github.com/llvm/llvm-project/commit/2a92efd0a23984c910f0ce3a6b515cc9e15ba87c DIFF: https://github.com/llvm/llvm-project/commit/2a92efd0a23984c910f0ce3a6b515cc9e15ba87c.diff LO

[clang] 5c57e6a - [Clang] Extend emitUnaryBuiltin to avoid duplicate logic.

Author: Jun Zhan Date: 2022-01-04T11:47:41Z New Revision: 5c57e6aa5777bddf9ddaca5d927f1b47a1a9d381 URL: https://github.com/llvm/llvm-project/commit/5c57e6aa5777bddf9ddaca5d927f1b47a1a9d381 DIFF: https://github.com/llvm/llvm-project/commit/5c57e6aa5777bddf9ddaca5d927f1b47a1a9d381.diff LOG: [Cla

[PATCH] D116161: [Clang] Extend emitUnaryBuiltin to avoid duplicate logic.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c57e6aa5777: [Clang] Extend emitUnaryBuiltin to avoid duplicate logic. (authored by junaire, committed by fhahn). Repository: rG LLVM Github Mono

[PATCH] D115429: [Clang] Implement the rest of __builtin_elementwise_* functions.

fhahn added a comment. This now needs a rebase after landing 5c57e6aa5777 , then it should be good to go. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115429/new/ https://revie

[PATCH] D116161: [Clang] Extend emitUnaryBuiltin to avoid duplicate logic.

fhahn added a comment. In D116161#3219149 , @junaire wrote: > In D116161#3219080 , @fhahn wrote: > >> @junaire please let me know if you want me to land this on your behalf. > > Yeah, thanks a lot! > > You can use

[clang] 3235726 - [Clang][NFC] Fix multiline comment prefixes in function headers

Author: Saiyedul Islam Date: 2022-01-04T11:51:31Z New Revision: 32357266fd055e0eba63fc321f31a1c88eae0ea8 URL: https://github.com/llvm/llvm-project/commit/32357266fd055e0eba63fc321f31a1c88eae0ea8 DIFF: https://github.com/llvm/llvm-project/commit/32357266fd055e0eba63fc321f31a1c88eae0ea8.diff LOG

[PATCH] D111545: [Clang][NFC] Fix multiline comment prefixes in function headers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG32357266fd05: [Clang][NFC] Fix multiline comment prefixes in function headers (authored by saiislam). Changed prior to commit: https://reviews.llv

[PATCH] D111545: [Clang][NFC] Fix multiline comment prefixes in function headers

saiislam added a comment. In D111545#3218961 , @MyDeveloperDay wrote: > Nit: That is more correct, but actually, you normally make the comment match > the param name (I think there might even be a clang-tidy check for that?) > > i.e. > > /*isBitCodeSD

[PATCH] D116592: [clang-format] Missing space after cast in a macro

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: curdeius, HazardyKnusperkeks, owenpan. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://github.com/llvm/llvm-project/issues/52979 Though SpaceAfterCStyleCast is set t

[clang] 1c66691 - [Clang][Sema] Adjust formatting (NFC)

Author: Egor Zhdan Date: 2022-01-04T12:54:20+01:00 New Revision: 1c66691ea770c2049bbc5a27fa6e998e01a7eaf8 URL: https://github.com/llvm/llvm-project/commit/1c66691ea770c2049bbc5a27fa6e998e01a7eaf8 DIFF: https://github.com/llvm/llvm-project/commit/1c66691ea770c2049bbc5a27fa6e998e01a7eaf8.diff LO

[PATCH] D116459: [Clang][Sema] Adjust formatting (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1c66691ea770: [Clang][Sema] Adjust formatting (NFC) (authored by egorzhdan, committed by jansvoboda11). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D115790: [Coroutines] Set presplit attribute in Clang and mlir

ChuanqiXu added a comment. @rjmccall gentle ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115790/new/ https://reviews.llvm.org/D115790 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D115790: [Coroutines] Set presplit attribute in Clang and mlir

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGCoroutine.cpp:712 + assert(CurFn); + CurFn->addFnAttr("coroutine.presplit", "0"); } The assertion here is not necessary; if it was, we'd need it everywhere. Please add a comment like "LLVM expect

[PATCH] D115790: [Coroutines] Set presplit attribute in Clang and mlir

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Alright, that's fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115790/new/ https://reviews.llvm.org/D115790 ___ cfe-commits maili

[PATCH] D115790: [Coroutines] Set presplit attribute in Clang and mlir

ChuanqiXu updated this revision to Diff 397217. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115790/new/ https://reviews.llvm.org/D115790 Files: clang/lib/CodeGen/CGCoroutine.cpp clang/test/CodeGenCoroutines/coro-always-inline.cpp cla

[PATCH] D115790: [Coroutines] Set presplit attribute in Clang and mlir

ChuanqiXu marked 2 inline comments as done. ChuanqiXu added inline comments. Comment at: llvm/lib/Transforms/Coroutines/CoroEarly.cpp:198 case Intrinsic::coro_id_async: F.addFnAttr(CORO_PRESPLIT_ATTR, PREPARED_FOR_SPLIT); break; rjmccall

[PATCH] D116154: [ARM] Adding macros for coprocessor intrinsics as per ACLE

vhscampos added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:929-949 + if (ArchKind == llvm::ARM::ArchKind::ARMV8A || + ArchKind == llvm::ARM::ArchKind::ARMV8R || + ArchKind == llvm::ARM::ArchKind::ARMV8_1A || + ArchKind == llvm::ARM::ArchKind::ARM

[PATCH] D115429: [Clang] Implement the rest of __builtin_elementwise_* functions.

junaire updated this revision to Diff 397260. junaire added a comment. rebase to main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115429/new/ https://reviews.llvm.org/D115429 Files: clang/include/clang/Basic/Builtins.def clang/lib/CodeGen/C

[PATCH] D115429: [Clang] Implement the rest of __builtin_elementwise_* functions.

junaire added a comment. In D115429#3219338 , @fhahn wrote: > This now needs a rebase after landing 5c57e6aa5777 > , then > it should be good to go. Well, I just found that you seem t

[PATCH] D116592: [clang-format] Missing space after cast in a macro

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116592/new/ https://reviews.llvm.org/D116592 __

[PATCH] D116161: [Clang] Extend emitUnaryBuiltin to avoid duplicate logic.

junaire added a comment. In D116161#3219343 , @fhahn wrote: > In D116161#3219149 , @junaire wrote: > >> In D116161#3219080 , @fhahn wrote: >> >>> @junaire please let me kn

[clang-tools-extra] 051847c - Improve the 'modernize-use-default-member-init'

Author: Oleg Smolsky Date: 2022-01-04T07:27:02-05:00 New Revision: 051847cfecaea3f55fc4f822facfbf5d21bde8dd URL: https://github.com/llvm/llvm-project/commit/051847cfecaea3f55fc4f822facfbf5d21bde8dd DIFF: https://github.com/llvm/llvm-project/commit/051847cfecaea3f55fc4f822facfbf5d21bde8dd.diff

[PATCH] D114995: clang-tidy: improve the 'modernize-use-default-member-init'

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the improvement! I've commit on your behalf in 051847cfecaea3f55fc4f822facfbf5d21bde8dd . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D116593: Fix `performance-unnecessary-value-param` for template specialization

Sockke created this revision. Sockke added reviewers: aaron.ballman, flx, njames93. Herald added a subscriber: carlosgalvezp. Sockke requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The checker missed a check for parameter type o

[PATCH] D116527: [clang-format] Fix indentation for array variables with alignment of consecutive assignments and declarations.

curdeius updated this revision to Diff 397265. curdeius added a comment. Reverted test changes. Checking for identifier before brace. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116527/new/ https://reviews.llvm.org/D116527 Files: clang/lib/For

[clang] 49f23af - [OpenMP] Add nec and nvidia as compiler vendors for OpenMP

Author: Saiyedul Islam Date: 2022-01-04T12:30:43Z New Revision: 49f23afdc3453ad6834f32f69b48aa88b5d17338 URL: https://github.com/llvm/llvm-project/commit/49f23afdc3453ad6834f32f69b48aa88b5d17338 DIFF: https://github.com/llvm/llvm-project/commit/49f23afdc3453ad6834f32f69b48aa88b5d17338.diff LOG

[PATCH] D116540: [OpenMP] Add nec and nvidia as compiler vendors for OpenMP

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG49f23afdc345: [OpenMP] Add nec and nvidia as compiler vendors for OpenMP (authored by saiislam). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D116595: [clang][sema] Add missing diagnostic parameter

tbaeder created this revision. tbaeder added a reviewer: rsmith. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The test case otherwise fails an assertion in Diagnostic::getArgKind(): clang++: /home/tbaeder/code/llvm-project/cl

[PATCH] D116414: [AST] Produce ReturnStmt containing RecoveryExpr when type is wrong

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, this looks great. Comment at: clang/lib/Sema/SemaStmt.cpp:4037 -// Drop the expression. -RetValExp = nullptr; +// Preserve the iniializers i

[PATCH] D116415: [Arm] Remove duplicate CPU tests

lenary accepted this revision. lenary added a comment. There is also a duplicate line (lines 29 and 31) of `// RUN: %clang -target arm -march=armv5 -mthumb -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-V5-THUMB %s` which I think can be removed when you land this. Repository: rG LLVM Github

[PATCH] D76038: PR45000: Let Sema::SubstParmVarDecl handle default args of lambdas in initializers

zahiraam added a comment. This change is generating this crash discussed here: https://bugs.llvm.org/show_bug.cgi?id=49834 @aaronpuchert do you have any fix for it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76038/new/ https://reviews.llvm.org

[clang] f552ba6 - Revert "[Clang] Extend emitUnaryBuiltin to avoid duplicate logic."

Author: Florian Hahn Date: 2022-01-04T13:45:28Z New Revision: f552ba6e84057cad56e91e7c54170a60349d3330 URL: https://github.com/llvm/llvm-project/commit/f552ba6e84057cad56e91e7c54170a60349d3330 DIFF: https://github.com/llvm/llvm-project/commit/f552ba6e84057cad56e91e7c54170a60349d3330.diff LOG:

[PATCH] D116326: [CodeCompletion] Signature help for aggregate initialization.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116326/new/ https://reviews.llvm.org/D116326 __

[clang] 82020de - Recommit "[Clang] Extend emitUnaryBuiltin to avoid duplicate logic.""

Author: Jun Zhang Date: 2022-01-04T13:46:41Z New Revision: 82020de532108969294abd47991c8a08bbee1737 URL: https://github.com/llvm/llvm-project/commit/82020de532108969294abd47991c8a08bbee1737 DIFF: https://github.com/llvm/llvm-project/commit/82020de532108969294abd47991c8a08bbee1737.diff LOG: Rec

[PATCH] D115429: [Clang] Implement the rest of __builtin_elementwise_* functions.

fhahn added a comment. In D115429#3219395 , @junaire wrote: > In D115429#3219338 , @fhahn wrote: > >> This now needs a rebase after landing 5c57e6aa5777 >>

[PATCH] D116596: [clang][dataflow] Add transfer functions for assignment

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added a subscriber: rnkovacs. sgatev requested review of this revision. Herald added a project: clang. This is part of the implementation of the dataflow analysis framework. See "[RFC] A dataflow analysis

[PATCH] D116597: [analyzer] Don't track function calls as control dependencies

Szelethus created this revision. Szelethus added reviewers: dkrupp, NoQ, steakhal, gamesh411, martong, balazske. Szelethus added a project: clang. Herald added subscribers: manas, ASDenysPetrov, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, kristof.beyls, xazax.hun.

[PATCH] D116369: [clang][dataflow] Add parameterized map lattice.

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/MapLattice.h:92 + /// entry as it was in the source map. + LatticeJoinEffect join(const MapLattice &Other) { +LatticeJoinEffect Effect = LatticeJo

[PATCH] D115429: [Clang] Implement the rest of __builtin_elementwise_* functions.

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115429/new/ https://reviews.llvm.org/D115429

[clang] 73205fe - [CodeGen] Regenerate test checks (NFC)

Author: Nikita Popov Date: 2022-01-04T15:04:00+01:00 New Revision: 73205feb00f57e8a976c385b1e7523683ec26d00 URL: https://github.com/llvm/llvm-project/commit/73205feb00f57e8a976c385b1e7523683ec26d00 DIFF: https://github.com/llvm/llvm-project/commit/73205feb00f57e8a976c385b1e7523683ec26d00.diff

[PATCH] D116596: [clang][dataflow] Add transfer functions for assignment

sgatev updated this revision to Diff 397275. sgatev added a comment. Extend TransferTest. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116596/new/ https://reviews.llvm.org/D116596 Files: clang/include/clang/Analysis/FlowSensitive/DataflowAnalys

[PATCH] D116587: [ConstantFold] Remove unnecessary bounded index restriction

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd74212987b35: [ConstantFold] Remove unnecessary bounded index restriction (authored by nikic). Herald added a project: clang. Herald added a subscrib

[PATCH] D116370: [clang][dataflow] Add multi-variable constant propagation example.

ymandel updated this revision to Diff 397277. ymandel marked an inline comment as done. ymandel added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116370/new/ https://reviews.llvm.org/D116370 Files: clang/unittests/A

[clang] fd6d3e6 - [CodeGen] Add target triple to test (NFC)

Author: Nikita Popov Date: 2022-01-04T15:24:14+01:00 New Revision: fd6d3e65dfc3ab444fae0a04f5afbe0f595ea541 URL: https://github.com/llvm/llvm-project/commit/fd6d3e65dfc3ab444fae0a04f5afbe0f595ea541 DIFF: https://github.com/llvm/llvm-project/commit/fd6d3e65dfc3ab444fae0a04f5afbe0f595ea541.diff

[clang] 4dcc47a - [clang][dataflow] Add parameterized map lattice.

Author: Yitzhak Mandelbaum Date: 2022-01-04T14:27:15Z New Revision: 4dcc47aaeaf015c4f1315a13a41819560b9946ab URL: https://github.com/llvm/llvm-project/commit/4dcc47aaeaf015c4f1315a13a41819560b9946ab DIFF: https://github.com/llvm/llvm-project/commit/4dcc47aaeaf015c4f1315a13a41819560b9946ab.diff

[PATCH] D116369: [clang][dataflow] Add parameterized map lattice.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. ymandel marked an inline comment as done. Closed by commit rG4dcc47aaeaf0: [clang][dataflow] Add parameterized map lattice. (authored by ymandel). Repository: rG LLV

[clang] 4950198 - [clang][dataflow] Add multi-variable constant propagation example.

Author: Yitzhak Mandelbaum Date: 2022-01-04T14:28:23Z New Revision: 4950198116a5b243b8e7b4267e0397e118a27c43 URL: https://github.com/llvm/llvm-project/commit/4950198116a5b243b8e7b4267e0397e118a27c43 DIFF: https://github.com/llvm/llvm-project/commit/4950198116a5b243b8e7b4267e0397e118a27c43.diff

[PATCH] D115982: [clang][AVR] Implement '__flashN' for variables on different flash banks

benshi001 updated this revision to Diff 397279. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115982/new/ https://reviews.llvm.org/D115982 Files: clang/lib/Basic/Targets/AVR.cpp clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/address-space-avr.c clang/test/CodeGen/avr-flash.c

[PATCH] D116370: [clang][dataflow] Add multi-variable constant propagation example.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4950198116a5: [clang][dataflow] Add multi-variable constant propagation example. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D115867: [C++20] [Coroutines] Warning for always_inline coroutine

Quuxplusone requested changes to this revision. Quuxplusone added a comment. This revision now requires changes to proceed. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:0-3 +def warn_always_inline_coroutine : Warning< + "A coroutine marked always_inlin

[PATCH] D115982: [clang][AVR] Implement '__flashN' for variables on different flash banks

benshi001 added a comment. In D115982#3218124 , @aykevl wrote: > avr-gcc checks whether the device supports the flash bank used. For example: > > $ cat test.c > int d = 5; > const int ro = 5; > __flash const int f = 5; > __flash1 const int f1 =

[clang] 9290ccc - Introduce the AttributeMask class

Author: serge-sans-paille Date: 2022-01-04T15:37:46+01:00 New Revision: 9290ccc3c1a17a7874de020656db38183a20f6b0 URL: https://github.com/llvm/llvm-project/commit/9290ccc3c1a17a7874de020656db38183a20f6b0 DIFF: https://github.com/llvm/llvm-project/commit/9290ccc3c1a17a7874de020656db38183a20f6b0.d

[PATCH] D116110: Introduce the AttributeMask class

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9290ccc3c1a1: Introduce the AttributeMask class (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D116110?vs=3972

[PATCH] D116283: [clang-format] Add an option to add a space between operator overloading and opening parentheses

rajatbajpai added a comment. In D116283#3218118 , @HazardyKnusperkeks wrote: > Thanks for adding the parse checks. Not an issue :) In D116283#3218101 , @curdeius wrote: > LGTM. > If you need help landing this

[PATCH] D116593: Fix `performance-unnecessary-value-param` for template specialization

flx added a comment. Thanks for improving this check! Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.cpp:177-178 const auto &CurrentParam = *FunctionDecl->getParamDecl(Index); +if (IsExplicitTemplateSpecialization && Function != Functi

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

lenary added a comment. Two quick comments about when this is enabled, and then I'm happy! Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:772-774 if (KernelOrKext) Features.push_back("+strict-align"); else if (Arg *A = Args.getLastArg(options::OPT_mno_unaligned

[PATCH] D115982: [clang][AVR] Implement '__flashN' for variables on different flash banks

benshi001 updated this revision to Diff 397287. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115982/new/ https://reviews.llvm.org/D115982 Files: clang/lib/Basic/Targets/AVR.cpp clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/address-space-avr.c clang/test/CodeGen/avr-flash.c

[PATCH] D116535: [clang-tidy] Fix false positive in modernize-pass-by-value

flx accepted this revision. flx added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/modernize/PassByValueCheck.cpp:108 +/// Returns true the given constructor is part of a lvalue/rvalue reference +/// pair, i.e. `Para

[PATCH] D115982: [clang][AVR] Implement '__flashN' for variables on different flash banks

benshi001 added a comment. In D115982#3218124 , @aykevl wrote: > avr-gcc checks whether the device supports the flash bank used. For example: > > $ cat test.c > int d = 5; > const int ro = 5; > __flash const int f = 5; > __flash1 const int f1 =

[PATCH] D114077: [clangd] Basic IncludeCleaner support for c/c++ standard library

thakis added a comment. Thanks for noticing that. It's back and happy now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114077/new/ https://reviews.llvm.org/D114077 ___ cfe-commits mailing list cfe-comm

[clang-tools-extra] 0683a1e - [clangd] Adjust compile flags so they work when applied to other file(type)s.

Author: Sam McCall Date: 2022-01-04T16:10:27+01:00 New Revision: 0683a1e588ade04bba2572e5ab6cf1361ed392d4 URL: https://github.com/llvm/llvm-project/commit/0683a1e588ade04bba2572e5ab6cf1361ed392d4 DIFF: https://github.com/llvm/llvm-project/commit/0683a1e588ade04bba2572e5ab6cf1361ed392d4.diff LO

[PATCH] D116167: [clangd] Adjust compile flags so they work when applied to other file(type)s.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0683a1e588ad: [clangd] Adjust compile flags so they work when applied to other file(type)s. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

OikawaKirie updated this revision to Diff 397289. OikawaKirie added a comment. Replace on-demand-parsing with loading AST file for the new test case. Tested on Linux and MacOS(x86). If it can also pass the CI test on Windows, I think we can have another try on landing this patch. Besides, as men

[clang] 8aea5d5 - [Arm] Remove duplicate CPU tests

Author: Tomas Matheson Date: 2022-01-04T15:22:10Z New Revision: 8aea5d5951dc7d2130ad671423830a45e215c540 URL: https://github.com/llvm/llvm-project/commit/8aea5d5951dc7d2130ad671423830a45e215c540 DIFF: https://github.com/llvm/llvm-project/commit/8aea5d5951dc7d2130ad671423830a45e215c540.diff LOG

[PATCH] D116415: [Arm] Remove duplicate CPU tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8aea5d5951dc: [Arm] Remove duplicate CPU tests (authored by tmatheson). Changed prior to commit: https://reviews.llvm.org/D116415?vs=396681&id=397

  1   2   >