sammccall marked 2 inline comments as done. sammccall added inline comments.
================ Comment at: clang-tools-extra/clangd/ConfigFragment.h:140 + /// The name can affect how flags are parsed (clang++ vs clang). + /// If the executable name is in the --query-driver allowlist, then it will + /// be invoked to extract include paths. ---------------- kadircet wrote: > not sure if query-driver interactions is worth explaining here I suspect this is the main reason that people will want to set this :-( Since they need to get two things right before they see any change, I think some reassurance might help. We could move this to an external guide though. ================ Comment at: clang-tools-extra/clangd/ConfigFragment.h:143 + /// + /// (Note that this simply replaces argv[0], and may mangle commands that + /// use more complicated drivers like ccache). ---------------- kadircet wrote: > i am also afraid of this :/ in theory json compilation database already drops > well-known wrappers and users that use another medium to communicate flags > should be responsible of taking care of this, so hopefully it won't bite us > badly Yeah. Anyway this is fixable if we need to fix it, it's just annoying to need the list of strings to skip over in two places. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116196/new/ https://reviews.llvm.org/D116196 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
