vhscampos added inline comments.
================
Comment at: clang/lib/Basic/Targets/ARM.cpp:929-949
+ if (ArchKind == llvm::ARM::ArchKind::ARMV8A ||
+ ArchKind == llvm::ARM::ArchKind::ARMV8R ||
+ ArchKind == llvm::ARM::ArchKind::ARMV8_1A ||
+ ArchKind == llvm::ARM::ArchKind::ARMV8_2A ||
+ ArchKind == llvm::ARM::ArchKind::ARMV8_3A ||
+ ArchKind == llvm::ARM::ArchKind::ARMV8_4A ||
+ ArchKind == llvm::ARM::ArchKind::ARMV8_5A ||
----------------
Consider merging these two if statements.
================
Comment at: clang/lib/Basic/Targets/ARM.cpp:951
+
+ if (ArchKind == llvm::ARM::ArchKind::ARMV8MMainline) {
+ Builder.defineMacro("__ARM_TARGET_COPROC", "1");
----------------
Is v8.1-M not included on purpose?
================
Comment at: clang/test/Preprocessor/aarch64-target-features.c:46
// CHECK-NOT: __ARM_SIZEOF_WCHAR_T 2
+// CHECK-NOT: __ARM_TARGET_COPROC 1
// CHECK-NOT: __ARM_FEATURE_SVE
----------------
I don't see any change to the AArch64 target macros. Does it use the same
function as ARM?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116154/new/
https://reviews.llvm.org/D116154
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
