[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

JonChesterfield added inline comments. Comment at: clang/tools/amdgpu-arch/CMakeLists.txt:13 + +find_package(hsa-runtime64 QUIET 1.2.0 HINTS ${CMAKE_INSTALL_PREFIX} PATH ${ROCM_PATH}) if (NOT ${hsa-runtime64_FOUND}) arsenm wrote: > I also think CMAKE_INSTALL_PR

[PATCH] D115893: [WebAssembly] Support clang -fwasm-exceptions for bitcode

aheejin created this revision. aheejin added a reviewer: dschuff. Herald added subscribers: wingo, ecnelises, pengfei, sunfish, hiraditya, jgravelle-google, sbc100. aheejin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

arsenm added a comment. In D109885#3198340 , @JonChesterfield wrote: > In D109885#3198296 , @arsenm wrote: > >> This isn't a feature, it's the introduction of a bug. > > It would regress people depending on the i

[PATCH] D115893: [WebAssembly] Support clang -fwasm-exceptions for bitcode

aheejin updated this revision to Diff 394951. aheejin added a comment. Revert a function name change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115893/new/ https://reviews.llvm.org/D115893 Files: clang/test/CodeGen/WebAssembly/wasm-eh.ll ll

[PATCH] D115792: [Modules] Incorrect ODR detection for unresolved using type

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115792/new/ https://reviews.llvm.org/D115792 ___ cfe-commits mailing list

[PATCH] D115456: Implement on-demand TLS initialization for Microsoft CXX ABI

majnemer added a comment. Is this a new feature in MSVC? Seems like it might be. If so, should it be predicated on `isCompatibleWithMSVC(1925)` or something? CHANGES SINCE LAS

[clang] 2b671c3 - [clang-format] add support for branch attribute macros

Author: mydeveloperday Date: 2021-12-16T20:36:25Z New Revision: 2b671c3fe0d6f6517dc5396e73d28285d6fe6223 URL: https://github.com/llvm/llvm-project/commit/2b671c3fe0d6f6517dc5396e73d28285d6fe6223 DIFF: https://github.com/llvm/llvm-project/commit/2b671c3fe0d6f6517dc5396e73d28285d6fe6223.diff LOG

[PATCH] D115865: [clang-format] add support for branch attribute macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2b671c3fe0d6: [clang-format] add support for branch attribute macros (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

paulaltin added a comment. > Thanks! I landed this as 9198d04c06b561cd78d9407cedd50f7b995ee6d8 > this > morning (sorry for the slight delay in getting this landed). No worries, thanks @aaron.ballman! CHANGES SINCE LAST ACTI

[PATCH] D111100: enable plugins for clang-tidy

vtjnash added a comment. Thanks! I will work on making those changes Comment at: clang-tools-extra/test/clang-tidy/CTTestTidyModule.cpp:24-25 + + //void registerMatchers(ast_matchers::MatchFinder *Finder) override; + //void check(const ast_matchers::MatchFinder::MatchResult &

[PATCH] D115901: [OpenMP][NFC] update status for 5.1 'fail' atomic extension

dreachem created this revision. dreachem added reviewers: jdoerfert, koops, cchen. Herald added subscribers: guansong, yaxunl. dreachem requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Update status for the atomic 'fail' clause to "

[PATCH] D115902: [OPENMP]Look through member function call base during implicit DSA analysis.

ABataev created this revision. ABataev added reviewers: jdoerfert, mikerice, ddpagan. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Need to look through the base of the member function call

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:3231 +return Style; + } else if (ParserErrorCode != ParseError::Success) { +return make_string_error("Error reading " + ConfigFile + ": " + else after return But I prefer

[PATCH] D115103: Leak Sanitizer port to Windows

vitalybuka added inline comments. Comment at: compiler-rt/lib/lsan/lsan_allocator.h:52-53 -#if defined(__mips64) || defined(__aarch64__) || defined(__i386__) || \ -defined(__arm__) || SANITIZER_RISCV64 || defined(__hexagon__) +#if defined(__mips64) || defined(__aarch64__) |

[PATCH] D115879: [clang-format] extern with new line brace without indentation

curdeius requested changes to this revision. curdeius added inline comments. This revision now requires changes to proceed. Comment at: clang/unittests/Format/FormatTest.cpp:3815 + + Style.IndentExternBlock = FormatStyle::IEBS_AfterExternBlock; + Style.BreakBeforeBraces = Forma

[PATCH] D115901: [OpenMP][NFC] update status for 5.1 'fail' atomic extension

cchen accepted this revision. cchen added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115901/new/ https://reviews.llvm.org/D115901 ___ cfe

[PATCH] D115693: [Try2][InstrProf] Attach debug info to counters

ellis updated this revision to Diff 394982. ellis added a comment. Use `std::string` instead of `Twine` to pass around the default raw profile name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115693/new/ https://reviews.llvm.org/D115693 Files:

[PATCH] D115903: [clang-format] Extra spaces surrounding arrow in templated member call in variable decl

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: curdeius, HazardyKnusperkeks, owenpan, lichray. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://github.com/llvm/llvm-project/issues/43196 Fixes #43196 -> is incorre

[PATCH] D115903: [clang-format] Extra spaces surrounding arrow in templated member call in variable decl

curdeius added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1682 Current.NestingLevel == 0 && - !Current.Previous->is(tok::kw_operator)) { + !Current.Previous->isOneOf(tok::kw_operator, tok::identifier)) { //

[clang] 58d9c1a - [Try2][InstrProf] Attach debug info to counters

Author: Ellis Hoag Date: 2021-12-16T14:20:30-08:00 New Revision: 58d9c1aec88d5d4c783643df057d87f6b0c9f693 URL: https://github.com/llvm/llvm-project/commit/58d9c1aec88d5d4c783643df057d87f6b0c9f693 DIFF: https://github.com/llvm/llvm-project/commit/58d9c1aec88d5d4c783643df057d87f6b0c9f693.diff LO

[PATCH] D115693: [Try2][InstrProf] Attach debug info to counters

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG58d9c1aec88d: [Try2][InstrProf] Attach debug info to counters (authored by ellis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

paulkirth created this revision. Herald added subscribers: abrachet, ormris, dexonsmith, wenlei, phosek, hiraditya, mgorny. paulkirth updated this revision to Diff 394995. paulkirth added a comment. paulkirth updated this revision to Diff 394997. paulkirth added reviewers: phosek, mcgrathr, leonar

[PATCH] D115903: [clang-format] Extra spaces surrounding arrow in templated member call in variable decl

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1682 Current.NestingLevel == 0 && - !Current.Previous->is(tok::kw_operator)) { + !Current.Previous->isOneOf(tok::kw_operator, tok::identifier)) {

[PATCH] D115410: [llvm][test] rewrite callbr to use i rather than X constraint NFC

jyknight added inline comments. Comment at: llvm/test/tools/llvm-diff/callbr.ll:28-29 entry: - callbr void asm sideeffect "", "X,X,~{dirflag},~{fpsr},~{flags}"(i8* blockaddress(@foo, %t_no), i8* blockaddress(@foo, %return)) + callbr void asm sideeffect "", "i,i,~{dirflag},~{f

[PATCH] D115893: [WebAssembly] Support clang -fwasm-exceptions for bitcode

dschuff accepted this revision. dschuff added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp:37 -// Emscripten's asm.js-style exception handling -cl::opt -WasmEnableEmEH("enable-emscript

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

stella.stamenova added a comment. In D114639#3192823 , @stella.stamenova wrote: > In D114639#3191752 , @RKSimon wrote: > >> @rnk @stella.stamenova How long do you think it will be before you can >> update your b

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

ahatanak added a comment. This commit seems to have caused a test to fail: https://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/26118/testReport/ Can you fix the failure or revert the patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

OikawaKirie added a comment. I do not know how this error happens. Maybe we can currently revert this patch an have another try in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102669/new/ https://reviews.llvm.org/D102669

[PATCH] D115893: [WebAssembly] Support clang -fwasm-exceptions for bitcode

aheejin updated this revision to Diff 395024. aheejin marked 2 inline comments as done. aheejin added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115893/new/ https://reviews.llvm.org/D115893 Files: clang/test/CodeGe

[PATCH] D115893: [WebAssembly] Support clang -fwasm-exceptions for bitcode

aheejin added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp:37 -// Emscripten's asm.js-style exception handling -cl::opt -WasmEnableEmEH("enable-emscripten-cxx-exceptions", - cl::desc("WebAssembly Emscripten-style ex

[PATCH] D115893: [WebAssembly] Support clang -fwasm-exceptions for bitcode

aheejin updated this revision to Diff 395025. aheejin added a comment. Remove an unnecessary include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115893/new/ https://reviews.llvm.org/D115893 Files: clang/test/CodeGen/WebAssembly/wasm-eh.ll ll

[PATCH] D115893: [WebAssembly] Support clang -fwasm-exceptions for bitcode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4625b848793f: [WebAssembly] Support clang -fwasm-exceptions for bitcode (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 4625b84 - [WebAssembly] Support clang -fwasm-exceptions for bitcode

Author: Heejin Ahn Date: 2021-12-16T16:49:24-08:00 New Revision: 4625b848793f8cfa4affac8d03b9f498b3e477fe URL: https://github.com/llvm/llvm-project/commit/4625b848793f8cfa4affac8d03b9f498b3e477fe DIFF: https://github.com/llvm/llvm-project/commit/4625b848793f8cfa4affac8d03b9f498b3e477fe.diff LO

[PATCH] D115021: [funcatts] Rewrite callsite operand handling in memory access inference

reames added a comment. I'm starting to split this into individual pieces with the writeonly dependence removed. The first one handles indirect calls, and is posted as D115916 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

thakis added a comment. This breaks tests on macOS: http://45.33.8.238/macm1/23920/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102669/new/ https://reviews.llvm.org/D102

[PATCH] D115893: [WebAssembly] Support clang -fwasm-exceptions for bitcode

dschuff added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp:37 -// Emscripten's asm.js-style exception handling -cl::opt -WasmEnableEmEH("enable-emscripten-cxx-exceptions", - cl::desc("WebAssembly Emscripten-style ex

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

OikawaKirie added a comment. Could you please revert this on my behalf? I currently have no idea to fix this problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102669/new/ https://reviews.llvm.org/D102669 _

[clang] 770ef94 - Revert "[analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file"

Author: Nico Weber Date: 2021-12-16T20:46:51-05:00 New Revision: 770ef94097c02205b3ec9e902f1d6a9c99b5189c URL: https://github.com/llvm/llvm-project/commit/770ef94097c02205b3ec9e902f1d6a9c99b5189c DIFF: https://github.com/llvm/llvm-project/commit/770ef94097c02205b3ec9e902f1d6a9c99b5189c.diff LO

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

thakis added a comment. reverted in 770ef94097c02205b3ec9e902f1d6a9c99b5189c . thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102669/new/ https://reviews.llvm.org/D102669

[PATCH] D113237: [RISCV] Support I extension version 2.1

kito-cheng added a comment. @jrtc27 > Outside of the I/F/D special cases, where F/D don't really matter and I2p0 is > just I2p1Zicsr2p0_Zifencei2p0,, I thought the new policy was that ratified > extensions would never be changed, only new extensions published, and thus > version numbers are ba

[PATCH] D115792: [Modules] Incorrect ODR detection for unresolved using type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc50a4b3f9749: [Modules] Incorrect ODR detection for unresolved using type (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES SI

[clang] c50a4b3 - [Modules] Incorrect ODR detection for unresolved using type

Author: Chuanqi Xu Date: 2021-12-17T10:37:40+08:00 New Revision: c50a4b3f97497c27ad62797080b52f501dac5e38 URL: https://github.com/llvm/llvm-project/commit/c50a4b3f97497c27ad62797080b52f501dac5e38 DIFF: https://github.com/llvm/llvm-project/commit/c50a4b3f97497c27ad62797080b52f501dac5e38.diff LO

[PATCH] D113237: [RISCV] Support I extension version 2.1

kito-cheng added a comment. @asb > Are you saying that there won't be a new ISA manual release (using whatever > naming scheme) that incorporates the ratified versions of bitmanip, crypto, > vector etc? Oh, I guess I using some word too strong there, here should have some newer release in fut

[PATCH] D112903: [C++20] [Module] Fix bug47116 and implement [module.interface]/p6

ChuanqiXu updated this revision to Diff 395045. ChuanqiXu added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112903/new/ https://reviews.llvm.org/D112903 Files: clang/include/clang/AST/DeclBase.h clang/include/clang/Basic/DiagnosticSemaKinds.td clang/

[PATCH] D115879: [clang-format] extern with new line brace without indentation

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:3819 + Style.IndentExternBlock = FormatStyle::IEBS_NoIndent; + verifyFormat("extern \"C\"\n{ /*13*/\n}", Style); + verifyFormat("extern \"C\"\n{\n" curdeius wrote: > I'd prefer th

[PATCH] D112903: [C++20] [Module] Fix bug47116 and implement [module.interface]/p6

ChuanqiXu marked 5 inline comments as done. ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:1622 +// [module.interface]p6: +// A redeclaration of an entity X is implicitly exported if X was introduced by aaron.ballman wrote: > I didn't

[PATCH] D115879: [clang-format] extern with new line brace without indentation

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1282-1300 if (FormatTok->Tok.is(tok::string_literal)) { nextToken(); if (FormatTok->Tok.is(tok::l_brace)) { +if (Style.BraceWrapping.AfterExternBlock) { + addUn

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

OikawaKirie added a comment. It seems that it is not this patch that triggers the problem, which is similar to D75665 . IMO it is the problem of on-demand-parsing, but I do not have a Mac M1 device to reproduce this bug. Maybe we can

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

linjamaki added a comment. Assuming that this patch is ready to land. @tra or @yaxunl, could you please commit this patch to the LLVM for us? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110622/new/ https://reviews.llvm.org/D110622 _

[PATCH] D114080: [SYCL] Diagnose uses of zero length arrays

Fznamznon added a comment. I hope that someone not from Intel will take a look as well. If this won't happen for reasonable amount of time, I'll submit this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114080/new/ https://reviews.llvm.org/

<    1   2