HazardyKnusperkeks added inline comments.
================
Comment at: clang/lib/Format/Format.cpp:3231
+ return Style;
+ } else if (ParserErrorCode != ParseError::Success) {
+ return make_string_error("Error reading " + ConfigFile + ": " +
----------------
else after return
But I prefer a `switch` on `ParseErrorCode`.
================
Comment at: clang/lib/Format/Format.cpp:3273
+ llvm::SmallVector<std::string, 2> FilesToLookFor;
+ // User provided clang-format file using -style=file:/path/to/format/file
----------------
Why move that, it it's not used here?
================
Comment at: clang/lib/Format/Format.cpp:2743
+ bool IsSuitable = true;
+ auto Style = LoadConfigFile(StyleNameFile, FS, &IsSuitable);
+ if (Style && !IsSuitable) {
----------------
MyDeveloperDay wrote:
> pass Style in and rename return value
Why did you not follow your own comment?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72326/new/
https://reviews.llvm.org/D72326
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
