JonChesterfield added inline comments.
================
Comment at: clang/tools/amdgpu-arch/CMakeLists.txt:13
+
+find_package(hsa-runtime64 QUIET 1.2.0 HINTS ${CMAKE_INSTALL_PREFIX} PATH
${ROCM_PATH})
if (NOT ${hsa-runtime64_FOUND})
----------------
arsenm wrote:
> I also think CMAKE_INSTALL_PREFIX in the search hints is bad practice. I
> don't recall ever seeing a project do this. Depending on the install path for
> anything leads to flaky builds
This was copied from the amdgpu plugin. I can't remember where I copied that
from. Alternatives welcome - what's the proper way to indicate 'this library?
it's probably next to all the other llvm libraries'
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109885/new/
https://reviews.llvm.org/D109885
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
