[clang] 7ba70d3 - [PR52549][clang-cl] Predefine _MSVC_EXECUTION_CHARACTER_SET

Author: Markus Böck Date: 2021-11-30T09:13:22+01:00 New Revision: 7ba70d32736aef0c640b9d0e7b9081fc208c81c2 URL: https://github.com/llvm/llvm-project/commit/7ba70d32736aef0c640b9d0e7b9081fc208c81c2 DIFF: https://github.com/llvm/llvm-project/commit/7ba70d32736aef0c640b9d0e7b9081fc208c81c2.diff L

[PATCH] D114576: [PR52549][clang-cl] Predefine _MSVC_EXECUTION_CHARACTER_SET

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ba70d32736a: [PR52549][clang-cl] Predefine _MSVC_EXECUTION_CHARACTER_SET (authored by zero9178). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114576/new/

[PATCH] D114579: [clang-tidy] Exempt _MSVC_EXECUTION_CHARACTER_SET from cppcoreguidelines-macro-usage

zero9178 abandoned this revision. zero9178 added a comment. Found another solution to the original issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114579/new/ https://reviews.llvm.org/D114579 ___ cfe

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

jhenderson added a comment. Re. the bots: I'd hope we'd have at least some bots using VS2019 rather than all rushing to VS2022. There's nothing worse than claiming to support a minimum version of something and then not actually supporting it...! Also internally, we are switching to a default of

[clang-tools-extra] 3356d88 - [clangd] Make std symbol generation script python3 friendly

Author: Kadir Cetinkaya Date: 2021-11-30T10:15:36+01:00 New Revision: 3356d8837e46a92446e4b9b0cbd6967e5f4e44ba URL: https://github.com/llvm/llvm-project/commit/3356d8837e46a92446e4b9b0cbd6967e5f4e44ba DIFF: https://github.com/llvm/llvm-project/commit/3356d8837e46a92446e4b9b0cbd6967e5f4e44ba.dif

[PATCH] D114723: [clangd] Make std symbol generation script python3 friendly

This revision was automatically updated to reflect the committed changes. Closed by commit rG3356d8837e46: [clangd] Make std symbol generation script python3 friendly (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114723/new/

[PATCH] D113118: [clang][AST] Check context of record in structural equivalence.

balazske added inline comments. Comment at: clang/unittests/AST/StructuralEquivalenceTest.cpp:1037 + "void foo(struct Param { int a; } *p);", Lang_C89); + EXPECT_TRUE(testStructuralMatch(Decls)); +} shafik wrote: > I expect this to be `false`

[clang] 5cff77c - [clang][ARM] PACBTI-M assembly support

Author: Ties Stuij Date: 2021-11-30T09:28:18Z New Revision: 5cff77c23f43130887b566dd0fe237e1c482e23b URL: https://github.com/llvm/llvm-project/commit/5cff77c23f43130887b566dd0fe237e1c482e23b DIFF: https://github.com/llvm/llvm-project/commit/5cff77c23f43130887b566dd0fe237e1c482e23b.diff LOG: [c

[PATCH] D112420: [clang][ARM] PACBTI-M assembly support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5cff77c23f43: [clang][ARM] PACBTI-M assembly support (authored by stuij, committed by Zeno ). Repository: rG LLVM Gi

[PATCH] D110155: [OpenCL] Allow optional __generic in __remove_address_space utility

Topotuna updated this revision to Diff 390617. Topotuna added a comment. Run line argument reordering CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110155/new/ https://reviews.llvm.org/D110155 Files: clang/lib/Headers/opencl-c-base.h clang/test/CodeGenOpenCLCXX/remove-address-space

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon added a comment. Thanks - I think all the MSVC bot admins are now on this patch, so I can avoid writing yet another email! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639

[PATCH] D110185: [OpenCL] Reuse C++ for OpenCL 1.0 address space tests for version 2021

Topotuna updated this revision to Diff 390622. Topotuna added a comment. Herald added a subscriber: Naghasan. Test coverage expanded CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110185/new/ https://reviews.llvm.org/D110185 Files: clang/test/CodeGenOpenCLCXX/address-space-castoperato

[PATCH] D114077: [clangd] Basic IncludeCleaner support for c/c++ standard library

kbobyrev added a comment. Mostly LG, few nits. Comment at: clang-tools-extra/clangd/Headers.h:32 namespace clang { +class NamespaceDecl; namespace clangd { Do we need a forward decl here? Comment at: clang-tools-extra/clangd/Headers.h:42 +p

[PATCH] D114703: [AArch64] Use Feature for A53 Erratum 835769 Fix

tmatheson accepted this revision. tmatheson added a comment. This revision is now accepted and ready to land. Makes sense to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114703/new/ https://reviews.llvm.org/D114703

[PATCH] D114782: [X86][clang] Emit diagnostic for float and double when we have features -x87 and -sse on 64-bits

pengfei created this revision. pengfei added reviewers: asavonic, erichkeane, nickdesaulniers. pengfei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A follow up of D114162 . Repository: rG LLVM Github

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

kbobyrev updated this revision to Diff 390627. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113995/new/ https://reviews.llvm.org/D113995 Files: clang-

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/dex/Trigram.cpp:47 + const size_t NPOS = std::numeric_limits::max(); + llvm::SmallVector> Next(LowercaseIdentifier.size()); + size_t NextTail = NPOS, NextHead = NPOS; sammccall wrote:

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kbobyrev updated this revision to Diff 390631. kbobyrev marked an inline comment as done. kbobyrev added a comment. Change the API, update the patch. It's crashing ATM, investigating the problems. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114072

[PATCH] D114782: [X86][clang] Emit diagnostic for float and double when we have features -x87 and -sse on 64-bits

pengfei updated this revision to Diff 390632. pengfei added a comment. Fix a lit fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114782/new/ https://reviews.llvm.org/D114782 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib

[PATCH] D112427: [ARM] Implement setjmp BTI placement for PACBTI-M

stuij updated this revision to Diff 390633. stuij added a comment. slight rewording Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112427/new/ https://reviews.llvm.org/D112427 Files: clang/docs/ClangCommandLineReference.rst clang/include/clang/

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/dex/Trigram.cpp:47 + const size_t NPOS = std::numeric_limits::max(); + llvm::SmallVector> Next(LowercaseIdentifier.size()); + size_t NextTail = NPOS, NextHead = NPOS; you've changed u

[clang] f02c5f3 - [Analyzer][solver] Do not remove the simplified symbol from the eq class

Author: Gabor Marton Date: 2021-11-30T11:13:13+01:00 New Revision: f02c5f3478318075d1a469203900e452ba651421 URL: https://github.com/llvm/llvm-project/commit/f02c5f3478318075d1a469203900e452ba651421 DIFF: https://github.com/llvm/llvm-project/commit/f02c5f3478318075d1a469203900e452ba651421.diff

[PATCH] D114619: [Analyzer][solver] Do not remove the simplified symbol from the eq class

This revision was automatically updated to reflect the committed changes. Closed by commit rGf02c5f347831: [Analyzer][solver] Do not remove the simplified symbol from the eq class (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[clang] 0a17896 - [Analyzer][Core] Make SValBuilder to better simplify svals with 3 symbols in the tree

Author: Gabor Marton Date: 2021-11-30T11:24:59+01:00 New Revision: 0a17896fe6fdbbde1f9d3ffbb10a4f3bfa8960f9 URL: https://github.com/llvm/llvm-project/commit/0a17896fe6fdbbde1f9d3ffbb10a4f3bfa8960f9 DIFF: https://github.com/llvm/llvm-project/commit/0a17896fe6fdbbde1f9d3ffbb10a4f3bfa8960f9.diff

[PATCH] D103317: [Analyzer][Core] Make SValBuilder to better simplify svals with 3 symbols in the tree

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a17896fe6fd: [Analyzer][Core] Make SValBuilder to better simplify svals with 3 symbols in… (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kbobyrev updated this revision to Diff 390639. kbobyrev marked an inline comment as done. kbobyrev added a comment. Fix failures, address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114072/new/ https://reviews.llvm.org/D114072 F

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/Headers.h:130 + // IWYU pragmas but it needs to be explicitly added to as a preprocessor + // comment handler. PP wants to own the PPCallbacks, so the typical way to + // do both is: sammccal

[PATCH] D114724: [clangd][StdSymbolMap] Prefer std::remove from algorithm

kadircet added inline comments. Comment at: clang-tools-extra/clangd/StdSymbolMap.inc:958 SYMBOL(remainder, std::, ) -SYMBOL(remove, std::, ) SYMBOL(remove_all_extents, std::, ) sammccall wrote: > Is the stdio version so uncommon we are willing to be wrong abou

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

kbobyrev updated this revision to Diff 390641. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113995/new/ https://reviews.llvm.org/D113995 Files: clang-

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

kbobyrev updated this revision to Diff 390643. kbobyrev added a comment. Remove refactoring leftovers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113995/new/ https://reviews.llvm.org/D113995 Files: clang-tools-extra/clangd/index/dex/Trigram.c

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

peterwaller-arm added inline comments. Comment at: clang/test/CodeGen/aarch64_neon_sve_bridge_intrinsics/acle_neon_sve_bridge_dup_neonq.c:8 + +#define SVE_ACLE_FUNC(A1,A2,A3,A4) A1##A2##A3##A4 + Do you also want to test the overloaded forms here via SVE_OVERLOAD

[PATCH] D114787: [clang][PR51931] Enable `-Wdeclaration-after-statement` for all C versions

zero9178 created this revision. zero9178 added reviewers: dblaikie, aaron.ballman, rsmith. zero9178 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `-Wdeclaration-after-statement` currently only outputs an diagnostic if the user is compili

[PATCH] D114540: Big-endian version of vpermxor

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Comment at: llvm/lib/Target/PowerPC/PPCInstrVSX.td:2506 + def : Pat<(v16i8 (int_ppc_altivec_crypto_vpermxor_be v16i8:$a, +

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

OikawaKirie updated this revision to Diff 390653. OikawaKirie marked an inline comment as done. OikawaKirie edited the summary of this revision. OikawaKirie added a comment. Herald added a subscriber: manas. It has been a long period since the last discussion, I hope you can still remember this b

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

peterwaller-arm added inline comments. Comment at: clang/include/clang/Basic/BuiltinsAArch64NeonSVEBridge.def:2 +#ifdef GET_SVE_BUILTINS +BUILTIN(__builtin_sve_svget_neonq_s8, "q4iq16bq4i", "n") +BUILTIN(__builtin_sve_svget_neonq_s16, "q4iq16bq4i", "n") Looks lik

[PATCH] D102149: [analyzer][ctu] Allow loading invocation list from a compilation database automatically detected from the ctu-dir

OikawaKirie abandoned this revision. OikawaKirie added a comment. Herald added a subscriber: manas. It seems that this issue has better solutions outside the CTU module, I will drop this revision as mentioned above. Sorry for the delay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D114497: [PowerPC] Drop stdlib paths in freestanding tests

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. Seems fine to me but maybe give @MaskRay a couple of days to see if this adequately addresses his comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D114699: Fixed a memory leak in the PDLToPDLInterp RootOrderingTest.

sfuniak updated this revision to Diff 390477. sfuniak added a comment. Herald added subscribers: cfe-commits, llvm-commits, libcxx-commits, lldb-commits, Sanitizers, luke957, asavonic, carlosgalvezp, armkevincheng, foad, jsmolens, eric-k256, frasercrmck, dang, martong, kerbowa, csigg, luismarque

[PATCH] D114699: Fixed a memory leak in the PDLToPDLInterp RootOrderingTest.

sfuniak abandoned this revision. sfuniak added a comment. Herald added a subscriber: JDevlieghere. Messed up a rebase, will submit a new diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114699/new/ https://reviews.llvm.org/D114699 _

[PATCH] D114699: Fixed a memory leak in the PDLToPDLInterp RootOrderingTest.

mehdi_amini added inline comments. Comment at: mlir/unittests/Conversion/PDLToPDLInterp/RootOrderingTest.cpp:37 + ~RootOrderingTest() { +for (int i = 0; i < 4; ++i) + v[i].getDefiningOp()->destroy(); bondhugula wrote: > bondhugula wrote: > > You need to

[PATCH] D114413: [OpenMPIRBuilder] Implement static-chunked workshare-loop schedules.

peixin added a comment. In D114413#3159095 , @Meinersbur wrote: > In D114413#3154936 , @peixin wrote: > >> @Meinersbur Please rebase on main. The function "getPreheader()" was moved >> into OMPIRBuilder.h. > > I

[PATCH] D114631: [DebugInfo][InstrRef] Turn instruction referencing on by default for x86

djtodoro accepted this revision. djtodoro added a comment. This revision is now accepted and ready to land. lgtm, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114631/new/ https://reviews.llvm.org/D114631 ___ cfe-commits mailing list

[PATCH] D114631: [DebugInfo][InstrRef] Turn instruction referencing on by default for x86

jmorse added inline comments. Comment at: llvm/lib/Target/X86/X86TargetMachine.cpp:29 #include "llvm/Analysis/TargetTransformInfo.h" +#include "llvm/CodeGen/CommandFlags.h" #include "llvm/CodeGen/ExecutionDomainFix.h" Orlando wrote: > nit: Is this change necess

[clang] 651122f - [DebugInfo][InstrRef] Pre-land on-by-default-for-x86 changes

Author: Jeremy Morse Date: 2021-11-30T12:40:59Z New Revision: 651122fc4ac92b93f36aab3b194de21065a0c48e URL: https://github.com/llvm/llvm-project/commit/651122fc4ac92b93f36aab3b194de21065a0c48e DIFF: https://github.com/llvm/llvm-project/commit/651122fc4ac92b93f36aab3b194de21065a0c48e.diff LOG:

[PATCH] D114769: [C++20] [Modules] [Concepts] Recognize same concepts more precisely in Serialization

ChuanqiXu updated this revision to Diff 390668. ChuanqiXu added a comment. Fix tests under Debug mode. I need to remember run debug tests : ( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114769/new/ https://reviews.llvm.org/D114769 Files: clang

[PATCH] D114790: [syntax][pseudo] Add grammar facilities for the pseudo-parser

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: mgrang, mgorny. hokein requested review of this revision. Herald added a project: clang. This patch introduces basic structures for the grammar, which is used to build a grammar-based parser. As the first

[PATCH] D113422: [clang-tidy][NFC] Move CachedGlobList to GlobList.h

carlosgalvezp added a comment. Kind ping to reviewers. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113422/new/ https://reviews.llvm.org/D113422 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D114631: [DebugInfo][InstrRef] Turn instruction referencing on by default for x86

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c045070882f: [DebugInfo] Turn instruction referencing on by default for x86 (authored by jmorse). Changed prior to commit: https://reviews.llvm.org/D114631?vs=390003&id=390673#toc Repository: rG LLV

[PATCH] D114631: [DebugInfo][InstrRef] Turn instruction referencing on by default for x86

jmorse added a comment. Cheers all, especially for the latest reviews; we'll now see whether there are extra edge cases I haven't caught! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114631/new/ https://reviews.llvm.org/D114631 _

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

steakhal added a comment. Looks good. Please get rid of the macro stuff, consider something along the lines I proposed for the parsing stuff. Also clang-format the code you touch. I haven't checked the docs and the comments of the codebase, but I'll assume you grepped and fixed all occurrences.

[PATCH] D91000: [clang-tidy] Add cert-msc24-c checker.

whisperity added a comment. Should/does this work in C++ mode for `std::whatever`? Comment at: clang-tools-extra/clang-tidy/cert/ObsolescentFunctionsCheck.cpp:48 + // Matching functions with safe replacements in annex K. + auto FunctionNamesWithAnnexKReplacementMatcher = hasA

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

erichkeane added a comment. IMO, if we're updating the MSVC versions, we should do the same for the GCC/Clang/AppleClang versions too. For example, GCC 5.1 is from 2015, and Clang 3.5 is from 2014. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

aaron.ballman added a comment. In D114639#3161303 , @erichkeane wrote: > IMO, if we're updating the MSVC versions, we should do the same for the > GCC/Clang/AppleClang versions too. For example, GCC 5.1 is from 2015, and > Clang 3.5 is from 2014. I'd

[PATCH] D114540: Big-endian version of vpermxor

tislam updated this revision to Diff 390683. tislam marked 2 inline comments as done. tislam added a comment. - The P9 RUN step on big-endian platform is removed from the lit test. - Fixed formatting in `llvm/lib/Target/PowerPC/PPCInstrVSX.td` CHANGES SINCE LAST AC

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

erichkeane added a comment. In D114639#3161362 , @aaron.ballman wrote: > In D114639#3161303 , @erichkeane > wrote: > >> IMO, if we're updating the MSVC versions, we should do the same for the >> GCC/Clang/Apple

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

aaron.ballman added a comment. In D114639#3161440 , @erichkeane wrote: > In D114639#3161362 , @aaron.ballman > wrote: > >> In D114639#3161303 , @erichkeane >> wrote: >>

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

erichkeane added a comment. See: https://lists.llvm.org/pipermail/llvm-dev/2021-November/153882.html for what I was thinking of. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639 __

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

steakhal requested changes to this revision. steakhal added a comment. This revision now requires changes to proceed. In D112621#3160082 , @manas wrote: > I have made few changes: > > 1. The failed assertions due to >

[clang] 6e2aecd - [clang][dataflow] Add base types for building dataflow analyses

Author: Stanislav Gatev Date: 2021-11-30T14:44:40Z New Revision: 6e2aecd759dc3f8bf664323388365ac234271e9b URL: https://github.com/llvm/llvm-project/commit/6e2aecd759dc3f8bf664323388365ac234271e9b DIFF: https://github.com/llvm/llvm-project/commit/6e2aecd759dc3f8bf664323388365ac234271e9b.diff LO

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e2aecd759dc: [clang][dataflow] Add base types for building dataflow analyses (authored by sgatev, committed by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

MattDevereau added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1325 setOperationAction(ISD::MLOAD, VT, Custom); + setOperationAction(ISD::INSERT_SUBVECTOR, VT, Custom); } paulwalker-arm wrote: > Can you extract th

[PATCH] D113422: [clang-tidy][NFC] Move CachedGlobList to GlobList.h

carlosgalvezp updated this revision to Diff 390708. carlosgalvezp added a comment. Switch to public inheritance + mutable cached data. This seems to be a valid use case for mutable, even though I'm not sure if there's anything against it in the LLVM codin

[PATCH] D112024: [clang] diagnose_as attribute for Fortify diagnosing like builtins.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:5956 +given. In addition, the order in which arguments should be applied must also +be given. + We should mention that the attribute cannot be applied to a member function (an

[PATCH] D114560: [OPENMP]Fix PR51327: Range based for loop not working if range's type is a template.

ABataev updated this revision to Diff 390714. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114560/new/ https://reviews.llvm.org/D114560 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/for_loop_auto.cpp

[PATCH] D113946: [libc][clang-tidy] fix namespace check for externals

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a tiny nit with the documentation. Comment at: libc/docs/clang_tidy_checks.rst:71 +There are exceptions for the following functions: +``__errno_location`` so that errno can be set +``malloc``,

[PATCH] D114546: [OPENMP]Fix PR52117: Crash caused by target region inside of task construct.

ABataev updated this revision to Diff 390716. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114546/new/ https://reviews.llvm.org/D114546 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/Analysis/cfg-openmp.cpp

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

jamesfarrell added a comment. In D114163#3160292 , @arphaman wrote: > Sorry for delay, this LGTM. Thanks for doing this cleanup! Thanks, and no worries about the time (I was out last week as well) Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D114653: [OPENMP]Fix error emission for dependent expressions in iterators for depend clauses.

ABataev updated this revision to Diff 390718. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114653/new/ https://reviews.llvm.org/D114653 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/target_enter_data_d

[clang] 3e32f82 - [clang][dataflow] Fix broken build in ClangStaticAnalyzer

Author: Yitzhak Mandelbaum Date: 2021-11-30T15:31:49Z New Revision: 3e32f827e2647b6fa8022cbc76eac384b3c4e2b4 URL: https://github.com/llvm/llvm-project/commit/3e32f827e2647b6fa8022cbc76eac384b3c4e2b4 DIFF: https://github.com/llvm/llvm-project/commit/3e32f827e2647b6fa8022cbc76eac384b3c4e2b4.diff

[clang] 1e82864 - Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

Author: James Farrell Date: 2021-11-30T15:44:23Z New Revision: 1e8286467036d8ef1a972de723f805a4981b2692 URL: https://github.com/llvm/llvm-project/commit/1e8286467036d8ef1a972de723f805a4981b2692 DIFF: https://github.com/llvm/llvm-project/commit/1e8286467036d8ef1a972de723f805a4981b2692.diff LOG:

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e8286467036: Use VersionTuple for parsing versions in Triple. This makes it possible to… (authored by jamesfarrell). Repository: rG LLVM Github M

[PATCH] D114776: [clang-offload-bundler] Reuse original file extension for device archive member

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114776/new/ https://reviews.llvm.org/D114776 ___

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

MattDevereau updated this revision to Diff 390731. MattDevereau added a comment. updated builtin signatures in `clang/include/clang/Basic/BuiltinsAArch64NeonSVEBridge.def` removed irrelevant change in `llvm/lib/Target/AArch64/AArch64ISelLowering.cpp` ran clang-format CHANGES SINCE LAST ACTION

[PATCH] D112626: Convert float to double on __builtin_dump_struct

aaron.ballman added a reviewer: paulsemel. aaron.ballman added a subscriber: paulsemel. aaron.ballman added a comment. Adding @paulsemel to the reviewer list as he was the original author of this functionality (I commit on his behalf which is how I showed up on the git blame). ===

[PATCH] D114718: [analyzer] Implement a new checker for Strict Aliasing Rule.

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StrictAliasingChecker.cpp:48-49 + // + // NOTE: User must provide canonical and unqualified QualType's for the + // correct result. + static bool canAccess(QualType From, QualType To, ASTContex

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

paulwalker-arm added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1325 setOperationAction(ISD::MLOAD, VT, Custom); + setOperationAction(ISD::INSERT_SUBVECTOR, VT, Custom); } MattDevereau wrote: > paulwalker-arm wro

[clang] fd1d8e4 - [clang][dataflow] Make header parse

Author: Benjamin Kramer Date: 2021-11-30T17:53:19+01:00 New Revision: fd1d8e45f488b28db8d63ab51733ddd1e37e751c URL: https://github.com/llvm/llvm-project/commit/fd1d8e45f488b28db8d63ab51733ddd1e37e751c DIFF: https://github.com/llvm/llvm-project/commit/fd1d8e45f488b28db8d63ab51733ddd1e37e751c.dif

[PATCH] D112663: [clang-repl] Allow Interpreter::getSymbolAddress to take a mangled name.

aaron.ballman added a comment. There is no information in this patch as to why the changes are needed or useful; please use a more descriptive summary next time. Comment at: clang/unittests/Interpreter/InterpreterTest.cpp:205-207 + // FIXME: We cannot yet handle delayed templ

[PATCH] D112663: [clang-repl] Allow Interpreter::getSymbolAddress to take a mangled name.

erichkeane added inline comments. Comment at: clang/unittests/Interpreter/InterpreterTest.cpp:237-240 + std::string MangledName = MangleName(TmpltSpec); + typedef int (*TemplateSpecFn)(void *); + auto fn = (TemplateSpecFn)cantFail(Interp->getSymbolAddress(MangledName)); + EXP

[clang] b8e03be - [PS4][DWARF] Explicitly set default DWARF version to 4

Author: Paul Robinson Date: 2021-11-30T08:58:40-08:00 New Revision: b8e03be88dc87303f7401ea7b9906947ac67a6db URL: https://github.com/llvm/llvm-project/commit/b8e03be88dc87303f7401ea7b9906947ac67a6db DIFF: https://github.com/llvm/llvm-project/commit/b8e03be88dc87303f7401ea7b9906947ac67a6db.diff

[PATCH] D112663: [clang-repl] Allow Interpreter::getSymbolAddress to take a mangled name.

aaron.ballman added inline comments. Comment at: clang/unittests/Interpreter/InterpreterTest.cpp:205-207 + // FIXME: We cannot yet handle delayed template parsing. If we run with + // -fdelayed-template-parsing we try adding the newly created decl to the + // active PTU which

[PATCH] D114651: [clang-cl] Expose -Wall to clang-cl by unaliasing -Wall, keeping /Wall as alias to -Weverything

rnk added a comment. It looks like this Wall -> Weverything alias is from my 2017 change: https://reviews.llvm.org/rGf9b08a382cc1e0669805991849ad69efbd4703e8 The commit message doesn't link to any bugs or any other motivating material. All I said is that this is being done for MSVC compatibility

[PATCH] D114725: [clang-format] add back tests which didn't cause a regression

crayroud added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14277 + // FIXME these tests regressed behaviour. // verifyFormat("T A::operator() () {}", SpaceFuncDef); verifyFormat("auto lambda = [] () { return 0; };", SpaceFuncDef); cr

[clang] 40d5eea - Revert "Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible."

Author: Nikita Popov Date: 2021-11-30T18:36:32+01:00 New Revision: 40d5eeac6cd89a2360c3ba997cbaa816abca828c URL: https://github.com/llvm/llvm-project/commit/40d5eeac6cd89a2360c3ba997cbaa816abca828c DIFF: https://github.com/llvm/llvm-project/commit/40d5eeac6cd89a2360c3ba997cbaa816abca828c.diff

[PATCH] D114082: [WIP] Normalize String Attributes

serge-sans-paille added a comment. In D114082#3149631 , @rnk wrote: >> it is possible to list all internal keys in one place > > I think one of the original goals of adding support for string attributes > (maybe @void will give some input) was specifical

[PATCH] D114394: Compile-time computation of string attribute hashes

serge-sans-paille added a comment. Gentle ping :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114394/new/ https://reviews.llvm.org/D114394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D114394: Compile-time computation of string attribute hashes

nikic added a comment. Compile-time: https://llvm-compile-time-tracker.com/compare.php?from=3608e18a946e77a474a468304b6c3904c55dbce0&to=0ce74a09cc8533a10fb67fdec4fb6ad8de4f1153&stat=instructions Some improvement at `O3`, not much change for optimized builds. A concern I have is that this may be

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

nikic added a comment. FYI I reverted this due to test failures -- one specific assertion failure is mentioned in https://reviews.llvm.org/rG40d5eeac6cd8. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114163/new/ https://reviews.llvm.org/D114163

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

fhahn added a comment. It is also breaking building `llvm-project/llvm/unittests/Support/Host.cpp` on macOS: https://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/25781/consoleFull FAILED: unittests/Support/CMakeFiles/SupportTests.dir/Host.cpp.o /Applications/Xcode.app/Co

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

jamesfarrell added a comment. In D114163#3161978 , @nikic wrote: > FYI I reverted this due to test failures -- one specific assertion failure is > mentioned in https://reviews.llvm.org/rG40d5eeac6cd8. Thanks! I saw the failures and was going to revert,

[PATCH] D114565: [InstrProf] Attach debug info to counters

kyulee added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp:851 + addString(AnnotationDie, dwarf::DW_AT_const_value, Value->getString()); +else if (const auto *Expr = dyn_cast(ValueOp)) + addConstantValue( It checks an expres

[PATCH] D44605: [Driver] Default to DWARF 5 for Fuchsia

phosek added a comment. Herald added a subscriber: abrachet. @mcgrathr This might be ready to land now. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44605/new/ https://reviews.llvm.org/D44605 ___ cfe-commits mailing l

[PATCH] D114115: [Driver] Support for compressed debug info on Fuchsia

phosek added a comment. @mcgrathr Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114115/new/ https://reviews.llvm.org/D114115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

mehdi_amini added a comment. In D114639#3161303 , @erichkeane wrote: > IMO, if we're updating the MSVC versions, we should do the same for the > GCC/Clang/AppleClang versions too. For example, GCC 5.1 is from 2015, and > Clang 3.5 is from 2014. We've

[PATCH] D114023: [Driver] Pass --fix-cortex-a53-843419 automatically on Fuchsia

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:91 +std::string CPU = getCPUName(D, Args, Triple); +if (CPU.empty() || CPU == "generic" || CPU == "cortex-a53") + CmdArgs.push_back("--fix-cortex-a53-843419"); mcgrathr

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon added a comment. In D114639#3162000 , @mehdi_amini wrote: > In D114639#3161303 , @erichkeane > wrote: > >> IMO, if we're updating the MSVC versions, we should do the same for the >> GCC/Clang/AppleClang

[PATCH] D114809: Fix documentation for `forEachLambdaCapture` and `hasAnyCapture`

jcking1034 created this revision. jcking1034 added reviewers: ymandel, tdl-g, aaron.ballman. jcking1034 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Updates the return types of these matchers' definitions to use `internal::Matcher` inste

[PATCH] D114382: [clang] Fix wrong -Wunused-local-typedef warning within a template function

krisb added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114382/new/ https://reviews.llvm.org/D114382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D114809: Fix documentation for `forEachLambdaCapture` and `hasAnyCapture`

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. #TIL :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114809/new/ https://reviews.llvm.org/D114809 __

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

erichkeane added a subscriber: jfb. erichkeane added a comment. In D114639#3162032 , @RKSimon wrote: > In D114639#3162000 , @mehdi_amini > wrote: > >> In D114639#3161303

  1   2   >