aaron.ballman added inline comments.
================ Comment at: clang/unittests/Interpreter/InterpreterTest.cpp:205-207 + // FIXME: We cannot yet handle delayed template parsing. If we run with + // -fdelayed-template-parsing we try adding the newly created decl to the + // active PTU which causes an assert. ---------------- aaron.ballman wrote: > FWIW, Intel's internal testing is hitting crashes with this test. With > `-fno-delayed-template-parsing` enabled, we get a failed assertion: > ``` > Assertion failed: OffsetBytes <= AllocationSize && "Offset out of bounds!", > file d:\iusers\ayrivera\dev-xmain-web\llvm\l > lvm\lib\executionengine\runtimedyld\RuntimeDyldImpl.h, line 90 > ``` > and when we enable the delayed template parsing, we get a different assertion: > ``` > Assertion failed: DC->getLexicalParent() == CurContext && "The next > DeclContext should be lexically contained in the current one.", file > D:/iusers/ayrivera/dev-xmain-web/llvm/clang/lib/Sema/SemaDecl.cpp, line 1305 > ``` > > I think this FIXME either needs to be addressed or the patch reverted until > this is addressed. Ignore this -- this comment was saved in my Phab drafts from an earlier investigation and I managed to not delete it when sending my other comment (below). Oops! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112663/new/ https://reviews.llvm.org/D112663 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits