This revision was automatically updated to reflect the committed changes.
Closed by commit rG3c045070882f: [DebugInfo] Turn instruction referencing on by
default for x86 (authored by jmorse).
Changed prior to commit:
https://reviews.llvm.org/D114631?vs=390003&id=390673#toc
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114631/new/
https://reviews.llvm.org/D114631
Files:
llvm/lib/CodeGen/CommandFlags.cpp
llvm/test/DebugInfo/X86/instr-ref-flag.ll
Index: llvm/test/DebugInfo/X86/instr-ref-flag.ll
===================================================================
--- llvm/test/DebugInfo/X86/instr-ref-flag.ll
+++ llvm/test/DebugInfo/X86/instr-ref-flag.ll
@@ -13,10 +13,6 @@
;; by llc by default, and that it can be turned explicitly on or off as
;; desired.
-;; XFail it for pre-landing the patch, and to allow a minimal delta if it
-;; has to be reverted.
-; XFAIL: *
-
; INSTRREFON: DBG_INSTR_REF
; INSTRREFOFF: DBG_VALUE
Index: llvm/lib/CodeGen/CommandFlags.cpp
===================================================================
--- llvm/lib/CodeGen/CommandFlags.cpp
+++ llvm/lib/CodeGen/CommandFlags.cpp
@@ -699,5 +699,7 @@
}
bool codegen::getDefaultValueTrackingVariableLocations(const llvm::Triple &T) {
+ if (T.getArch() == llvm::Triple::x86_64)
+ return true;
return false;
}
Index: llvm/test/DebugInfo/X86/instr-ref-flag.ll
===================================================================
--- llvm/test/DebugInfo/X86/instr-ref-flag.ll
+++ llvm/test/DebugInfo/X86/instr-ref-flag.ll
@@ -13,10 +13,6 @@
;; by llc by default, and that it can be turned explicitly on or off as
;; desired.
-;; XFail it for pre-landing the patch, and to allow a minimal delta if it
-;; has to be reverted.
-; XFAIL: *
-
; INSTRREFON: DBG_INSTR_REF
; INSTRREFOFF: DBG_VALUE
Index: llvm/lib/CodeGen/CommandFlags.cpp
===================================================================
--- llvm/lib/CodeGen/CommandFlags.cpp
+++ llvm/lib/CodeGen/CommandFlags.cpp
@@ -699,5 +699,7 @@
}
bool codegen::getDefaultValueTrackingVariableLocations(const llvm::Triple &T) {
+ if (T.getArch() == llvm::Triple::x86_64)
+ return true;
return false;
}
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
