[PATCH] D112519: parallel-libs: remove some artifacts

sylvestre.ledru created this revision. sylvestre.ledru added reviewers: dblaikie, jlebar. sylvestre.ledru requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D112

[PATCH] D111870: [clangd] Add a way to enable IncludeCleaner through config

kbobyrev marked 9 inline comments as done. kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:215 +D.Message = "Included header is unused"; +D.Name = "clangd-include-cleaner"; +// FIXME: This range should be the whole line with tar

[PATCH] D111870: [clangd] Add a way to enable IncludeCleaner through config

kbobyrev updated this revision to Diff 382214. kbobyrev marked an inline comment as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111870/new/ https://reviews.llvm.org/D111870 Files: clang-

[PATCH] D111870: [clangd] Add a way to enable IncludeCleaner through config

kbobyrev updated this revision to Diff 382215. kbobyrev added a comment. Use IncludeCleaner to get rid of unused include in IncludeCleaner.cpp 🆒 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111870/new/ https://reviews.llvm.org/D111870 Files: cl

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence marked 6 inline comments as done. achieveartificialintelligence added inline comments. Comment at: llvm/lib/Target/RISCV/Disassembler/RISCVDisassembler.cpp:164 +static DecodeStatus DecodeGPRF16RegisterClass(MCInst &Inst, uint64_t RegNo, +

[PATCH] D111711: [clangd] IncludeCleaner: Don't consider the definition as usage for function forward declarations

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:42 + bool VisitFunctionDecl(FunctionDecl *FD) { +// Function definition will require redeclar

[PATCH] D112447: [clangd] IncludeCleaner: Support macros

kbobyrev updated this revision to Diff 382221. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Try another strategy to reduce the number of processed tokens (doesn't work in all cases). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D112447: [clangd] IncludeCleaner: Support macros

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:140 +// locations for the found macros. +void findReferencedMacros(ParsedAST &AST, ReferencedLocations &Result) { + auto Tokens = sammccall wrote: > sammccall wrote: > > can

[clang-tools-extra] c521288 - [clangd] IncludeCleaner: Don't consider the definition as usage for function forward declarations

Author: Kirill Bobyrev Date: 2021-10-26T10:37:10+02:00 New Revision: c521288ed391bd29a37f1c444d08ae542df5341c URL: https://github.com/llvm/llvm-project/commit/c521288ed391bd29a37f1c444d08ae542df5341c DIFF: https://github.com/llvm/llvm-project/commit/c521288ed391bd29a37f1c444d08ae542df5341c.diff

[PATCH] D111711: [clangd] IncludeCleaner: Don't consider the definition as usage for function forward declarations

This revision was automatically updated to reflect the committed changes. Closed by commit rGc521288ed391: [clangd] IncludeCleaner: Don't consider the definition as usage for function… (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D112521: [CUDA][NFC] Fix inexact warning message about lambdas

benshi001 created this revision. benshi001 added reviewers: tra, fodinabor, Hahnfeld, yaxunl. benshi001 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D112521 Files: clang/

[PATCH] D112521: [CUDA][NFC] Fix inexact warning message about lambdas

benshi001 added a comment. Acutally lambdas with CUDA attributes can have non-empty parameter list, and the original warning message is inexact. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112521/new/ https://reviews.llvm.org/D112521 __

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

eopXD updated this revision to Diff 382225. eopXD added a comment. Fix test fail and clang-format error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112359/new/ https://reviews.llvm.org/D112359 Files: clang/test/CodeGen/RISCV/riscv-metadata.c

[PATCH] D111986: [Clang] Add elementwise abs builtin.

fhahn updated this revision to Diff 382226. fhahn marked 2 inline comments as done. fhahn added a comment. Rebased after recent changes in D111985 : changes the return type of SemaBuiltinElementwiseMathOneArg to bool and drop the CallResult argument. Also added

[PATCH] D111047: CUDA/HIP: Allow __int128 on the host side

linjamaki updated this revision to Diff 382228. linjamaki added a comment. Rephrase expressions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111047/new/ https://reviews.llvm.org/D111047 Files: clang/lib/Sema/Sema.cpp clang/lib/Sema/SemaType.

[PATCH] D111870: [clangd] Add a way to enable IncludeCleaner through config

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Awesome, let's ship it! Only nits on the text, feel free to ignore any you don't like Comment at: clang-tools-extra/clangd/ConfigFragment.h:213 +/// Controls how

[PATCH] D112296: [Analyzer][solver] Handle adjustments in constraint assignor remainder

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1623 if (!Constraint.containsZero()) { - State = RCM.assumeSymNE(State, LHS, Zero, Zero); + State = RCM.assumeSymRel(State, LHS, BO_NE, Zero); if (!State) --

[PATCH] D111047: CUDA/HIP: Allow __int128 on the host side

linjamaki added a comment. Thanks for the review. Updated the patch with the style suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111047/new/ https://reviews.llvm.org/D111047 ___ cfe-commits

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki added a comment. Gentle ping. Is anything needed to be addressed to get this patch accepted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108621/new/ https://reviews.llvm.org/D108621 ___ cfe-c

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

linjamaki added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110549/new/ https://reviews.llvm.org/D110549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki added a comment. Gentle ping. Is anything needed to be addressed to get this patch accepted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 ___ cfe-c

[PATCH] D109506: [clangd] Print current request context along with the stack trace

uabelho added a comment. Hi, It seems like this patch may cause timeouts. I've seen it myself and also in this bot: http://lab.llvm.org:8011/#/builders/52/builds/11791 When I got the timeout in our downstream CI I think it was the Clangd :: crash.test that had problems. Repository: rG LLVM

[PATCH] D107339: [analyzer] Retrieve a character from StringLiteral as an initializer for constant arrays.

ASDenysPetrov added a comment. @martong (inline) Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1757-1760 + // FIXME: Nevertheless, we can't do the same for cases, like: + // const char *str = "123"; // literal length is 4 + // char c = str[41];// offs

[PATCH] D112001: [Clang] Add min/max reduction builtins.

fhahn updated this revision to Diff 382240. fhahn added a comment. Rebased after recent changes in D111985 https://reviews.llvm.org/D111985: changes the return type of SemaBuiltinReduceMath to bool and drop the CallResult argument. Also added tests with const

[PATCH] D111870: [clangd] Add a way to enable IncludeCleaner through config

kbobyrev updated this revision to Diff 382242. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Resolve the review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111870/new/ https://reviews.llvm.org/D111870 Files: cl

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

linjamaki updated this revision to Diff 382244. linjamaki added a comment. Improve `--offload` option description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110622/new/ https://reviews.llvm.org/D110622 Files: clang/include/clang/Basic/Cuda.h

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

eopXD updated this revision to Diff 382250. eopXD added a comment. Update code and test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112359/new/ https://reviews.llvm.org/D112359 Files: clang/test/CodeGen/RISCV/riscv-metadata.c clang/tes

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

eopXD added a comment. The test cases are modified because unifying the logic here shows the place where clang / llvm deal with target feature inconsistently. I think it would be beneficial if we have them consistent. - Test cases with `clang -cc1` originally don't do dependency check to target

[clang-tools-extra] 6d314ee - [clangd] Add a way to enable IncludeCleaner through config

Author: Kirill Bobyrev Date: 2021-10-26T12:53:05+02:00 New Revision: 6d314ee570975610ef85e8c56659f00857b49744 URL: https://github.com/llvm/llvm-project/commit/6d314ee570975610ef85e8c56659f00857b49744 DIFF: https://github.com/llvm/llvm-project/commit/6d314ee570975610ef85e8c56659f00857b49744.diff

[PATCH] D111870: [clangd] Add a way to enable IncludeCleaner through config

This revision was automatically updated to reflect the committed changes. Closed by commit rG6d314ee57097: [clangd] Add a way to enable IncludeCleaner through config (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111870/new/ h

[PATCH] D109506: [clangd] Print current request context along with the stack trace

thakis added a comment. In D109506#3086214 , @smeenai wrote: > In D109506#3086183 , @thakis wrote: > >> This doesn't build on windows: http://45.33.8.238/win/47615/step_4.txt >> >> Please take a look and revert fo

[PATCH] D112285: [PowerPC] PPC backend optimization to lower int_ppc_tdw/int_ppc_tw intrinsics to TDI/TWI machine instructions

nemanjai added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:5003 +N->getConstantOperandVal(1) == Intrinsic::ppc_tw) { + int16_t SImm; + if (isIntS16Immediate(N->getOperand(3), SImm)) { I think a couple of improvements

[PATCH] D112050: [clang] NFC: return void in an alternative expression after call to void function.

zhouyizhou added a comment. ping Just a ping, to see if there are any comments :-P Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112050/new/ https://reviews.llvm.org/D112050 ___ cfe-commits mailing list

[PATCH] D109506: [clangd] Print current request context along with the stack trace

jansvoboda11 added a comment. Here's another test failure: https://green.lab.llvm.org/green/job/clang-stage1-RA/24998 Can you revert if the fix is not trivial? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109506/new/ https://reviews.llvm.org/D109

Re: [clang] 2edb89c - Lex arguments for __has_cpp_attribute and friends as expanded tokens

On Mon, Oct 25, 2021 at 8:41 PM Nico Weber wrote: > > Was this reviewed anywhere? Post-commit review (as attribute code owner). > I'll note that some internal project apparently used to check `#if > __has_attribute(__unsafe_unretained)`. That used to silently (and incorrectly > I think) always

[PATCH] D112527: [clangd] Fix a hover crash on templated spaceship operator.

adamcz created this revision. adamcz added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, yaxunl. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. We make assumption that: getDe

[PATCH] D112408: [WIP][RISCV] Add the zve extension according to the v1.0-rc2 spec

frasercrmck added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:182 +def FeatureExtZve32x +: SubtargetFeature<"experimental-zve32x", "HasStdExtZve32x", "true", craig.topper wrote: > frasercrmck wrote: > > Do we need to define distinct `Subtarg

[PATCH] D111985: [Clang] Add elementwise min/max builtins.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:16695 + TheCall->setArg(1, B.get()); + TheCall->setType(TyB); + return false; I think you want to set this to `Res`, because that's the common type between `TyB` and `TyA`, right

[PATCH] D111985: [Clang] Add elementwise min/max builtins.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8747-8748 +def err_elementwise_math_arg_types_mismatch : Error < + "argument types do not match, %0 != %1">; + Does `err_typecheck_call_different_arg_types` suffi

[PATCH] D112406: [Driver][AArch64]Add driver support for neoverse-512tvb target

CarolineConcatto updated this revision to Diff 382273. CarolineConcatto added a comment. - Rebase and remove support on for ARM 32 bits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112406/new/ https://reviews.llvm.org/D112406 Files: clang/test/

[PATCH] D109506: [clangd] Print current request context along with the stack trace

0x1eaf added a comment. I think this should work-around end-to-end test failure on Windows: diff --git a/clang-tools-extra/clangd/test/crash.test b/clang-tools-extra/clangd/test/crash.test index 1197e1ab07c3..68ef54808f09 100644 --- a/clang-tools-extra/clangd/test/crash.test +++ b/clang-

[clang-tools-extra] 51be706 - [clangd] Remove tricky integration test that flakes/fails on some platforms.

Author: Sam McCall Date: 2021-10-26T14:19:05+02:00 New Revision: 51be7061d025139ba66869d5d99c7157a3ae9edd URL: https://github.com/llvm/llvm-project/commit/51be7061d025139ba66869d5d99c7157a3ae9edd DIFF: https://github.com/llvm/llvm-project/commit/51be7061d025139ba66869d5d99c7157a3ae9edd.diff LO

[PATCH] D111985: [Clang] Add elementwise min/max builtins.

aaron.ballman added a comment. I thought of another test case -- should these new functions work on complex types? (Those are weird enough we may want to consider adding both Sema and CodeGen tests if we do support them, and Sema tests alone if we don't.) Repository: rG LLVM Github Monorepo

[PATCH] D111986: [Clang] Add elementwise abs builtin.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8754 +def err_elementwise_math_invalid_arg_type_2: Error < + "argument must have a %0 type, but was %1">; + I feel like we must already have a diagnostic that cover

[PATCH] D109506: [clangd] Print current request context along with the stack trace

sammccall added a comment. In D109506#3087055 , @0x1eaf wrote: > I think this should work-around end-to-end test failure on Windows: > > diff --git a/clang-tools-extra/clangd/test/crash.test > b/clang-tools-extra/clangd/test/crash.test > index 1197e1

[PATCH] D112406: [Driver][AArch64]Add driver support for neoverse-512tvb target

CarolineConcatto marked an inline comment as done. CarolineConcatto added a comment. Thank you for your review @dmgreen and @tschuett. I rebase the patch, now VScaleForTuning is being set. And I removed support for neoverse-512tvb from Arm 32 bits. @paulwalker-arm pointed me that neoverse-512t

[PATCH] D112001: [Clang] Add min/max reduction builtins.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:16606-16609 + const VectorType *VecTy = TyA->getAs(); + if (!VecTy) +return Diag(A->getBeginLoc(), diag::err_elementwise_math_invalid_arg_type_2) + << "vector" << TyA; --

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

Sockke added a comment. Herald added a subscriber: carlosgalvezp. Kindly ping. @whisperity, @aaron.ballman, @Quuxplusone CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/ https://reviews.llvm.org/D107450 ___ cfe-commits mailing list c

[PATCH] D112447: [clangd] IncludeCleaner: Support macros

kbobyrev updated this revision to Diff 382277. kbobyrev added a comment. Skip the tokens that are not identifiers or weren't defined as macros, attach tracer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112447/new/ https://reviews.llvm.org/D11244

[PATCH] D111434: [PowerPC] PPC backend optimization on conditional trap intrustions

nemanjai added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp:1011 + case PPC::TDI: + case PPC::TWI: { +MachineInstr *LiMIA = getVRegDefOrNull(&MI.getOperand(1), MRI); Seems that we should be able to handle all 4 in the s

[PATCH] D112447: [clangd] IncludeCleaner: Support macros

kbobyrev updated this revision to Diff 382278. kbobyrev added a comment. Rebase on top of main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112447/new/ https://reviews.llvm.org/D112447 Files: clang-tools-extra/clangd/IncludeCleaner.cpp clang

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/MoveConstArgCheck.cpp:140 + diag(InvocationParm->getLocation(), + "consider changing the %0st parameter of %1 from %2 to 'const %3 &'", + DiagnosticIDs::Note)

[PATCH] D112491: Add `LambdaCapture`-related matchers.

aaron.ballman added a comment. I'm a bit confused as to why this is necessary. We already have `lambdaExpr(hasAnyCapture(varDecl(hasName("whatever"` and `lambdaExpr(hasAnyCapture(cxxThisExpr()))`, so I'm not certain why we need this as a parallel construct? Comment at: c

[PATCH] D109506: [clangd] Print current request context along with the stack trace

thakis added a comment. Thanks for the fixes! My bots are happy now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109506/new/ https://reviews.llvm.org/D109506 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

whisperity added a comment. I think this is becoming okay and looks safe enough. I can't really grasp what `HasCheckedMoveSet` means, and how it synergises with storing `CallExpr`s so maybe a better name should be added. Do you mean `AlreadyCheckedMoves`? When is it possible that the same `Call

[PATCH] D112530: [clangd] AddUsing: Fix support for template specializations.

adamcz created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Before this change, we would add "using std::vector" instead of

[PATCH] D112334: [clang-tidy] Suppress readability-static-access-through-instance for CUDA built-in variables

whisperity added a comment. In D112334#3084533 , @aaron.ballman wrote: > In D112334#3081213 , @carlosgalvezp > wrote: > >> Btw, regarding this `CHECK-MESSAGES-NOT`, how does it work? I can't find it >> in `chec

[PATCH] D112334: [clang-tidy] Suppress readability-static-access-through-instance for CUDA built-in variables

whisperity closed this revision. whisperity added a comment. @carlosgalvezp Force pushes are prevented by the serverside integration so we couldn't force push even if we wanted to. What one could do is to revert the patch and land it again (or land an empty patch that has the association line i

[PATCH] D112287: [clang] Implement CFG construction for @try and @catch

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm, just some nits. Comment at: clang/lib/Analysis/CFG.cpp:485 - // This can point either to a try or a __try block. The frontend forbids - // mixing both kinds in one func

[PATCH] D46081: [analyzer] Expand conversion check to check more expressions for overflow and underflow

whisperity added reviewers: martong, steakhal. whisperity added a subscriber: balazske. whisperity added a comment. Herald added subscribers: manas, ASDenysPetrov, donat.nagy. Pinging my people here, perhaps you being more knowledgeable in the analyser can say if this patch is salvageable in any

[PATCH] D112398: [RISCV] Add ABI testing for Float16.

frasercrmck added a comment. It looks as though all checks are checking the same thing? Presumably this is expected? I wonder if allowing an extra combined check (`--check-prefixes=CHECK,CHECK-ZFH-ILP32F` or something) would make it more obvious when things *are* different between the different

[PATCH] D112504: [OpenMP] Wrap (v)printf in the new RT and use same handling for AMD

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGGPUBuiltin.cpp:128 return RValue::get(Builder.CreateCall( VprintfFunc, {Args[0].getRValue(*this).getScalarVal(), BufferPtr})); } >>! In D112504#3086474, @JonChesterfield wrote: > That's a

[PATCH] D112406: [Driver][AArch64]Add driver support for neoverse-512tvb target

dmgreen added a comment. Thanks. If the cpu has a 512 bit total vector bandwidth, should the VScaleForTuning be 1 or 2 (or higher)? llvm doesn't usually deal with total bandwidth a lot, perhaps not as much as it should. @david-arm any thoughts? Repository: rG LLVM Github Monorepo CHANGES S

[libunwind] 56b7461 - [libunwind] Take 2: Use the from-scratch testing configuration by default

Author: Louis Dionne Date: 2021-10-26T09:34:40-04:00 New Revision: 56b74613bf9168bb79e0088b424ec0b6dd0a66c9 URL: https://github.com/llvm/llvm-project/commit/56b74613bf9168bb79e0088b424ec0b6dd0a66c9 DIFF: https://github.com/llvm/llvm-project/commit/56b74613bf9168bb79e0088b424ec0b6dd0a66c9.diff

[PATCH] D110065: [AArch64] Add support for the 'R' architecture profile.

labrinea updated this revision to Diff 382288. labrinea marked an inline comment as done. labrinea added a comment. Added a comment explaining system register lookups by alternative name as suggested and rebased on top of https://reviews.llvm.org/D111551. @john.brawn you may want to re-review th

[PATCH] D112334: [clang-tidy] Suppress readability-static-access-through-instance for CUDA built-in variables

carlosgalvezp added a comment. @whisperity Understood, thanks for the help! I'll take more care to remember the reference next time :) I added it as a comment in Github for reference so there's at least some traceability. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112334/new/ https

[PATCH] D112532: [Matrix] Replace some err kinds with err_builtin_invalid_arg_type. (NFC)

fhahn created this revision. fhahn added reviewers: aaron.ballman, erichkeane, rjmccall. Herald added a subscriber: tschuett. fhahn requested review of this revision. Herald added a project: clang. Replace some custom matrix diagnostic kinds with the more generic err_builtin_invalid_arg_type intro

[PATCH] D112287: [clang] Implement CFG construction for @try and @catch

thakis marked 4 inline comments as done. thakis added a comment. Thanks, all done. Looks like there's no range access to a try's catch blocks, so no for-range loop for now. Maybe I'll add range accessors for those later. Comment at: clang/lib/Analysis/CFG.cpp:3895 CFGBlock *

[clang] d054b31 - [clang] Use consistent punctuation at end of Block NULL comment

Author: Nico Weber Date: 2021-10-26T09:45:22-04:00 New Revision: d054b31d5975f6cffeef8c9f3fa57e1c4b60d427 URL: https://github.com/llvm/llvm-project/commit/d054b31d5975f6cffeef8c9f3fa57e1c4b60d427 DIFF: https://github.com/llvm/llvm-project/commit/d054b31d5975f6cffeef8c9f3fa57e1c4b60d427.diff LO

[clang] aa42785 - [clang] Simplify CFG block printing code a bit

Author: Nico Weber Date: 2021-10-26T09:45:22-04:00 New Revision: aa42785d01cb498c1eb880e9f0e08f01006839c6 URL: https://github.com/llvm/llvm-project/commit/aa42785d01cb498c1eb880e9f0e08f01006839c6 DIFF: https://github.com/llvm/llvm-project/commit/aa42785d01cb498c1eb880e9f0e08f01006839c6.diff LO

[clang] 0b7c9ad - [clang] Make loop in CFGBuilder::VisitCXXTryStmt() more canonical

Author: Nico Weber Date: 2021-10-26T09:45:22-04:00 New Revision: 0b7c9addce69ca089a23334490758907dd4ab0db URL: https://github.com/llvm/llvm-project/commit/0b7c9addce69ca089a23334490758907dd4ab0db DIFF: https://github.com/llvm/llvm-project/commit/0b7c9addce69ca089a23334490758907dd4ab0db.diff LO

[clang] 04f3079 - [clang] Implement CFG construction for @try and @catch

Author: Nico Weber Date: 2021-10-26T09:45:22-04:00 New Revision: 04f30795f1663843b219393040946136786aa591 URL: https://github.com/llvm/llvm-project/commit/04f30795f1663843b219393040946136786aa591 DIFF: https://github.com/llvm/llvm-project/commit/04f30795f1663843b219393040946136786aa591.diff LO

[PATCH] D112287: [clang] Implement CFG construction for @try and @catch

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG04f30795f166: [clang] Implement CFG construction for @try and @catch (authored by thakis). Herald added a project: clang. Changed prior to commit:

[PATCH] D112406: [Driver][AArch64]Add driver support for neoverse-512tvb target

paulwalker-arm added a comment. In D112406#3087191 , @dmgreen wrote: > Thanks. If the cpu has a 512 bit total vector bandwidth, should the > VScaleForTuning be 1 or 2 (or higher)? llvm doesn't usually deal with total > bandwidth a lot, perhaps not as mu

[PATCH] D112534: [PoC][RISCV] Use an attribute to declare C intrinsics with different policy.

HsiangKai created this revision. HsiangKai added reviewers: kito-cheng, craig.topper, frasercrmck, rogfer01. Herald added subscribers: achieveartificialintelligence, StephenFan, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, Ma

[PATCH] D112534: [PoC][RISCV] Use an attribute to declare C intrinsics with different policy.

HsiangKai updated this revision to Diff 382298. HsiangKai added a comment. Remove redundant test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112534/new/ https://reviews.llvm.org/D112534 Files: clang/include/clang/Basic/Attr.td clang/in

[PATCH] D111985: [Clang] Add elementwise min/max builtins.

fhahn updated this revision to Diff 382300. fhahn marked 3 inline comments as done. fhahn added a comment. Address latest comments, thanks - Added a generic `err_builtin_invalid_arg_type` diagnostic kind, which can also be used for some of the matrix type mismatches (see D112532

[PATCH] D112532: [Matrix] Replace some err kinds with err_builtin_invalid_arg_type. (NFC)

erichkeane added a comment. I'm fine with this change in general... but did this not manage to break any tests? Comment at: clang/lib/Sema/SemaChecking.cpp:16654 +Diag(PtrExpr->getBeginLoc(), diag::err_builtin_invalid_arg_type) +<< PtrArgIdx + 1 << "pointer to a va

[PATCH] D111985: [Clang] Add elementwise min/max builtins.

fhahn marked 3 inline comments as done. fhahn added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8747-8748 +def err_elementwise_math_arg_types_mismatch : Error < + "argument types do not match, %0 != %1">; + aaron.ballman wrote

[PATCH] D112504: [OpenMP] Wrap (v)printf in the new RT and use same handling for AMD

JonChesterfield added a comment. Nice! Yep, can add a size argument later. Will want it to control copying the payload over to the host Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112504/new/ https://reviews.llvm.org/D112504 ___

[PATCH] D110065: [AArch64] Add support for the 'R' architecture profile.

labrinea updated this revision to Diff 382294. labrinea added a comment. Added v8.1a_ops on AppleA10. However, the target parser lists it as v8.0a, which seems odd. Out of the scope of this patch anyway. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110065/new/ https://reviews.llvm.org

[clang-tools-extra] 1c2e249 - [clangd] IncludeCleaner: don't stop the traversal

Author: Kirill Bobyrev Date: 2021-10-26T16:08:54+02:00 New Revision: 1c2e249f938c50e1b331a1f7adc83c0a381f3897 URL: https://github.com/llvm/llvm-project/commit/1c2e249f938c50e1b331a1f7adc83c0a381f3897 DIFF: https://github.com/llvm/llvm-project/commit/1c2e249f938c50e1b331a1f7adc83c0a381f3897.diff

[PATCH] D111199: [Clang][LLVM][Attr] support btf_type_tag attribute

aaron.ballman added reviewers: rsmith, dblaikie. aaron.ballman added a comment. Adding some additional reviewers who may have more opinions about the changes in CodeGen. Comment at: clang/include/clang/Basic/AttrDocs.td:2029-2034 +Clang supports the ``__attribute__((btf_type_t

[PATCH] D112532: [Matrix] Replace some err kinds with err_builtin_invalid_arg_type. (NFC)

aaron.ballman added a comment. In general, I like the direction of this cleanup. Thanks! In D112532#3087293 , @erichkeane wrote: > I'm fine with this change in general... but did this not manage to break any > tests? Precommit CI says things are broke

[PATCH] D112527: [clangd] Fix a hover crash on templated spaceship operator.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Hover.cpp:271 + DeclForComment = TSD->getSpecializedTemplate(); if (const auto *TIP = TSD->getTemplateInstantiationPatt

[PATCH] D111985: [Clang] Add elementwise min/max builtins.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111985/new/ https://reviews.llvm.org/D111985 _

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

JonChesterfield updated this revision to Diff 382306. JonChesterfield added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112227/new/ https://reviews.llvm.org/D112227 Files: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp open

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

aaron.ballman added a comment. In D107450#3087103 , @whisperity wrote: > There has been a new release since the patch was proposed so a rebase should > be needed. > @aaron.ballman What do you think, does this warrant a ReleaseNotes entry? I think a rel

[PATCH] D112530: [clangd] AddUsing: Fix support for template specializations.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp:284 +// Remove the template arguments from the name. +NameRange = SourceRange(Na

[PATCH] D112459: [AArch64] Enablement of Cortex-X2

mubashar_ updated this revision to Diff 382309. mubashar_ marked 2 inline comments as done. mubashar_ added a comment. Made adjustments to AArch64.td and AArch64Subtarget.cpp files. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112459/new/ https://reviews.llvm.org/D112459 Files: clan

[PATCH] D112459: [AArch64] Enablement of Cortex-X2

mubashar_ added a comment. Addressed comments from @dmgreen. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112459/new/ https://reviews.llvm.org/D112459 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang] 025988d - Specify Clang vector builtins.

Author: Florian Hahn Date: 2021-10-26T15:34:31+01:00 New Revision: 025988ded6b2a57022dbf9775f35a1a933584bfa URL: https://github.com/llvm/llvm-project/commit/025988ded6b2a57022dbf9775f35a1a933584bfa DIFF: https://github.com/llvm/llvm-project/commit/025988ded6b2a57022dbf9775f35a1a933584bfa.diff

[PATCH] D111529: Specify Clang vector builtins.

This revision was automatically updated to reflect the committed changes. Closed by commit rG025988ded6b2: Specify Clang vector builtins. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111529/new/ https://reviews.llvm.org/D111529

[PATCH] D112409: [clang-tidy] Add check 'cert-err33-c'.

balazske updated this revision to Diff 382312. balazske added a comment. Improved the documentation. Small code layout changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112409/new/ https://reviews.llvm.org/D112409 Files: clang-tools-extra/c

[PATCH] D111654: [analyzer] Retrieve a value from list initialization of multi-dimensional array declaration.

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1643-1654 + const VarRegion *VR = dyn_cast(R->getSuperRegion()); + SmallVector SValOffsets; + SValOffsets.push_back(R->getIndex()); + if (const ElementRegion *ER = dyn_cast(R->getSu

[PATCH] D111434: [PowerPC] PPC backend optimization on conditional trap intrustions

amyk added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp:1011 + case PPC::TDI: + case PPC::TWI: { +MachineInstr *LiMIA = getVRegDefOrNull(&MI.getOperand(1), MRI); nemanjai wrote: > Seems that we should be able to handle

[PATCH] D112285: [PowerPC] PPC backend optimization to lower int_ppc_tdw/int_ppc_tw intrinsics to TDI/TWI machine instructions

amyk added inline comments. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-trap-64bit-only.ll:131 +; CHECK: # %bb.0: +; CHECK-NEXT:tdi 3, 3, 32767 +; CHECK-NEXT:blr nemanjai wrote: > Can we add `-ppc-asm-full-reg-names` to the RUN line

[PATCH] D112409: [clang-tidy] Add check 'cert-err33-c'.

balazske marked 8 inline comments as done. balazske added a comment. I was not sure how the aliasing is to be handled if the check is not exactly the same as the original. (This was a topic on the mailing list.) I like it more if only those checks are aliases that are exactly the same. But for n

[PATCH] D112409: [clang-tidy] Add check 'cert-err33-c'.

balazske added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/cert-err33-c.rst:1 +.. title:: clang-tidy - cert-err33-c + carlosgalvezp wrote: > I believe we usually mention that this is an alias to another check, and then > redirect the us

[PATCH] D112409: [clang-tidy] Add check 'cert-err33-c'.

balazske updated this revision to Diff 382323. balazske added a comment. Added to release notes, added new links to documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112409/new/ https://reviews.llvm.org/D112409 Files: clang-tools-extr

  1   2   3   >