erichkeane added a comment.

I'm fine with this change in general... but did this not manage to break any 
tests?



================
Comment at: clang/lib/Sema/SemaChecking.cpp:16654
+    Diag(PtrExpr->getBeginLoc(), diag::err_builtin_invalid_arg_type)
+        << PtrArgIdx + 1 << "pointer to a valid matrix element type"
+        << PtrExpr->getType();
----------------
Can you make these be a "select" instead?  It makes it really difficult to 
localize if we do this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112532/new/

https://reviews.llvm.org/D112532

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to