[PATCH] D111367: [Driver] Change -dumpmachine to respect --target/LLVM_DEFAULT_TARGET_TRIPLE verbatim

MaskRay added a comment. If this is trivially correct, may I get a stamp? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111367/new/ https://reviews.llvm.org/D111367 ___ cfe-commits mailing list cfe-commi

[PATCH] D111367: [Driver] Change -dumpmachine to respect --target/LLVM_DEFAULT_TARGET_TRIPLE verbatim

hvdijk added a comment. In D111367#3050062 , @MaskRay wrote: > If GCC installation has library files under `lib/x86_64-redhat-linux`, I > think inferred `LLVM_DEFAULT_TARGET_TRIPLE` should be `x86_64-redhat-linux`, > instead of `x86_64-redhat-linux-gnu`

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

noajshu updated this revision to Diff 378289. noajshu added a comment. Make file prefix and error prefix configurable. This sets the prefix for existing use to "Thin" to avoid chaning the behavior. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11137

[PATCH] D111273: [clang-format-diff] Fix missing formatting for zero length git diff lines

zequanwu updated this revision to Diff 378291. zequanwu added a comment. Fix the same error in git-clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111273/new/ https://reviews.llvm.org/D111273 Files: clang/tools/clang-format/clang-for

[clang] f931692 - [clang-format-diff] Fix missing formatting for zero length git diff lines

Author: Zequan Wu Date: 2021-10-08T10:25:54-07:00 New Revision: f93169226a298f8fb22d768671d5564030c0ffa9 URL: https://github.com/llvm/llvm-project/commit/f93169226a298f8fb22d768671d5564030c0ffa9 DIFF: https://github.com/llvm/llvm-project/commit/f93169226a298f8fb22d768671d5564030c0ffa9.diff LOG

[PATCH] D111273: [clang-format-diff] Fix missing formatting for zero length git diff lines

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf93169226a29: [clang-format-diff] Fix missing formatting for zero length git diff lines (authored by zequanwu). Repository: rG LLVM Github Monorep

[PATCH] D110935: [NFC] Update vec_extract builtin signatures to take signed int.

NeHuang accepted this revision as: NeHuang. NeHuang added a comment. This revision is now accepted and ready to land. LTGM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110935/new/ https://reviews.llvm.org/D110935 _

[PATCH] D111443: [Driver] Fix ToolChain::getSanitizerArgs

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: abrachet, kerbowa, mstorsjo, jgravelle-google, sbc100, nhaehnle, jvesely, dschuff, emaste. yaxunl requested review of this revision. Herald added a subscriber: aheejin. The driver uses class SanitizerArgs to sto

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

noajshu updated this revision to Diff 378296. noajshu added a comment. Rebase against main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111371/new/ https://reviews.llvm.org/D111371 Files: clang/lib/CodeGen/BackendUtil.cpp lld/COFF/LTO.cpp

[clang] a23a596 - [clang] Fix absolute file paths with -fdebug-prefix-map

Author: Keith Smiley Date: 2021-10-08T10:35:17-07:00 New Revision: a23a5967932292b82e9a7e4b37817d1b3f5be5ec URL: https://github.com/llvm/llvm-project/commit/a23a5967932292b82e9a7e4b37817d1b3f5be5ec DIFF: https://github.com/llvm/llvm-project/commit/a23a5967932292b82e9a7e4b37817d1b3f5be5ec.diff

[PATCH] D111352: [clang] Fix absolute file paths with -fdebug-prefix-map

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa23a59679322: [clang] Fix absolute file paths with -fdebug-prefix-map (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D111242: Add `TypeLoc`-related matchers.

jcking1034 updated this revision to Diff 378298. jcking1034 added a comment. Rebase onto master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111242/new/ https://reviews.llvm.org/D111242 Files: clang/docs/LibASTMatchersReference.html clang/inc

[PATCH] D111229: [PowerPC][Builtin] Allowing __rlwnm to accept a variable as a shift parameter

NeHuang added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-error.c:46 unsigned int mask; - unsigned int res = __builtin_ppc_rlwnm(ui, shift, 7); // expected-error {{argument to '__builtin_ppc_rlwnm' must be a constant integer}} + unsigned int res =

[PATCH] D111444: Revert "[clang] Fix absolute file paths with -fdebug-prefix-map"

keith created this revision. keith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reverts commit a23a5967932292b82e9a7e4b37817d1b3f5be5ec . This broke a windows te

[clang] 68e49ae - Revert "[clang] Fix absolute file paths with -fdebug-prefix-map"

Author: Keith Smiley Date: 2021-10-08T10:39:44-07:00 New Revision: 68e49aea9ac4dca550df70706cc845de04939c03 URL: https://github.com/llvm/llvm-project/commit/68e49aea9ac4dca550df70706cc845de04939c03 DIFF: https://github.com/llvm/llvm-project/commit/68e49aea9ac4dca550df70706cc845de04939c03.diff

[PATCH] D111444: Revert "[clang] Fix absolute file paths with -fdebug-prefix-map"

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG68e49aea9ac4: Revert "[clang] Fix absolute file paths with -fdebug

[clang] ac74296 - Add `TypeLoc`-related matchers.

Author: James King Date: 2021-10-08T17:42:18Z New Revision: ac742965628631059af7fdc77e8661fa660ac180 URL: https://github.com/llvm/llvm-project/commit/ac742965628631059af7fdc77e8661fa660ac180 DIFF: https://github.com/llvm/llvm-project/commit/ac742965628631059af7fdc77e8661fa660ac180.diff LOG: Ad

[PATCH] D111242: Add `TypeLoc`-related matchers.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGac7429656286: Add `TypeLoc`-related matchers. (authored by jcking1034, committed by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] 3ab238a - [AST Matchers] Update dump_ast_matchers.py to query only class index page.

Author: James King Date: 2021-10-08T17:45:10Z New Revision: 3ab238af4fa44a12ff3d479dc7fac50332ad2875 URL: https://github.com/llvm/llvm-project/commit/3ab238af4fa44a12ff3d479dc7fac50332ad2875 DIFF: https://github.com/llvm/llvm-project/commit/3ab238af4fa44a12ff3d479dc7fac50332ad2875.diff LOG: [A

[PATCH] D111332: [AST Matchers] Update dump_ast_matchers.py to query only class index page.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ab238af4fa4: [AST Matchers] Update dump_ast_matchers.py to query only class index page. (authored by jcking1034, committed by ymandel). Changed prior to commit: https://reviews.llvm.org/D111332?vs=3782

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

phosek added inline comments. Comment at: llvm/lib/Support/Caching.cpp:32 + AddBufferFn AddBuffer, + StringRef CacheNameRef) { if (std::error_code EC = sys::fs::create_directories(CacheDire

[PATCH] D111293: [CFE][Codegen][In-progress] Remove CodeGenFunction::InitTempAlloca()

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Patch LGTM, but please remove the test, it's been folded into a test I added in my patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1112

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

tejohnson added inline comments. Comment at: llvm/include/llvm/Support/Caching.h:68 +/// already exist. +Expected localCache(StringRef CacheDirectoryPath, + AddBufferFn AddBuffer, Nit: document new parameter. ==

[PATCH] D94472: [clang][cli] Command line round-trip for HeaderSearch options

saudi added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:677 + SwapOpts(Res); + bool Success2 = Parse(Res, GeneratedArgs1, Diags); + jansvoboda11 wrote: > saudi wrote: > > jansvoboda11 wrote: > > > saudi wrote: > > > > Hello, > > > >

[PATCH] D111283: [clang] WIP: template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 378313. mizvekov edited the summary of this revision. mizvekov added a comment. - Handle all type classes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: c

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev added inline comments. Comment at: clang/unittests/Interpreter/CMakeLists.txt:5 + OrcJIT + Support ) thakis wrote: > Why are these additions needed here again? This change doesn't add any code > to ClangReplInterpreterTests as far as I can tell

[PATCH] D111443: [Driver] Fix ToolChain::getSanitizerArgs

tra added a comment. I'm curious why we need the cache at all. While the construction of sanitizer args is hairy, it's only called few times from the driver and will be lost in the noise compared to everything else. Comment at: clang/include/clang/Driver/ToolChain.h:165 -

[clang] b0f6879 - [clang] Option control afn flag

Author: Masoud Ataei Date: 2021-10-08T14:26:14-04:00 New Revision: b0f68791f0ad867118497daf6aa23f9a71500012 URL: https://github.com/llvm/llvm-project/commit/b0f68791f0ad867118497daf6aa23f9a71500012 DIFF: https://github.com/llvm/llvm-project/commit/b0f68791f0ad867118497daf6aa23f9a71500012.diff

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

noajshu updated this revision to Diff 378316. noajshu added a comment. Adjust cache name/prefix customization. Move customization arguments to be first. Convert to twines, remove unnecessary copy. Separate customized file prefix from customized cache name (to avoid chaning any behavior from exis

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

noajshu marked 3 inline comments as done. noajshu added inline comments. Comment at: llvm/lib/Support/Caching.cpp:36 + SmallString<10> CacheName = CacheNameRef; return [=](unsigned Task, StringRef Key) -> AddStreamFn { tejohnson wrote: > Is this copy necess

[PATCH] D111250: [clang] Set max allowed alignment to 2^32

This revision was automatically updated to reflect the committed changes. Closed by commit rGa6891d2104fc: [clang] Set max allowed alignment to 2^32 (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111250/new/ https://reviews.ll

[clang] a6891d2 - [clang] Set max allowed alignment to 2^32

Author: Arthur Eubanks Date: 2021-10-08T11:44:15-07:00 New Revision: a6891d2104fc2c491885aece5c9d040926ff1ef2 URL: https://github.com/llvm/llvm-project/commit/a6891d2104fc2c491885aece5c9d040926ff1ef2 DIFF: https://github.com/llvm/llvm-project/commit/a6891d2104fc2c491885aece5c9d040926ff1ef2.diff

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei updated this revision to Diff 378324. haowei added a comment. Added unit test when "-ffuchsia-api-level" is supplied with a non integer value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://reviews.llvm.org/D108592 Files:

[PATCH] D111453: Delay trailing constraing evaluation so we short-circuit

erichkeane created this revision. erichkeane added reviewers: rsmith, hubert.reinterpretcast, saar.raz, arthur.j.odwyer, aaron.ballman, changyu, nwilson, cor3ntin. erichkeane requested review of this revision. As reported as a part of PR47508 (and somewhat confirmed in PR44833), our behavior to f

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

noajshu updated this revision to Diff 378328. noajshu marked 2 inline comments as done. noajshu added a comment. Add documentation for new parameters to localCache. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111371/new/ https://reviews.llvm.org/

[PATCH] D111453: Delay trailing constraing evaluation so we short-circuit

erichkeane added a comment. The implementation seems to have tried checking this constraint 2x, and the first time required fully instantiating the constraint. The only condition in the check is PartialOrdering here: https://github.com/llvm/llvm-project/blob/main/clang/lib/Sema/SemaTemplateDed

[PATCH] D111457: [clang][test] Add lit helper for windows paths

keith created this revision. keith added reviewers: jroelofs, rmaz. keith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds 2 new lit helpers (only to the clang config) `%{rootsep}` and `%{sep}`, these allow writing tests that corre

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

rjmccall added a comment. I agree. It doesn't have to be a CodeGen test, just anything that directly verifies that we get the right type, since I think those calls can succeed due to promotion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109950

[PATCH] D111324: [CFE][Codegen] Remove CodeGenFunction::InitTempAlloca()

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks. This LGTM when all the patches it depends on are checked in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111324/new/ https://revi

[PATCH] D109948: [Clang] Enable _Complex __ibm128 type

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109948/new/ https://reviews.llvm.org/D109948 ___

[PATCH] D111400: [Clang] Implement P2242R3

hubert.reinterpretcast added a comment. I am concerned that the general direction of this patch (to allow the previously ill-formed constexpr functions as an extension under older language levels) is based upon bugs/divergences-from-orthodoxy in Clang's implementation of C++20 (noting that the

[PATCH] D109632: [clang] de-duplicate methods from AST files

rmaz added a comment. In D109632#3046976 , @vsapsai wrote: > These are interesting results. I'm curious to measure the time spent in > `ASTReader::ReadMethodPool`. Updated numbers from today, looks like we added a lot more modular deps since last week.

[PATCH] D111459: Fix a diagnoses-valid in C++20 with variadic macros

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, erichkeane, cor3ntin. aaron.ballman requested review of this revision. Herald added a project: clang. C++20 and later allow you to pass no argument for the ... parameter in a variadic macro, whereas earlier language modes

[PATCH] D111242: Add `TypeLoc`-related matchers.

aaron.ballman added a comment. Oh! I did think of something else we should do -- can you add a release note to make users aware of the awesome new functionality? It doesn't have to be super detailed, but enough to alert people to the fact that this is significant new functionality. Repository

[PATCH] D111367: [Driver] Change -dumpmachine to respect --target/LLVM_DEFAULT_TARGET_TRIPLE verbatim

MaskRay added a comment. Agree that Red Hat GCC switching to `x86_64-redhat-linux-gnu` is the best long-term approach. > (Edit: @tstellar's approach to make LLVM get a x86_64-redhat-linux-gnu triple > avoids that problem, so that sounds good to me.) Let the `config.guess` removal patch normali

[PATCH] D111443: [Driver] Fix ToolChain::getSanitizerArgs

yaxunl added a comment. In D111443#3052099 , @tra wrote: > I'm curious why we need the cache at all. While the construction of sanitizer > args is hairy, it's only called few times from the driver and will be lost in > the noise compared to everything e

[clang] e1a9c04 - [test] Fixup builtin-assume-aligned.c

Author: Arthur Eubanks Date: 2021-10-08T13:07:28-07:00 New Revision: e1a9c0443533723300f76db10dcb221733420882 URL: https://github.com/llvm/llvm-project/commit/e1a9c0443533723300f76db10dcb221733420882 DIFF: https://github.com/llvm/llvm-project/commit/e1a9c0443533723300f76db10dcb221733420882.diff

[PATCH] D102923: [clang][lex] Remark on search path usage

dexonsmith added inline comments. Comment at: clang/test/Preprocessor/header-search-user-entries.c:9-11 +// CHECK: remark: user-provided search path used: '{{.*}}/header-search-user-entries/a' +// CHECK: remark: user-provided search path used: '{{.*}}/header-search-user-entries

[clang] 03bfdda - [NFC] Update vec_extract builtin signatures to take signed int.

Author: Amy Kwan Date: 2021-10-08T15:09:53-05:00 New Revision: 03bfddae5080f8b92d86342d68439c7f07838369 URL: https://github.com/llvm/llvm-project/commit/03bfddae5080f8b92d86342d68439c7f07838369 DIFF: https://github.com/llvm/llvm-project/commit/03bfddae5080f8b92d86342d68439c7f07838369.diff LOG:

[PATCH] D110935: [NFC] Update vec_extract builtin signatures to take signed int.

This revision was automatically updated to reflect the committed changes. Closed by commit rG03bfddae5080: [NFC] Update vec_extract builtin signatures to take signed int. (authored by amyk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110935/new/

[PATCH] D111453: Delay trailing constraing evaluation so we short-circuit

erichkeane added a comment. So debugging a DIFFERENT issue, I found that this is likely incomplete since we likely have a similar problem in `VisitCXXMethodDecl` below this. I can extend the tests here/fix easily enough, if we decide this is the right way around this. CHANGES SINCE LAST ACTI

[PATCH] D102923: [clang][lex] Remark on search path usage

dexonsmith added inline comments. Comment at: clang/test/Preprocessor/header-search-user-entries.c:9-11 +// CHECK: remark: user-provided search path used: '{{.*}}/header-search-user-entries/a' +// CHECK: remark: user-provided search path used: '{{.*}}/header-search-user-entries

[PATCH] D111462: [Driver][OpenBSD] Use ToolChain reference instead of getToolChain().

fcambus created this revision. fcambus added a reviewer: brad. Herald added a subscriber: fedor.sergeev. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D111462 Files:

[PATCH] D102488: [clang][deps] Prune unused header search paths

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102488/new/ https://reviews.llvm.org/D102488 __

[PATCH] D111463: [OpenMP] Remove doing assumption propagation in the front end.

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch removes the assumption propagation that was added in

[PATCH] D111453: Delay trailing constraing evaluation so we short-circuit

erichkeane abandoned this revision. erichkeane added a comment. Looking into my other issue, I think I'm reasonably convinced this is wrong. I was looking into the PR44833 blocker for 'ranges' which hits the VisitCXXRecordMethod part, and removing THAT breaks the constraint entirely, so I thin

[PATCH] D111382: Support _Float128 and F128 literal in C mode

hubert.reinterpretcast added a comment. Are we sure this is wise? We know that any future standard C++ type can't be the same as `__float128` (without changing the latter) because `__float128` mangles the same as 128-bit `long double`. So by making `__float128` the same as `_Float128` in C, we'

[clang] 05d46f6 - [NFC][sanitizer] Remove sanitizer_persistent_allocator.cpp

Author: Vitaly Buka Date: 2021-10-08T13:43:28-07:00 New Revision: 05d46f627c49ca9a576150be910a869034ced764 URL: https://github.com/llvm/llvm-project/commit/05d46f627c49ca9a576150be910a869034ced764 DIFF: https://github.com/llvm/llvm-project/commit/05d46f627c49ca9a576150be910a869034ced764.diff L

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

noajshu marked 3 inline comments as not done. noajshu added inline comments. Comment at: llvm/lib/Support/Caching.cpp:36 + SmallString<10> CacheName = CacheNameRef; return [=](unsigned Task, StringRef Key) -> AddStreamFn { noajshu wrote: > tejohnson wrote:

[PATCH] D111382: Support _Float128 and F128 literal in C mode

MaskRay added a subscriber: zatrazz. MaskRay added a comment. This is to make more glibc files compilable with Clang. (@zatrazz) In D111382#3052514 , @hubert.reinterpretcast wrote: > Are we sure this is wise? We know that any future standard C++ type ca

[clang] 7ac308f - PR52073: Fix equivalence computation for lambda-expressions.

Author: Richard Smith Date: 2021-10-08T13:54:01-07:00 New Revision: 7ac308fb8f283249b89851702aa07f3ed9ac86d4 URL: https://github.com/llvm/llvm-project/commit/7ac308fb8f283249b89851702aa07f3ed9ac86d4 DIFF: https://github.com/llvm/llvm-project/commit/7ac308fb8f283249b89851702aa07f3ed9ac86d4.diff

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

dexonsmith added a comment. In D80833#2069411 , @aganea wrote: > In D80833#2069246 , @amccarth wrote: > >> Does embedding full paths affect distributed builds or build reproducibility? > > It does affect reproducibi

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

leonardchan added a comment. Hi. I think our clang builders are failing from this after the reland (https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8833962834812688769/overview): Script: -- /b/s/w/ir/x/w/staging/llvm_build/tools/clang/unittests/Interprete

[PATCH] D111242: Add `TypeLoc`-related matchers.

jcking1034 added a comment. @aaron.ballman that sounds like a good idea, what's the process for adding a release note? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111242/new/ https://reviews.llvm.org/D111242

[PATCH] D111457: [clang][test] Add lit helper for windows paths

rmaz added inline comments. Comment at: clang/test/lit.cfg.py:60 +if platform.system() == 'Windows': +root_sep = 'C:\\' +else: `c:\`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111457/new/ https://reviews.l

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang/Basic/LangOptions.def:432 +VALUE_LANGOPT(FuchsiaAPILevel, 32, 0, "Fuchsia API Level") + Comment at

[PATCH] D94472: [clang][cli] Command line round-trip for HeaderSearch options

dexonsmith added a comment. Looking at `CommandLineArgs`, and its eventual forward to `MCTargetInfo`, the existing design looks like a reference leak, which would also block freeing Clang memory when LLVM is still running. Given that 89ea0b05207d45c145fb525df554b3b986ae379b

[clang] 64e9044 - Fix unintended fall-through.

Author: Richard Smith Date: 2021-10-08T14:25:17-07:00 New Revision: 64e9044ea43d2cee2a927bf221c5395a40a5e2fd URL: https://github.com/llvm/llvm-project/commit/64e9044ea43d2cee2a927bf221c5395a40a5e2fd DIFF: https://github.com/llvm/llvm-project/commit/64e9044ea43d2cee2a927bf221c5395a40a5e2fd.diff

[clang] 3db1ade - [Driver][test] Fix undefined-libs.cpp when CLANG_DEFAULT_UNWINDLIB is libunwind

Author: Fangrui Song Date: 2021-10-08T14:40:22-07:00 New Revision: 3db1ade368e538ba795486eea4923e331a8dde5a URL: https://github.com/llvm/llvm-project/commit/3db1ade368e538ba795486eea4923e331a8dde5a DIFF: https://github.com/llvm/llvm-project/commit/3db1ade368e538ba795486eea4923e331a8dde5a.diff

[PATCH] D111454: Move TargetRegistry.(h|cpp) from Support to MC

dexonsmith added a comment. Seems like a reasonable move to me. Comment at: llvm/include/llvm/MC/TargetRegistry.h:18-19 #ifndef LLVM_SUPPORT_TARGETREGISTRY_H #define LLVM_SUPPORT_TARGETREGISTRY_H Should be `LLVM_MC_TARGETREGISTRY_H` now. ===

[PATCH] D111454: Move TargetRegistry.(h|cpp) from Support to MC

rnk added a comment. Thanks for the review! I uploaded it a bit quickly because I wanted to kick off Bazel presubmit testing, since I haven't replicated that locally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111454/new/ https://reviews.llvm.o

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 added a comment. Passed internal CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109707/new/ https://reviews.llvm.org/D109707 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D111454: Move TargetRegistry.(h|cpp) from Support to MC

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111454/new/ https://reviews.llvm.org/D111454 __

[PATCH] D111454: Move TargetRegistry.(h|cpp) from Support to MC

MaskRay accepted this revision. MaskRay added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111454/new/ https://reviews.llvm.org/D111454 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D111454: Move TargetRegistry.(h|cpp) from Support to MC

lhames added a comment. Yeah -- this seems like a good idea to me. Thanks Reid! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111454/new/ https://reviews.llvm.org/D111454 ___ cfe-commits mailing list cfe

[PATCH] D111443: [Driver] Fix ToolChain::getSanitizerArgs

tra added a reviewer: eugenis. tra added a subscriber: eugenis. tra added a comment. In D111443#3052381 , @yaxunl wrote: > In D111443#3052099 , @tra wrote: > >> I'm curious why we need the cache at all. While the

[clang] 955dc34 - Fix TargetRegistry shlib build, clang edition

Author: Reid Kleckner Date: 2021-10-08T15:43:56-07:00 New Revision: 955dc3449acd64c0505a3823aa93a6af38b00782 URL: https://github.com/llvm/llvm-project/commit/955dc3449acd64c0505a3823aa93a6af38b00782 DIFF: https://github.com/llvm/llvm-project/commit/955dc3449acd64c0505a3823aa93a6af38b00782.diff

[PATCH] D110451: [IR] Increase max alignment to 4GB

leonardchan added a comment. Hi. It seems the reland caused an assertion to fail on our clang builders (https://luci-milo.appspot.com/ui/p/fuchsia/builders/prod/clang-linux-x64/b8834065059600721665/overview): [194/194] Building CXX object lib/Target/AArch64/CMakeFiles/LLVMAArch64CodeGen.dir/A

[PATCH] D111468: [clang] Capture Framework when HeaderSearch is resolved via headermap

cishida created this revision. cishida added reviewers: dexonsmith, ributzka. cishida requested review of this revision. Herald added a project: clang. When building frameworks, headermaps responsible for mapping angle-included headers to their source file location are passed via `-I` and not `-i

[PATCH] D94472: [clang][cli] Command line round-trip for HeaderSearch options

dexonsmith added a subscriber: aprantl. dexonsmith added a comment. In D94472#3052604 , @dexonsmith wrote: > Looking at `CommandLineArgs`, and its eventual forward to `MCTargetInfo`, the > existing design looks like a reference leak, which would also bloc

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

dexonsmith added a comment. If you do go with "off-by-default", the natural driver option to use would be the existing `-grecord-command-line`. You could use the same plumbing through `-cc1` that it does. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D110451: [IR] Increase max alignment to 4GB

aeubanks added a comment. Yes a stack trace/repro would be nice. I see a couple places that might be causing issues, I'll try fixing those. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110451/new/ https://reviews.llvm.org/D110451

[PATCH] D111457: [clang][test] Add lit helper for windows paths

keith updated this revision to Diff 378380. keith added a comment. Herald added a subscriber: ormris. Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111457/new/ https://reviews.llvm.org/D111457 Files: clang/test/CodeGen/debug-prefix-map

[PATCH] D111457: [clang][test] Add lit helper for windows paths

keith added inline comments. Comment at: clang/test/lit.cfg.py:60 +if platform.system() == 'Windows': +root_sep = 'C:\\' +else: rmaz wrote: > `c:\`? Do you mean lowercase or a single slash? I see ~2x the number of uppercase vs lowercase in this codebase now,

[PATCH] D111475: [OpenMP] Add RTL function for getting number of threads in block.

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. Herald added subscribers: guansong, tpr, yaxunl, jvesely, jholewinski. jhuber6 requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, sstefan1. Herald added projects: clang, OpenMP. This patch ad

[PATCH] D111475: [OpenMP] Add RTL function for getting number of threads in block.

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Great! I like the decrease in complexity of the compiler. Pretty close to dropping the nvptx and amdgpu subclasses entirely Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D111476: [modules] Make a module map referenced by a system map a system one too.

vsapsai created this revision. vsapsai added reviewers: Bigcheese, jansvoboda11. Herald added a subscriber: ributzka. vsapsai requested review of this revision. Herald added a project: clang. Mimic the behavior of including headers where a system includer makes an includee a system header too. rd

[PATCH] D110451: [IR] Increase max alignment to 4GB

aeubanks added a comment. I've comitted https://reviews.llvm.org/rGa0a493518245fa20fe15703a1be6babcb0c43c0a, if your stack trace is different, the fix will probably be very similar Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110451/new/ https:/

[PATCH] D111476: [modules] Make a module map referenced by a system map a system one too.

vsapsai added a comment. Used the mechanism simpler than the one with headers on purpose. // The #included file will be considered to be a system header if either it

[PATCH] D111477: DO NOT SUBMIT: workaround for context-sensitive use of non-type-template-parameter integer suffixes

dblaikie created this revision. dblaikie added reviewers: aprantl, probinson, JDevlieghere. dblaikie requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There's a nuanced check about when to use suffixes on these integer non-type-template-param

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 378388. mizvekov retitled this revision from "[clang] WIP: template / auto deduction deduces common sugar" to "[clang] template / auto deduction deduces common sugar". mizvekov edited the summary of this revision. mizvekov added a comment. - Add missing tes

[clang] 04aff39 - Revert "Reland "[clang-repl] Re-implement clang-interpreter as a test case.""

Author: Leonard Chan Date: 2021-10-08T17:43:23-07:00 New Revision: 04aff395047ab39811eea1fd811a5874d3e4dfe4 URL: https://github.com/llvm/llvm-project/commit/04aff395047ab39811eea1fd811a5874d3e4dfe4 DIFF: https://github.com/llvm/llvm-project/commit/04aff395047ab39811eea1fd811a5874d3e4dfe4.diff

[clang] 0f00aa5 - Add no_instrument_function attribute to Objective C methods as well

Author: Aditya Kumar Date: 2021-10-08T17:54:44-07:00 New Revision: 0f00aa502d79acf8a92b0b8490489895a9f28829 URL: https://github.com/llvm/llvm-project/commit/0f00aa502d79acf8a92b0b8490489895a9f28829 DIFF: https://github.com/llvm/llvm-project/commit/0f00aa502d79acf8a92b0b8490489895a9f28829.diff

[PATCH] D111286: Add no_instrument_function attribute to Objective C methods as well

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f00aa502d79: Add no_instrument_function attribute to Objective C methods as well (authored by hiraditya). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1112

[PATCH] D110451: [IR] Increase max alignment to 4GB

leonardchan added a comment. Finally got the stacktrace: leonardchan@cp-snakewater:~/llvm-monorepo/llvm-build-1-clang-only-debug$ bin/clang++ "-cc1" "-triple" "x86_64-unknown-linux-gnu" "-emit-obj" "--mrelax-relocations" "-disable-free" "-main-file-name" "AArch64SpeculationHardening.cpp" "-m

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 updated this revision to Diff 378391. Ericson2314 added a comment. Rebase, avoid extra string ref conversions in llvm-config Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 Files: clang/tool

[PATCH] D110451: [IR] Increase max alignment to 4GB

aeubanks added a comment. Sorry about that, should be fixed with 20a0c482e0 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110451/new/ https://reviews.llvm.org/D110451

[PATCH] D111475: [OpenMP] Add RTL function for getting number of threads in block.

jhuber6 updated this revision to Diff 378393. jhuber6 added a comment. Fixing tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111475/new/ https://reviews.llvm.org/D111475 Files: clang/lib/CodeGen/CGOpenMPRuntimeAMDGCN.cpp clang/lib/CodeGe

[clang] 222305d - PR51079: Treat thread_local variables with an incomplete class type as

Author: Richard Smith Date: 2021-10-08T18:46:01-07:00 New Revision: 222305d6ff6f6d156145d7de4f06d1c368383e41 URL: https://github.com/llvm/llvm-project/commit/222305d6ff6f6d156145d7de4f06d1c368383e41 DIFF: https://github.com/llvm/llvm-project/commit/222305d6ff6f6d156145d7de4f06d1c368383e41.diff

[PATCH] D111109: AddGlobalAnnotations for function with or without function body.

python3kgae added a comment. Updated summary. Tried to debug the linux fail with Hyper-V VM, cannot repro. Restarted Buildkite build to see if it still happens. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D09/new/ https://reviews.llvm.org/D11

<    1   2   3   >