phosek added inline comments.

================
Comment at: llvm/lib/Support/Caching.cpp:32
+                                             AddBufferFn AddBuffer,
+                                             StringRef CacheNameRef) {
   if (std::error_code EC = sys::fs::create_directories(CacheDirectoryPath))
----------------
Can we make this a `Twine`? I'd also make this argument the first one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111371/new/

https://reviews.llvm.org/D111371

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to