[PATCH] D111037: [X86] Check if struct is blank before getting the inner types

LuoYuanke accepted this revision. LuoYuanke added a comment. This revision is now accepted and ready to land. LGTM, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111037/new/ https://reviews.llvm.org/D111037

[PATCH] D111387: [NFC] [Clang] Remove pre-computed complex float types

qiucf created this revision. qiucf added reviewers: rjmccall, teemperor. qiucf requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D111387 Files: clang/include

[PATCH] D109948: [Clang] Enable _Complex __ibm128 type

qiucf updated this revision to Diff 378112. qiucf marked 2 inline comments as done. qiucf added a comment. Based on another patch to remove pre-computed complex CanQualType. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109948/new/ https://reviews.

[PATCH] D111387: [NFC] [Clang] Remove pre-computed complex float types

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. Would be nice to have the motivation for this in the commit message (IIUC this is based on the suggestion from D109948

[PATCH] D111228: [clang-tidy] Add options to bugprone-unused-return-value.

balazske updated this revision to Diff 378113. balazske added a comment. Using `StringRef`, added documentation (untested). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111228/new/ https://reviews.llvm.org/D111228 Files: clang-tools-extra/clang

[clang] 00c0ce0 - [NFC] [Clang] Remove pre-computed complex float types

Author: Qiu Chaofan Date: 2021-10-08T15:52:16+08:00 New Revision: 00c0ce0655da804c2ffb1a2a807052298032acc6 URL: https://github.com/llvm/llvm-project/commit/00c0ce0655da804c2ffb1a2a807052298032acc6 DIFF: https://github.com/llvm/llvm-project/commit/00c0ce0655da804c2ffb1a2a807052298032acc6.diff L

[PATCH] D111387: [NFC] [Clang] Remove pre-computed complex float types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG00c0ce0655da: [NFC] [Clang] Remove pre-computed complex float types (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D111340: [Driver][NetBSD] Use ToolChain reference instead of getToolChain().

fcambus updated this revision to Diff 378124. fcambus added a comment. Herald added a subscriber: fedor.sergeev. Also define and use ToolChain reference in netbsd::Assembler::ConstructJob(). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111340/new/ https://reviews.llvm.org/D111340 File

[PATCH] D111340: [Driver][NetBSD] Use ToolChain reference instead of getToolChain().

fcambus marked an inline comment as done. fcambus added inline comments. Comment at: clang/lib/Driver/ToolChains/NetBSD.cpp:32 const char *LinkingOutput) const { const Driver &D = getToolChain().getDriver(); mgorny wrote

[clang-tools-extra] b1309a1 - [clangd] Revert unwanted change from D108194

Author: Kirill Bobyrev Date: 2021-10-08T10:42:30+02:00 New Revision: b1309a1ed99deb3508da9d53fee2ae1f766d8432 URL: https://github.com/llvm/llvm-project/commit/b1309a1ed99deb3508da9d53fee2ae1f766d8432 DIFF: https://github.com/llvm/llvm-project/commit/b1309a1ed99deb3508da9d53fee2ae1f766d8432.diff

[PATCH] D111391: [NFC] [Clang] Use global enum for explicit float mode

qiucf created this revision. qiucf added reviewers: rjmccall, nemanjai, aaron.ballman, erichkeane. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, there're multiple float types that can be represented by `__attribute__((mo

[PATCH] D110798: [NFC] Use CHECK-NEXT instead of CHECK-SAME in target-invalid-cpu-note.c

DavidSpickett added a comment. This LGTM with the comment reworded. Thanks! Comment at: clang/test/Misc/target-invalid-cpu-note.c:1 +// Use CHECK-NEXT instead of CHECK-SAME: ensure outputs between different lines of CHECK-SAME not missing checked. // RUN: not %clang_cc1 -trip

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

qiucf updated this revision to Diff 378131. qiucf marked 2 inline comments as done. qiucf added a comment. Split and rebase upon D111391 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109950/new/ https://reviews.l

[clang] c0f9c7c - [X86] Check if struct is blank before getting the inner types

Author: Wang, Pengfei Date: 2021-10-08T17:09:34+08:00 New Revision: c0f9c7c01561a70974485e0e4a358d6bbdaf3b8e URL: https://github.com/llvm/llvm-project/commit/c0f9c7c01561a70974485e0e4a358d6bbdaf3b8e DIFF: https://github.com/llvm/llvm-project/commit/c0f9c7c01561a70974485e0e4a358d6bbdaf3b8e.diff

[PATCH] D111037: [X86] Check if struct is blank before getting the inner types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc0f9c7c01561: [X86] Check if struct is blank before getting the inner types (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SI

[clang] 1f90b36 - [Driver][NetBSD] Use ToolChain reference instead of getToolChain().

Author: Frederic Cambus Date: 2021-10-08T11:13:22+02:00 New Revision: 1f90b365bd626e5d7d963106692143699c69f616 URL: https://github.com/llvm/llvm-project/commit/1f90b365bd626e5d7d963106692143699c69f616 DIFF: https://github.com/llvm/llvm-project/commit/1f90b365bd626e5d7d963106692143699c69f616.dif

[PATCH] D111340: [Driver][NetBSD] Use ToolChain reference instead of getToolChain().

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. fcambus marked an inline comment as done. Closed by commit rG1f90b365bd62: [Driver][NetBSD] Use ToolChain reference instead of getToolChain(). (authored by fcambus). R

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

salman-javed-nz added a comment. What should happen with the following code: // NOLINTBEGIN(google*) // NOLINTEND(google-explicit-constructor) // NOLINTEND(google-runtime-operator) and this code: // NOLINTBEGIN(google-explicit-constructor) // NOLINTBEGIN(google-runtime-operator)

[clang] 35ebe4c - [Clang][OpenMP] Add partial support for Static Device Libraries

Author: Saiyedul Islam Date: 2021-10-08T09:37:51Z New Revision: 35ebe4cc24f87397762e35831953c4bfe5f52def URL: https://github.com/llvm/llvm-project/commit/35ebe4cc24f87397762e35831953c4bfe5f52def DIFF: https://github.com/llvm/llvm-project/commit/35ebe4cc24f87397762e35831953c4bfe5f52def.diff LOG

[clang] 5ab6ee7 - Fix a variety of bugs with nil-receiver checks when targeting

Author: John McCall Date: 2021-10-08T05:44:06-04:00 New Revision: 5ab6ee75994d645725264e757d67bbb1c96fb2b6 URL: https://github.com/llvm/llvm-project/commit/5ab6ee75994d645725264e757d67bbb1c96fb2b6 DIFF: https://github.com/llvm/llvm-project/commit/5ab6ee75994d645725264e757d67bbb1c96fb2b6.diff L

[PATCH] D111293: [CFE][Codegen][In-progress] Remove CodeGenFunction::InitTempAlloca()

rjmccall added a comment. Hmm. I decided the ObjC case needed a more complex change and went ahead and committed that fix here: https://github.com/llvm/llvm-project/commit/5ab6ee75994d. That obviates the need for the new test; sorry for the runaround. Please rebase and I'll review. Reposit

[PATCH] D111273: [clang-format-diff] Fix missing formatting for zero length git diff lines

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm If you want to look into it, I think having some kind of test for this script would be useful. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

carlosgalvezp added a comment. > How should Clang-Tidy behave when mixing check-specific NOLINTBEGIN/ENDs with > globbed ones? I would say keep current behavior - complain that the user wrote something different in the BEGIN and in the END. I like keeping things simple and easy to read and rea

[PATCH] D111273: [clang-format-diff] Fix missing formatting for zero length git diff lines

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. So this isn't just clang-format-diff.py but also all of `git clang-format` git add Analysis.cpp $ git clang-format clang-format did not modify any files This is bad because this is a way in which those using "git cla

[PATCH] D111293: [CFE][Codegen][In-progress] Remove CodeGenFunction::InitTempAlloca()

hsmhsm updated this revision to Diff 378157. hsmhsm added a comment. Rebase to latest trunk. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111293/new/ https://reviews.llvm.org/D111293 Files: clang/lib/CodeGen/CodeGenFunction.cpp clang/test/Cod

[PATCH] D110742: [OpenCL] Add pure and const attributes to vload builtins

stuart added a comment. In D110742#3048301 , @svenvh wrote: >> For the constant address space, the const attribute (or readnone) can be >> used. As memory in the constant address space is immutable, the statement in >> the langref that: "if a readnone f

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:353 + if (SuppressionIsSpecific) +*SuppressionIsSpecific = true; } salman-javed-nz wrote: > So when this function is called with args `

[clang] ff013b6 - Extend init-statement to allow alias-declaration

Author: Corentin Jabot Date: 2021-10-08T07:13:45-04:00 New Revision: ff013b61004b01043bdbebb6416c30ecb3d3d48c URL: https://github.com/llvm/llvm-project/commit/ff013b61004b01043bdbebb6416c30ecb3d3d48c DIFF: https://github.com/llvm/llvm-project/commit/ff013b61004b01043bdbebb6416c30ecb3d3d48c.diff

[PATCH] D111175: [Clang] Extend init-statement to allow alias-declaration

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit on your behalf in ff013b61004b01043bdbebb6416c30ecb3d3d48c , thank you for the new functionality! Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

thakis added inline comments. Comment at: clang/unittests/Interpreter/CMakeLists.txt:5 + OrcJIT + Support ) Why are these additions needed here again? This change doesn't add any code to ClangReplInterpreterTests as far as I can tell. Are these remnants fro

[PATCH] D111228: [clang-tidy] Add options to bugprone-unused-return-value.

aaron.ballman added a reviewer: alexfh. aaron.ballman added a comment. Thank you for the new documentation, that helps! The one thing I'm still struggling with is the design approach and how well this will scale. Basically, the issue here is that `CheckedFunctions` already has a very long list o

[PATCH] D111391: [NFC] [Clang] Use global enum for explicit float mode

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks for the cleanup! Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4209 ComplexMode = false; + ExplicitType = FloatModeKind::NoFloat; switch (Str.

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

aaron.ballman added a comment. I'd appreciate some codegen tests for the new functionality as well (so we're testing not just "do we accept it" but also "does it work" as well), but this looks correct to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D111400: [Clang] Implement P2242R3

cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Allow goto, label statements as well as static, thread_local and non-literal variables in constexpr functions. The proposal is implemented as a langua

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

Sockke updated this revision to Diff 378168. Sockke retitled this revision from "[clang-tidy] Fix wrong FIxIt in performance-move-const-arg" to "[clang-tidy] Fix wrong FixIt in performance-move-const-arg". Sockke added a comment. Sorry for the delayed reply because of National Day. I have updat

[PATCH] D111400: [Clang] Implement P2242R3

cor3ntin updated this revision to Diff 378172. cor3ntin added a comment. Fix diagnostics formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111400/new/ https://reviews.llvm.org/D111400 Files: clang/docs/ReleaseNotes.rst clang/include/cla

[PATCH] D111400: [Clang] Implement P2242R3

cor3ntin updated this revision to Diff 378173. cor3ntin added a comment. Add missing test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111400/new/ https://reviews.llvm.org/D111400 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Ba

[PATCH] D110215: [C++2a] [Module] Support extern C/C++ semantics

aaron.ballman added subscribers: cfe-commits, aaron.ballman. aaron.ballman added reviewers: aaron.ballman, erichkeane. aaron.ballman added a comment. Adding some more reviewers and subscribing the mailing lists. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10842

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

salman-javed-nz added a comment. In D111208#3050680 , @carlosgalvezp wrote: >> How should Clang-Tidy behave when mixing check-specific NOLINTBEGIN/ENDs >> with globbed ones? > > I would say keep current behavior - complain that the user wrote something

[PATCH] D111332: [AST Matchers] Update dump_ast_matchers.py to query only class index page.

aaron.ballman accepted this revision. aaron.ballman added reviewers: sammccall, klimek. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though I'll note I'm by no means a Python expert. I'm adding a few more AST matching folks in case they spot something I've

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

david-arm updated this revision to Diff 378180. david-arm marked an inline comment as done. david-arm added a comment. - Fixed formatting issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110258/new/ https://reviews.llvm.org/D110258 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D110913: [analyzer][solver] Handle simplification to ConcreteInt

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2104 + const llvm::APSInt &SV = CI->getValue(); + const RangeSet *ClassConstraint = getConstraint(State, Class); + // We have found a contradiction. --

[PATCH] D111318: [clang][clangd] Improve signature help for variadic functions.

sammccall added a comment. Thanks, this looks great, just want to check if there are more callsites we can hit while here. Comment at: clang/lib/Sema/SemaOverload.cpp:6460 // list (8.3.5). if (TooManyArguments(NumParams, Args.size(), PartialOverloading) && !Proto-

[PATCH] D110913: [analyzer][solver] Handle simplification to ConcreteInt

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2099-2111 + +SymbolRef SimplifiedMemberSym = nullptr; +SVal SimplifiedMemberVal = simplifyToSVal(State, MemberSym); +if (const auto CI = SimplifiedMemberVal.getAs

[PATCH] D111332: [AST Matchers] Update dump_ast_matchers.py to query only class index page.

sammccall accepted this revision. sammccall added a comment. Nice! Comment at: clang/docs/tools/dump_ast_matchers.py:48 text = re.sub(r'>', '>', text) def link_if_exists(m): name = m.group(1) While here I'd add a comment: ``` """ Wrap a likely AST no

[PATCH] D111260: [clang] Visit enum base specifiers in libIndex

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG. As you pointed out offline it's slightly out-of-order compared to he body but I don't think this matters, and it'd cost a fair bit of complexity to fix. Repository: rG LLVM Github

[clang-tools-extra] 6393c21 - [clangd] IncludeCleaner: Stop crashing when included file is not found

Author: Kirill Bobyrev Date: 2021-10-08T14:51:11+02:00 New Revision: 6393c21d476de2584b3ac010aace6a9b26d5bbec URL: https://github.com/llvm/llvm-project/commit/6393c21d476de2584b3ac010aace6a9b26d5bbec DIFF: https://github.com/llvm/llvm-project/commit/6393c21d476de2584b3ac010aace6a9b26d5bbec.diff

[PATCH] D111259: [clang] Fix range for forward-declared enums

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/Decl.cpp:4509 + auto Res = TagDecl::getSourceRange(); + // Has a definition, we can use the usual source range. + if (TagDecl::getBrace

[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

linjamaki added a comment. > What I have in mind is to continue using SPIR target for now (until SPIR-V > back-end is added). > For instance, SYCL compiler emits code for SPIR target and code format is > configured via flag. > > `-emit-llvm` changes output file format for regular C++ compilatio

[PATCH] D111242: Add `TypeLoc`-related matchers.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:6406-6414 +/// Matches reference `TypeLoc`s. +/// +/// Given +/// \code +/// int x = 3; +/// int& xx = x; +/// \endcode jcki

[PATCH] D110798: [NFC] Use CHECK-NEXT instead of CHECK-SAME in target-invalid-cpu-note.c

FreddyYe updated this revision to Diff 378199. FreddyYe marked an inline comment as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110798/new/ https://reviews.llvm.org/D110798 Files: clang/test/Mi

[PATCH] D110798: [NFC] Use CHECK-NEXT instead of CHECK-SAME in target-invalid-cpu-note.c

FreddyYe added inline comments. Comment at: clang/test/Misc/target-invalid-cpu-note.c:1 +// Use CHECK-NEXT instead of CHECK-SAME: ensure outputs between different lines of CHECK-SAME not missing checked. // RUN: not %clang_cc1 -triple armv5--- -target-cpu not-a-cpu -fsyntax-onl

[PATCH] D111406: [AIX][ZOS] Excluding merge-objc-interface.m from Tests

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: jsji, Jake-Egan. qiongsiwu1 added a project: LLVM. qiongsiwu1 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Objective C is not supported on AIX or ZOS. This patch excludes the

[PATCH] D110798: [NFC] Use CHECK-NEXT instead of CHECK-SAME in target-invalid-cpu-note.c

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. Forgot to accept, looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110798/new/ https://reviews.llvm.org/D110798

[clang] 75127bc - [AIX][ZOS] Excluding merge-objc-interface.m from Tests

Author: Qiongsi Wu Date: 2021-10-08T14:00:06Z New Revision: 75127bce6de78b83b70b898a04473f213451f13e URL: https://github.com/llvm/llvm-project/commit/75127bce6de78b83b70b898a04473f213451f13e DIFF: https://github.com/llvm/llvm-project/commit/75127bce6de78b83b70b898a04473f213451f13e.diff LOG: [A

[PATCH] D111406: [AIX][ZOS] Excluding merge-objc-interface.m from Tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG75127bce6de7: [AIX][ZOS] Excluding merge-objc-interface.m from Tests (authored by qiongsiwu1, committed by jsji). Repository: rG LLVM Github Monor

[clang] 6d27659 - [NFC] Use CHECK-NEXT instead of CHECK-SAME in target-invalid-cpu-note.c

Author: Freddy Ye Date: 2021-10-08T22:07:40+08:00 New Revision: 6d276595d1ce734a2269f6d3828dc457d7da99c4 URL: https://github.com/llvm/llvm-project/commit/6d276595d1ce734a2269f6d3828dc457d7da99c4 DIFF: https://github.com/llvm/llvm-project/commit/6d276595d1ce734a2269f6d3828dc457d7da99c4.diff LOG

[PATCH] D110798: [NFC] Use CHECK-NEXT instead of CHECK-SAME in target-invalid-cpu-note.c

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6d276595d1ce: [NFC] Use CHECK-NEXT instead of CHECK-SAME in target-invalid-cpu-note.c (authored by FreddyYe). Repository: rG LLVM Github Monorepo

[PATCH] D111352: [clang] Fix absolute file paths with -fdebug-prefix-map

probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. I suspect this is not the only way for directories and filenames to become confused, but it certainly helps. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

david-arm added a comment. Gentle ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110258/new/ https://reviews.llvm.org/D110258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D109652: [PowerPC] Restrict various P10 options to P10 only.

amyk added a comment. Ping @lei. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109652/new/ https://reviews.llvm.org/D109652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

mubashar_ updated this revision to Diff 378216. mubashar_ marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109825/new/ https://reviews.llvm.org/D109825 Files: llvm/include/llvm/Support/AArch64TargetParser.def llvm/

[PATCH] D102923: [clang][lex] Remark for used header search paths

jansvoboda11 updated this revision to Diff 378222. jansvoboda11 added a comment. Rebase, handle module maps, add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102923/new/ https://reviews.llvm.org/D102923 Files: clang/include/clang/Bas

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

xgupta added a comment. Where are the other patches? Or diff is not uploaded correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109825/new/ https://reviews.llvm.org/D109825 ___ cfe-commits mailing

[PATCH] D106191: [clang] Option control afn flag

masoud.ataei marked an inline comment as not done. masoud.ataei added inline comments. Comment at: clang/docs/UsersManual.rst:1393 + + Allow substitution of approximate calculations for functions. + Defaults to ``-fno-approx-func``. erichkeane wrote: > masoud

[PATCH] D111332: [AST Matchers] Update dump_ast_matchers.py to query only class index page.

jcking1034 updated this revision to Diff 378236. jcking1034 added a comment. Add docstring to `link_if_exists`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111332/new/ https://reviews.llvm.org/D111332 Files: clang/docs/LibASTMatchersReference.

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

mubashar_ added a comment. @xgupta those would be under the history tab. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109825/new/ https://reviews.llvm.org/D109825 ___ cfe-commits mailing list cfe-commit

[PATCH] D106191: [clang] Option control afn flag

erichkeane added inline comments. Comment at: clang/docs/UsersManual.rst:1393 + + Allow substitution of approximate calculations for functions. + Defaults to ``-fno-approx-func``. masoud.ataei wrote: > erichkeane wrote: > > masoud.ataei wrote: > > > erichkean

[PATCH] D102923: [clang][lex] Remark for used header search paths

jansvoboda11 added a comment. I believe I've addressed all suggestions provided so far. @dexonsmith & @Bigcheese, can you check again? Comment at: clang/test/Preprocessor/header-search-user-entries.c:9-11 +// CHECK: remark: user-provided search path used: '{{.*}}/header-searc

[PATCH] D102923: [clang][lex] Remark on search path usage

jansvoboda11 added inline comments. Comment at: clang/test/Preprocessor/header-search-user-entries.c:9-11 +// CHECK: remark: user-provided search path used: '{{.*}}/header-search-user-entries/a' +// CHECK: remark: user-provided search path used: '{{.*}}/header-search-user-entri

[PATCH] D111258: [PowerPC] Emit dcbt and dcbtst in place of their extended mnemonics on AIX

nemanjai accepted this revision. nemanjai added a comment. LGTM. This is already approved, but just wanted to indicate that I think the comments were addressed adequately. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111258/new/ https://reviews.llvm.org/D111258 __

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

xgupta added a comment. Yeah, those changes are in history, But we need them in the present to commit :) The patch is incorrectly updated, did you followed https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-command-line? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D106191: [clang] Option control afn flag

aaron.ballman added inline comments. Comment at: clang/docs/UsersManual.rst:1393 + + Allow substitution of approximate calculations for functions. + Defaults to ``-fno-approx-func``. erichkeane wrote: > masoud.ataei wrote: > > erichkeane wrote: > > > masoud.a

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

mubashar_ added a comment. @xgupta I followed the request review via web interface section of that page. Let me look into it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109825/new/ https://reviews.llvm.org/D109825 _

[PATCH] D109506: [clangd] Print current request context along with the stack trace

0x1eaf updated this revision to Diff 378257. 0x1eaf added a comment. Addressed feedback from the last round of comments. Sorry for the delay! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109506/new/ https://reviews.llvm.org/D109506 Files: clang

[PATCH] D108138: [WIP] Remove switch statements before vectorization

kmclaughlin abandoned this revision. kmclaughlin added a comment. I just wanted to give an update on this patch, which I'm abandoning for the time being: @lebedev.ri raised some good questions about the approach taken and whether the additional compile time spent would be worth the additional o

[PATCH] D109506: [clangd] Print current request context along with the stack trace

0x1eaf marked 9 inline comments as done. 0x1eaf added a comment. I've opted for simulating signals in the unit test on Windows by manually calling the signal handler, and added a list test to test the crash handling integration end-to-end. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D108138: [WIP] Remove switch statements before vectorization

lebedev.ri added a comment. :( I'm sorry for derailing this. I still think proper switch handling for loops would be nice. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108138/new/ https://reviews.llvm.org/D108138 ___ cfe-commits mailing list

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

tejohnson added a comment. This lgtm but I agree with @phosek 's suggestion to configure the file prefix and keep it as "Thin" for ThinLTO. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111371/new/ https://reviews.llvm.org/D111371 ___

[PATCH] D110641: Implement P0857R0 -Part B: requires clause for template-template params

cor3ntin added inline comments. Comment at: clang/test/CXX/temp/temp.arg/temp.arg.template/p3-2a.cpp:60-62 + // A naive individual might expect the following to all fail concept checking, + // but there does not seem to be any requirement to check these in the + // standard,

[PATCH] D111434: [PowerPC] PPC backend optimization on conditional trap intrustions

NeHuang created this revision. NeHuang added reviewers: nemanjai, stefanp, PowerPC. NeHuang added projects: LLVM, PowerPC. Herald added subscribers: shchenz, JDevlieghere, kbarton, hiraditya. NeHuang requested review of this revision. This patch adds PPC back end optimization to analyze the argume

[PATCH] D111336: [AIX] Disable tests failing due to missing DWARF sections

This revision was automatically updated to reflect the committed changes. Closed by commit rG8037481cb2d7: [AIX] Disable tests failing due to missing DWARF sections (authored by Jake-Egan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111336/new/ h

[clang] 8037481 - [AIX] Disable tests failing due to missing DWARF sections

Author: Jake Egan Date: 2021-10-08T12:06:38-04:00 New Revision: 8037481cb2d729ae3d782c3fed930f69d740fa23 URL: https://github.com/llvm/llvm-project/commit/8037481cb2d729ae3d782c3fed930f69d740fa23 DIFF: https://github.com/llvm/llvm-project/commit/8037481cb2d729ae3d782c3fed930f69d740fa23.diff LOG

[PATCH] D110641: Implement P0857R0 -Part B: requires clause for template-template params

cor3ntin added inline comments. Comment at: clang/test/CXX/temp/temp.arg/temp.arg.template/p3-2a.cpp:60-62 + // A naive individual might expect the following to all fail concept checking, + // but there does not seem to be any requirement to check these in the + // standard,

[PATCH] D110641: Implement P0857R0 -Part B: requires clause for template-template params

erichkeane added inline comments. Comment at: clang/test/CXX/temp/temp.arg/temp.arg.template/p3-2a.cpp:60-62 + // A naive individual might expect the following to all fail concept checking, + // but there does not seem to be any requirement to check these in the + // standard

[PATCH] D110641: Implement P0857R0 -Part B: requires clause for template-template params

cor3ntin added inline comments. Comment at: clang/test/CXX/temp/temp.arg/temp.arg.template/p3-2a.cpp:60-62 + // A naive individual might expect the following to all fail concept checking, + // but there does not seem to be any requirement to check these in the + // standard,

[PATCH] D111228: [clang-tidy] Add options to bugprone-unused-return-value.

balazske added a comment. Probably it can work to only have a "add" or "remove" possibility in the config string, and not using an option name like in the provided example. Otherwise it can be possible to mix string lists from different checks, that seems to be a difficult problem. Other soluti

[PATCH] D110641: Implement P0857R0 -Part B: requires clause for template-template params

erichkeane added inline comments. Comment at: clang/test/CXX/temp/temp.arg/temp.arg.template/p3-2a.cpp:60-62 + // A naive individual might expect the following to all fail concept checking, + // but there does not seem to be any requirement to check these in the + // standard

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 updated this revision to Diff 377922. gandhi21299 added a comment. refreshing patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109707/new/ https://reviews.llvm.org/D109707 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 updated this revision to Diff 378218. gandhi21299 added a comment. added -nogpulib and -nogpuinc flags to amdgpu-alias-undef-symbols.cu Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109707/new/ https://reviews.llvm.org/D109707 Files:

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109707/new/ https://reviews.llvm.org/D109707 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D106191: [clang] Option control afn flag

masoud.ataei updated this revision to Diff 378277. masoud.ataei added a comment. Update the documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106191/new/ https://reviews.llvm.org/D106191 Files: clang/docs/UsersManual.rst clang/inclu

[PATCH] D111332: [AST Matchers] Update dump_ast_matchers.py to query only class index page.

jcking1034 updated this revision to Diff 378279. jcking1034 added a comment. Rebase onto master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111332/new/ https://reviews.llvm.org/D111332 Files: clang/docs/LibASTMatchersReference.html clang/doc

[PATCH] D110823: [clangd] Add code completion of param name on /* inside function calls.

kadircet added a comment. thanks, mostly LG, a couple of nits :) Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1120 + OverloadCandidate Candidate = Candidates[I]; + if (auto *Func = Candidate.getFunction()) { +if (Func->getNumParams() <= CurrentArg) --

[PATCH] D111228: [clang-tidy] Add options to bugprone-unused-return-value.

aaron.ballman added a comment. In D111228#3051686 , @balazske wrote: > Probably it can work to only have a "add" or "remove" possibility in the > config string, and not using an option name like in the provided example. > Otherwise it can be possible to

[PATCH] D111440: [MS compat] Handle #pragma fenv_access like #pragma STDC FENV_ACCESS (PR50694)

hans created this revision. hans added reviewers: thakis, rsmith. Herald added a subscriber: dexonsmith. hans requested review of this revision. Herald added a project: clang. This adds support for the MSVC spelling of the pragma in -fms-extensions mode. Repository: rG LLVM Github Monorepo ht

[PATCH] D106191: [clang] Option control afn flag

erichkeane added a comment. 1 small 'english' question, hopefully Aaron can answer, otherwise LGTM. Comment at: clang/docs/UsersManual.rst:1395 + to be replaced with an approximately equivalent set of instructions + or alternative math function calls. For example, a ``pow(x

[PATCH] D111434: [PowerPC] PPC backend optimization on conditional trap intrustions

NeHuang updated this revision to Diff 378284. NeHuang added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111434/new/ https://reviews.llvm.org/D111434 Files: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp llvm/test/CodeGen/P

[PATCH] D106191: [clang] Option control afn flag

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/docs/UsersManual.rst:1395 + to be replaced with an approximately equivalent set of instructions + or alternative math function calls.

[PATCH] D102488: [clang][deps] Prune unused header search paths

jansvoboda11 updated this revision to Diff 378285. jansvoboda11 added a comment. Rebase, switch from `std::vector` to `llvm::BitVector`, load the bit vector eagerly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102488/new/ https://reviews.llvm.or

  1   2   3   >