sammccall accepted this revision. sammccall added a comment. Nice!
================ Comment at: clang/docs/tools/dump_ast_matchers.py:48 text = re.sub(r'>', '>', text) def link_if_exists(m): name = m.group(1) ---------------- While here I'd add a comment: ``` """ Wrap a likely AST node name in a link to its clang docs. We want to do this only if the page exists, in which case it will be referenced from the class index page. """ ``` (You're only adding a bit of conceptual complexity here, but it looks like it's been built up over time...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111332/new/ https://reviews.llvm.org/D111332 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits