[PATCH] D108286: [clang][Driver][Linux] fix regression issue when define LIBCXX_LIBDIR_SUFFIX=64

sunlin added a comment. Thanks all of you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108286/new/ https://reviews.llvm.org/D108286 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang] ad59735 - Fix __has_unique_object_representations with no_unique_address

Author: Gabor Bencze Date: 2021-08-26T09:23:37+02:00 New Revision: ad59735f9d150ebd10d4752a4468795c39f02c5d URL: https://github.com/llvm/llvm-project/commit/ad59735f9d150ebd10d4752a4468795c39f02c5d DIFF: https://github.com/llvm/llvm-project/commit/ad59735f9d150ebd10d4752a4468795c39f02c5d.diff

[clang-tools-extra] 3373e84 - [clang-tidy] Add bugprone-suspicious-memory-comparison check

Author: Gabor Bencze Date: 2021-08-26T09:23:37+02:00 New Revision: 3373e845398bfb8fa0e3c81b7ca84cbfedbad3ae URL: https://github.com/llvm/llvm-project/commit/3373e845398bfb8fa0e3c81b7ca84cbfedbad3ae DIFF: https://github.com/llvm/llvm-project/commit/3373e845398bfb8fa0e3c81b7ca84cbfedbad3ae.diff

[PATCH] D89649: Fix __has_unique_object_representations with no_unique_address

This revision was automatically updated to reflect the committed changes. Closed by commit rGad59735f9d15: Fix __has_unique_object_representations with no_unique_address (authored by gbencze, committed by steakhal). Changed prior to commit: https://reviews.llvm.org/D89649?vs=303082&id=368823#to

[PATCH] D89651: [clang-tidy] Add bugprone-suspicious-memory-comparison check

This revision was automatically updated to reflect the committed changes. Closed by commit rG3373e845398b: [clang-tidy] Add bugprone-suspicious-memory-comparison check (authored by gbencze, committed by steakhal). Changed prior to commit: https://reviews.llvm.org/D89651?vs=306679&id=368824#toc

[PATCH] D108742: Reclassify form-feed and vertical tab as vertical WS for the purposes of lexing.

cor3ntin updated this revision to Diff 368826. cor3ntin added a comment. Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108742/new/ https://reviews.llvm.org/D108742 Files: clang/lib/Basic/CharInfo.cpp clang/unittests/Basic/CharInfoTes

[libunwind] 21b25a1 - [libunwind] Support stack unwind in CET environment

Author: gejin Date: 2021-08-26T16:20:38+08:00 New Revision: 21b25a1fb32ecd2e1f336123c2715f8ef1a49f97 URL: https://github.com/llvm/llvm-project/commit/21b25a1fb32ecd2e1f336123c2715f8ef1a49f97 DIFF: https://github.com/llvm/llvm-project/commit/21b25a1fb32ecd2e1f336123c2715f8ef1a49f97.diff LOG: [l

[PATCH] D108367: [NFC] computeSPIRKernelABIInfo(): use SPIRABInfo

pekka.jaaskelainen added a comment. @Anastasia I used to have svn commit access, but haven't committed anything for a long while in LLVM, so don't know if I can get them back to github by just asking. So, can you please commit these HIPSPV patches for us? Repository: rG LLVM Github Monorepo

[PATCH] D108752: [clang-format] Group options that pack constructor initializers

owenpan created this revision. owenpan added reviewers: djasper, klimek, krasimir, MyDeveloperDay, curdeius, HazardyKnusperkeks. owenpan added a project: clang-format. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a new optio

[clang] bf66b0e - Fix LLVM_ENABLE_THREADS check from 26a92d5852b2c6bf77efd26f6c0194c913f40285

Author: Alex Richardson Date: 2021-08-26T10:09:39+01:00 New Revision: bf66b0eefcda20170eeb574670121159fcd755fa URL: https://github.com/llvm/llvm-project/commit/bf66b0eefcda20170eeb574670121159fcd755fa DIFF: https://github.com/llvm/llvm-project/commit/bf66b0eefcda20170eeb574670121159fcd755fa.dif

[clang] 7cab90a - Fix __attribute__((annotate("")) with non-zero globals AS

Author: Alex Richardson Date: 2021-08-26T10:09:40+01:00 New Revision: 7cab90a7b1c47780bbf7cfbfda4a1cbab24f0e5b URL: https://github.com/llvm/llvm-project/commit/7cab90a7b1c47780bbf7cfbfda4a1cbab24f0e5b DIFF: https://github.com/llvm/llvm-project/commit/7cab90a7b1c47780bbf7cfbfda4a1cbab24f0e5b.dif

[PATCH] D108110: Fix LLVM_ENABLE_THREADS check from 26a92d5852b2c6bf77efd26f6c0194c913f40285

This revision was automatically updated to reflect the committed changes. Closed by commit rGbf66b0eefcda: Fix LLVM_ENABLE_THREADS check from 26a92d5852b2c6bf77efd26f6c0194c913f40285 (authored by arichardson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D105972: Fix __attribute__((annotate("")) with non-zero globals AS

This revision was automatically updated to reflect the committed changes. Closed by commit rG7cab90a7b1c4: Fix __attribute__((annotate("")) with non-zero globals AS (authored by arichardson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105972/new/

[libunwind] 5ece556 - [libunwind] Don't include cet.h/immintrin.h unconditionally

Author: Benjamin Kramer Date: 2021-08-26T11:37:07+02:00 New Revision: 5ece5562719dde1d8e88fdb41ec5ac0cf6f05274 URL: https://github.com/llvm/llvm-project/commit/5ece5562719dde1d8e88fdb41ec5ac0cf6f05274 DIFF: https://github.com/llvm/llvm-project/commit/5ece5562719dde1d8e88fdb41ec5ac0cf6f05274.dif

[PATCH] D108753: [analyzer] MallocChecker: Add notes from NoOwnershipChangeVisitor only when a function "intents", but doesn't change ownership, enable by default

Szelethus created this revision. Szelethus added reviewers: NoQ, martong, steakhal, balazske, ASDenysPetrov, vsavchenko. Szelethus added a project: clang. Herald added subscribers: manas, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun,

[clang] 564d85e - The maximal representable alignment in LLVM IR is 1GiB, not 512MiB

Author: Roman Lebedev Date: 2021-08-26T12:53:39+03:00 New Revision: 564d85e090afdaac6475d43708d77a7fa0cf5301 URL: https://github.com/llvm/llvm-project/commit/564d85e090afdaac6475d43708d77a7fa0cf5301 DIFF: https://github.com/llvm/llvm-project/commit/564d85e090afdaac6475d43708d77a7fa0cf5301.diff

[PATCH] D108661: The maximal representable alignment in LLVM IR is 1GiB, not 512MiB

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG564d85e090af: The maximal representable alignment in LLVM IR is 1GiB, not 512MiB (authored by lebedev.ri). Changed prior

[PATCH] D106191: [clang] Option control afn flag

qiucf added a comment. Making a new option mapped to another float op flag looks reasonable, but is there any clearer motivation for this? (such as the need for `-Ofast -fno-approx-func`) Comment at: llvm/include/llvm/Target/TargetOptions.h:179 +/// with approximate calcu

[PATCH] D107078: [analyzer] Catch leaking stack addresses via stack variables

steakhal marked an inline comment as done. steakhal added a comment. I plan to commit to this tomorrow. @NoQ @martong CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107078/new/ https://reviews.llvm.org/D107078 ___ cfe-commits mailing list cfe-

[PATCH] D107078: [analyzer] Catch leaking stack addresses via stack variables

steakhal added a comment. Oh wait, it's not yet accepted by @NoQ. Then, consider this as a polite ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107078/new/ https://reviews.llvm.org/D107078 ___ cfe-commits mailing list cfe-commits@lists.

[clang] de15979 - Assert pointer cannot be null; NFC

Author: Sindhu Chittireddy Date: 2021-08-26T06:58:56-04:00 New Revision: de15979bc32d761c9b5071fb7d28d7c04ebbfaf3 URL: https://github.com/llvm/llvm-project/commit/de15979bc32d761c9b5071fb7d28d7c04ebbfaf3 DIFF: https://github.com/llvm/llvm-project/commit/de15979bc32d761c9b5071fb7d28d7c04ebbfaf3.

[PATCH] D108756: [clang] Add '-ast-dump-filter=' support

oToToT created this revision. oToToT added reviewers: rsmith, alexfh. oToToT added a project: clang. Herald added a subscriber: dang. oToToT requested review of this revision. Herald added a subscriber: cfe-commits. Before this patch, we only support syntax like `clang -cc1 -ast-dump -ast-dump-fil

[PATCH] D108712: Avoid nullptr dereferencing of 'SubExpr'; NFC

aaron.ballman closed this revision. aaron.ballman added a comment. I've committed on your behalf in de15979bc32d761c9b5071fb7d28d7c04ebbfaf3 , thank you for the improvement! Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D107873: [clang-tidy] Add 'performance-const-parameter-value-or-ref' for checking const-qualified parameters

jmarrec added a comment. Imported some discussion from https://reviews.llvm.org/D107900#inline-1029358. Sorry it took that long Comment at: clang-tools-extra/clang-tidy/performance/ConstParameterValueOrRef.h:40 + static constexpr int DefaultSmallMaxSize = 16; + int SmallMax

[PATCH] D108761: [OpenCL] Remove decls for scalar vloada_half and vstorea_half* fns

stuart created this revision. stuart added reviewers: svenvh, Anastasia, airlied, yaxunl. Herald added a subscriber: ldrumm. stuart requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These functions are not part of the OpenCL C specification.

[PATCH] D108752: [clang-format] Group options that pack constructor initializers

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. This looks good, I like to move towards one style, it was getting too confusing. Did you test this on a large code base at all? and maybe wait for one of the others to take a l

[PATCH] D108618: [CGCall] Add NoInline attr if presented for the target

djtodoro added a comment. In D108618#2964265 , @rjmccall wrote: > Why do you want to add `noinline` to a function declaration that lacks a > definition? If this won't be used at all I guess the compiler should throw a warning at least. One example come

[clang] 6097a41 - [analyzer] Extend the documentation of MallocOverflow

Author: Balazs Benics Date: 2021-08-26T15:20:41+02:00 New Revision: 6097a41924584b613153237d8e66e9660001ce7d URL: https://github.com/llvm/llvm-project/commit/6097a41924584b613153237d8e66e9660001ce7d DIFF: https://github.com/llvm/llvm-project/commit/6097a41924584b613153237d8e66e9660001ce7d.diff

[PATCH] D107756: [analyzer] Extend the documentation of MallocOverflow

This revision was automatically updated to reflect the committed changes. Closed by commit rG6097a4192458: [analyzer] Extend the documentation of MallocOverflow (authored by steakhal). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CH

[clang] 379b639 - Revert "[analyzer] Extend the documentation of MallocOverflow"

Author: Balazs Benics Date: 2021-08-26T15:29:32+02:00 New Revision: 379b6394d9ca254593b77ec3c0028e6d820715e4 URL: https://github.com/llvm/llvm-project/commit/379b6394d9ca254593b77ec3c0028e6d820715e4 DIFF: https://github.com/llvm/llvm-project/commit/379b6394d9ca254593b77ec3c0028e6d820715e4.diff

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

haonanya added a comment. Hi, svenvh. Should we use cl_khr_int64_base_atomics and cl_khr_int64_extended_atomics to guard the functions using atomic_double type? Thanks very much. #if defined(__opencl_c_ext_fp64_local_atomic_min_max) double __ovld atomic_fetch_min(volatile __local atomic_dou

[PATCH] D108138: [SimplifyCFG] Remove switch statements before vectorization

kmclaughlin added a comment. Thanks all for the suggestions on this patch :) I had a look at the LowerSwitch pass as suggested by @junparser, and I did find that running it before vectorisation transforms the switch and allows the same loops to be vectorised. However, I did find that if the loo

[PATCH] D108138: [SimplifyCFG] Remove switch statements before vectorization

lebedev.ri added a comment. IMO anything other than enhancing LV is wrong. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108138/new/ https://reviews.llvm.org/D108138 ___ cfe-commits mailing list cfe-comm

[PATCH] D107756: [analyzer] Extend the documentation of MallocOverflow

steakhal added a comment. I'm not exactly sure what does the sphinx build bot complain about: Warning, treated as error: /home/buildbot/llvm-build-dir/clang-sphinx-docs/llvm/build/tools/clang/docs/analyzer/checkers.rst:2159:Unexpected indentation. Unfortunately, I could not (yet) set up sp

[PATCH] D108138: [SimplifyCFG] Remove switch statements before vectorization

david-arm added a comment. In D108138#2967100 , @lebedev.ri wrote: > IMO anything other than enhancing LV is wrong. Hi @lebedev.ri I personally disagree here. Adding support to LV for this is significantly more work (and IMO unnecessary) because there

[PATCH] D108138: [SimplifyCFG] Remove switch statements before vectorization

lebedev.ri added a comment. How is it conceptually different to break apart IR in LV itself, or do the same in a special pass just before that? If we want to go this road, we need to completely make `switch`es illegal/non-canonical before LV. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

dgoldman added a comment. > I put a case for it in the declprinter so it is handled appropriately so it > would get the pointee type, whereas before this was neglected. > > Other than that, there should be no difference. It looks like DeclPrinter only uses that method here

[PATCH] D108138: [SimplifyCFG] Remove switch statements before vectorization

david-arm added a comment. In D108138#2967133 , @lebedev.ri wrote: > How is it conceptually different to break apart IR in LV itself, or do the > same in a special pass just before that? > If we want to go this road, we need to completely make `switch`e

[PATCH] D108138: [SimplifyCFG] Remove switch statements before vectorization

lebedev.ri added a comment. In D108138#2967156 , @david-arm wrote: > In D108138#2967133 , @lebedev.ri > wrote: > >> How is it conceptually different to break apart IR in LV itself, or do the >> same in a special

[PATCH] D105269: [X86] AVX512FP16 instructions enabling 6/6

LuoYuanke added inline comments. Comment at: clang/test/CodeGen/X86/avx512fp16-builtins.c:4223 + +// CFC ADD PH + MADD? Comment at: clang/test/CodeGen/X86/avx512fp16-builtins.c:4315 + +// CF ADD PH + MADD? Co

[PATCH] D106191: [clang] Option control afn flag

masoud.ataei added a comment. In D106191#2966852 , @qiucf wrote: > Making a new option mapped to another float op flag looks reasonable, but is > there any clearer motivation for this? (such as the need for `-Ofast > -fno-approx-func`) This patch https

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

FederAndInk created this revision. FederAndInk requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix little inconsistency and use `std::string` (which is used everywhere else) instead of `string` Repository: rG LLVM Github Monorepo https

[PATCH] D108138: [SimplifyCFG] Remove switch statements before vectorization

xbolva00 added a comment. >> I could try to change LowerSwitch to create branches which SimplifyCFG will >> be able to recognise and replace with a switch, or try to change SimplifyCFG >> to recognise this pattern of compares & branches. 2. option is better. Repository: rG LLVM Github Mon

[PATCH] D101759: [PowerPC] Scalar IBM MASS library conversion pass

lebedev.ri added a comment. Do we *really* need `-enable-approx-func-fp-math`? I'm pretty sure we are moving away from such global options, onto relying only on the per-instruction fast-math flags. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1017

[PATCH] D108138: [SimplifyCFG] Remove switch statements before vectorization

xbolva00 added a comment. >> I had a look at the LowerSwitch pass as suggested by @junparser, and I did >> find that running it before vectorisation transforms the switch and allows >> the same loops to be vectorised. However, I did find that if the loop is not >> vectorised then the switch is

[PATCH] D107900: [clang-tidy] Add a new clang-tidy check for trivially copyable types passed by const reference

jmarrec updated this revision to Diff 368881. jmarrec added a comment. documentation updates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107900/new/ https://reviews.llvm.org/D107900 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt cla

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. Thank you for your submission, but... 1. This is not the way to change this file, its autogenerated from clang/include/Format/Format.h using clang/docs/tools/dump_fo

[PATCH] D107764: [OpenMP][OpenMPIRBuilder] Implement loop unrolling.

kiranchandramohan added a comment. I have a few minor questions. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:2055 +/// Attach loop metadata \p Properties to the loop described by \p Loop. If the +/// loop already has metadata, the loop properties are appended. +static

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

bader added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:59 +// translation). This mapping is enabled when the language mode is HIP. +1, // cuda_device +// cuda_constant pointer can be casted to default/"flat" pointer, but in Anastasia

[PATCH] D105269: [X86] AVX512FP16 instructions enabling 6/6

pengfei added inline comments. Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:3902 + case X86::VFCMADDCSHZr: + case X86::VFCMADDCSHZrb: + case X86::VFCMADDCSHZrbk: LuoYuanke wrote: > "b" means rounding. Right? broadcasting Commen

[PATCH] D105269: [X86] AVX512FP16 instructions enabling 6/6

pengfei added inline comments. Comment at: llvm/lib/Target/X86/X86InstrFoldTables.cpp:1852 + { X86::VFCMULCPHZrr, X86::VFCMULCPHZrm, 0 }, + { X86::VFCMULCSHZrr, X86::VFCMULCSHZrm, TB_NO_REVERSE }, { X86::VFMADDPD4Yrr,

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables by removing the enum FixIt, and add support for initialization check of scoped enum.

whisperity added a comment. @Sockke Sorry to circle back here, but it seems to me that Clang now has a flag `-Wuninitialized`. Could you check how it behaves, compared to this check? If there are overlaps, what should we do, @aaron.ballman? Should parts of the check be deprecated? Repository:

[PATCH] D101759: [PowerPC] Scalar IBM MASS library conversion pass

masoud.ataei marked an inline comment as done. masoud.ataei added a comment. In D101759#2967250 , @lebedev.ri wrote: > Do we *really* need `-enable-approx-func-fp-math`? > I'm pretty sure we are moving away from such global options, onto relying > only

[PATCH] D106618: [Clang][LLVM] generate btf_tag annotations for DISubprogram types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd383df32c0d5: [DebugInfo] generate btf_tag annotations for DISubprogram types (authored by yonghong-song). Changed prior to commit: https://review

[PATCH] D101759: [PowerPC] Scalar IBM MASS library conversion pass

lebedev.ri added a reviewer: spatel. lebedev.ri added a comment. In D101759#2967331 , @masoud.ataei wrote: > In D101759#2967250 , @lebedev.ri > wrote: > >> Do we *really* need `-enable-approx-func-fp-math`? >> I

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

FederAndInk added a comment. Thank you for your explanations, I understand now. But as I look into `clang/docs/tools/dump_format_style.py` I see that it does not entirely generate `clang/docs/ClangFormatStyleOptions.rst` it replaces the lines between `{START,END}_FORMAT_STYLE_OPTIONS` I unders

[PATCH] D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins

lei added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15833 + // without the need for the programmer to swap operands. + if (IsLE) { +SmallVector RevOps; doesn't look like we need the interm var `IsLE`. Just use the call directl

[PATCH] D108302: [PowerPC] Fixed the crash due to early if conversion with fixed CR fields.

amyk added a comment. Please update the patch with full context. Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.cpp:1546 + // into a select. + if (Register::isPhysicalRegister(Cond[1].getReg())) { +return false; nit: `uses a physical register` ===

[clang] 2de051b - [DebugInfo] convert btf_tag attrs to DI annotations for DISubprograms

Author: Yonghong Song Date: 2021-08-26T08:54:11-07:00 New Revision: 2de051ba124d92de953ac2420668407f458bcec6 URL: https://github.com/llvm/llvm-project/commit/2de051ba124d92de953ac2420668407f458bcec6 DIFF: https://github.com/llvm/llvm-project/commit/2de051ba124d92de953ac2420668407f458bcec6.diff

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

kstoimenov updated this revision to Diff 368903. kstoimenov added a comment. Added a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377 Files: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp

[PATCH] D108481: Avoid nullptr dereferencing of 'Constraint'

mlychkov added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:1065-1068 assert(TC && "TPL must have a template type parameter with a type constraint"); auto *Constraint = + cast(TC->getImmediatelyDeclaredConstraint()); aaron.ball

[clang] af79f1b - [analyzer] Extend the documentation of MallocOverflow

Author: Balazs Benics Date: 2021-08-26T18:15:10+02:00 New Revision: af79f1bff90bee957ec9f963b68226e0b33eb169 URL: https://github.com/llvm/llvm-project/commit/af79f1bff90bee957ec9f963b68226e0b33eb169 DIFF: https://github.com/llvm/llvm-project/commit/af79f1bff90bee957ec9f963b68226e0b33eb169.diff

[PATCH] D104285: [analyzer][AST] Retrieve value by direct index from list initialization of constant array declaration.

ASDenysPetrov updated this revision to Diff 368905. ASDenysPetrov edited the summary of this revision. ASDenysPetrov added a comment. Reworked the patch according to the discussion and taking UB into account. Moved `Expr::getExprForConstArrayByRawIndex` to `RegionStoreManager`. CHANGES SINCE LA

[PATCH] D101960: [openmp] Drop requirement on library path environment variables

JonChesterfield added a comment. Test setup can be fixed independently (and possibly should be). D102043 is newly simplified. It looks for plugins next to libomptarget.so, which means it can find them even when the application uses a non-transitive method to f

[PATCH] D108481: Avoid nullptr dereferencing of 'Constraint'

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:1065-1068 assert(TC && "TPL must have a template type parameter with a type constraint"); auto *Constraint = + cast(TC->getImmediatelyDeclaredConstraint()); mlych

[PATCH] D108481: Avoid nullptr dereferencing of 'Constraint'

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:1065-1068 assert(TC && "TPL must have a template type parameter with a type constraint"); auto *Constraint = + cast(TC->getImmediatelyDeclaredConstraint()); aaron.ba

[PATCH] D107756: [analyzer] Extend the documentation of MallocOverflow

steakhal added inline comments. Comment at: clang/docs/analyzer/checkers.rst:2159-2160 +It tries to catch ``malloc(n * c)`` patterns, where: + - ``n``: a variable or member access of an object + - ``c``: a constant foldable integral + steakhal wrote: > Am I suppo

[PATCH] D108624: [Clang][RISCV] Implement getConstraintRegister for RISC-V

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. Looks good to me - I'm surprised only Arm, AArch64, and X86 implement this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108624/new/ https://reviews.

[clang] 34e055d - [Clang][RISCV] Implement getConstraintRegister for RISC-V

Author: Luís Marques Date: 2021-08-26T17:43:43+01:00 New Revision: 34e055d33e37cd87b9f6f4b0431a4c061628d036 URL: https://github.com/llvm/llvm-project/commit/34e055d33e37cd87b9f6f4b0431a4c061628d036 DIFF: https://github.com/llvm/llvm-project/commit/34e055d33e37cd87b9f6f4b0431a4c061628d036.diff

[PATCH] D108624: [Clang][RISCV] Implement getConstraintRegister for RISC-V

This revision was automatically updated to reflect the committed changes. Closed by commit rG34e055d33e37: [Clang][RISCV] Implement getConstraintRegister for RISC-V (authored by luismarques). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108624/new/

[clang] 0cf4f81 - Adding an assertion back.

Author: Aaron Ballman Date: 2021-08-26T12:51:14-04:00 New Revision: 0cf4f81082e9fa052e60450b8cbb10007e59931c URL: https://github.com/llvm/llvm-project/commit/0cf4f81082e9fa052e60450b8cbb10007e59931c DIFF: https://github.com/llvm/llvm-project/commit/0cf4f81082e9fa052e60450b8cbb10007e59931c.diff

[PATCH] D108481: Avoid nullptr dereferencing of 'Constraint'

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:1065-1068 assert(TC && "TPL must have a template type parameter with a type constraint"); auto *Constraint = + cast(TC->getImmediatelyDeclaredConstraint()); erich

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

MyDeveloperDay added subscribers: HazardyKnusperkeks, owenpan, krasimir, sammccall, curdeius, klimek. MyDeveloperDay added a comment. In D108765#2967363 , @FederAndInk wrote: > Thank you for your explanations, I understand now. > > But as I look into `c

[clang] a233f03 - Typo fix; NFC

Author: Aaron Ballman Date: 2021-08-26T12:53:52-04:00 New Revision: a233f0350d4790227f138e2118c0d18c2b45f855 URL: https://github.com/llvm/llvm-project/commit/a233f0350d4790227f138e2118c0d18c2b45f855 DIFF: https://github.com/llvm/llvm-project/commit/a233f0350d4790227f138e2118c0d18c2b45f855.diff

[PATCH] D108742: Reclassify form-feed and vertical tab as vertical WS for the purposes of lexing.

dexonsmith added a comment. Thanks for looking at this — I'm just reviewing the test changes in the minimizer (assuming the code change is the right thing to do). Comment at: clang/unittests/Lex/DependencyDirectivesSourceMinimizerTest.cpp:170-173 ASSERT_FALSE( - minim

[PATCH] D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

NoQ added a comment. Would this work correctly when the property is changed but then reverted to its original state? This probably can't happen to MallocChecker (what has been freed cannot be unfreed) but it may happen to eg. PthreadLockChecker or to, well, Stores. In such cases it would be inc

[PATCH] D105167: [analyzer] Fix HTML report deduplication.

NoQ updated this revision to Diff 368917. NoQ marked 4 inline comments as done. NoQ added a comment. Address review comments! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105167/new/ https://reviews.llvm.org/D105167 Files: clang/include/clang/Analysis/PathDiagnostic.h clang/includ

[PATCH] D105167: [analyzer] Fix HTML report deduplication.

NoQ added a comment. In D105167#2949521 , @ASDenysPetrov wrote: > Nice work! Unfortunately I'm not able to run tests on my Windows env, but > I've run you tests files manually. It works for me. > > P.S. BTW, is there any workarounds to make current test

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

weiwang added a comment. In D70172#2964118 , @sugak wrote: > Hi @yaxunl! I'm working on upgrading a large codebase from LLVM-9 to LLVM-12. > I noticed on average 10% compilation speed regression that seems to be caused > this change. We use Clang modules

[PATCH] D107769: [OpenCL] Make generic addrspace optional for -fdeclare-opencl-builtins

Anastasia added a comment. In D107769#2960441 , @svenvh wrote: > I have done an alternative spin of this patch: instead of introducing > `RequireDisabledExtension`, simply always make the `private`, `global`, and > `local` overloads available. This mak

[PATCH] D106619: [Clang][LLVM] generate btf_tag annotations for DIGlobalVariable

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG30c288489ae5: [DebugInfo] generate btf_tag annotations for DIGlobalVariable (authored by yonghong-song). Changed prior to commit: https://reviews.

[PATCH] D108704: [OpenCL] Define OpenCL 3.0 optional core features in C++ for OpenCL 2021

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108704/new/ https://reviews.llvm.org/D108704 _

[PATCH] D108693: [OpenCL] Defines helper function for kernel language compatible OpenCL version

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! This is a very nice clean up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108693/new/ https://reviews.llvm.org/D108693 _

[PATCH] D108243: Revert "Avoid needlessly copying a block to the heap when a block literal"

jyknight added a comment. Ping. Any comment from Apple folks? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108243/new/ https://reviews.llvm.org/D108243 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D102449: [WIP][Clang][OpenMP] Add the support for compare clause in atomic directive

carlo.bertolli added a comment. Thanks for uploading this. I tried it locally and it is missing proper parsing +sema of the cond-expr-stmt and cond-update-stmt as indicate in the openmp 5.1 spec's. I am sure you are aware of this and this is still WIP. Do you plan to add support for that? The r

[clang] d2d7a90 - [DebugInfo] convert btf_tag attrs to DI annotations for DIGlobalVariable

Author: Yonghong Song Date: 2021-08-26T10:36:33-07:00 New Revision: d2d7a90ceded94251905b7adcd5eb2ac5191896f URL: https://github.com/llvm/llvm-project/commit/d2d7a90ceded94251905b7adcd5eb2ac5191896f DIFF: https://github.com/llvm/llvm-project/commit/d2d7a90ceded94251905b7adcd5eb2ac5191896f.diff

[PATCH] D108774: [OpenMP][FIX] Allow declare variant to work with reference types

jdoerfert created this revision. jdoerfert added reviewers: JonChesterfield, ABataev, pdhaliwal, aaron.ballman. Herald added subscribers: guansong, bollu, yaxunl. jdoerfert requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Reference types in the

[PATCH] D108774: [OpenMP][FIX] Allow declare variant to work with reference types

jdoerfert updated this revision to Diff 368940. jdoerfert added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108774/new/ https://reviews.llvm.org/D108774 Files: clang/lib/AST/ASTContext.cpp clang/test/AST/ast-dump-openmp-b

[PATCH] D108775: [CMake] Change -DENABLE_EXPERIMENTAL_NEW_PASS_MANAGER=off to -DLLVM_ENABLE_NEW_PASS_MANAGER=off

MaskRay created this revision. MaskRay added reviewers: aeubanks, phosek, tstellar. Herald added a subscriber: mgorny. MaskRay requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. LLVM_ENABLE_NEW_PASS_MANAGER is set to ENABLE_E

[PATCH] D108774: [OpenMP][FIX] Allow declare variant to work with reference types

jdoerfert updated this revision to Diff 368943. jdoerfert added a comment. Clang format patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108774/new/ https://reviews.llvm.org/D108774 Files: clang/lib/AST/ASTContext.cpp clang/test/AST/ast-dum

[PATCH] D108775: [CMake] Change -DENABLE_EXPERIMENTAL_NEW_PASS_MANAGER=off to -DLLVM_ENABLE_NEW_PASS_MANAGER=off

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. this is good, but IMO it's not clear enough in the description that this is a breaking change in terms of CMake flags (use -DLLVM_ENABLE_NEW_PASS_MANAGER instead of -DEXPERIMENTAL_NEW_PASS

[PATCH] D108742: Reclassify form-feed and vertical tab as vertical WS for the purposes of lexing.

cor3ntin added inline comments. Comment at: clang/unittests/Lex/DependencyDirectivesSourceMinimizerTest.cpp:170-173 ASSERT_FALSE( - minimizeSourceToDependencyDirectives("#define MACRO(a\\\n" + minimizeSourceToDependencyDirectives("#define MACRO(a \\\

[PATCH] D108752: [clang-format] Group options that pack constructor initializers

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:18472 + FormatStyle::PCIS_Never); + Style.EmptyLineBeforeAccessModifier = FormatStyle::ELBAMS_LogicalBlock; Shou

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. As the one who wrote that: 1. Yes that part is not auto generated, because it is not in the `format.h`. 2. I'm more in favor of removing the `std::` from the documentation. 3. It is for the YAML documentati

[PATCH] D108742: Reclassify form-feed and vertical tab as vertical WS for the purposes of lexing.

cor3ntin updated this revision to Diff 368958. cor3ntin added a comment. - Add tests and fix existing tests (again) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108742/new/ https://reviews.llvm.org/D108742 Files: clang/lib/Basic/CharInfo.cpp

[PATCH] D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

Szelethus added a comment. In D108695#2967540 , @NoQ wrote: > Would this work correctly when the property is changed but then reverted to > its original state? This probably can't happen to MallocChecker (what has > been freed cannot be unfreed) but it

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1890 -if (auto FD = dyn_cast(D)) - return CGM.GetAddrOfFunction(FD); +if (auto FD = dyn_cast(D)) { + auto *C = CGM.GetAddrOfFunction(FD); fix linter warnin

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

kstoimenov updated this revision to Diff 368959. kstoimenov added a comment. Fixed the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377 Files: llvm/lib/Transforms/Instrumentation/AddressSanitizer.c

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

ricejasonf updated this revision to Diff 368962. ricejasonf added a comment. I moved the test to CodeGenCXX and actually test output with FileCheck. I used the code from a non-template function as the expected output. Some minor formatting changes are also addressed. Repository: rG LLVM Gith

[PATCH] D108774: [OpenMP][FIX] Allow declare variant to work with reference types

ABataev added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:9691 // the expression is a function call (possibly inside parentheses). + if (LHS->getAs() && RHS->getAs()) +return mergeTypes(LHS->getAs()->getPointeeType(), Does it matter if it is

  1   2   >