NoQ added a comment.

Would this work correctly when the property is changed but then reverted to its 
original state? This probably can't happen to MallocChecker (what has been 
freed cannot be unfreed) but it may happen to eg. PthreadLockChecker or to, 
well, Stores. In such cases it would be incorrect to say "returning without 
changing the state".



================
Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:370
+  while (N && !N->getLocationAs<CallExitEnd>())
+    N = N->getFirstSucc();
+  return N;
----------------
This is the right successor because we're in a heavily trimmed exploded graph, 
right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108695/new/

https://reviews.llvm.org/D108695

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to