[PATCH] D108265: .clang-tidy: Push variable related readability-identifier-naming options down to projects

mehdi_amini added a comment. +1 on arguments from @dblaikie : I'm not sure I understand the motivation for this change right now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108265/new/ https://reviews.llvm.org/D108265 _

[PATCH] D105426: [clangd] IncludeCleaner as a library: Find all references to symbols in the file

kbobyrev updated this revision to Diff 367138. kbobyrev marked an inline comment as done. kbobyrev added a comment. Remove unused code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105426/new/ https://reviews.llvm.org/D105426 Files: clang-tools

[clang-tools-extra] d1ec581 - [clangd] IncludeCleaner as a library: Find all references to symbols in the file

Author: Kirill Bobyrev Date: 2021-08-18T10:08:35+02:00 New Revision: d1ec581ebfca9bd455ae1a467b2d4b52fc59092b URL: https://github.com/llvm/llvm-project/commit/d1ec581ebfca9bd455ae1a467b2d4b52fc59092b DIFF: https://github.com/llvm/llvm-project/commit/d1ec581ebfca9bd455ae1a467b2d4b52fc59092b.diff

[PATCH] D105426: [clangd] IncludeCleaner as a library: Find all references to symbols in the file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1ec581ebfca: [clangd] IncludeCleaner as a library: Find all references to symbols in the file (authored by kbobyrev). Repository: rG LLVM Github

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 367140. kbobyrev added a comment. Rebase on top of main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: clang-tools-extra/clangd/Headers.cpp clang-tools-

[PATCH] D107963: [OpenCL] Fix as_type(vec3) invalid store creation

svenvh added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:4789 - -if (!CGF.CGM.getCodeGenOpts().PreserveVec3Type) { - Src = createCastsForTypeOfSameSize(Builder, CGF.CGM.getDataLayout(), Src, jaykang10 wrote: > svenvh wrote: > > jaykan

[clang] 0d0628b - [OpenCL] C++ for OpenCL version 2021 introduced to command line.

Author: Justas Janickas Date: 2021-08-18T10:08:59+01:00 New Revision: 0d0628b2d213a43f80e4967d83b905c6d2211651 URL: https://github.com/llvm/llvm-project/commit/0d0628b2d213a43f80e4967d83b905c6d2211651 DIFF: https://github.com/llvm/llvm-project/commit/0d0628b2d213a43f80e4967d83b905c6d2211651.dif

[PATCH] D108038: [C++4OpenCL] C++ for OpenCL version 2021 introduced to command line

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0d0628b2d213: [OpenCL] C++ for OpenCL version 2021 introduced to command line. (authored by Topotuna). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D108235: [CUDA] Bump default GPU architecture to sm_35.

Hahnfeld accepted this revision. Hahnfeld added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108235/new/ https://reviews.llvm.org/D108235 ___

[PATCH] D108247: [CUDA] Improve CUDA version detection and diagnostics.

Hahnfeld added inline comments. Comment at: clang/test/Driver/cuda-version-check.cu:75 -// UNKNOWN_VERSION_V: unknown CUDA version: version.txt:{{.*}}; assuming the latest supported version -// UNKNOWN_VERSION_H: unknown CUDA version: cuda.h: CUDA_VERSION={{.*}}; assuming the

[PATCH] D108248: [CUDA] Bump the latest supported CUDA version to 11.4.

Hahnfeld accepted this revision. Hahnfeld added a comment. This revision is now accepted and ready to land. LG, should land after the other revisions are in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108248/new/ https://reviews.llvm.org/D108248

[PATCH] D107547: [CodeGen] Align calling convention bit-width to bitcode

Xinglong added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107547/new/ https://reviews.llvm.org/D107547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] 1d06a39 - Fix a typo around 'builtin'

Author: Qiu Chaofan Date: 2021-08-18T17:42:12+08:00 New Revision: 1d06a39d6ede7f641063e5dfccd145703ee20b98 URL: https://github.com/llvm/llvm-project/commit/1d06a39d6ede7f641063e5dfccd145703ee20b98 DIFF: https://github.com/llvm/llvm-project/commit/1d06a39d6ede7f641063e5dfccd145703ee20b98.diff L

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

sammccall added a comment. I realize many of the things I'll object to came from my own prototype, sorry about that :-\ I think/hope I gave you some forewarning about this! Comment at: clang-tools-extra/clangd/Headers.h:137 + // Maps including files (from) to included files (

[PATCH] D107882: BPF: Enable frontend constant folding for VLA size

pchaigno added a comment. I tested this patch by running it through Cilium's CI which compiles, loads, and validates the behavior of hundreds of slightly different BPF programs. The tests cover several different kernels and all three BPF instruction set extensions (mcpu={v1,v2,v3}). It did not

[PATCH] D108150: [Remarks] [AMDGPU] Emit optimization remarks for atomics generating hardware instructions

rampitec added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12195 + if (!fpModeMatchesGlobalFPAtomicMode(RMW)) +return reportUnsafeHWInst(RMW, AtomicExpansionKind::None); gandhi21299 wrote: > rampitec wrote: > > rampitec w

[PATCH] D108150: [Remarks] [AMDGPU] Emit optimization remarks for atomics generating hardware instructions

gandhi21299 updated this revision to Diff 366958. gandhi21299 added a comment. - requested changes from reviewer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108150/new/ https://reviews.llvm.org/D108150 Files: clang/test/CodeGenOpenCL/atomics-c

[PATCH] D108150: [Remarks] [AMDGPU] Emit optimization remarks for atomics generating hardware instructions

gandhi21299 updated this revision to Diff 367000. gandhi21299 marked an inline comment as done. gandhi21299 added a comment. - corrected AtomicExpansionKind return value in SIISelLowering as pointed out by reviewer - eliminated previous function declaration which is not defined/used anymore Rep

[PATCH] D108150: [Remarks] [AMDGPU] Emit optimization remarks for atomics generating hardware instructions

rampitec requested changes to this revision. rampitec added a comment. This revision now requires changes to proceed. Logic is still wrong. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108150/new/ https://reviews.llvm.org/D108150

[PATCH] D108150: [Remarks] [AMDGPU] Emit optimization remarks for atomics generating hardware instructions

gandhi21299 added a comment. @rampitec Which part of the logic is wrong? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108150/new/ https://reviews.llvm.org/D108150 ___ cfe-commits mailing list cfe-commit

[PATCH] D108150: [Remarks] [AMDGPU] Emit optimization remarks for atomics generating hardware instructions

rampitec added a comment. In D108150#2950458 , @gandhi21299 wrote: > @rampitec Which part of the logic is wrong? Still the same around LDS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108150/new/ https

[PATCH] D108150: [Remarks] [AMDGPU] Emit optimization remarks for atomics generating hardware instructions

gandhi21299 added a comment. My understanding is that since we are reporting unsafe expansion into hw instructions, `fpModeMatchesGlobalFPAtomicMode(RMW)` must be false to match the logic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108150/new/

[PATCH] D108150: [Remarks] [AMDGPU] Emit optimization remarks for atomics generating hardware instructions

rampitec added a comment. In D108150#2950479 , @gandhi21299 wrote: > My understanding is that since we are reporting unsafe expansion into hw > instructions, `fpModeMatchesGlobalFPAtomicMode(RMW)` must be false to match > the logic. Please run check-l

[PATCH] D108150: [Remarks] [AMDGPU] Emit optimization remarks for atomics generating hardware instructions

gandhi21299 updated this revision to Diff 367042. gandhi21299 added a comment. - corrected logic for ORE in SIISelLowering.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108150/new/ https://reviews.llvm.org/D108150 Files: clang/test/CodeGenOp

[PATCH] D108150: [Remarks] [AMDGPU] Emit optimization remarks for atomics generating hardware instructions

gandhi21299 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108150/new/ https://reviews.llvm.org/D108150 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D108286: [clang][Driver][Linux] fix regression issue when define LIBCXX_LIBDIR_SUFFIX=64

sunlin created this revision. Herald added a subscriber: mgorny. sunlin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang failed to compile c++ when LIBCXX_LIBDIR_SUFFIX=64 is defeined for the lib path "../lib64" are not be included.

[clang] f22e586 - [Sema] CheckObjCBridgeNSCast - fix dead code warning. NFCI.

Author: Simon Pilgrim Date: 2021-08-18T11:53:27+01:00 New Revision: f22e5869a012af09e130d804bba441eff261b1fe URL: https://github.com/llvm/llvm-project/commit/f22e5869a012af09e130d804bba441eff261b1fe DIFF: https://github.com/llvm/llvm-project/commit/f22e5869a012af09e130d804bba441eff261b1fe.diff

[PATCH] D108286: [clang][Driver][Linux] fix regression issue when define LIBCXX_LIBDIR_SUFFIX=64

sunlin updated this revision to Diff 367167. sunlin added a comment. [clang][Driver][Linux] fix regression issue when define LIBCXX_LIBDIR_SUFFIX=64 remove unrelated files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108286/new/ https://reviews.l

[PATCH] D108286: [clang][Driver][Linux] fix regression issue when define LIBCXX_LIBDIR_SUFFIX=64

sunlin added a subscriber: MaskRay. sunlin added a comment. Hi @MaskRay Please help to review this change. I compiled clang with "-DLLVM_LIBDIR_SUFFIX=64" "-DLIBCXX_LIBDIR_SUFFIX=64" "-DLIBCXXABI_LIBDIR_SUFFIX=64" and the clang 12 work as expected. But after I turn to clang 13, it's failed to

[PATCH] D108113: [C++4OpenCL] Enable -cl-std flag clc++21 as a shorthand for clc++2021

Anastasia requested changes to this revision. Anastasia added a comment. This revision now requires changes to proceed. In D108113#2949173 , @svenvh wrote: > In D108113#2949141 , @Anastasia > wrote: > >> @svenvh

[PATCH] D104285: [analyzer][AST] Retrieve value by direct index from list initialization of constant array declaration.

ASDenysPetrov added a comment. In D104285#2949772 , @aaron.ballman wrote: > I don't think that compilers will create a disjointed multidimensional array, > as that would waste space at runtime. However, I do think that *optimizers* > are getting much s

[clang] 4e80636 - Implement P1949

Author: Corentin Jabot Date: 2021-08-18T07:33:14-04:00 New Revision: 4e80636db71a1b6123d15ed1f9eda3979b4292de URL: https://github.com/llvm/llvm-project/commit/4e80636db71a1b6123d15ed1f9eda3979b4292de DIFF: https://github.com/llvm/llvm-project/commit/4e80636db71a1b6123d15ed1f9eda3979b4292de.diff

[PATCH] D104975: Implement P1949

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the patch, I've landed it on your behalf in 4e80636db71a1b6123d15ed1f9eda3979b4292de Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

haonanya updated this revision to Diff 367178. haonanya added a comment. Remove OpenCL3.0 macro guards on opencl-c.h and OpenCLBuiltins.td. Add missing feature macro. simplify test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106343/new/ https://reviews.llvm.org/D106343 Files: clan

[PATCH] D104285: [analyzer][AST] Retrieve value by direct index from list initialization of constant array declaration.

ASDenysPetrov added a comment. @aaron.ballman Now I'm going to rework this patch according to our disscussion. This is the first patch in the stack as you can see. And I don't want to loose the series of improvements so I will adjust it to save further patches. CHANGES SINCE LAST ACTION htt

[PATCH] D108291: [clang-nvlink-wrapper] Wrapper around nvlink for archive files

saiislam created this revision. saiislam added reviewers: jdoerfert, ye-luo, grokos, ABataev. Herald added subscribers: mstorsjo, mgorny. saiislam requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. nvlink does not support linking of cubin file

[PATCH] D104285: [analyzer][AST] Retrieve value by direct index from list initialization of constant array declaration.

aaron.ballman added a comment. In D104285#2951911 , @ASDenysPetrov wrote: > This is really significant obstructions. As what I see the only thing left > for us is to wait until the Standard transforms this //shenanigans// into > legal operations and be

[PATCH] D108094: [clang-format] Improve detection of parameter declarations in K&R C

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108094/new/ https://reviews.llvm.org/D108094 ___ cfe-commits mailing li

[PATCH] D108291: [clang-nvlink-wrapper] Wrapper around nvlink for archive files

JonChesterfield added a comment. Tests. The usual bug in this area is that an archive can contain multiple files with the same name which clobber each other if extracted to the same directory. It looks to me like this implementation will fail that test. Also, motivation? Seems this can be worke

[PATCH] D108094: [clang-format] Improve detection of parameter declarations in K&R C

MyDeveloperDay added a comment. @owenpan Can we push all these commits to 13 RC2 via https://bugs.llvm.org/show_bug.cgi?id=51470 We need to mark the commits we want to cherry pick I think. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108094/new/ https://reviews.llvm.org/D108094 ___

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

saiislam added a comment. In D105191#2910961 , @ye-luo wrote: > Do I must use llvm-ar/ranlib or system ar/ranlib is OK? > > 1. existing use case breaks > > Use https://github.com/ye-luo/openmp-target/blob/master/tests/math/modf.cpp > $ clang++ -fopenmp -

[PATCH] D108291: [clang-nvlink-wrapper] Wrapper around nvlink for archive files

saiislam added a comment. In D108291#2951969 , @JonChesterfield wrote: > Tests. The usual bug in this area is that an archive can contain multiple > files with the same name which clobber each other if extracted to the same > directory. It looks to me

[PATCH] D93525: [clang-offload-bundler] Add unbundling of archives containing bundled object files into device specific archives

JonChesterfield added a comment. This is mentioned as broken in the referenced patch and landed with @t-tye still marked as requires changes. Revert warranted? Testing looks very sparse for something handling archives. Presumably it has the same set of bugs as Repository: rG LLVM Github Mon

[PATCH] D93525: [clang-offload-bundler] Add unbundling of archives containing bundled object files into device specific archives

saiislam added a comment. In D93525#2952012 , @JonChesterfield wrote: > This is mentioned as broken in the referenced patch and landed with @t-tye > still marked as requires changes. Revert warranted? > > Testing looks very sparse for something handling

[PATCH] D108296: Do not emit diagnostics for invalid unicode characters in preprocessing mode

cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D108296 Files: clang/lib/Lex/Lexer.cpp clang/test/Lexer/unicode.c Index: clang/t

[clang] 2715c4d - Do not emit diagnostics for invalid unicode characters in preprocessing mode

Author: Corentin Jabot Date: 2021-08-18T09:12:36-04:00 New Revision: 2715c4da50387ed6dae49a2a17fdcfad8a769a3c URL: https://github.com/llvm/llvm-project/commit/2715c4da50387ed6dae49a2a17fdcfad8a769a3c DIFF: https://github.com/llvm/llvm-project/commit/2715c4da50387ed6dae49a2a17fdcfad8a769a3c.diff

[PATCH] D108296: Do not emit diagnostics for invalid unicode characters in preprocessing mode

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/test/Lexer/unicode.c:3 // RUN: %clang_cc1 -fsyntax-only -verify -x c++ -std=c++11 %s +// RUN: %clang_cc1 -triple x86_64-scei-ps4 -E -DP

[PATCH] D108296: Do not emit diagnostics for invalid unicode characters in preprocessing mode

aaron.ballman closed this revision. aaron.ballman added a comment. I've landed this in 2715c4da50387ed6dae49a2a17fdcfad8a769a3c , thanks for the quick fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

svenvh added inline comments. Comment at: clang/lib/Sema/OpenCLBuiltins.td:1108 + +let Extension = FuncExtFloatAtomics in { + let MinVersion = CL20 in { So now all of those builtins are guarded by `cl_ext_float_atomics`, which is good, but not by any of the `__

[clang] 9f27364 - Use a more general test here.

Author: Aaron Ballman Date: 2021-08-18T09:32:05-04:00 New Revision: 9f27364377a247cc779c11b1e1f220b20755982f URL: https://github.com/llvm/llvm-project/commit/9f27364377a247cc779c11b1e1f220b20755982f DIFF: https://github.com/llvm/llvm-project/commit/9f27364377a247cc779c11b1e1f220b20755982f.diff

[PATCH] D105267: [X86] AVX512FP16 instructions enabling 4/6

LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:1920 + setOperationAction(ISD::STRICT_FTRUNC, VT, Legal); + setOperationAction(ISD::FRINT, VT, Legal); + setOperationAction(ISD::STRICT_FRINT, VT, Legal); -

[PATCH] D108291: [clang-nvlink-wrapper] Wrapper around nvlink for archive files

ye-luo added a comment. this is the working steps in the linking script. clang-offload-bundler (host,device) in: complex_reduction.cpp.o out: complex_reduction-494ba8.o, complex_reduction-5aba63.cubin nvlink (device) in: complex_reduction-5aba63.cubin out: complex_reduction-b1898c.

[PATCH] D108109: [CodeCompletion] Provide placeholders for known attribute arguments

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108109/new/ https://reviews.llvm.org/D108109

[PATCH] D108111: [CodeComplete] Only complete attributes that match the current LangOpts

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108111/new/ https://reviews.llvm.org/D108111

[PATCH] D108299: [MSP430][Clang] Remove support for -mmcu=msp430

jozefl created this revision. jozefl requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The -mmcu= option accepts a generic MCU named "msp430", which sets the CPU to msp430 and disables hardware multiply support. The current purpose of accept

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

jozefl created this revision. jozefl added a reviewer: asl. jozefl requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch updates MSP430 MCU data to the latest version distributed by TI, adding support for 451 additional MCUs. The hard

[PATCH] D108246: [clang-offload-wrapper] Disabled ELF offload notes embedding by default.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. As discussed, LG, we will look into the NVIDIA GPU problem now to get rid of this again. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108246/new/ https://reviews.llvm.org/D108

[PATCH] D108302: [PowerPC] Fixed the crash due to early if conversion with fixed CR fields.

NeHuang created this revision. NeHuang added reviewers: stefanp, nemanjai, PowerPC. NeHuang added a project: LLVM. Herald added subscribers: shchenz, kbarton, hiraditya. NeHuang requested review of this revision. This patch adds a fix to do early if conversion to select when conditional branch no

[PATCH] D108291: [clang-nvlink-wrapper] Wrapper around nvlink for archive files

JonChesterfield added a comment. Discussed at the multicompany meeting today. Consensus reached is that the whole-archive/no-whole-archive distinction is unimportant - we can ship a toolchain that has whole-archive semantics and later change the default when doing more work in the linker. It's

[PATCH] D108247: [CUDA] Improve CUDA version detection and diagnostics.

yaxunl added a comment. The change about amdgpu LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108247/new/ https://reviews.llvm.org/D108247 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

JonChesterfield added a comment. Nvptx broken here too, amdgpu is fine. I'm guessing one of the cuda tools does some overly aggressive input validation that we're running afoul of. There was a discussion about this on the call today - plan was to put it behind a disabled boolean argument while

[PATCH] D108303: [clang][openmp] Disable embedded elf notes

JonChesterfield created this revision. JonChesterfield added reviewers: vzakhari, ABataev, grokos, sdmitriev, jdoerfert, ronlieb. Herald added subscribers: guansong, yaxunl. JonChesterfield requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project:

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

vzakhari added a comment. In D99551#2952336 , @JonChesterfield wrote: > Nvptx broken here too, amdgpu is fine. I'm guessing one of the cuda tools > does some overly aggressive input validation that we're running afoul of. > > There was a discussion about

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

JonChesterfield added a comment. It's a hack, but D108303 will unblock nvptx offloading. Alternative to reverting. Suggest we go with that then revisit in a couple of weeks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D108246: [clang-offload-wrapper] Disabled ELF offload notes embedding by default.

JonChesterfield accepted this revision. JonChesterfield added a comment. Amusingly similar to D108303 . LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108246/new/ https://reviews.llvm.org/D108246 ___ cfe

[PATCH] D108303: [clang][openmp] Disable embedded elf notes

vzakhari added a comment. Hi Jon, I am about to merge D108246 that disables the notes embedding. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108303/new/ https://reviews.llvm.org/D108303 ___

[PATCH] D108246: [clang-offload-wrapper] Disabled ELF offload notes embedding by default.

JonChesterfield added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:79 +static cl::opt AddOpenMPOffloadNotes( +"add-omp-offload-notes", I'd have probably gone with an explicit false here but it doesn't make much dif

[PATCH] D106960: [OffloadArch] Library to query properties of current offload archicture

jdoerfert added inline comments. Comment at: llvm/lib/OffloadArch/OffloadArch.cpp:280 + return results; +} the _aot_ names are not great. Comment at: llvm/lib/OffloadArch/amdgpu/hsa-subset.h:40 +// DEALINGS WITH THE SOFTWARE. +// +

[PATCH] D108303: [clang][openmp] Disable embedded elf notes

JonChesterfield abandoned this revision. JonChesterfield added a comment. I like D108246 more. None of the offloading tests updated in D108246 failed with the above patch, perhaps they're not run by `make check-openmp` Repos

[PATCH] D107882: BPF: Enable frontend constant folding for VLA size

yonghong-song added a comment. ping. @rsmith could you help take a look at the patch? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107882/new/ https://reviews.llvm.org/D107882 ___ cfe-commits ma

[PATCH] D108303: [clang][openmp] Disable embedded elf notes

vzakhari added a comment. In D108303#2952393 , @JonChesterfield wrote: > I like D108246 more. None of the > offloading tests updated in D108246 failed > with the above patch, perhaps

[clang] 1ffbe8c - [clang-offload-wrapper] Disabled ELF offload notes embedding by default.

Author: Vyacheslav Zakharin Date: 2021-08-18T08:18:03-07:00 New Revision: 1ffbe8c04ff269ca9847c37036fbad943820d6ae URL: https://github.com/llvm/llvm-project/commit/1ffbe8c04ff269ca9847c37036fbad943820d6ae DIFF: https://github.com/llvm/llvm-project/commit/1ffbe8c04ff269ca9847c37036fbad943820d6ae

[PATCH] D108246: [clang-offload-wrapper] Disabled ELF offload notes embedding by default.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1ffbe8c04ff2: [clang-offload-wrapper] Disabled ELF offload notes embedding by default. (authored by vzakhari). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D108286: [clang][Driver][Linux] fix regression issue when define LIBCXX_LIBDIR_SUFFIX=64

MaskRay added a comment. Please provide more information: the platform name and the output of `g++ empty.cc '-###' |& sed -E 's/ "?-[LiIr]/\n&/g'` Note that there is a FIXME. It's unclear why your platform needs the specific rule. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D107290: [PoC][RISCV] Add support for the vscale_range attribute

frasercrmck updated this revision to Diff 367232. frasercrmck added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. update usage in vein of AArch64: - use vscale_range attribute to determine RVV vector bits min/max values - if no attribute is present, u

[PATCH] D108286: [clang][Driver][Linux] fix regression issue when define LIBCXX_LIBDIR_SUFFIX=64

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:307 + if (StringRef(D.Dir).startswith(SysRoot)) { addPathIfExists(D, D.Dir + "/../lib", Paths); +addPathIfExists(D, D.Dir + "/../" + OSLibDir, Paths); Is `D.Dir + "/../lib"

[PATCH] D108241: [hwasan] Flag stack safety check as requiring aarch64

fmayer accepted this revision. fmayer added a comment. This revision is now accepted and ready to land. Thanks LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108241/new/ https://reviews.llvm.org/D108241

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit added a comment. I don't think there are any other outstanding issues. Are we good to accept and merge? @ldionne CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ cfe-commits mailing

[PATCH] D105267: [X86] AVX512FP16 instructions enabling 4/6

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:1920 + setOperationAction(ISD::STRICT_FTRUNC, VT, Legal); + setOperationAction(ISD::FRINT, VT, Legal); + setOperationAction(ISD::STRICT_FRINT, VT, Legal)

[PATCH] D108265: .clang-tidy: Push variable related readability-identifier-naming options down to projects

MaskRay added a comment. The number of top-level projects using `VariableName` is smaller than the number of projects not using the style. The top-level variable style just provoked projects to either override the options (flang/, lld/, mlir/) or disable the check. `VariableName` is not even a s

[PATCH] D107430: [OMPIRBuilder] Add ordered directive to OMPIRBuilder

Meinersbur added a comment. Note that the `OpenMPIRBuilderTest.OrderedDirective` test is still crashing. Comment at: llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp:2156-2157 + + Value *EntryBBTI = EntryBB->getTerminator(); + EXPECT_EQ(EntryBBTI, nullptr); +

Phabricator Creator Pulling the Plug

All I'm a massive fan of Phabricator, and I know there is often lots of contentious discussion about its relative merits vs github, But unless I missed this, was there any discussion regarding the recent "Winding Down" announcement of Phabricator? and what it might mean for us in LLVM See: https

[PATCH] D108247: [CUDA] Improve CUDA version detection and diagnostics.

tra updated this revision to Diff 367246. tra edited the summary of this revision. tra added a comment. Do not report the version if we don't know it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108247/new/ https://reviews.llvm.org/D108247 Files

[PATCH] D108247: [CUDA] Improve CUDA version detection and diagnostics.

tra added inline comments. Comment at: clang/test/Driver/cuda-version-check.cu:75 -// UNKNOWN_VERSION_V: unknown CUDA version: version.txt:{{.*}}; assuming the latest supported version -// UNKNOWN_VERSION_H: unknown CUDA version: cuda.h: CUDA_VERSION={{.*}}; assuming the late

[PATCH] D107850: [asan] Implemented custom calling convention similar to the one used by HWASan for X86.

kstoimenov added a comment. I know it seems redundant to pass the constants with every function call, but otherwise the code generation code will have to take dependency on AddressSanitizerCommon.h, which I am not sure is ideal. I spent some time looking into it and becomes quite messy. For exa

[Job Ad] Intel is hiring Frontend Compiler Engineers

Intel is looking for Frontend Compiler Engineers to be a part of the Intel compiler engineering organization on the frontend team. Join our growing team, helping to develop new features and maintain existing functionality in Clang. We are currently hiring folks for entry-level and experienced posit

[PATCH] D108308: Cleanup identifier parsing.

cor3ntin created this revision. Herald added subscribers: dexonsmith, usaxena95, kadircet, arphaman. Herald added a reviewer: aaron.ballman. cor3ntin requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. - Rename methods to clea

[PATCH] D108150: [Remarks] [AMDGPU] Emit optimization remarks for atomics generating hardware instructions

rampitec added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12194 - return (fpModeMatchesGlobalFPAtomicMode(RMW) || - RMW->getFunction() - ->getFnAttribute("amdgpu-unsafe-fp-atomics") - .getVa

[PATCH] D108247: [CUDA] Improve CUDA version detection and diagnostics.

Hahnfeld accepted this revision. Hahnfeld added a comment. This revision is now accepted and ready to land. Otherwise LGTM Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:103-104 +std::string VersionString = CudaVersionToString(Version); +if (!VersionString.empty()) +

[PATCH] D108235: [CUDA] Bump default GPU architecture to sm_35.

Hahnfeld added a comment. (might be good to have an entry in the release notes?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108235/new/ https://reviews.llvm.org/D108235 ___ cfe-commits mailing list cf

[PATCH] D108239: [CUDA] Add support for CUDA-11.4.

Hahnfeld added a comment. I didn't follow the recent CUDA support in Clang very closely, but this makes sense to me. Comment at: clang/lib/Basic/Targets/NVPTX.cpp:48-49 PTXVersion = llvm::StringSwitch(Feature) + .Case("+ptx72", 74) +

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

samitolvanen added a comment. FYI, this breaks the Linux kernel when built with ThinLTO: https://github.com/ClangBuiltLinux/linux/issues/1440 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105265/new/ https://reviews.llvm.org/D105265 _

[PATCH] D108248: [CUDA] Bump the latest supported CUDA version to 11.4.

tra updated this revision to Diff 367259. tra edited the summary of this revision. tra added a comment. Prepend space to version string. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108248/new/ https://reviews.llvm.org/D108248 Files: clang/incl

[PATCH] D108248: [CUDA] Bump the latest supported CUDA version to 11.4.

tra updated this revision to Diff 367260. tra added a comment. Undo unintentional change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108248/new/ https://reviews.llvm.org/D108248 Files: clang/include/clang/Basic/Cuda.h Index: clang/include/c

[PATCH] D108247: [CUDA] Improve CUDA version detection and diagnostics.

tra updated this revision to Diff 367261. tra added a comment. Prepend space to the version string. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108247/new/ https://reviews.llvm.org/D108247 Files: clang/include/clang/Basic/Cuda.h clang/includ

[PATCH] D108247: [CUDA] Improve CUDA version detection and diagnostics.

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:103-104 +std::string VersionString = CudaVersionToString(Version); +if (!VersionString.empty()) + VersionString += " "; +D.Diag(diag::warn_drv_new_cuda_version) Hahnfeld

[PATCH] D105007: [NewPM] Update some sanitizer pass names in the PassRegistry

bjope updated this revision to Diff 367263. bjope added a comment. Herald added subscribers: cfe-commits, ormris. Herald added a project: clang. Updated to use _PASS_WITH_PARAMS and option parsing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10500

[clang] 2afb939 - [hwasan] Flag stack safety check as requiring aarch64

Author: Christopher Tetreault Date: 2021-08-18T11:14:01-07:00 New Revision: 2afb9394a745733739f217d53cd9cf4ae03a3157 URL: https://github.com/llvm/llvm-project/commit/2afb9394a745733739f217d53cd9cf4ae03a3157 DIFF: https://github.com/llvm/llvm-project/commit/2afb9394a745733739f217d53cd9cf4ae03a31

[PATCH] D108241: [hwasan] Flag stack safety check as requiring aarch64

This revision was automatically updated to reflect the committed changes. Closed by commit rG2afb9394a745: [hwasan] Flag stack safety check as requiring aarch64 (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108241/new/ https:

[PATCH] D105007: [NewPM] Make some sanitizer passes parameterized in the PassRegistry

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105007/new/ https://reviews.llvm.org/D105007 ___

  1   2   >