[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables by removing the enum FixIt, and add support for initialization check of scoped enum.

Sockke updated this revision to Diff 362291. Sockke retitled this revision from "[clang-tidy] Fix cppcoreguidelines-init-variables with enum judgement" to "[clang-tidy] Fix cppcoreguidelines-init-variables by removing the enum FixIt, and add support for initialization check of scoped enum.". Soc

[clang] 7161672 - [clang-format] Correctly attach enum braces with ShortEnums disabled

Author: Luna Kirkby Date: 2021-07-28T10:29:15+02:00 New Revision: 71616722d4092f88861e9eb337e2902bbab2cbd4 URL: https://github.com/llvm/llvm-project/commit/71616722d4092f88861e9eb337e2902bbab2cbd4 DIFF: https://github.com/llvm/llvm-project/commit/71616722d4092f88861e9eb337e2902bbab2cbd4.diff L

[PATCH] D99840: [clang-format] Correctly attach enum braces with ShortEnums disabled

This revision was automatically updated to reflect the committed changes. Closed by commit rG71616722d409: [clang-format] Correctly attach enum braces with ShortEnums disabled (authored by lunasorcery, committed by curdeius). Changed prior to commit: https://reviews.llvm.org/D99840?vs=362220&id

[PATCH] D106790: prfchwintrin.h: Make _m_prefetchw take a pointer to volatile (PR49124)

hans added a comment. > Sure, they won't be included together, but will GCC users get warnings from > passing non-volatile pointers to `_mm_prefetchw`? If we change these > qualifiers to match MSVC, will GCC/Clang users be able to observe any change > in behavior? I don't think that should cau

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis updated this revision to Diff 362305. ggeorgakoudis added a comment. Rebase, update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp cla

[PATCH] D106939: [RISCV] If the maskedoff is vundefined(), use ta, ma for vsetvli.

HsiangKai created this revision. HsiangKai added reviewers: frasercrmck, khchen, arcbbb, rogfer01, evandro, craig.topper. Herald added subscribers: StephenFan, vkmr, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones,

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables by removing the enum FixIt, and add support for initialization check of scoped enum.

whisperity added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:156 + + ⁣Added support for initialization check of the scoped enum + Unterminated sequence. Also, where is this feature implemented? CHANGES SINCE LAST ACTION https://revie

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD updated this revision to Diff 362310. RedDocMD added a comment. Invalidating via the CallEvent Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105821/new/ https://reviews.llvm.org/D105821 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtrM

[PATCH] D106778: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics

azabaznov added inline comments. Comment at: clang/lib/Headers/opencl-c.h:13304 +#else +void __ovld atomic_init(volatile __global atomic_int *object, int value); +void __ovld atomic_init(volatile __local atomic_int *object, int value); These new atomics with glob

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

AMDChirag updated this revision to Diff 362319. AMDChirag added a comment. Rebased. Verified, this patch is not causing any test failures for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93373/new/ https://reviews.llvm.org/D93373 Files: cla

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables by removing the enum FixIt, and add support for initialization check of scoped enum.

Sockke updated this revision to Diff 362320. Sockke added a comment. Update! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106431/new/ https://reviews.llvm.org/D106431 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/InitVariablesCheck.cpp clang-tools-extra/docs/ReleaseNotes.r

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

crownyanguan added a comment. This commit also makes the phoronix/pgbench run fail. clang --gcc-toolchain=/usr/bin/.. -target aarch64-unknown-linux-gnu -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-stric

[clang] b0ef3d8 - Allow #pragma float_control(push|pop) within a language linkage specification

Author: Aaron Ballman Date: 2021-07-28T07:37:56-04:00 New Revision: b0ef3d8f666fa6008abb09340b73d9340d442569 URL: https://github.com/llvm/llvm-project/commit/b0ef3d8f666fa6008abb09340b73d9340d442569 DIFF: https://github.com/llvm/llvm-project/commit/b0ef3d8f666fa6008abb09340b73d9340d442569.diff

[PATCH] D106863: Allow #pragma float_control(push|pop) within a language linkage specification

aaron.ballman closed this revision. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. In D106863#2907362 , @mibintc wrote: > Thanks for fixing this Aaron, just curious was there a bug report? There's no public bug to close fr

[PATCH] D106946: [clang-tidy] Fix crash on "reference to array" parameters in 'bugprone-easily-swappable-parameters'

whisperity created this revision. whisperity added a reviewer: aaron.ballman. whisperity added a project: clang-tools-extra. Herald added subscribers: martong, gamesh411, Szelethus, dkrupp, rnkovacs, xazax.hun. whisperity requested review of this revision. Herald added a subscriber: cfe-commits.

[PATCH] D106946: [clang-tidy] Fix crash on "reference to array" parameters in 'bugprone-easily-swappable-parameters'

whisperity updated this revision to Diff 362333. whisperity added a comment. Add some more test cases! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106946/new/ https://reviews.llvm.org/D106946 Files: clang-tools-extra/clang-tidy/bugprone/Easily

[PATCH] D106946: [clang-tidy] Fix crash on "reference to array" parameters in 'bugprone-easily-swappable-parameters'

whisperity updated this revision to Diff 362334. whisperity added a comment. **NFC** //Typo-fix//: Remove empty line from end of diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106946/new/ https://reviews.llvm.org/D106946 Files: clang-tools-

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables by removing the enum FixIt, and add support for initialization check of scoped enum.

whisperity added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:156 + + ⁣Added support for initialization check of the scoped enum + whisperity wrote: > Unterminated sequence. Also, where is this feature implemented? @Sockke Sorry if I'm ul

[PATCH] D106898: Revert "Revert "[clang][pp] adds '#pragma include_instead'""

aaron.ballman added a comment. Generally LGTM, but the CI is failing. Comment at: clang/test/PCH/ms-pch-macro-include_instead-regression.c:3 +// RUN: %clang_cc1 -DMSEXT -fms-extensions -DFOO %S/variables.h -DBAZ=\"Inputs/pch-through1.h\" -emit-pch -o %t1.pch +// RUN: %clang_cc

[PATCH] D106860: [clang][AArch64][SVE] Avoid going through memory for fixed/scalable predicate casts

bsmith added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2110-2129 // Perform VLAT <-> VLST bitcast through memory. // TODO: since the llvm.experimental.vector.{insert,extract} intrinsics // require the element types of the vectors to be t

[PATCH] D106946: [clang-tidy] Fix crash on "reference to array" parameters in 'bugprone-easily-swappable-parameters'

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-easily-swappable-parameters-implicits.cpp:46 + +void crefToArrayTypedefBoth1(const Point2D &VecDescartes, const Point3D &VecThreeD) {} +// NO-WARN: Distinct types. -

[PATCH] D106946: [clang-tidy] Fix crash on "reference to array" parameters in 'bugprone-easily-swappable-parameters'

whisperity added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-easily-swappable-parameters-implicits.cpp:46 + +void crefToArrayTypedefBoth1(const Point2D &VecDescartes, const Point3D &VecThreeD) {} +// NO-WARN: Distinct types.

[PATCH] D106946: [clang-tidy] Fix crash on "reference to array" parameters in 'bugprone-easily-swappable-parameters'

whisperity updated this revision to Diff 362340. whisperity added a comment. Add a test case where the referenced arrays are deduced from template parameters. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106946/new/ https://reviews.llvm.org/D1069

[PATCH] D106614: [Clang] add btf_tag attribute

aaron.ballman added a comment. This currently has no codegen, so it only adds the attribute to the AST and does nothing with it. Can you also add the codegen components to this patch? Comment at: clang/include/clang/Basic/Attr.td:1835 + let Args = [StringArgument<"BTFTag">];

[PATCH] D106792: [clang-tidy] Always open files using UTF-8 encoding

kbobyrev added a comment. Hi! Thanks for the patch, it makes sense to me! Honestly, I think having the `open` shadow is maybe not the best way to solve this (please feel free to let me know if there are reasons it would be better), maybe spell it out explicitly (there aren't that many cases of

[PATCH] D106946: [clang-tidy] Fix crash on "reference to array" parameters in 'bugprone-easily-swappable-parameters'

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-easily-swappable-parameters-implicits.cpp:60 + + // NO-WARN: Implicit instantiations are

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

jamieschmeiser added a comment. @crownyanguan Why do you think this caused the linker to crash? It is a warning in the front end. Would it even be executed in your posted command? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98798/new/ https://

[clang-tools-extra] 2183212 - [clang-tidy] Fix crash on "reference-to-array" parameters in 'bugprone-easily-swappable-parameters'

Author: Whisperity Date: 2021-07-28T14:44:20+02:00 New Revision: 21832121e112d97f1e197b35959867f3a99226ee URL: https://github.com/llvm/llvm-project/commit/21832121e112d97f1e197b35959867f3a99226ee DIFF: https://github.com/llvm/llvm-project/commit/21832121e112d97f1e197b35959867f3a99226ee.diff LO

[PATCH] D106946: [clang-tidy] Fix crash on "reference to array" parameters in 'bugprone-easily-swappable-parameters'

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG21832121e112: [clang-tidy] Fix crash on "reference-to-array" parameters in 'bugprone-easily… (authored by whisperity). Repository: rG LLVM Github

[PATCH] D106792: [clang-tidy] Always open files using UTF-8 encoding

kbobyrev added a comment. > For example, right now > clang-tools-extra/docs/clang-tidy/checks/abseil-no-internal-dependencies.rst > has non-ASCII quotes Also, hm... Do we really need these? It's safe to remove those, this shouldn't be a problem, I think. Repository: rG LLVM Github Monorepo

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables by removing the enum FixIt, and add support for initialization check of scoped enum.

Sockke updated this revision to Diff 362345. Sockke added a comment. Thanks for your reply @whisperity. I have updated! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106431/new/ https://reviews.llvm.org/D106431 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/InitVariablesCheck

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables by removing the enum FixIt, and add support for initialization check of scoped enum.

whisperity added a comment. Alright, thanks! So it does work that way, I didn't know. I think this is okay from my end. You can mark the inline discussion done, by the way. 🙂 Let's see if @aaron.ballman has any comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106431/new/ https:

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev updated this revision to Diff 362348. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 Files: clang/include/clang/Serialization/ASTWriter.h clang/lib/Serialization/ASTWriter.cpp Index: clang/

[PATCH] D105981: [AMDGPU][OpenMP] Support linking of math libraries

JonChesterfield added a comment. I don't like that this pulls in ockl automatically but don't think that's a blocker. OK on my side, @yaxunl? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105981/new/ https://reviews.llvm.org/D105981 _

[PATCH] D106900: [PowerPC][AIX] Packed zero-width bitfields do not affect alignment.

sfertile updated this revision to Diff 362365. sfertile added a comment. clang-formatted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106900/new/ https://reviews.llvm.org/D106900 Files: clang/lib/AST/RecordLayoutBuilder.cpp clang/test/Layout/

[PATCH] D105981: [AMDGPU][OpenMP] Support linking of math libraries

pdhaliwal added a comment. Due to the current state of math headers, I was unable to test this patch without ockl. But last time when headers were working, I was actually required to link ockl for a symbol (I forgot the name). I will update once I am able to get the math headers work again. R

[PATCH] D106924: [Preprocessor] -E -P: Ensure newline after 8 skipped lines.

mstorsjo added a comment. Thanks! I can confirm that this fixes the issue I ran into. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106924/new/ https://reviews.llvm.org/D106924 ___ cfe-commits mailing li

[PATCH] D92935: Introduce support for PowerPC devices with an Embedded Floating-point APU version 2 (efpu2)

jrtc27 added inline comments. Comment at: llvm/test/CodeGen/PowerPC/spe.ll:2 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py -; RUN: llc -verify-machineinstrs < %s -mtriple=powerpc-unknown-linux-gnu \ -; RUN: -mattr=+spe | FileCheck %s +;

[PATCH] D92935: Introduce support for PowerPC devices with an Embedded Floating-point APU version 2 (efpu2)

jrtc27 added inline comments. Comment at: llvm/test/CodeGen/PowerPC/spe.ll:2 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py -; RUN: llc -verify-machineinstrs < %s -mtriple=powerpc-unknown-linux-gnu \ -; RUN: -mattr=+spe | FileCheck %s +;

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

jdoerfert added a comment. `x64 debian > Clang.Driver::fat_archive.cpp Failed` @ABataev @grokos any comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://reviews.llvm.org/D105191

[PATCH] D105981: [AMDGPU][OpenMP] Support linking of math libraries

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:831-860 auto Kind = llvm::AMDGPU::parseArchAMDGCN(GpuArch); const StringRef CanonArch = llvm::AMDGPU::getArchNameAMDGCN(Kind); std::string LibDeviceFile = RocmInstallation.getLibDeviceFile(C

[PATCH] D92935: Introduce support for PowerPC devices with an Embedded Floating-point APU version 2 (efpu2)

jrtc27 added inline comments. Comment at: llvm/test/CodeGen/PowerPC/spe.ll:2 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py -; RUN: llc -verify-machineinstrs < %s -mtriple=powerpc-unknown-linux-gnu \ -; RUN: -mattr=+spe | FileCheck %s +;

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility]

quinnp created this revision. Herald added subscribers: shchenz, kbarton, hiraditya, mgorny, nemanjai. quinnp requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch is in a series of patches to provide builtins for com

[PATCH] D105981: [AMDGPU][OpenMP] Support linking of math libraries

JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:831-860 auto Kind = llvm::AMDGPU::parseArchAMDGCN(GpuArch); const StringRef CanonArch = llvm::AMDGPU::getArchNameAMDGCN(Kind); std::string LibDeviceFile = RocmInstallation.getLibDev

[clang] 66ddac2 - [CLANG][PATCH][FPEnv] Add support for option -ffp-eval-method and extend #pragma float_control similarly

Author: Melanie Blower Date: 2021-07-28T10:50:32-04:00 New Revision: 66ddac22e2a7f268e91c26d694112970dfa607ae URL: https://github.com/llvm/llvm-project/commit/66ddac22e2a7f268e91c26d694112970dfa607ae DIFF: https://github.com/llvm/llvm-project/commit/66ddac22e2a7f268e91c26d694112970dfa607ae.diff

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

This revision was automatically updated to reflect the committed changes. Closed by commit rG66ddac22e2a7: [CLANG][PATCH][FPEnv] Add support for option -ffp-eval-method and extend… (authored by mibintc). Changed prior to commit: https://reviews.llvm.org/D93769?vs=360247&id=362385#toc Repositor

[PATCH] D92935: Introduce support for PowerPC devices with an Embedded Floating-point APU version 2 (efpu2)

kiausch added inline comments. Comment at: llvm/test/CodeGen/PowerPC/spe.ll:2 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py -; RUN: llc -verify-machineinstrs < %s -mtriple=powerpc-unknown-linux-gnu \ -; RUN: -mattr=+spe | FileCheck %s +;

[PATCH] D106870: [OpenMP] Multi architecture compilation support

saiislam added inline comments. Comment at: openmp/libomptarget/src/rtl.cpp:306 + std::string cmd_bin; + cmd_bin.assign(libomptarget_dir_name).append("/../bin/amdgpu-arch"); + struct stat stat_buffer; saiislam wrote: > Call to amdgpu-arch binary is going to be

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

jrtc27 added a comment. I'm seeing the test fail locally with: 000d1799 t clang_CompileCommand_getNumMappedSources being found by grep. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105527/new/ https://reviews.llvm.org/D105527

[PATCH] D106243: [Utils] Support class template specializations in update_cc_test_checks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e79a94836d7: [Utils] Support class template specializations in update_cc_test_checks (authored by jrtc27). Repository: rG LLVM Github Monorepo C

[clang] 0e79a94 - [Utils] Support class template specializations in update_cc_test_checks

Author: Jessica Clarke Date: 2021-07-28T16:03:41+01:00 New Revision: 0e79a94836d7127a87c36fdca43ffaf6a17d8964 URL: https://github.com/llvm/llvm-project/commit/0e79a94836d7127a87c36fdca43ffaf6a17d8964 DIFF: https://github.com/llvm/llvm-project/commit/0e79a94836d7127a87c36fdca43ffaf6a17d8964.diff

[clang] 40080e7 - [Clang interpreter] Avoid storing pointers at unaligned locations

Author: Jessica Clarke Date: 2021-07-28T16:03:41+01:00 New Revision: 40080e7e7f42857c8edac4a53e476a68563f1a98 URL: https://github.com/llvm/llvm-project/commit/40080e7e7f42857c8edac4a53e476a68563f1a98 DIFF: https://github.com/llvm/llvm-project/commit/40080e7e7f42857c8edac4a53e476a68563f1a98.diff

[PATCH] D97606: [Clang interpreter] Avoid storing pointers at unaligned locations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG40080e7e7f42: [Clang interpreter] Avoid storing pointers at unaligned locations (authored by jrtc27). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D106899: [LLVM][NFC] Use C++ 14 and C11 noreturn specifier

gAlfonso-bit updated this revision to Diff 362371. gAlfonso-bit added a comment. Herald added subscribers: cfe-commits, ormris, lxfind, usaxena95, rupprecht, arphaman, steven_wu, hiraditya. Herald added a reviewer: jhenderson. Herald added a project: clang-tools-extra. Removed LLVM_ATTRIBUTE_NORE

[PATCH] D106899: [LLVM][NFC] Remove LLVM_ATTRIBUTE_NORETURN and use [[noreturn]] directly

gAlfonso-bit updated this revision to Diff 362398. gAlfonso-bit added a comment. Formatted ONLY the code I changed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106899/new/ https://reviews.llvm.org/D106899 Files: clang-tools-extra/pp-trace/PPTrace.cpp clang/utils/TableGen/ClangDiag

[PATCH] D106899: [LLVM][NFC] Remove LLVM_ATTRIBUTE_NORETURN and use [[noreturn]] directly

gAlfonso-bit added a comment. @MaskRay I finished the migration to noreturn CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106899/new/ https://reviews.llvm.org/D106899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D105981: [AMDGPU][OpenMP] Support linking of math libraries

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:831-860 auto Kind = llvm::AMDGPU::parseArchAMDGCN(GpuArch); const StringRef CanonArch = llvm::AMDGPU::getArchNameAMDGCN(Kind); std::string LibDeviceFile = RocmInstallation.getLibDeviceFile(C

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility

quinnp updated this revision to Diff 362400. quinnp added a comment. Fixing a failing test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106959/new/ https://reviews.llvm.org/D106959 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/

[PATCH] D106860: [clang][AArch64][SVE] Avoid going through memory for fixed/scalable predicate casts

c-rhodes added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2110-2129 // Perform VLAT <-> VLST bitcast through memory. // TODO: since the llvm.experimental.vector.{insert,extract} intrinsics // require the element types of the vectors to be

[PATCH] D105981: [AMDGPU][OpenMP] Support linking of math libraries

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:831-860 auto Kind = llvm::AMDGPU::parseArchAMDGCN(GpuArch); const StringRef CanonArch = llvm::AMDGPU::getArchNameAMDGCN(Kind); std::string LibDeviceFile = RocmInstallation.getLibDeviceFile(C

[PATCH] D106778: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics

Anastasia added inline comments. Comment at: clang/lib/Headers/opencl-c.h:13678 +uintptr_t __ovld atomic_fetch_sub_explicit(volatile __local atomic_uintptr_t *object, ptrdiff_t operand, memory_order order, memory_scope scope); +#endif +#endif airlied wrote: > An

[PATCH] D106688: [AIX] Pass the -b option to linker on AIX

anjankgk updated this revision to Diff 362412. anjankgk added a comment. Addressed review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106688/new/ https://reviews.llvm.org/D106688 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/CommonArgs.cpp cl

[PATCH] D106688: [AIX] Pass the -b option to linker on AIX

anjankgk marked an inline comment as done. anjankgk added inline comments. Comment at: clang/test/Driver/Xlinker-args.c:15-16 + +// RUN: %clang -target powerpc-unknown-aix -### \ +// RUN: -b one %s 2> %t +// RUN: FileCheck -check-prefix=AIX < %t %s ZarkoCA wrot

[PATCH] D106899: [LLVM][NFC] Remove LLVM_ATTRIBUTE_NORETURN and use [[noreturn]] directly

gAlfonso-bit added a comment. Also yes I rebased my fork so they don't clash with your changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106899/new/ https://reviews.llvm.org/D106899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D106899: [LLVM][NFC] Remove LLVM_ATTRIBUTE_NORETURN and use [[noreturn]] directly

gAlfonso-bit added a comment. Note: This is a candidate for cherry-picking onto the 13 branch since it was only partially done there. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106899/new/ https://reviews.llvm.org/D106899 ___ cfe-commits

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

cjdb added a comment. In D106394#2905660 , @dblaikie wrote: > Just a thought (nothing to hold up this patch/suggest a revert/suggest any > immediate action), but: > >> The problem with extending this to non-system headers is that you need a way >> to te

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

tstellar added a comment. In D105527#2910319 , @jrtc27 wrote: > I'm seeing the test fail locally (on ca0fe3447fb85762838468537d93d4ef82c5a1af > ) with: > > 000d1799 t clang_Co

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

jrtc27 added a comment. In D105527#2910616 , @tstellar wrote: > In D105527#2910319 , @jrtc27 wrote: > >> I'm seeing the test fail locally (on >> ca0fe3447fb85762838468537d93d4ef82c5a1af >>

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

tstellar added a comment. It looks like that function is missing from libclang.map, I think if you add it there it should fix the test. I'm going to check to see if there are any more missing functions and then commit a fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D106925: COFF/ELF: Place llvm.global_ctors elements in llvm.used if comdat is used

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm So the main impact here is that, on ELF, linker GC will no longer be able to GC vague linkage global variables with dynamic initializers. Those are things like - C++17 inline globals - selecta

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

NoQ added a comment. No, that's the wrong destructor. We don't want to invalidate the smart pointer; we've already modeled it precisely. What i meant was construct a new `CallEvent` (through `CallEventManager`) for the destructor of the //pointee// and use that. Repository: rG LLVM Github M

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD added a comment. Ah I see. As a side note, without the "redundant" invalidation that is being done, the analyzer crashes on `shared_ptr`. (Because the `State` essentially remains the same and that's what causes the crash). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D106899: [LLVM][NFC] Remove LLVM_ATTRIBUTE_NORETURN and use [[noreturn]] directly

MaskRay added a comment. I migrated all llvm/ files. You need to remove them from the patch. It is a good idea to drop the macro definition in `llvm/include/llvm/Support/Compiler.h` separately. It makes it easy to bring back the definition if some downstream users want extended time for migrat

[PATCH] D106925: COFF/ELF: Place llvm.global_ctors elements in llvm.used if comdat is used

MaskRay added a comment. In D106925#2910638 , @rnk wrote: > lgtm > > So the main impact here is that, on ELF, linker GC will no longer be able to > GC vague linkage global variables with dynamic initializers. Those are things > like > > - C++17 inline g

[PATCH] D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String

MarcusJohnson91 updated this revision to Diff 362431. MarcusJohnson91 added a comment. Updated the tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106753/new/ https://reviews.llvm.org/D106753 Files: llvm/include/llvm/Support/ConvertUTF.h llvm/lib/Support/ConvertUTFWrapper.cpp

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables by removing the enum FixIt, and add support for initialization check of scoped enum.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM -- it's not the cleanest solution (we're duplicating the call to `diag()`), but it'll suffice. If we wanted to clean it up a bit, we could use an `llvm::Optional Diagnose =

[PATCH] D106924: [Preprocessor] -E -P: Ensure newline after 8 skipped lines.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106924/new/ https://reviews.llvm.org/D106924

[PATCH] D106974: libcang: Add missing function to libclang.map

tstellar created this revision. tstellar added a reviewer: jrtc27. tstellar requested review of this revision. Herald added a project: clang. This function is marked with CINDEX_LINKAGE, but was never added to the export list / linker script. Repository: rG LLVM Github Monorepo https://review

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

tstellar added a comment. Can you let me know if D106974 fixes the problem? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105527/new/ https://reviews.llvm.org/D105527

[PATCH] D106974: libcang: Add missing function to libclang.map

tstellar updated this revision to Diff 362439. tstellar added a comment. Add missing ; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106974/new/ https://reviews.llvm.org/D106974 Files: clang/tools/libclang/libclang.map Index: clang/tools/libcl

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

dblaikie added a comment. In D106394#2910571 , @cjdb wrote: > In D106394#2905660 , @dblaikie > wrote: > >> Just a thought (nothing to hold up this patch/suggest a revert/suggest any >> immediate action), but: >>

[PATCH] D106756: Added l16/l32 length modifiers for char16_t/char32_t

MarcusJohnson91 updated this revision to Diff 362444. MarcusJohnson91 added a comment. Added a couple tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106756/new/ https://reviews.llvm.org/D106756 Files: clang/include/clang/AST/FormatString.h clang/lib/AST/FormatString.cpp clan

[PATCH] D104854: Introduce intrinsic llvm.isnan

sepavloff added a comment. In D104854#2905430 , @efriedma wrote: > In D104854#2904826 , @sepavloff > wrote: > >> In D104854#2886328 , @efriedma >> wrote: >> The opt

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

gandhi21299 updated this revision to Diff 362433. gandhi21299 added a comment. - added more tests with supported combinations of address spaces - minor nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106909/new/ https://reviews.llvm.org/D106909

[PATCH] D106899: [LLVM][NFC] Remove LLVM_ATTRIBUTE_NORETURN and use [[noreturn]] directly

gAlfonso-bit updated this revision to Diff 362437. gAlfonso-bit added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106899/new/ https://reviews.llvm.org/D106899 Files: clang-tools-extra/pp-trace/PPTrace.cpp clang/utils/TableGen/ClangDiagnosticsEmitter.cpp flang

[PATCH] D106899: [LLVM][NFC] Remove LLVM_ATTRIBUTE_NORETURN and use [[noreturn]] directly

gAlfonso-bit added a comment. In D106899#2910655 , @MaskRay wrote: > I migrated all llvm/ files. You need to remove them from the patch. > > It is a good idea to drop the macro definition in > `llvm/include/llvm/Support/Compiler.h` separately. > > It mak

[PATCH] D106755: Extended format string checking to wprintf/wscanf

MarcusJohnson91 updated this revision to Diff 362446. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106755/new/ https://reviews.llvm.org/D106755 Files: clang-tools-extra/clang-tidy/boost/UseToStringCheck.cpp clang-tools-extra/clang-tidy/misc/ThrowByValueCatchByReferenceCheck.cpp cl

[clang] 71f0359 - Simplify allowing pragma float_control in a linkage specification

Author: Aaron Ballman Date: 2021-07-28T13:29:41-04:00 New Revision: 71f0359a9defbf3e35828189629f166508390d5d URL: https://github.com/llvm/llvm-project/commit/71f0359a9defbf3e35828189629f166508390d5d DIFF: https://github.com/llvm/llvm-project/commit/71f0359a9defbf3e35828189629f166508390d5d.diff

[PATCH] D106785: [C++4OpenCL] Introduces __remove_address_space utility

Anastasia added a subscriber: rjmccall. Anastasia added a comment. The patch looks good but I would like to check with @rjmccall whether it would make sense to add this functionality generically for C/C++ too just like `__remove_const` and other builtins proposed in https://reviews.llvm.org/D670

[PATCH] D106974: libcang: Add missing function to libclang.map

jrtc27 accepted this revision. jrtc27 added a comment. This revision is now accepted and ready to land. Thanks; I can confirm the test passes if and only if I apply this patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106974/new/ https://review

[PATCH] D106674: Runtime for Interop directive

tianshilei1992 added inline comments. Comment at: openmp/libomptarget/src/interop.cpp:13 +static omp_interop_rc_t +__kmpc_interop_get_property_err_type(omp_interop_property_t property) { + switch (property) { tianshilei1992 wrote: > There are some conventions in

[PATCH] D99381: [compiler-rt][hwasan] Remove __sanitizer allocation functions from hwasan interface

vitalybuka added a comment. In D99381#2908102 , @vitalybuka wrote: > @eugenis Why do we have them in here and in sanitizer/hwasan_interface.h ? And if we don't need them in sanitizer/hwasan_interface.h and interface_internal, SANITIZER_INTERFACE_ATTRIB

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

ye-luo added a comment. Do I must use llvm-ar/ranlib or system ar/ranlib is OK? 1. existing use case breaks Use https://github.com/ye-luo/openmp-target/blob/master/tests/math/modf.cpp $ clang++ -fopenmp -fopenmp-targets=nvptx64 -Xopenmp-target=nvptx64 -march=sm_80 modf.cpp # still OK $ clang+

[PATCH] D106898: Revert "Revert "[clang][pp] adds '#pragma include_instead'""

cjdb updated this revision to Diff 362479. cjdb added a comment. - attempts to get CI passing (@aaron.ballman) - minimises test case (@hans) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106898/new/ https://reviews.llvm.org/D106898 Files: clang/

[PATCH] D99381: [compiler-rt][hwasan] Remove __sanitizer allocation functions from hwasan interface

eugenis added a comment. They are used here: https://cs.android.com/android/platform/superproject/+/master:bionic/libc/bionic/malloc_common.h;l=54;drc=f3968e89cb72400951f93a2a8237ac1428d2627c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99381/new/

[clang] 828767f - COFF/ELF: Place llvm.global_ctors elements in llvm.used if comdat is used

Author: Fangrui Song Date: 2021-07-28T11:44:19-07:00 New Revision: 828767f325b5dd0356c5fd90e40a1c047010853e URL: https://github.com/llvm/llvm-project/commit/828767f325b5dd0356c5fd90e40a1c047010853e DIFF: https://github.com/llvm/llvm-project/commit/828767f325b5dd0356c5fd90e40a1c047010853e.diff

[PATCH] D106925: COFF/ELF: Place llvm.global_ctors elements in llvm.used if comdat is used

This revision was automatically updated to reflect the committed changes. Closed by commit rG828767f325b5: COFF/ELF: Place llvm.global_ctors elements in llvm.used if comdat is used (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D106732: Support macro deprecation #pragma clang deprecated

aaron.ballman added inline comments. Comment at: clang/test/Lexer/deprecate-macro.c:34-39 +#ifdef foo +#endif + +// expected-warning@+1{{macro 'foo' has been marked as deprecated}} +#ifndef foo +#endif Some more test cases to add: ``` // Test that we diagnose on

[PATCH] D106924: [Preprocessor] -E -P: Ensure newline after 8 skipped lines.

mstorsjo added a subscriber: tstellar. mstorsjo added a comment. @Meinersbur After landing this, can you coordinate with @tstellar to get an ack for backporting this to the 13.x release branch, which also suffers from the regression? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D104854: Introduce intrinsic llvm.isnan

RKSimon added inline comments. Comment at: llvm/test/CodeGen/X86/x86-fpclass.ll:173 + +define <1 x i1> @isnan_double_vec1(<1 x double> %x) { +; CHECK-32-LABEL: isnan_double_vec1: add nounwind to reduce cfi noise (other tests would benefit as well)?

  1   2   >