aaron.ballman added a comment. Generally LGTM, but the CI is failing.
================ Comment at: clang/test/PCH/ms-pch-macro-include_instead-regression.c:3 +// RUN: %clang_cc1 -DMSEXT -fms-extensions -DFOO %S/variables.h -DBAZ=\"Inputs/pch-through1.h\" -emit-pch -o %t1.pch +// RUN: %clang_cc1 -DMSEXT -fms-extensions -include-pch %t1.pch -DBAR=int -pch-through-header=%S/variables.h -verify %s + ---------------- This is getting a shell parse error on Windows according to the CI runner. I suspect you need to quote the `-pch-through-header=` argument. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106898/new/ https://reviews.llvm.org/D106898 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
