[PATCH] D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String

MarcusJohnson91 added a comment. I don't understand why the build failed? I've compiled it and ran all the tests with `time ninja check` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106753/new/ https://reviews.llvm.org/D106753 ___ cfe-commi

[PATCH] D106349: [clang-format] respect AfterEnum for enums

m1cha updated this revision to Diff 361493. m1cha added a comment. I've added a note to `ReleaseNotes.rst` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106349/new/ https://reviews.llvm.org/D106349 Files: clang/docs/ReleaseNotes.rst clang/lib/Format/UnwrappedLineParser.cpp clang/

[PATCH] D106757: [PowerPC] Implement partial vector ld/st builtins for XL compatibility

nemanjai added a comment. In D106757#2902849 , @Conanap wrote: > do we need an IR -> ASM test case as well? I didn't add this as the builtins do not produce any new IR - there are no new intrinsics or any other modifications to the back end. Since the c

[PATCH] D106401: [CUDA, MemCpyOpt] Add a flag to force-enable memcpyopt and use it for CUDA.

nikic added a comment. Would the variant of the original patch at D106769 be sufficient for your purposes? Or are you also interested in the optimizations that introduce new memset/memcpy? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String

efriedma added a comment. Please fix clang-format issues. (You can use the clang-format-diff.py script.) Comment at: llvm/lib/Support/ConvertUTFWrapper.cpp:154 + // Error out on an uneven byte count. + if (SrcBytes.size() % 2) +return false; Wrong consta

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:3800 + FormatStyle Style = getLLVMStyle(); + Style.BreakBeforeInlineASMColon = true; verifyFormat( I already gave my go in the past, but now I have to wonder, why are

[PATCH] D105320: [CodeView] Saturate values bigger than supported by APInt.

mizvekov updated this revision to Diff 361527. mizvekov marked an inline comment as done. mizvekov added a comment. - rebase on top of D106585 - Reimplement test based on IR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String

MarcusJohnson91 marked 3 inline comments as done. MarcusJohnson91 added inline comments. Comment at: llvm/lib/Support/ConvertUTFWrapper.cpp:168 + std::vector ByteSwapped; + if (Src[0] == UNI_UTF16_BYTE_ORDER_MARK_SWAPPED) { +ByteSwapped.insert(ByteSwapped.end(), Src, SrcEnd

[PATCH] D106773: [clang-format] Fix aligning with linebreaks #2

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, baramin. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This amend

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

HazardyKnusperkeks added a comment. In D98214#2901304 , @baramin wrote: > This is true. > .clang-format: > > Language:Cpp > AlignConsecutiveAssignments: Consecutive > BinPackArguments: false > BinPackParameters: false > ColumnLimit:

[PATCH] D106755: Extended format string checking to wprintf/wscanf

MarcusJohnson91 updated this revision to Diff 361534. MarcusJohnson91 added a comment. Herald added subscribers: llvm-commits, dexonsmith, hiraditya. Herald added a project: LLVM. Implemented the fixes mentioned and reformatted the patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1067

[PATCH] D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String

MarcusJohnson91 updated this revision to Diff 361535. MarcusJohnson91 marked an inline comment as done. MarcusJohnson91 added a comment. Implemented the fixes mentioned and reformatted the patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106753/new/ https://reviews.llvm.org/D106753

[PATCH] D106755: Extended format string checking to wprintf/wscanf

MarcusJohnson91 updated this revision to Diff 361538. MarcusJohnson91 added a comment. Clang-formatted the diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106755/new/ https://reviews.llvm.org/D106755 Files: clang-tools-extra/clang-tidy/boost/UseToStringCheck.cpp clang-tools-ext

[PATCH] D106756: Added l16/l32 length modifiers for char16_t/char32_t

MarcusJohnson91 updated this revision to Diff 361539. MarcusJohnson91 added a comment. Clang-formatted the diff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106756/new/ https://reviews.llvm.org/D106756 Files: clang/include/clang/AST/FormatString.h clang/lib/AST/FormatString.cpp I

[PATCH] D103426: Clang: Extend format string checking to wprintf/wscanf

MarcusJohnson91 marked 5 inline comments as done. MarcusJohnson91 added inline comments. Comment at: clang/lib/AST/Expr.cpp:1091 + if (llvm::convertUTF32ToUTF8String(AR, Output)) { +CString = new char[Output.size() + 1]; +memcpy(CString, Output.c_str(), Outpu

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

mizvekov added a comment. If you think landing this in 13 after the release branch is created will be complicated, then please consider this message a gentle **Ping** :) Frankly, I am satisfied with the mechanics of this workaround as is. - After another look, I think doing something more targe

[PATCH] D105320: [CodeView] Saturate values bigger than supported by APInt.

mizvekov updated this revision to Diff 361543. mizvekov marked 4 inline comments as done. mizvekov added a comment. - Expose and use APInt::isSingleWord. - Use ApInt::getLimitedValue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105320/new/ https:

[PATCH] D105320: [CodeView] Saturate values bigger than supported by APInt.

mizvekov updated this revision to Diff 361547. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105320/new/ https://reviews.llvm.org/D105320 Files: llvm/include/llvm/ADT/APInt.h llvm/include/llvm/IR/DIBuilder.h llvm/

[PATCH] D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String

MarcusJohnson91 added a comment. Anyone got any ideas what happened this time? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106753/new/ https://reviews.llvm.org/D106753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D106757: [PowerPC] Implement partial vector ld/st builtins for XL compatibility

Conanap accepted this revision. Conanap added a comment. This revision is now accepted and ready to land. Thanks for answering the Qs. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106757/new/ https://reviews.llvm.org/D106757 ___

[PATCH] D106111: opencl-c.h: add initial CL 3.0 conditionals for atomic operations.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9451403c5f8c: [OPENCL] opencl-c.h: add initial CL 3.0 conditionals for atomic operations. (authored by airlied). Changed prior to commit: https://

[clang] 9451403 - [OPENCL] opencl-c.h: add initial CL 3.0 conditionals for atomic operations.

Author: Dave Airlie Date: 2021-07-26T11:06:33+10:00 New Revision: 9451403c5f8c70c2ef022bd721db2b1c452eac79 URL: https://github.com/llvm/llvm-project/commit/9451403c5f8c70c2ef022bd721db2b1c452eac79 DIFF: https://github.com/llvm/llvm-project/commit/9451403c5f8c70c2ef022bd721db2b1c452eac79.diff L

[PATCH] D103426: Clang: Extend format string checking to wprintf/wscanf

tahonermann added inline comments. Comment at: clang/lib/AST/Type.cpp:1962 +bool Type::isType(const std::string TypeName) const { + QualType Desugar = this->getLocallyUnqualifiedSingleStepDesugaredType(); MarcusJohnson91 wrote: > efriedma wrote: > > MarcusJohn

[PATCH] D105555: [RISCV][Clang] Compute the default target-abi if it's empty.

khchen updated this revision to Diff 361568. khchen marked 6 inline comments as done. khchen added a comment. address @jrtc27's comment, thanks again! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10/new/ https://reviews.llvm.org/D10 Files

[PATCH] D100768: [Clang][OpenMP] Remove the mandatory flush for capture for OpenMP 5.1

tianshilei1992 added a comment. @ABataev I updated the description. If you agree with my understanding, I'll land it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100768/new/ https://reviews.llvm.org/D100768 _

[PATCH] D100768: [Clang][OpenMP] Remove the mandatory flush for capture for OpenMP 5.1

ABataev added a comment. In D100768#2903520 , @tianshilei1992 wrote: > @ABataev I updated the description. If you agree with my understanding, I'll > land it. Still LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D106778: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics

airlied created this revision. airlied added a project: clang. Herald added subscribers: ldrumm, jfb, Anastasia, yaxunl. airlied requested review of this revision. Herald added a subscriber: cfe-commits. CL 2.0 interdocued atomics and generic address space so there were only one set of APIs for do

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

Jim added a comment. @jrtc27 Any more feedback? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95588/new/ https://reviews.llvm.org/D95588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang] ae6b400 - [Preprocessor] Implement -fminimize-whitespace.

Author: Michael Kruse Date: 2021-07-25T23:30:57-05:00 New Revision: ae6b4238e5f319ffcfc713a15e459be8 URL: https://github.com/llvm/llvm-project/commit/ae6b4238e5f319ffcfc713a15e459be8 DIFF: https://github.com/llvm/llvm-project/commit/ae6b4238e5f319ffcfc713a15e459be8.diff

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae6b4238: [Preprocessor] Implement -fminimize-whitespace. (authored by Meinersbur). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD added a comment. In D105821#2897006 , @NoQ wrote: >> the following code doesn't emit any warnings > > This code doesn't seem to have any `unique_ptr`s in it? It's not like you're > modeling this custom class as well? Can you try the same with th

[PATCH] D106739: [analyzer] Add option to SATest.py for extra checkers

RedDocMD added a comment. @vsavchenko is this okay? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106739/new/ https://reviews.llvm.org/D106739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String

efriedma added a comment. The buildbot seems to think your new unittests are broken. Not sure why. (You can run just the unittests with "ninja check-llvm-unit".) Comment at: llvm/include/llvm/Support/ConvertUTF.h:127 +#define UNI_UTF32_BYTE_ORDER_MARK_NATIVE 0xFEFF +#def

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD updated this revision to Diff 361581. RedDocMD added a comment. Removed a fatal bug Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105821/new/ https://reviews.llvm.org/D105821 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables with enum judgement

Sockke added a comment. In D106431#2896472 , @whisperity wrote: > In D106431#2896441 , @aaron.ballman > wrote: > >> However, I don't recall how clang-tidy interacts with fix-its on notes off >> the top of my he