[PATCH] D105692: [analyzer][solver][NFC] Introduce ConstraintAssignor

uabelho added a comment. Hi, When compiling with gcc I see the following new warnings with this patch: [4/22] Building CXX object tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/RangeConstraintManager.cpp.o /repo/uabelho/master-github/clang/lib/StaticAnalyzer

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

vsavchenko added a comment. In D103096#2877818 , @ASDenysPetrov wrote: > Made `ignoreCast` non-virtual. > P.S. IMO, this change is not something that can be taken as a pattern, > though. It is already a pattern in other type hierarchies. Virtual funct

[clang] b0d38ad - [clang][Analyzer] Add symbol uninterestingness to bug report.

Author: Balázs Kéri Date: 2021-07-15T10:02:18+02:00 New Revision: b0d38ad0bc254b887123cd063a5f0db30a80f938 URL: https://github.com/llvm/llvm-project/commit/b0d38ad0bc254b887123cd063a5f0db30a80f938 DIFF: https://github.com/llvm/llvm-project/commit/b0d38ad0bc254b887123cd063a5f0db30a80f938.diff L

[PATCH] D105637: [clang][Analyzer] Add symbol uninterestingness to bug report.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb0d38ad0bc25: [clang][Analyzer] Add symbol uninterestingness to bug report. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov added a comment. @vsavchenko > It is already a pattern in other type hierarchies. I just rarely met them. And it was hard to me reading the code searching for implementation all over the places. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive

[PATCH] D104925: [Analyzer] Improve report of file read at end-of-file condition.

balazske marked 4 inline comments as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:419-421 + const CheckerNameRef CheckerName; + SymbolRef StreamSym; + const ExplodedNode *NotePosition; balazske wrote: >

[PATCH] D105384: [NVPTX, CUDA] Add .and.popc variant of the b1 MMA instruction.

steffenlarsen accepted this revision. steffenlarsen added a comment. LGTM! Are the test failures related to this, you reckon? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105384/new/ https://reviews.llvm.org/D105384 __

[PATCH] D106044: [RISCV] Update to vcpop.m, vlm.v and vsm.v according to v1.0-rc1.

rogfer01 added a comment. I'm confused because the PDF at https://github.com/riscv/riscv-v-spec/releases/tag/v1.0-rc1 doesn't seem to describe `vcpop.m`. I can see this has changed in the ToT https://github.com/riscv/riscv-v-spec/blob/master/v-spec.adoc#changes-from-v1-0-rc1 Perhaps this wi

[PATCH] D103849: Fix undeduced type when instanciating template member

This revision was automatically updated to reflect the committed changes. Closed by commit rG4b219051a331: Fix undeduced type assert (authored by serge-sans-paille). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103849/

[clang] 4b21905 - Fix undeduced type assert

Author: serge-sans-paille Date: 2021-07-15T10:52:25+02:00 New Revision: 4b219051a331d49c391fe452548bc220bcfe8ea3 URL: https://github.com/llvm/llvm-project/commit/4b219051a331d49c391fe452548bc220bcfe8ea3 DIFF: https://github.com/llvm/llvm-project/commit/4b219051a331d49c391fe452548bc220bcfe8ea3.d

[PATCH] D105974: [analyzer] Do not assume that all pointers have the same bitwidth as void*

vabridgers updated this revision to Diff 358869. vabridgers added a comment. update test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105974/new/ https://reviews.llvm.org/D105974 Files: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp clang

[PATCH] D106044: [RISCV] Update to vcpop.m, vlm.v and vsm.v according to v1.0-rc1.

HsiangKai added a comment. In D106044#2879361 , @rogfer01 wrote: > I'm confused because the PDF at > https://github.com/riscv/riscv-v-spec/releases/tag/v1.0-rc1 doesn't seem to > describe `vcpop.m`. > > I can see this has changed in the ToT > https:/

[PATCH] D106049: [RISCV] Update to vfredusum.vs and vfwredusum.vs according to v1.0-rc1.

frasercrmck added a comment. Duplicate of D105690 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106049/new/ https://reviews.llvm.org/D106049 ___ cfe-commits mailing li

[PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I'm really sorry, I don't understand what kind of review is expected here given the state of this patch. - The patch **still** doesn't include the tests that I asked for in my

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

kadircet added a comment. In D105904#2877281 , @dgoldman wrote: > Yep, I can you send you some searches internally with how prevalent they are. Thanks! > I don't think this an Xcode limitation really - more of an LSP spec > limitation. If we create a g

[PATCH] D105553: [analyzer][NFC] Split the main logic of NoStoreFuncVisitor to an abstract NoStateChangeVisitor class

Szelethus updated this revision to Diff 358876. Szelethus marked 3 inline comments as done. Szelethus added a comment. - Change parameter names to highlight that the node at the end of the function call is a `CallExitBegin`. - Change individual parameter callbacks to the entire call -- if a clien

[PATCH] D105553: [analyzer][NFC] Split the main logic of NoStoreFuncVisitor to an abstract NoStateChangeVisitor class

Szelethus added a comment. In D105553#2867881 , @NoQ wrote: > In the mailing list I seem to have made a mistake about how this works: we > don't explicitly scan the AST for potential statements that could cause a > state change (eg., assignment operator

[PATCH] D105819: [analyzer] MallocChecker: Add a visitor to leave a note on functions that could have, but did not change ownership on leaked memory

Szelethus updated this revision to Diff 358883. Szelethus added a comment. - Fixes according to reviewer comments! - Rebase on D105553 . - Primitively check whether the allocated memory was actually passed into the function. CHANGES SINCE LAST ACTION https://

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 358884. fmayer marked 7 inline comments as done. fmayer added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/Ba

[PATCH] D105819: [analyzer] MallocChecker: Add a visitor to leave a note on functions that could have, but did not change ownership on leaked memory

Szelethus marked 2 inline comments as done. Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:801 +// must be a superset of, but not necessarily equal to ExitOwners. +return !llvm::set_is_subset(ExitOwners, CurrOwners); + }

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer added a comment. Thanks! Comment at: clang/test/CodeGen/hwasan-stack-safety-analysis-asm.c:4 + +int main(int argc, char **argv) { + char buf[10]; vitalybuka wrote: > fmayer wrote: > > vitalybuka wrote: > > > this patch mostly change code under llvm/ so

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 358885. fmayer added a comment. fixup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/include/llvm/Transforms/Instrum

[PATCH] D105629: [TSan] Add SystemZ support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGacf0a6428681: [sanitizer] Fix __sanitizer_kernel_sigset_t endianness issue (authored by iii). Changed prior to commit: https://reviews.llvm.org/D1

[clang] e34078f - [TSan] Enable SystemZ support

Author: Ilya Leoshkevich Date: 2021-07-15T12:18:48+02:00 New Revision: e34078f121a58b503d225cf715d1494117e7948b URL: https://github.com/llvm/llvm-project/commit/e34078f121a58b503d225cf715d1494117e7948b DIFF: https://github.com/llvm/llvm-project/commit/e34078f121a58b503d225cf715d1494117e7948b.di

[PATCH] D105988: [OpenCL] NULL introduced prior to v2.0

Anastasia added inline comments. Comment at: clang/lib/Headers/opencl-c-base.h:167 -#if defined(__OPENCL_CPP_VERSION__) || (__OPENCL_C_VERSION__ >= CL_VERSION_2_0) +#if defined(__OPENCL_CPP_VERSION__) || defined(__OPENCL_C_VERSION__) #define NULL ((void*)0) I

[PATCH] D105987: [C++4OpenCL] NULL redefined as nullptr

Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/null_literal.cl:2 +// RUN: %clang_cc1 -fdeclare-opencl-builtins -finclude-default-header -verify %s +// RUN: %clang_cc1 -cl-std=CL1.0 -fdeclare-opencl-builtins -finclude-default-header -verify %s +// RUN: %clang

[PATCH] D103191: [OpenCL] Add support of __opencl_c_program_scope_global_variables feature macro

azabaznov updated this revision to Diff 358909. azabaznov added a comment. Restructured test a little Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103191/new/ https://reviews.llvm.org/D103191 Files: clang/include/clang/Basic/OpenCLOptions.h c

[PATCH] D105973: [ASTMatchers] NFC: Fix the annotation.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thank you for the fix! Do you need me to commit it on your behalf? If so, what name and email address would you like me to use for patch attribution? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105973/new/ htt

[PATCH] D105988: [OpenCL] NULL introduced prior to v2.0

Topotuna updated this revision to Diff 358911. Topotuna added a comment. Full diff now added. Redundant condition `#if` removed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105988/new/ https://reviews.llvm.org/D105988 Files: clang/lib/Headers/opencl-c-base.h clang/test/SemaOpenCL/

[PATCH] D105988: [OpenCL] NULL introduced prior to v2.0

Topotuna marked 2 inline comments as done. Topotuna added inline comments. Comment at: clang/test/SemaOpenCL/null_literal.cl:7 #define NULL ((void*)0) Anastasia wrote: > Anastasia wrote: > > I think we should remove this `NULL` definition but instead add >

[PATCH] D105660: [PowerPC][AIX] Add warning when alignment is incompatible with XL

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3255-3256 +def warn_not_xl_compatible +: Warning<"requested alignment of arguments 16 bytes or greater is not" + " compatible with previous versions of the AIX XL co

[PATCH] D105257: [clang][darwin] add support for remapping macOS availability to Mac Catalyst availability

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Comment at: clang/lib/Sema/Sema.cpp:63 + StringRef Platform) { + if (!CachedDarwinSDKInfo) { +auto SDKInfo = parseDarwinSDKInfo( dexonsm

[PATCH] D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL.

stefanp updated this revision to Diff 358915. stefanp added a comment. Sorry for letting this patch sit for so long. I have updated the tests to simplify them so that we only include the intrinsics (As per a comment). This reduces quite a bit of clutter. Added Sema Checking for the builtins that

[PATCH] D106049: [RISCV] Update to vfredusum.vs and vfwredusum.vs according to v1.0-rc1.

HsiangKai abandoned this revision. HsiangKai added a comment. In D106049#2879422 , @frasercrmck wrote: > Duplicate of D105690 ? I didn't aware of it. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D105973: [ASTMatchers] NFC: Fix the annotation.

Sockke added a comment. I would appreciate it if you could submit it on my behalf. Thanks a lot! Name: liuke Email: liuke.ge...@bytedance.com CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105973/new/ https://reviews.llvm.org/D105973 ___ cfe-

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

sammccall added a comment. In D105904#2877184 , @kadircet wrote: > So first of all, it is not clear to me if this is a useful enough improvement > to justify all the new code, but looking at your investment I'll assume this > is really common in ObjC la

[PATCH] D105819: [analyzer] MallocChecker: Add a visitor to leave a note on functions that could have, but did not change ownership on leaked memory

Szelethus updated this revision to Diff 358927. Szelethus marked an inline comment as done. Szelethus added a comment. - Fix testfiles. - Fix a typo in the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105819/new/ https://reviews.llvm.org/D105819 Files: clang/lib/StaticAnal

[PATCH] D105819: [analyzer] MallocChecker: Add a visitor to leave a note on functions that could have, but did not change ownership on leaked memory

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:801 +// must be a superset of, but not necessarily equal to ExitOwners. +return !llvm::set_is_subset(ExitOwners, CurrOwners); + } Szelethus wrote: > NoQ wrot

[PATCH] D105660: [PowerPC][AIX] Add warning when alignment is incompatible with XL

ZarkoCA updated this revision to Diff 358934. ZarkoCA added a comment. - Fix formatting in test case - Reword warning message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105660/new/ https://reviews.llvm.org/D105660 Files: clang/include/clang/B

[PATCH] D105660: [PowerPC][AIX] Add warning when alignment is incompatible with XL

ZarkoCA marked 2 inline comments as done. ZarkoCA added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3255-3256 +def warn_not_xl_compatible +: Warning<"requested alignment of arguments 16 bytes or greater is not" + " compatible wit

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

kadircet added a comment. > However those difficulties don't apply here - I believe you can take the > current final representation (vector) + the list of marks and > produce a markified vector via a fairly natural tree walk. > And this does a *really* good job of isolating this feature - we li

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos added a comment. @tlively once D105423 lands, is it enough to test and reland it under this revision or shall i open a new one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104797/new/ https://reviews.llv

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

lei added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:1569 + def int_ppc_sthcx : Intrinsic<[llvm_i32_ty], [llvm_ptr_ty, llvm_i32_ty], [IntrWriteMem]>; + def int_ppc_lharx : GCCBuiltin<"__builtin_ppc_lharx">, + Intrinsic<[llvm_i32

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

lei added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:3371 +return SemaFeatureCheck(*this, TheCall, "extdiv", +diag::err_ppc_builtin_only_on_arch, "8"); #define CUSTOM_BUILTIN(Name, Intr, Types, Acc) \ need tests

[clang] 034b94b - Fix documentation; NFC

Author: liuke Date: 2021-07-15T09:38:05-04:00 New Revision: 034b94bb7161c64234e4ec35bf49428c3a1f8f0a URL: https://github.com/llvm/llvm-project/commit/034b94bb7161c64234e4ec35bf49428c3a1f8f0a DIFF: https://github.com/llvm/llvm-project/commit/034b94bb7161c64234e4ec35bf49428c3a1f8f0a.diff LOG: Fi

[PATCH] D105973: [ASTMatchers] NFC: Fix the annotation.

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the patch! I've commit on your behalf in 034b94bb7161c64234e4ec35bf49428c3a1f8f0a . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105973

[PATCH] D106063: [Analyzer][solver] Remove unused functions

martong created this revision. martong added a reviewer: vsavchenko. Herald added subscribers: manas, steakhal, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus. mar

[PATCH] D105692: [analyzer][solver][NFC] Introduce ConstraintAssignor

martong added a comment. In D105692#2879186 , @uabelho wrote: > Hi, > > When compiling with gcc I see the following new warnings with this patch: > > [4/22] Building CXX object > tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCor

[PATCH] D104744: [PowerPC] Add PowerPC rotate related builtins and emit target independent code for XL compatibility

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM other than a couple of nits. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15064 } + case PPC::BI__builtin_ppc_rldimi: + case PPC::BI__builtin_ppc_rlwimi: { -

[PATCH] D106064: [clang][deps] Normalize paths in minimizing file system

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 added a project: clang. jansvoboda11 requested review of this revision. This patch normalizes paths in `DependencyScanningWorkerFilesystem` so that lookup of ignored files and cached fi

[PATCH] D104536: WIP: [clang][deps] Avoid minimizing PCH input files

jansvoboda11 updated this revision to Diff 358951. jansvoboda11 edited the summary of this revision. jansvoboda11 set the repository for this revision to rG LLVM Github Monorepo. jansvoboda11 added a comment. Rebase on top of D106064 , solving Windows CI failure.

[PATCH] D106063: [Analyzer][solver] Remove unused functions

vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. Yes, let's do this! Thanks for addressing it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106063/new/ https://reviews.llvm.org/D10606

[PATCH] D105692: [analyzer][solver][NFC] Introduce ConstraintAssignor

uabelho added a comment. In D105692#2879983 , @martong wrote: > In D105692#2879186 , @uabelho wrote: > >> Hi, >> >> When compiling with gcc I see the following new warnings with this patch: >> >> [4/22] Building

[PATCH] D105660: [PowerPC][AIX] Add warning when alignment is incompatible with XL

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3255-3256 +def warn_not_xl_compatible +: Warning<"requested alignment of argum

[clang] f24335c - MachO: fix Clang test broken by dropping private labels in LLVM.

Author: Tim Northover Date: 2021-07-15T15:05:08+01:00 New Revision: f24335c69ea363082d922797363e98f1dcb3b14f URL: https://github.com/llvm/llvm-project/commit/f24335c69ea363082d922797363e98f1dcb3b14f DIFF: https://github.com/llvm/llvm-project/commit/f24335c69ea363082d922797363e98f1dcb3b14f.diff

[PATCH] D105083: [clangd] Ensure Ref::Container refers to an indexed symbol

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! sorry for the late reply :( adding a couple nits. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:170 + while (Enclosing) { +const Named

[clang] 05eb59e - [OpenCL] Add support of __opencl_c_program_scope_global_variables feature macro

Author: Anton Zabaznov Date: 2021-07-15T17:21:19+03:00 New Revision: 05eb59e1d0ea7505539434a32ccc5c3dc2097597 URL: https://github.com/llvm/llvm-project/commit/05eb59e1d0ea7505539434a32ccc5c3dc2097597 DIFF: https://github.com/llvm/llvm-project/commit/05eb59e1d0ea7505539434a32ccc5c3dc2097597.diff

[PATCH] D103191: [OpenCL] Add support of __opencl_c_program_scope_global_variables feature macro

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG05eb59e1d0ea: [OpenCL] Add support of __opencl_c_program_scope_global_variables feature macro (authored by azabaznov). Repository: rG LLVM Github

[clang] d0d37fc - [Analyzer][solver] Remove unused functions

Author: Gabor Marton Date: 2021-07-15T16:36:01+02:00 New Revision: d0d37fcc4e2965c4ccd3401f8bdf22935815136a URL: https://github.com/llvm/llvm-project/commit/d0d37fcc4e2965c4ccd3401f8bdf22935815136a DIFF: https://github.com/llvm/llvm-project/commit/d0d37fcc4e2965c4ccd3401f8bdf22935815136a.diff

[PATCH] D106063: [Analyzer][solver] Remove unused functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd0d37fcc4e29: [Analyzer][solver] Remove unused functions (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D106065: [Clang] Add an empty builtins.h file.

stefanp created this revision. stefanp added reviewers: nemanjai, lei. Herald added a subscriber: mgorny. stefanp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. On Power PC some legacy compilers included a number of builtins in a builtins.

[PATCH] D103938: Diagnose -Wunused-value in constant evaluation context

aaron.ballman added inline comments. Comment at: clang/include/clang/Sema/Sema.h:5077 + /// Conditionally issue a diagnostic based on the statements reachability + /// analysis evaluation context. Comment at: clang/test/Sema/i-c-e.c:77-78

[PATCH] D106069: [HIP] Add test with_fopenmp.hip

yaxunl created this revision. yaxunl added reviewers: tra, ashi1. Herald added subscribers: guansong, mgorny. yaxunl requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Add a test to test-suite for testing std::isnan in host and device functi

[PATCH] D106070: [HIP] Remove workaround in __clang_hip_runtime_wrapper.h

yaxunl created this revision. yaxunl added reviewers: tra, JonChesterfield, ronl, ashi1. yaxunl requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Remove the workaround for -fopenmp in __clang_hip_runtime_wrapper.h since it causes device fun

[PATCH] D104420: thread_local support for AIX

jamieschmeiser updated this revision to Diff 358974. jamieschmeiser added a comment. Respond to review comments, formatting: fix comments, add assertion, fix linkage, expand test to include body of generated function. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104420/new/ https://rev

[PATCH] D106070: [HIP] Remove workaround in __clang_hip_runtime_wrapper.h

yaxunl added a comment. Since this is not easily tested with lit tests, I added a test to llvm-test-suite: https://reviews.llvm.org/D106069 My understanding is that OpenMP no longer uses __clang_hip_runtime_wrapper.h, so we should be able to remove this workaround. CHANGES SINCE LAST ACTION

[clang] d40e809 - [PowerPC] Add PowerPC rotate related builtins and emit target independent code for XL compatibility

Author: Victor Huang Date: 2021-07-15T10:23:54-05:00 New Revision: d40e8091bd1f48e8d3f64e4f99952f0139e9c27b URL: https://github.com/llvm/llvm-project/commit/d40e8091bd1f48e8d3f64e4f99952f0139e9c27b DIFF: https://github.com/llvm/llvm-project/commit/d40e8091bd1f48e8d3f64e4f99952f0139e9c27b.diff

[PATCH] D104744: [PowerPC] Add PowerPC rotate related builtins and emit target independent code for XL compatibility

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd40e8091bd1f: [PowerPC] Add PowerPC rotate related builtins and emit target independent code… (authored by NeHuang). Changed prior to commit: http

[PATCH] D105909: [clang][CallGraphSection] Add type id metadata to indirect call and targets

necipfazil added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2068 +EmittedMDIdGeneralized = true; + } + morehouse wrote: > This code also seems unnecessary as it puts metadata on function definitions. We need the metadata for mapping ind

[PATCH] D105909: [clang][CallGraphSection] Add type id metadata to indirect call and targets

necipfazil updated this revision to Diff 358996. necipfazil added a comment. - rebase - add C struct parameter test - add C++ tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105909/new/ https://reviews.llvm.org/D105909 Files: clang/lib/CodeG

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD updated this revision to Diff 358998. RedDocMD added a comment. Removed one bug, many more to go Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105821/new/ https://reviews.llvm.org/D105821 Files: clang/lib/StaticAnalyzer/Checkers/SmartPt

[PATCH] D106074: [AIX] Emit unsupported 128-bit long double option for AIX

anjankgk created this revision. anjankgk added reviewers: daltenty, Whitney, hubert.reinterpretcast. anjankgk requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. AIX currently doesn't support the 128-bit long double. Repository: rG LLVM Git

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 359001. dgoldman added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/

[PATCH] D106044: [RISCV] Update to vlm.v and vsm.v according to v1.0-rc1.

craig.topper added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vse.c:1182 +void test_vsm_v_b1(uint8_t *base, vbool1_t value, size_t vl) { return vse1(base, value, vl); } Was the call supposed to be renamed or just the test

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov updated this revision to Diff 359007. ASDenysPetrov edited the summary of this revision. ASDenysPetrov added a comment. Improved `ignoreCasts` implementation. Adapted to `ConstraintAssignor`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103096/new/ https://reviews.llvm.or

[PATCH] D105907: [CallGraphSection] Add call graph section options and documentation

necipfazil updated this revision to Diff 359010. necipfazil marked 2 inline comments as done. necipfazil added a comment. - test new clang flags - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105907/new/ https://reviews.llvm.org/D105907 Fi

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1908-1912 +// Handle SymbolCast before actual assignment. +std::tie(Sym, NewConstraint) = +modifySymbolAndConstraints(Sym, NewConstraint); +if (!State) +

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman added a comment. In D105904#2879445 , @kadircet wrote: > In D105904#2877281 , @dgoldman > wrote: > >> Yep, I can you send you some searches internally with how prevalent they are. > > Thanks! > >> I don'

[PATCH] D106070: [HIP] Remove workaround in __clang_hip_runtime_wrapper.h

JonChesterfield added a comment. OK from the openmp gpu side as far as I can tell. This is probably another instance of where we really wanted _OPENMP_TARGET or similar. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106070/new/ https://reviews.llvm.org/D106070

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1908-1912 +// Handle SymbolCast before actual assignment. +std::tie(Sym, NewConstraint) = +modifySymbolAndConstraints(Sym, NewConstraint); +if (!State) +

[PATCH] D106070: [HIP] Remove workaround in __clang_hip_runtime_wrapper.h

ashi1 accepted this revision. ashi1 added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106070/new/ https://reviews.llvm.org/D106070 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1908-1912 +// Handle SymbolCast before actual assignment. +std::tie(Sym, NewConstraint) = +modifySymbolAndConstraints(Sym, NewConstraint); +if (!State) +

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

hvdijk updated this revision to Diff 359016. hvdijk edited the summary of this revision. hvdijk added a reviewer: MaskRay. hvdijk added a comment. Updated to use `Triple.isX32()`. Should we perhaps just merge this as is, ahead of the update to compiler-rt to create x32 objects? For non-x32, this

[PATCH] D106069: [HIP] Add test with_fopenmp.hip

ashi1 accepted this revision. ashi1 added a comment. This revision is now accepted and ready to land. LGTM! Repository: rT test-suite CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106069/new/ https://reviews.llvm.org/D106069 ___ cfe-commit

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

glaubitz added a comment. In D100148#2880499 , @hvdijk wrote: > Updated to use `Triple.isX32()`. > > Should we perhaps just merge this as is, ahead of the update to compiler-rt > to create x32 objects? For non-x32, this change is NFC, for x32, the change

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

mibintc added a comment. Intel compiles VS2019 #include files regularly with clang, and the file compiled with -std:c++latest encounters this error report, which @aaron.ballman suggests is related to this effort. In file included from tst_incl_filesystem.cpp:2: c:/Program files (x86)/Micro

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. We have encountered an issue with `lwarx/ldarx` that required that they emit inline asm rather than an intrinsic. What makes `lbarx/lharx` different? Comment a

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

sammccall added inline comments. Comment at: clang-tools-extra/clangd/TextMarks.h:22 +/// Represents a programmer specified mark/note, typically used to easily locate +/// or differentiate code. e.g. a `pragma mark`, a `TODO`. +/// dgoldman wrote: > sammccall wr

[PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2693 +other_die = dcu->LookupAddress( +symtab->SymbolAtIndex(symbol_indexes[index])->GetFileAddress()); + } should there be an early exit

[PATCH] D106065: [Clang] Add an empty builtins.h file.

nemanjai added inline comments. Comment at: clang/lib/Headers/builtins.h:8 +\*===--===*/ + +#ifndef __BUILTINS_H Please describe the purpose of this header file in a comment here. =

[PATCH] D105384: [NVPTX, CUDA] Add .and.popc variant of the b1 MMA instruction.

tra updated this revision to Diff 359047. tra marked an inline comment as done. tra added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105384/new/ https://reviews.llvm.org/D105384 Files: clang/include/clang/Basic/BuiltinsNVPTX

[PATCH] D101759: [PowerPC] Scalar IBM MASS library conversion pass

bmahjour added inline comments. Comment at: clang/include/clang/Driver/Options.td:1726 NegFlag>; -def fapprox_func : Flag<["-"], "fapprox-func">, Group, Flags<[CC1Option, NoDriverOption]>, - MarshallingInfoFlag>, ImpliedByAnyOf<[menable_unsafe_fp_math.KeyPath]>; +defm appro

[PATCH] D105384: [NVPTX, CUDA] Add .and.popc variant of the b1 MMA instruction.

tra added a comment. In D105384#2879308 , @steffenlarsen wrote: > LGTM! Are the test failures related to this, you reckon? AFAICT, no, the test failures don't seem to be related. It appears that the test runs rarely succeed in general. They are mostly

[PATCH] D105930: [PowerPC] Implement XL compact math builtins

lei updated this revision to Diff 359050. lei marked 3 inline comments as done. lei added a comment. Address review comments to add/upate: - builtin encoding for params that need to be folded into constant expr - llvm intrinsic property for immediates - test line for `-mattr=-vsx` Repository:

[PATCH] D105930: [PowerPC] Implement XL compact math builtins

lei added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.td:3650 +// XL Compat intrinsics. +def : Pat<(int_ppc_fmsub f64:$A, f64:$B, f64:$C), (FMSUB $A, $B, $C)>; +def : Pat<(int_ppc_fmsubs f32:$A, f32:$B, f32:$C), (FMSUBS $A, $B, $C)>; nemanja

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

akhuang created this revision. Herald added subscribers: dexonsmith, fedor.sergeev. akhuang requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Constructor homing reduces the amount of class type info that is emitted by emitti

[PATCH] D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL.

stefanp updated this revision to Diff 359054. stefanp added a comment. Realized after I updated the patch that I got the darn tests wrong. I've updated the patch and fixed that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104386/new/ https://revi

[PATCH] D104887: [clang] Evaluate strlen of strcpy argument for -Wfortify-source.

cjdb added a comment. Thanks for getting around to this! Just a nit and a clarifying question. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:821 + "'%0' will always overflow; destination buffer has size %1," + " but the source string has length %2 (including nu

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

dblaikie accepted this revision. dblaikie added subscribers: probinson, aprantl. dblaikie added a comment. This revision is now accepted and ready to land. Please wait for sign-off from @aprantl (or another appropriate Apple representative) & @probinson (or another appropriate Sony representative

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

aaron.ballman added a comment. In D105951#2880654 , @mibintc wrote: > Intel compiles VS2019 #include files regularly with clang, and the file > compiled with -std:c++latest encounters this error report, which > @aaron.ballman suggests is related to thi

  1   2   >