aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM!
================
Comment at: clang/lib/Sema/Sema.cpp:63
+ StringRef Platform) {
+ if (!CachedDarwinSDKInfo) {
+ auto SDKInfo = parseDarwinSDKInfo(
----------------
dexonsmith wrote:
> Nit: I think I'd find this function easier to read if it used an early return
> here, duplicating the `CachedDarwinSDKInfo->get()` call. But I'm fine if you
> prefer it this way.
I don't have strong feelings either, but I think an early return would be
reasonable.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105257/new/
https://reviews.llvm.org/D105257
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
