Topotuna marked 2 inline comments as done. Topotuna added inline comments.
================ Comment at: clang/test/SemaOpenCL/null_literal.cl:7 #define NULL ((void*)0) ---------------- Anastasia wrote: > Anastasia wrote: > > I think we should remove this `NULL` definition but instead add > > `-finclude-default-header -fdeclare-opencl-builtins` to test the definition > > you are adding in the header. > Ok, is this a full diff? > https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface > > > Because the file appears to be incompletely displayed or something... Apologies. That was not a full diff. Should be fixed now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105988/new/ https://reviews.llvm.org/D105988 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
