[PATCH] D105462: [X86] Add CRC32 feature.

tianqing created this revision. Herald added subscribers: dexonsmith, dang, pengfei, hiraditya, mgorny. tianqing requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. d8faf03807ac

[PATCH] D105462: [X86] Add CRC32 feature.

craig.topper added inline comments. Comment at: llvm/lib/Support/X86TargetParser.cpp:531 constexpr FeatureBitset ImpliedFeaturesSSE4_1 = FeatureSSSE3; -constexpr FeatureBitset ImpliedFeaturesSSE4_2 = FeatureSSE4_1; +constexpr FeatureBitset ImpliedFeaturesSSE4_2 = FeatureSSE4_1 |

[PATCH] D105462: [X86] Add CRC32 feature.

tianqing added inline comments. Comment at: llvm/lib/Target/X86/X86.td:84 "Enable SSE 4.2 instructions", - [FeatureSSE41]>; + [FeatureSSE41, FeatureCRC32]>; // The MM

[PATCH] D105447: [analyzer] Allow cmake options to be passed to satest container

vsavchenko added inline comments. Comment at: clang/utils/analyzer/entrypoint.py:12 settings, rest = parse_arguments() +cmake_opts = list(filter(lambda cmd: cmd[:2]=='-D', rest)) if settings.wait: I think we should still use `argparse` for stuff lik

[PATCH] D21113: Add support for case-insensitive header lookup

Yoav added a comment. Herald added a subscriber: dang. Any progress with this? @hans its been stale for a while now and this feature is crucial CHANGES SINCE LAST ACTION https://reviews.llvm.org/D21113/new/ https://reviews.llvm.org/D21113 ___ cfe-

[clang] 6017cb3 - [analyzer][solver] Use all sources of constraints

Author: Valeriy Savchenko Date: 2021-07-06T11:09:08+03:00 New Revision: 6017cb31bb3548641465ea66219e11abc3106d38 URL: https://github.com/llvm/llvm-project/commit/6017cb31bb3548641465ea66219e11abc3106d38 DIFF: https://github.com/llvm/llvm-project/commit/6017cb31bb3548641465ea66219e11abc3106d38.d

[PATCH] D105436: [analyzer][solver] Use all sources of constraints

This revision was automatically updated to reflect the committed changes. Closed by commit rG6017cb31bb35: [analyzer][solver] Use all sources of constraints (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105436/new/ https://

[clang] cbb09c5 - Revert "[clang] fixes named return of variables with dependent alignment"

Author: Adrian Kuegel Date: 2021-07-06T10:31:39+02:00 New Revision: cbb09c5b2c2e0558de50355f4cbbbe2d2840073e URL: https://github.com/llvm/llvm-project/commit/cbb09c5b2c2e0558de50355f4cbbbe2d2840073e DIFF: https://github.com/llvm/llvm-project/commit/cbb09c5b2c2e0558de50355f4cbbbe2d2840073e.diff

[PATCH] D105436: [analyzer][solver] Use all sources of constraints

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:908 +// into subexpressions of Sym. +Visit(Sym)); } Alright. So, this is correct because `Visit` boils down finally to either `infer(Sym->getTy

[PATCH] D105380: [clang] fixes named return of variables with dependent alignment

MForster added a comment. Adrian has reverted this commit for me. Here is a reproduction case for the issue that is triggered by this change: #include template struct S {}; template S foo() { for (auto status : { S() }) { return status; } } void a() {

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ChuanqiXu added a comment. In D97915#2848816 , @ychen wrote: >> Thanks for clarifying. Let's solve the semantics problem first. >> With the introduction about 'raw frame', I think it's necessary to introduce >> this concept in the section 'Switched-Resume

[PATCH] D105436: [analyzer][solver] Use all sources of constraints

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:908 +// into subexpressions of Sym. +Visit(Sym)); } martong wrote: > Alright. So, this is correct because `Visit` boils down finally to eithe

[PATCH] D105436: [analyzer][solver] Use all sources of constraints

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:908 +// into subexpressions of Sym. +Visit(Sym)); } vsavchenko wrote: > martong wrote: > > Alright. So, this is correct because `Visit` boils do

[PATCH] D105436: [analyzer][solver] Use all sources of constraints

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:908 +// into subexpressions of Sym. +Visit(Sym)); } martong wrote: > vsavchenko wrote: > > martong wrote: > > > Alright. So, this is correct

[PATCH] D21113: Add support for case-insensitive header lookup

hans added a comment. In D21113#2859165 , @Yoav wrote: > Any progress with this? @hans its been stale for a while now and this feature > is crucial No progress, I'm afraid. I'm not working on this, so someone would have to take over the patch to push it

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov updated this revision to Diff 356668. ASDenysPetrov added a comment. Splitted this revision and moved `SValBuilder` related changes to separate patch D105340 . Added detailed comments. Made `NominalTypeList` //static// and as a result removed the f

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

vsavchenko added a comment. This is a very complicated patch, I think we'll have to iterate on it quite a lot. Additionally, we have to be sure that this doesn't crash our performance. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1131 +class NominalTy

[PATCH] D105380: [clang] fixes named return of variables with dependent alignment

mizvekov reopened this revision. mizvekov added a comment. This revision is now accepted and ready to land. Thanks for reporting that one! Yeah looking if the type is dependent is not enough, a non-deduced auto type is not considered dependent. I will work on a patch for it later today. Reposit

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

aaron.ballman added a comment. In D99005#2844365 , @mizvekov wrote: > But is this example a reduction from a real world code base? > The committee wants feedback and we are interested how hard you believe this > change affects you. This is an example tha

[PATCH] D105447: [analyzer] Allow cmake options to be passed to satest container

manas added inline comments. Comment at: clang/utils/analyzer/entrypoint.py:12 settings, rest = parse_arguments() +cmake_opts = list(filter(lambda cmd: cmd[:2]=='-D', rest)) if settings.wait: vsavchenko wrote: > I think we should still use `argparse

[PATCH] D104858: [OpenCL][ARM] Fix ICE when compiling a kernel

Anastasia added a comment. In D104858#2857958 , @pekka.jaaskelainen wrote: >> The reason why we would like to fix it is that upstream clang has a crash >> currently when OpenCL sources are compiled for any Arm CPU: >> https://bugs.llvm.org/show_bug.cgi

[libunwind] f7d8754 - [runtimes] Move enable_32bit to the DSL

Author: Louis Dionne Date: 2021-07-06T08:42:07-04:00 New Revision: f7d8754312bf3d10fb902d94f2bc84e3adf12ba4 URL: https://github.com/llvm/llvm-project/commit/f7d8754312bf3d10fb902d94f2bc84e3adf12ba4 DIFF: https://github.com/llvm/llvm-project/commit/f7d8754312bf3d10fb902d94f2bc84e3adf12ba4.diff

[PATCH] D98710: [clang-tidy] Add --skip-headers, part 1 (use setTraversalScope)

sammccall added a comment. This generally looks good now, mostly nits left. The exception is the remaining complexity around stashing and restoring the traversal scope state. If it's needed, it points to a deeper problem in static analyzer and we should understand it a bit (and whether it must

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

aaron.ballman added a comment. In D99005#2843201 , @mizvekov wrote: > Thank you again @sberg. > > I have talked to the MSVC STL maintainers. They would be open to a pull > request for fixing this. > The repo can be found at https://github.com/microsoft/ST

[PATCH] D105477: Define __LONGDOUBLE64 macro

Jake-Egan created this revision. Herald added subscribers: kbarton, nemanjai. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D105477 Files: clang/lib/Basic/Target

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

NeHuang updated this revision to Diff 356701. NeHuang marked 4 inline comments as done. NeHuang added a comment. Address review comments on the test case. Target cpu sema checking covered in front end test cases. will keep current coverage in backend test. Repository: rG LLVM Github Monorepo

[PATCH] D105478: [clang] Make CXXRecrdDecl invalid if it contains any undeduced fields.

adamcz created this revision. adamcz added a reviewer: hokein. adamcz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Undeduced fields in a valid record cause crashes when trying to obtain the size and/or layout of the record. Repository:

[PATCH] D104420: thread_local support for AIX

jamieschmeiser updated this revision to Diff 356705. jamieschmeiser added a comment. Fix formatting problem. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104420/new/ https://reviews.llvm.org/D104420 Files: clang/lib/CodeGen/ItaniumCXXABI.cpp clang/test/CodeGenCXX/cxx11-thread-loca

[PATCH] D105479: [clang-tidy] [PR50069] readability-braces-around-statements doesn't work well with [[likely]] [[unlikely]]

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: alexfh, njames93, aaron.ballman. MyDeveloperDay added projects: clang-tools-extra, clang. Herald added subscribers: jdoerfert, xazax.hun. MyDeveloperDay requested review of this revision. https://bugs.llvm.org/show_bug.cgi?id=50

[PATCH] D103587: [AIX] Define __TOS_AIX__ predefined macro

cebowleratibm accepted this revision. cebowleratibm added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103587/new/ https://reviews.llvm.org/D103587 _

[PATCH] D104858: [OpenCL][ARM] Fix ICE when compiling a kernel

pekka.jaaskelainen added a comment. > Ok, thanks for clarification. Does it mean there is something we need to add > to LLVM somewhere to make it work correctly? Would it be specific to Arm or > generally for all CPU targets? To my understanding, what is required is to keep SPIR_KERNEL CC wor

[PATCH] D105375: [OPENMP]Remove const firstprivate allocation as a variable in a constant space.

ABataev updated this revision to Diff 356715. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105375/new/ https://reviews.llvm.org/D105375 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRun

[PATCH] D105360: [PowerPC] Fix popcntb XL Compat Builtin for 32bit

quinnp updated this revision to Diff 356719. quinnp added a comment. Addressing review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105360/new/ https://reviews.llvm.org/D105360 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeG

[PATCH] D105135: [Internalize] Preserve variables externally initialized.

hliao updated this revision to Diff 356721. hliao added a comment. Kindly PING for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105135/new/ https://reviews.llvm.org/D105135 Files: clang/test/CodeGenCUDA/host-used-device-var.cu clang/t

[PATCH] D105462: [X86] Add CRC32 feature.

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86.td:84 "Enable SSE 4.2 instructions", - [FeatureSSE41]>; + [FeatureSSE41, FeatureCRC32]>; // Th

[PATCH] D99436: [OPENMP]Fix PR49366: crash on VLAs in task untied regions.

ABataev updated this revision to Diff 356726. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99436/new/ https://reviews.llvm.org/D99436 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

mizvekov added a comment. In D99005#2859476 , @aaron.ballman wrote: > https://godbolt.org/z/dvEbv7GKo > > I'm not certain if this is as expected of an issue, though. In the original > example, `C` carried state that was set up after initialization but wa

[PATCH] D105462: [X86] Add CRC32 feature.

hjl.tools added inline comments. Comment at: llvm/lib/Target/X86/X86.td:84 "Enable SSE 4.2 instructions", - [FeatureSSE41]>; + [FeatureSSE41, FeatureCRC32]>; // The M

[PATCH] D105408: [clang-format] Pass a TextDiagnosticPrinter when we can not create tempory file.

Et7f3 added a comment. Mb I just looked in driver how to setup diagnostics (which included frontend). Ok so I see 2 options: - move TextDiagnosticsPrinter in clangBasic - Use SMDiagnostic like clang/tools/clang-format/ClangFormat.cpp:324 but it seem to need a SMLoc so not really adapted. Repo

[PATCH] D105462: [X86] Add CRC32 feature.

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86.td:84 "Enable SSE 4.2 instructions", - [FeatureSSE41]>; + [FeatureSSE41, FeatureCRC32]>; // Th

[PATCH] D105462: [X86] Add CRC32 feature.

hjl.tools added inline comments. Comment at: llvm/lib/Target/X86/X86.td:84 "Enable SSE 4.2 instructions", - [FeatureSSE41]>; + [FeatureSSE41, FeatureCRC32]>; // The M

[PATCH] D105477: [AIX] Define __LONGDOUBLE64 macro

cebowleratibm requested changes to this revision. cebowleratibm added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Basic/Targets/PPC.cpp:175 + if (getTriple().isOSAIX() && LongDoubleWidth == 64) { +Builder.defineMacro("__LONGDOUBLE6

[PATCH] D99350: [OPENMP]Fix PR49649: The introduction of $ref globals is not always valid.

ABataev updated this revision to Diff 356737. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99350/new/ https://reviews.llvm.org/D99350 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/declare_targe

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman added a comment. @theraven: Can you post a minimal repro of your case? I don't follow your distinction between "caller" and "enclosing function." Regarding `noreturn` and `always_inline`: maybe the rules for `musttail` could be relaxed in cases like the one you mention, but it would re

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov added a comment. I found some issues. Working on improvement. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2797-2799 +ProgramStateRef +RangeConstraintManager::updateExistingConstraints(ProgramStateRef State, +

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

aaron.ballman added a comment. In D99005#2859886 , @mizvekov wrote: > In D99005#2859476 , @aaron.ballman > wrote: > >> https://godbolt.org/z/dvEbv7GKo >> >> I'm not certain if this is as expected of an issue, thoug

[PATCH] D105408: [clang-format] Pass a TextDiagnosticPrinter when we can not create tempory file.

MyDeveloperDay added a comment. Yeah, I made the almost identical change but got some push back on it extending the dependencies (I think it also meant that the clang-format target needed alot more source to be compiled) Dinking around in clangBasic is probably outside my pay grade ;-) Reposi

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2801-2802 + // Get a root symbol in case of SymbolCast. + while (isa(Sym)) +Sym = cast(Sym)->getOperand(); + ASDenysPetrov wrote: > vsavchenko wrote: > >

[PATCH] D104917: [Analyzer] Extend exploded-graph-rewriter to support eq and diseq classes

martong updated this revision to Diff 356751. martong added a comment. Herald added a reviewer: Szelethus. - Rebase on top of the newest version of the dependent patch - Draw borders for the table of the disequality info - Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D105297: [OPENMP]Fix PR50347: Mapping of global scope deep object fails.

ABataev updated this revision to Diff 356752. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105297/new/ https://reviews.llvm.org/D105297 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/target_code

[PATCH] D105489: [compiler-rt] [test] Fix asan symbolize tests on py3.10

mgorny created this revision. mgorny added a reviewer: delcypher. Herald added a subscriber: dberris. mgorny requested review of this revision. Update the asan_symbolize_script for changes in argparse output in Python 3.10. The parser output 'options' instead of 'optional arguments'. https://re

[PATCH] D104917: [Analyzer] Extend exploded-graph-rewriter to support eq and diseq classes

martong added a comment. In D104917#2845181 , @NoQ wrote: >> We have a few in `test/Analysis/exploded-graph-rewriter/` where we test >> parts of the emitted html. > > And they're now failing on the pre-merge buildbots. So i guess updating > existing tes

[clang] f1cbea3 - [RISCV] Remove Zvamo implication for v1.0-rc change

Author: ShihPo Hung Date: 2021-07-07T00:14:58+08:00 New Revision: f1cbea3e527547fc08c55235c11970a8d9f2637e URL: https://github.com/llvm/llvm-project/commit/f1cbea3e527547fc08c55235c11970a8d9f2637e DIFF: https://github.com/llvm/llvm-project/commit/f1cbea3e527547fc08c55235c11970a8d9f2637e.diff L

[PATCH] D105396: [RISCV] Remove Zvamo implication for v1.0-rc change

This revision was automatically updated to reflect the committed changes. Closed by commit rGf1cbea3e5275: [RISCV] Remove Zvamo implication for v1.0-rc change (authored by arcbbb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105396/new/ https://re

[PATCH] D104917: [Analyzer] Extend exploded-graph-rewriter to support eq and diseq classes

martong added a comment. > Do you happen to have a screenshot of how it looks? Yes! :) F17793264: image.png F17793282: image.png I've added borders to the tables in the `Disequality Info` section, because the default ren

[PATCH] D105490: Remove unused parameter from parseMSInlineAsm.

simon_tatham created this revision. simon_tatham added reviewers: rsmith, lebedev.ri, akyrtzi. Herald added a subscriber: hiraditya. simon_tatham requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. No implementation uses the `

[PATCH] D105491: [clang] Use i64 for the !srcloc metadata on asm IR nodes.

simon_tatham created this revision. simon_tatham added reviewers: rsmith, lebedev.ri, akyrtzi. Herald added subscribers: dexonsmith, hiraditya. simon_tatham requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This is part of a

[PATCH] D105492: [clang] Introduce SourceLocation::[U]IntType typedefs.

simon_tatham created this revision. simon_tatham added reviewers: rsmith, lebedev.ri, akyrtzi. Herald added subscribers: dexonsmith, arphaman, kbarton, nemanjai. simon_tatham requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is part of a

[PATCH] D105494: [clang] Introduce a union inside ProgramPoint.

simon_tatham created this revision. simon_tatham added reviewers: rsmith, lebedev.ri, akyrtzi. simon_tatham requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is part of a patch series working towards the ability to make SourceLocation in

[PATCH] D105493: [clang] Change set type used for SourceLocation.

simon_tatham created this revision. simon_tatham added reviewers: rsmith, lebedev.ri, akyrtzi. Herald added a subscriber: dexonsmith. simon_tatham requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is part of a patch series working toward

[PATCH] D105495: [clang] Make negative getLocWithOffset widening-safe.

simon_tatham created this revision. simon_tatham added reviewers: rsmith, lebedev.ri, akyrtzi. Herald added subscribers: dexonsmith, martong. simon_tatham requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is part of a patch series workin

[PATCH] D105497: [clang] Serialize source locations as 64-bit in PCH.

simon_tatham created this revision. simon_tatham added reviewers: rsmith, lebedev.ri, akyrtzi. simon_tatham requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is part of a patch series working towards the ability to make SourceLocation in

[PATCH] D105498: [clang] Remove assumption about SourceLocation alignment.

simon_tatham created this revision. simon_tatham added reviewers: rsmith, lebedev.ri, akyrtzi. simon_tatham requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is part of a patch series working towards the ability to make SourceLocation in

[PATCH] D97204: [RFC] Clang 64-bit source locations

simon_tatham added a comment. This patch doesn't seem to have attracted much review attention in the last couple of weeks. On the theory that perhaps it's just too big and monolithic to review in one go, I've started to break it up into smaller pieces. So far I've only covered the preparation s

[PATCH] D105151: [OPENMP]Fix PR50733: unexpected final value of list-item in linear clause in loop construct.

ABataev updated this revision to Diff 356766. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105151/new/ https://reviews.llvm.org/D105151 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/for_linear_codegen.

[PATCH] D103165: Threading: use independent llvm::thread implementation on Apple platforms to increase stack size

t.p.northover added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103165/new/ https://reviews.llvm.org/D103165 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D104858: [OpenCL][ARM] Fix ICE when compiling a kernel

Anastasia added a comment. In D104858#2859742 , @pekka.jaaskelainen wrote: >> Ok, thanks for clarification. Does it mean there is something we need to add >> to LLVM somewhere to make it work correctly? Would it be specific to Arm or >> generally for a

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2801-2802 + // Get a root symbol in case of SymbolCast. + while (isa(Sym)) +Sym = cast(Sym)->getOperand(); + vsavchenko wrote: > ASDenysPetrov wrote: >

[PATCH] D105263: [X86] AVX512FP16 instructions enabling 1/6

craig.topper added inline comments. Comment at: clang/lib/Headers/avx512fp16intrin.h:254 +/// Constructs a 512-bit floating-point vector of [32 x half] from a +///128-bit floating-point vector of [16 x half]. The lower 256 bits +///contain the value of the source vector.

[PATCH] D105501: [PowerPC] Power ISA features for Semachecking

quinnp created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [NFC] This patch adds features for pwr7, pwr8, and pwr9 that can be used for semacheking builtin func

[PATCH] D105501: [PowerPC] Power ISA features for Semachecking

quinnp updated this revision to Diff 356774. quinnp added a comment. Updating pwr10 features to include previous features. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105501/new/ https://reviews.llvm.org/D105501 Files: clang/lib/Basic/Targets/

[PATCH] D105295: [CUDA] Only allow NVIDIA offload-arch during CUDA compilation.

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105295/new/ https://reviews.llvm.org/D105295 __

[PATCH] D105285: [Clang] Add test dependency on llvm-ar

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105285/new/ https://reviews.llvm.org/D105285 __

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

quinnp added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-sync.c:2 // RUN: %clang_cc1 -triple powerpc64-unknown-unknown \ -// RUN:-emit-llvm %s -o - -target-cpu pwr8 | FileCheck %s +// RUN:-emit-llvm %s -o - -target-cpu pwr7 | FileCheck %s //

[PATCH] D105489: [compiler-rt] [test] Fix asan symbolize tests on py3.10

delcypher accepted this revision. delcypher added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105489/new/ https://reviews.llvm.org/D105489 ___ cfe-commits mailing list cfe-com

[clang] 045872f - [AIX] Define __TOS_AIX__ predefined macro

Author: Jake Egan Date: 2021-07-06T14:15:35-04:00 New Revision: 045872f42203223450c96a518b6478d255a5d586 URL: https://github.com/llvm/llvm-project/commit/045872f42203223450c96a518b6478d255a5d586 DIFF: https://github.com/llvm/llvm-project/commit/045872f42203223450c96a518b6478d255a5d586.diff LOG

[PATCH] D103587: [AIX] Define __TOS_AIX__ predefined macro

This revision was automatically updated to reflect the committed changes. Closed by commit rG045872f42203: [AIX] Define __TOS_AIX__ predefined macro (authored by Jake-Egan, committed by stevewan). Changed prior to commit: https://reviews.llvm.org/D103587?vs=349913&id=356783#toc Repository: r

[PATCH] D105135: [Internalize] Preserve variables externally initialized.

yaxunl added a comment. LGTM. Pls change the negative tests to positive tests as Artem suggested. Comment at: clang/test/CodeGenCUDA/host-used-device-var.cu:20 -// DEV-NEG-NOT: @v1 -__device__ int v1; tra wrote: > hliao wrote: > > BTW, as clang codegen tests,

[PATCH] D105489: [compiler-rt] [test] Fix asan symbolize tests on py3.10

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d68bb1765f9: [compiler-rt] [test] Fix asan symbolize tests on py3.10 (authored by mgorny). Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. Repository: rG LLVM Github Monorepo

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

mizvekov added a comment. In D99005#2860021 , @aaron.ballman wrote: > I would argue it gives the committee valuable implementation experience > feedback: the change breaks at least one popular system header. But we already knew that :-) Reverting the ch

[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

ychen updated this revision to Diff 356796. ychen added a comment. - address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102531/new/ https://reviews.llvm.org/D102531 Files: clang/lib/Sema/SemaExprCXX.cpp clang/lib/Sema/SemaTemplate.

[PATCH] D103527: [Clang][RISCV] Implement vlseg and vlsegff.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103527/new/ https://reviews.llvm.org/D103527 ___

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

dblaikie added a comment. Looks generally good - few things might be able to be tidied up/simplified, I think? Comment at: clang/unittests/AST/ASTPrint.h:61-62 +private: + // Can be specialized for specific node types. + bool shouldIgnoreNode(const NodeType *N) { return fals

[PATCH] D105395: [IRBuilder] Add type argument to CreateMaskedLoad/Gather

dblaikie added a comment. Might use some testing? (guess there was previously missing testing, or this API change would've broken those tests) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105395/new/ https://reviews.llvm.org/D105395

[PATCH] D103165: Threading: use independent llvm::thread implementation on Apple platforms to increase stack size

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. This LGTM, with some whitespace nits inline. In D103165#2790932 , @t.p.northover wrote: >> Also this way llvm::thread users that don't need f

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

Quuxplusone added a comment. > I'd like to give some time for other stakeholders to give their opinion if > this is not too urgent, specially @Quuxplusone and @rsmith. I have no strong/well-informed opinions here. I have an idea to offer, //if// there is precedent for it. My idea is, keep it as

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

mizvekov added a comment. In D99005#2860598 , @Quuxplusone wrote: > I have no strong/well-informed opinions here. I have an idea to offer, //if// > there is precedent for it. My idea is, keep it as an error if the rvalue > resolution finds nothing, but (

[PATCH] D105512: [AIX] Don't pass no-integrated-as by default

jsji created this revision. jsji added reviewers: PowerPC, shchenz. jsji requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D105314 added the abibility choose to use AsmParser for parsing inline asm. -no-int

[PATCH] D105447: [analyzer] Allow cmake options to be passed to satest container

manas updated this revision to Diff 356821. manas added a comment. Pass commands through settings instead of rest Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105447/new/ https://reviews.llvm.org/D105447 Files: clang/utils/analyzer/entrypoint.p

[PATCH] D105375: [OPENMP]Remove const firstprivate allocation as a variable in a constant space.

vzakhari accepted this revision. vzakhari added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105375/new/ https://reviews.llvm.org/D105375 ___

[PATCH] D105516: [clang][PassManager] Add -falways-mem2reg to run mem2reg at -O0

jrtc27 created this revision. jrtc27 added reviewers: chandlerc, rjmccall, rsmith. Herald added subscribers: ormris, dexonsmith, dang, s.egerton, simoncook, hiraditya, kristof.beyls. jrtc27 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commit

[PATCH] D102582: [RISCV] Report an error when ABI mismatch with target-abi module flag.

jrtc27 added inline comments. Comment at: llvm/test/CodeGen/RISCV/module-target-abi-tests.ll:5 +; RUN: cat %s > %t.emptyabi +; RUN: echo '!0 = !{i32 1, !"target-abi", !""}' >> %t.emptyabi +; RUN: llc -mtriple=riscv32 < %t.emptyabi -o /dev/null khchen wrote: > jrt

[PATCH] D105380: [clang] fixes named return of variables with dependent alignment

mizvekov updated this revision to Diff 356833. mizvekov added a comment. - hasDependentAlignment now returns true for VarDecls with undeduced auto types. - Add couple of tests that cover these kinds of VarDecls appearing: - Valid code with a range for loop in dependent context. - Error recover

[PATCH] D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO

jrtc27 added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:633 + // pass more options in specific target + switch (ToolChain.getArch()) { Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:634-638 + switch (T

[clang] 6c9559b - DebugInfo: Mangle K&R declarations for debug info linkage names

Author: David Blaikie Date: 2021-07-06T16:28:02-07:00 New Revision: 6c9559b67b91966bfeff9e17808a3e84a92e64a0 URL: https://github.com/llvm/llvm-project/commit/6c9559b67b91966bfeff9e17808a3e84a92e64a0 DIFF: https://github.com/llvm/llvm-project/commit/6c9559b67b91966bfeff9e17808a3e84a92e64a0.diff

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

dblaikie added a comment. In D98799#2850700 , @dblaikie wrote: > In D98799#2850682 , @ahatanak wrote: > >> I think I've fixed all the places in CodeGen that create fake >> `FunctionDecl`s and would cause clang to c

[PATCH] D105142: RFC: Implementing new mechanism for hard register operands to inline asm as a constraint.

MaskRay added subscribers: rampitec, arsenm. MaskRay added a comment. This is great. unsigned long foo(unsigned long addr, unsigned long a0, unsigned long a1, unsigned long a2, unsigned long a3, unsigned long a4, unsigned long a5) {

[PATCH] D105380: [clang] fixes named return of variables with dependent alignment

mizvekov updated this revision to Diff 356835. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105380/new/ https://reviews.llvm.org/D105380 Files: clang/include/clang/AST/Decl.h clang/lib/AST/Decl.cpp clang/lib/Sema

[PATCH] D105451: [clang] Fix crash when there is an invalid declaration with flag -Wcast-align

qdelacru updated this revision to Diff 356836. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105451/new/ https://reviews.llvm.org/D105451 Files: clang/lib/Sema/SemaChecking.cpp clang/test/Sema/warn-cast-align.c Index: clang/test/Sema/warn-cast-align.c ==

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

hoy added a comment. In D98799#2860881 , @dblaikie wrote: > In D98799#2850700 , @dblaikie wrote: > >> In D98799#2850682 , @ahatanak wrote: >> >>> I think I've fixed all the p

  1   2   >