manas added inline comments.

================
Comment at: clang/utils/analyzer/entrypoint.py:12
     settings, rest = parse_arguments()
+    cmake_opts = list(filter(lambda cmd: cmd[:2]=='-D', rest))
     if settings.wait:
----------------
vsavchenko wrote:
> I think we should still use `argparse` for stuff like this, and we don't want 
> any of these flags to sneak into `rest`.
> https://stackoverflow.com/a/31141568/11582326
Understood! I will rework on this. Thanks for the review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105447/new/

https://reviews.llvm.org/D105447

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to