[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen added a comment. In D97915#2832667 , @ChuanqiXu wrote: > In D97915#2832446 , @ychen wrote: > >> In D97915#2829581 , @ChuanqiXu >> wrote: >> >>> A remained question. >>

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen updated this revision to Diff 353855. ychen added a comment. - Update intrinsics documentation. - Inline `EmitBuiltinAlignTo` as `emitAlignUpTo`. - Address other comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97915/new/ https://revie

[PATCH] D103943: [X86] Add -mgeneral-regs-only support.

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103943/new/ https://reviews.llvm.org/D103943 ___ cfe-commits mailing list cfe-commit

[PATCH] D102134: [docs]Updated the AMD GPU Attributes documentation

pooja2299 abandoned this revision. pooja2299 added a comment. Closing this issue because the default workgroup size is 1024 now, so no changes are required. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102134/new/ https://reviews.llvm.org/D102134

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

vsavchenko added a comment. Hey, it looks like we are finally converging on this one! Great job! NOTE: I don't know if you noticed, but I want to point out that there are three failing tests: F17553262: Screen Shot 2021-06-23 at 11.35.49.png

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas added a comment. Thanks @vsavchenko and everyone for helping! :) Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1075-1076 + /// LHSOpd binop RHSOpd == Result, where binop is any binary operation + bool hasOverflowed(llvm::APSInt LHSOpd, llvm:

[PATCH] D104550: [analyzer] Implement getType for SVal

NoQ added a comment. Another thing to mention about `SVal::getType()` in its doxygen comment is that //most of the time you don't need it//. Similarly to how checking whether an `SVal` is a `Loc` or a `NonLoc` results in incorrect code 95% of the time (because such code is unable to discriminat

[PATCH] D104770: Add support for #pragma system_header with -fms-extensions

hans created this revision. hans added a reviewer: thakis. hans requested review of this revision. Herald added a project: clang. Clang already supports the pragma prefixed by "GCC" or "clang". MSVC has more recently added support for the pragma, but without any prefix; see https://devblogs.mic

[PATCH] D104770: Add support for #pragma system_header with -fms-extensions

hans added inline comments. Comment at: clang/test/Lexer/pragma-operators.cpp:22 #define pragma_L _Pragma(L"GCC diagnostic push") -#define pragma_u8 _Pragma(u8"system_header") +#define pragma_u8 _Pragma(u8"pack(1)") #define pragma_u _Pragma(u"GCC diagnostic pop") --

[PATCH] D104744: [PowerPC] Add PowerPC rotate related builtins and emit target independent code for XL compatibility

qiucf added a comment. Please provide context of the patch (`git diff -U999`) :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104744/new/ https://reviews.llvm.org/D104744 ___ cfe-commits mailing list c

[PATCH] D102730: [clang-format] Support custom If macros

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102730/new/ https://reviews.llvm.org/D102730 ___ cfe-commits mailing list cfe-com

[clang] 157473a - [IR] Simplify createReplacementInstr

Author: Jay Foad Date: 2021-06-23T10:47:43+01:00 New Revision: 157473a58f02b8f2ad12ecbaaa1af32d0342257b URL: https://github.com/llvm/llvm-project/commit/157473a58f02b8f2ad12ecbaaa1af32d0342257b DIFF: https://github.com/llvm/llvm-project/commit/157473a58f02b8f2ad12ecbaaa1af32d0342257b.diff LOG:

[PATCH] D104124: [IR] Simplify createReplacementInstr

This revision was automatically updated to reflect the committed changes. Closed by commit rG157473a58f02: [IR] Simplify createReplacementInstr (authored by foad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104124/new/ https://reviews.llvm.org/D1

[PATCH] D103943: [X86] Add -mgeneral-regs-only support.

RKSimon added a comment. Thanks - that makes sense - LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103943/new/ https://reviews.llvm.org/D103943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[PATCH] D104082: [CodeGen] Don't create a fake FunctionDecl when generating block/block_byref copy/dispose helper functions

fhahn added a comment. In D104082#2835080 , @zequanwu wrote: > Hi, this caused compiler crash with error "Assertion > `cast(Scope)->describes(&MF->getFunction())' failed." on iOS > platforms. So, I reverted it. > I'm working on a reduced repro. FYI th

[PATCH] D104774: [clang-format] Fix a bug that indents else-comment-if incorrectly

owenpan created this revision. owenpan added reviewers: djasper, klimek, MyDeveloperDay. owenpan added a project: clang-format. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If there is a comment between "else" and "if", the "if"

[PATCH] D104770: Add support for #pragma system_header with -fms-extensions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though you could add a test that `#pragma system_header` gives a diagnostic outside of `-fms-extensions` mode if you think that's valuable. Repository: rG LLVM Github Mo

[PATCH] D104117: [clangd] Fix highlighting for implicit ObjC property refs

sammccall added a comment. Drive by from vacation, sorry - can this be tackled "upstream" in findExplicitReferences rather than special cased in syntax highlighting? That would help with xrefs, rename etc. Features should really be only handled here if they're somehow not a simple token->decl r

[PATCH] D93525: [clang-offload-bundler] Add unbundling of archives containing bundled object files into device specific archives

saiislam updated this revision to Diff 353922. saiislam added a comment. Updated clang and hip tests to ensure that all 4 components of triple are mandataroly available in the bundle entry ID. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93525/new

[PATCH] D104774: [clang-format] Fix a bug that indents else-comment-if incorrectly

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104774/new/ https://reviews.llvm.org/D104774 ___

[PATCH] D104777: PR50767: clear non-distinct debuginfo for function with nodebug definition after undecorated declaration

brunodefraine created this revision. brunodefraine added reviewers: ychen, dblaikie. brunodefraine added a project: clang. brunodefraine requested review of this revision. Herald added a subscriber: cfe-commits. Fix suggested by Yuanfang Chen: Non-distinct debuginfo is attached to the function du

[PATCH] D104770: Add support for #pragma system_header with -fms-extensions

hans added a comment. In D104770#2835596 , @aaron.ballman wrote: > LGTM, though you could add a test that `#pragma system_header` gives a > diagnostic outside of `-fms-extensions` mode if you think that's valuable. Thanks! Yes, I'll do that, and I'll a

[PATCH] D104770: Add support for #pragma system_header with -fms-extensions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG24037c37b6c4: Add support for #pragma system_header with -fms-extensions (authored by hans). Changed prior to commit: https://reviews.llvm.org/D10

[clang] 24037c3 - Add support for #pragma system_header with -fms-extensions

Author: Hans Wennborg Date: 2021-06-23T13:26:03+02:00 New Revision: 24037c37b6c4043faae7bf396b735e1ba36e46e0 URL: https://github.com/llvm/llvm-project/commit/24037c37b6c4043faae7bf396b735e1ba36e46e0 DIFF: https://github.com/llvm/llvm-project/commit/24037c37b6c4043faae7bf396b735e1ba36e46e0.diff

[clang] 76c931a - [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

Author: Zarko Todorovski Date: 2021-06-23T07:40:38-04:00 New Revision: 76c931ae42cf1080199a238446306e8554ebb6de URL: https://github.com/llvm/llvm-project/commit/76c931ae42cf1080199a238446306e8554ebb6de DIFF: https://github.com/llvm/llvm-project/commit/76c931ae42cf1080199a238446306e8554ebb6de.di

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG76c931ae42cf: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D103131: support debug info for alias variable

kamleshbhalui added a comment. Here is what we get when we replace int with float. $lldb-11 ./a.out (lldb) target create "./a.out" Current executable set to '/folk/kkumar/tcllvm/llvm-build-lldb-rel/bin/a.out' (x86_64). (lldb) b main Breakpoint 1: where = a.out`main + 4 at test.c:3:12,

[clang] ca7f471 - [clang-format] Fix a bug that indents else-comment-if incorrectly

Author: owenca Date: 2021-06-23T04:57:45-07:00 New Revision: ca7f4715858137dc97ac782cead65ba706bffa3c URL: https://github.com/llvm/llvm-project/commit/ca7f4715858137dc97ac782cead65ba706bffa3c DIFF: https://github.com/llvm/llvm-project/commit/ca7f4715858137dc97ac782cead65ba706bffa3c.diff LOG: [

[PATCH] D104774: [clang-format] Fix a bug that indents else-comment-if incorrectly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGca7f47158581: [clang-format] Fix a bug that indents else-comment-if incorrectly (authored by owenca ). Changed pri

[PATCH] D104774: [clang-format] Fix a bug that indents else-comment-if incorrectly

owenpan added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104774/new/ https://reviews.llvm.org/D104774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

whisperity marked 2 inline comments as done. whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:657-667 + // Certain kinds unfortunately need to be side-stepped for canonical type + // matching. + if (LType->

[PATCH] D104777: PR50767: clear non-distinct debuginfo for function with nodebug definition after undecorated declaration

brunodefraine updated this revision to Diff 353949. brunodefraine added a comment. Fix issues from Windows/clang-format buildbot. Fix mistake in code comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104777/new/ https://reviews.llvm.org/D10477

[PATCH] D104117: [clangd] Fix highlighting for implicit ObjC property refs

dgoldman added a comment. In D104117#2835599 , @sammccall wrote: > Drive by from vacation, sorry - can this be tackled "upstream" in > findExplicitReferences rather than special cased in syntax highlighting? > > That would help with xrefs, rename etc. Fe

[clang] a0d05ed - Handle interactions between reserved identifier and user-defined suffixes

Author: serge-sans-paille Date: 2021-06-23T15:38:42+02:00 New Revision: a0d05ed848990c06c6dcdfc2e37bc8f13f7fe470 URL: https://github.com/llvm/llvm-project/commit/a0d05ed848990c06c6dcdfc2e37bc8f13f7fe470 DIFF: https://github.com/llvm/llvm-project/commit/a0d05ed848990c06c6dcdfc2e37bc8f13f7fe470.d

[PATCH] D104299: Handle interactions between reserved identifier and user-defined suffixes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. serge-sans-paille marked 2 inline comments as done. Closed by commit rGa0d05ed84899: Handle interactions between reserved identifier and user-defined suffixes (authored

[PATCH] D104677: [OpenMP][AMDGCN] Apply fix for isnan, isinf and isfinite for amdgcn.

yaxunl added inline comments. Comment at: clang/test/Headers/hip-header.hip:21 +// RUN: -target-cpu gfx906 -emit-llvm %s -fcuda-is-device -o - \ +// RUN: -D__HIPCC_RTC__ -DUSE_ISNAN_WITH_INT_RETURN | FileCheck %s -check-prefixes=AMD_INT_RETURN +// RUN: %clang_cc1 -include __

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

ggeorgakoudis added a comment. LGMT too! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104714/new/ https://reviews.llvm.org/D104714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D103131: support debug info for alias variable

dblaikie added a comment. In D103131#2835702 , @kamleshbhalui wrote: > Here is what we get when we replace int with float. > > $lldb-11 ./a.out > (lldb) target create "./a.out" > Current executable set to > '/folk/kkumar/tcllvm/llvm-build-lldb-re

[PATCH] D93525: [clang-offload-bundler] Add unbundling of archives containing bundled object files into device specific archives

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7619 if (CurKind == Action::OFK_HIP && CurDep->getOffloadingArch()) { - Triples += '-'; + Triples += "--"; Triples += CurDep->getOffloadingArch(); This is not HI

[PATCH] D104677: [OpenMP][AMDGCN] Apply fix for isnan, isinf and isfinite for amdgcn.

estewart08 added inline comments. Comment at: clang/test/Headers/hip-header.hip:21 +// RUN: -target-cpu gfx906 -emit-llvm %s -fcuda-is-device -o - \ +// RUN: -D__HIPCC_RTC__ -DUSE_ISNAN_WITH_INT_RETURN | FileCheck %s -check-prefixes=AMD_INT_RETURN +// RUN: %clang_cc1 -includ

[PATCH] D104677: [OpenMP][AMDGCN] Apply fix for isnan, isinf and isfinite for amdgcn.

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104677/new/ https://reviews.llvm.org/D104677 __

[PATCH] D104677: [OpenMP][AMDGCN] Apply fix for isnan, isinf and isfinite for amdgcn.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5dfdc1812d9b: [OpenMP][AMDGCN] Apply fix for isnan, isinf and isfinite for amdgcn. (authored by estewart08, committed by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 5dfdc18 - [OpenMP][AMDGCN] Apply fix for isnan, isinf and isfinite for amdgcn.

Author: Ethan Stewart Date: 2021-06-23T15:26:09+01:00 New Revision: 5dfdc1812d9b9c043204d39318f6446424d8f2d7 URL: https://github.com/llvm/llvm-project/commit/5dfdc1812d9b9c043204d39318f6446424d8f2d7 DIFF: https://github.com/llvm/llvm-project/commit/5dfdc1812d9b9c043204d39318f6446424d8f2d7.diff

[PATCH] D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions.

ASDenysPetrov updated this revision to Diff 353954. ASDenysPetrov added a comment. Made changes according to comments. Optimized `castTo` function for each cast case. Simplified unit test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103094/new/ https://reviews.llvm.org/D103094 Files

[PATCH] D104777: PR50767: clear non-distinct debuginfo for function with nodebug definition after undecorated declaration

dblaikie added a subscriber: aaron.ballman. dblaikie added a comment. @aaron.ballman Do we have attributes/infrastructure for attributes that have to be the same from their first declaration or at least from their first call? I'm wondering if it might be simpler/better to require nodebug to be p

[PATCH] D98710: [clang-tidy] Add --skip-headers, part 1 (use setTraversalScope)

hokein added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchFinder.h:148 +/// Check if a Decl should be skipped. +std::shared_ptr Filter; }; chh wrote: > sammccall wrote: > > I don't think the filter belongs here. > > The design o

[PATCH] D103131: support debug info for alias variable

kamleshbhalui added a comment. In D103131#2835909 , @dblaikie wrote: > In D103131#2835702 , @kamleshbhalui > wrote: > >> Here is what we get when we replace int with float. >> >> $lldb-11 ./a.out >> (lldb) t

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

SaurabhJha updated this revision to Diff 353970. SaurabhJha added a comment. Herald added a project: clang-tools-extra. Did a --amend to rebuild Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104198/new/ https://reviews.llvm.org/D104198 Files: cl

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

whisperity updated this revision to Diff 353969. whisperity marked 8 inline comments as done. whisperity added a comment. All changes are **NFC** and styling only. - Remove the `FB` macro in favour of explicitly specifying the bit flag value - Change debug printout from bit pattern to individual

[PATCH] D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions.

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:297-307 +bool clang::ento::RangeSet::isUnsigned() const { + return begin()->From().isUnsigned(); +} + +uint32_t clang::ento::RangeSet::getBitWidth() const { + return begin()->

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

SaurabhJha updated this revision to Diff 353971. SaurabhJha added a comment. Removing mistakenly added files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104198/new/ https://reviews.llvm.org/D104198 Files: clang/docs/LanguageExtensions.rst In

[PATCH] D95736: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with `typedef` and `const &` diagnostics

whisperity updated this revision to Diff 353972. whisperity added a comment. **NFC**: Rebase & update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95736/new/ https://reviews.llvm.org/D95736 Files: clang-tools-extra/clang-tidy/bugprone/EasilySw

[PATCH] D96355: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with optionally considering differently qualified types mixable

whisperity updated this revision to Diff 353974. whisperity added a comment. **NFC**: Rebase & update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96355/new/ https://reviews.llvm.org/D96355 Files: clang-tools-extra/clang-tidy/bugprone/EasilySw

[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

whisperity updated this revision to Diff 353975. whisperity marked 5 inline comments as done. whisperity added a comment. **NFC**. - Rebase and update for changes of base patch D69560 . - Remove the `<<=` and `%=` operators in favour of named functions. - Elabora

[PATCH] D78652: [clang-tidy] Suppress reports to similarly used parameters in 'bugprone-easily-swappable-parameters'

whisperity updated this revision to Diff 353978. whisperity added a comment. **NFC**: Rebase & update. While this patch conceptually only depends on D69560 , the diff itself has become linear during the code review and subsequent updates, and as such, must be ap

[PATCH] D97297: [clang-tidy] Suppress reports to patternedly named parameters in 'bugprone-easily-swappable-parameters'

whisperity updated this revision to Diff 353979. whisperity added a comment. **NFC**: Rebase & update. While this patch conceptually only depends on D69560 , the diff itself has become linear during the code review and subsequent updates, and as such, must be ap

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

whisperity added a comment. In D69560#2747092 , @alexfh wrote: > BTW, any ideas why "patch application failed"? (See the Build status in the > Diff Detail section) I think I figured out why the pre-build CI isn't working... it seems that the fact that t

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

whisperity updated this revision to Diff 353983. whisperity added a comment. (Try nudging the CI to only apply this commit after removal of parent links.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69560/new/ https://reviews.llvm.org/D69560 Fil

[PATCH] D104117: [clangd] Fix highlighting for implicit ObjC property refs

dgoldman updated this revision to Diff 353987. dgoldman added a comment. Minor comment fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104117/new/ https://reviews.llvm.org/D104117 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp cl

[PATCH] D104118: [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C

stuart updated this revision to Diff 353988. stuart added a comment. Added handling of `-gstrict-dwarf` and updated tests accordingly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104118/new/ https://reviews.llvm.org/D104118 Files: clang/lib/Co

[PATCH] D103131: support debug info for alias variable

dblaikie added a comment. In D103131#2835981 , @kamleshbhalui wrote: > In D103131#2835909 , @dblaikie > wrote: > >> In D103131#2835702 , >> @kamleshbhalui wrote: >> >>>

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

samitolvanen added inline comments. Comment at: llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:58-80 +std::string OldName = Name.str(); std::string NewName = (Name + ModuleId).str(); if (const auto *C = ExportGV.getComdat()) if (C->getName() == Name)

[PATCH] D104381: [analyzer] Added a test case for PR46264

ASDenysPetrov updated this revision to Diff 353992. ASDenysPetrov added a comment. Updated due to comments. Confirm crash on commit `3ed8ebc2f6b8172bed48cc5986d3b7af4cfca1bc` from 24.05.2020. @NoQ ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104381/new/ https://reviews.llvm.org/D104

[PATCH] D104285: [analyzer] Retrieve value by direct index from list initialization of constant array declaration.

ASDenysPetrov added a comment. @chrish_ericsson_atx Sorry for the late reply. Thank you for reveiwing this. > I think the presence of the initializer list in the test case is not > necessary to trigger the spurious warnings Could you please provide some test cases that you think will uncover o

[clang] be9a87f - [clang-format] Add IfMacros option

Author: Vitali Lovich Date: 2021-06-23T08:51:53-07:00 New Revision: be9a87fe9bc395074c383c07fbd9c0bce953985f URL: https://github.com/llvm/llvm-project/commit/be9a87fe9bc395074c383c07fbd9c0bce953985f DIFF: https://github.com/llvm/llvm-project/commit/be9a87fe9bc395074c383c07fbd9c0bce953985f.diff

[PATCH] D102730: [clang-format] Support custom If macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbe9a87fe9bc3: [clang-format] Add IfMacros option (authored by vlovich). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D104342: [IR] convert warn-stack-size from module flag to fn attr

aaron.ballman added a comment. In D104342#2834240 , @dblaikie wrote: > In D104342#2834119 , > @nickdesaulniers wrote: > >> I would think >> https://clang.llvm.org/docs/DiagnosticsReference.html#wframe-larger-tha

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

jdenny updated this revision to Diff 353998. jdenny marked an inline comment as done. jdenny added a comment. Applied arichardson's suggestion: comment on exclusion of separator comments. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104714/new/ https://reviews.llvm.org/D10471

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

jdenny added a comment. In D104714#2835874 , @ggeorgakoudis wrote: > LGTM too! Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104714/new/ https://reviews.llvm.org/D104714 ___ cfe-commits mai

[PATCH] D104342: [IR] convert warn-stack-size from module flag to fn attr

dblaikie added a comment. In D104342#2836222 , @aaron.ballman wrote: > In D104342#2834240 , @dblaikie > wrote: > >> In D104342#2834119 , >> @nickdesaulniers wrote: >> >

[PATCH] D104790: [x86] fix mm*_undefined* intrinsics to use arbitrary frozen bit pattern

aqjune created this revision. aqjune added reviewers: efriedma, spatel, craig.topper, RKSimon. Herald added a subscriber: pengfei. aqjune requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes lowering of `mm*_undefined*` intrinsics to

[PATCH] D104790: [x86] fix mm*_undefined* intrinsics to use arbitrary frozen bit pattern

aqjune added a comment. I couldn't find end-to-end tests for checking assembly generation. To check whether this is working ok, which tests should I write and how would it look like? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104790/new/ https:

[PATCH] D97224: Use Address for CGBuilder's CreateAtomicRMW and CreateAtomicCmpXchg.

jyknight added a comment. Ping. I think this is correct, and would like to commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97224/new/ https://reviews.llvm.org/D97224 ___ cfe-commits mailing list cf

[PATCH] D104729: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but you should land this only after we accept D100118 because it's only needed for that functionality. Repository: rG LLVM Github Mon

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

aaron.ballman added a comment. In D100118#2833864 , @mibintc wrote: > This patch addresses almost all the review comments, not yet sure about > @aaron.ballman 's question about CoreOptions FWIW, I'm fine addressing that comment in a follow-up. Also, it

[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

vsk added a comment. A one-time exception to the .profraw compatibility policy sounds reasonable to me. A little more context: llvm has historically rev'd the .profraw format with abandon to deliver performance/size improvements (as David & co. did with name compression) and new functionality

[PATCH] D104777: PR50767: clear non-distinct debuginfo for function with nodebug definition after undecorated declaration

aaron.ballman added a comment. In D104777#2835965 , @dblaikie wrote: > @aaron.ballman Do we have attributes/infrastructure for attributes that have > to be the same from their first declaration or at least from their first > call? I'm wondering if it mi

[PATCH] D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions.

ASDenysPetrov added a comment. I'll update tommorow. Comment at: clang/unittests/StaticAnalyzer/RangeSetTest.cpp:120 + + template const llvm::APSInt &from(T X) { +static llvm::APSInt Int = APSIntTy.getZeroValue(); vsavchenko wrote: > Default to `BaseType`

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc updated this revision to Diff 354009. mibintc added a comment. The patch I uploaded for review yesterday wasn't correct, not sure what happened. This one looks better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100118/new/ https://revi

[PATCH] D103938: Diagnose -Wunused-value in constant evaluation context

ychen added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103938/new/ https://reviews.llvm.org/D103938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc marked 9 inline comments as done. mibintc added a comment. A couple inline replies to go along with the updated patch Comment at: clang/include/clang/Driver/Options.td:1757 + LangOpts<"ProtectParens">, DefaultFalse, + PosFlag Should this option also be exposed to clan

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos created this revision. pmatos added a reviewer: tlively. Herald added subscribers: ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. pmatos requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, aheejin. Herald added projects: clang, LLVM. R

[PATCH] D104790: [x86] fix mm*_undefined* intrinsics to use arbitrary frozen bit pattern

craig.topper added a comment. In D104790#2836253 , @aqjune wrote: > I couldn't find end-to-end tests for checking assembly generation. > To check whether this is working ok, which tests should I write and how would > it look like? There are tests like t

[PATCH] D103938: Diagnose -Wunused-value in constant evaluation context

rsmith added a comment. I've given this some more thought, and I think it's only the "constant evaluated" check that we want to bypass in this case. It's common to use `sizeof` or `decltype` with a comma operator in order to put an expression in a SFINAE context, and I don't think we should war

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos added a comment. This patch would have fixed the problems with AArch64 caused by D95425 . However, since that was landed and reverted, this landed: https://github.com/llvm/llvm-project/commit/ac81cb7e6dde9b0890ee1780eae94ab96743569b This breaks the test

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos added a subscriber: reames. pmatos added a comment. Adding @reames to subscribers since he's the author of https://github.com/llvm/llvm-project/commit/ac81cb7e6dde9b0890ee1780eae94ab96743569b and might have something to add to the discussion. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D104388: [clang-format] PR50727 C# Invoke Lamda Expression indentation incorrect

MyDeveloperDay added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104388/new/ https://reviews.llvm.org/D104388 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

aaron.ballman added inline comments. Comment at: clang/include/clang/Driver/Options.td:1757 + LangOpts<"ProtectParens">, DefaultFalse, + PosFlag aaron.ballman wrote: > > Should this option also be exposed to clang-cl (should it be a > > `CoreOption`)? > I don't know the answer

[PATCH] D104800: [OpenCL] Do not include default header for preprocessor output as input

yaxunl created this revision. yaxunl added a reviewer: Anastasia. Herald added subscribers: kerbowa, nhaehnle, jvesely. yaxunl requested review of this revision. When clang driver is used with -save-temps to compile OpenCL program, clang driver first launches clang -cc1 -E to generate preprocessor

[PATCH] D104800: [OpenCL] Do not include default header for preprocessor output as input

yaxunl added a comment. I am not quite sure about whether "-fdeclare-opencl-builtins" should be kept when input is preprocessor output. Suggestions? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104800/new/ https://reviews.llvm.org/D104800 _

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

aaron.ballman added inline comments. Comment at: clang/test/AST/arithmetic-fence-builtin.c:34 + + v = (a + b); + aaron.ballman wrote: > Does the `(a + b)` still have an AST node for the `ParenExpr`? Nevermind, it won't, it'll have the `CallExpr` node. I think t

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe3d24b45b8f8: ThinLTO: Fix inline assembly references to static functions with CFI (authored by samitolvanen). Repository: rG LLVM Github Monorepo

[clang] 4a14206 - [AIX] Emitting diagnostics error for profile options

Author: Whitney Tsang Date: 2021-06-23T18:17:40Z New Revision: 4a14206522384f5868227145a6598f41710e6c91 URL: https://github.com/llvm/llvm-project/commit/4a14206522384f5868227145a6598f41710e6c91 DIFF: https://github.com/llvm/llvm-project/commit/4a14206522384f5868227145a6598f41710e6c91.diff LOG:

[PATCH] D104505: [HIP] Defer operator overloading errors

yaxunl added inline comments. Comment at: clang/test/SemaCUDA/deferred-oeverload.cu:55 callee3(); // dev-error {{no matching function for call to 'callee3'}} callee4(); // com-error {{no matching function for call to 'callee4'}} + S s; tra wrote: > If we're a

[PATCH] D104777: PR50767: clear non-distinct debuginfo for function with nodebug definition after undecorated declaration

dblaikie added a comment. In D104777#2836327 , @aaron.ballman wrote: > In D104777#2835965 , @dblaikie > wrote: > >> @aaron.ballman Do we have attributes/infrastructure for attributes that have >> to be the same

[PATCH] D104082: [CodeGen] Don't create a fake FunctionDecl when generating block/block_byref copy/dispose helper functions

zequanwu added a comment. In D104082#2835496 , @fhahn wrote: > In D104082#2835080 , @zequanwu > wrote: > >> Hi, this caused compiler crash with error "Assertion >> `cast(Scope)->describes(&MF->getFunction())' fa

[PATCH] D104800: [OpenCL] Do not include default header for preprocessor output as input

yaxunl added a comment. In D104800#2836594 , @yaxunl wrote: > I am not quite sure about whether "-fdeclare-opencl-builtins" should be kept > when input is preprocessor output. Suggestions? Thanks. The question is that whether those builtins declared thr

[PATCH] D104790: [x86] fix mm*_undefined* intrinsics to use arbitrary frozen bit pattern

craig.topper added a comment. We may want to update the code in X86ISelLowering getAVX2GatherNode and getGatherNode to replace freeze+poison on Src with a zero vector. We already do this when the Src is undef. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D104803: [AIX] Emitting diagnostics error for profile options

Whitney created this revision. Whitney added reviewers: hubert.reinterpretcast, etiotto, bmahjour, kbarton, daltenty. Whitney added a project: LLVM. Whitney requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Only LLVM-based instrumentation pr

[PATCH] D104774: [clang-format] Fix a bug that indents else-comment-if incorrectly

HazardyKnusperkeks added a comment. That was fast. I personally like it better to give others a chance to look at. ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104774/new/ https://reviews.llvm.org/D104774 _

  1   2   >