hans added a comment. In D104770#2835596 <https://reviews.llvm.org/D104770#2835596>, @aaron.ballman wrote:
> LGTM, though you could add a test that `#pragma system_header` gives a > diagnostic outside of `-fms-extensions` mode if you think that's valuable. Thanks! Yes, I'll do that, and I'll also add a test to see that it actually warns when no system_header is used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104770/new/ https://reviews.llvm.org/D104770 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits