yaxunl added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7619
if (CurKind == Action::OFK_HIP && CurDep->getOffloadingArch()) {
- Triples += '-';
+ Triples += "--";
Triples += CurDep->getOffloadingArch();
----------------
This is not HIP specific. Other toolchain could use a non-canonical triple too.
Also there may be more components of triple missing. A generic fix would be use
Triple::normalize for all toolchain. same as below.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93525/new/
https://reviews.llvm.org/D93525
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
