[PATCH] D103495: [static initializers] Don't put ordered dynamic initializers of static variables into global_ctors

MaskRay added a comment. In D103495#2804254 , @efriedma wrote: > Are there any existing optimizations that might be affected by this? In > particular, I think GlobalOpt implicitly reorders functions in global_ctors. Thanks for mentioning llvm::optimize

[PATCH] D101873: [clang] Support clang -fpic -fno-semantic-interposition for AArch64

MaskRay added a comment. In D101873#2804669 , @lanza wrote: > Hey Fangrui, is there any reason this couldn't extend to armv7? @lanza Always happy when more folks are interested in such kind of stuff:) This needs backend work. See D101872

[PATCH] D103874: [IR] Rename the shufflevector's undef mask to poison

aqjune created this revision. aqjune added reviewers: nikic, efriedma, spatel, fhahn, lebedev.ri, RKSimon. Herald added a reviewer: deadalnix. Herald added subscribers: dexonsmith, kerbowa, pengfei, dmgreen, zzheng, kbarton, hiraditya, nhaehnle, jvesely, nemanjai. aqjune requested review of this r

[clang] d3a6181 - [analyzer] [NFC] Implement a wrapper SValBuilder::getCastedMemRegionVal for similar functionality on region cast

Author: Denys Petrov Date: 2021-06-08T10:43:43+03:00 New Revision: d3a6181e82ca8d1c49c1bc049c07233bd8c38550 URL: https://github.com/llvm/llvm-project/commit/d3a6181e82ca8d1c49c1bc049c07233bd8c38550 DIFF: https://github.com/llvm/llvm-project/commit/d3a6181e82ca8d1c49c1bc049c07233bd8c38550.diff

[PATCH] D103803: [analyzer] [NFC] Implement a wrapper SValBuilder::getCastedMemRegionVal for similar functionality on region cast

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd3a6181e82ca: [analyzer] [NFC] Implement a wrapper SValBuilder::getCastedMemRegionVal for… (authored by ASDenysPetrov). Repository: rG LLVM Githu

[PATCH] D103678: [Format] Fix incorrect pointer/reference detection

Nuu updated this revision to Diff 350519. Nuu added a comment. Add more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103678/new/ https://reviews.llvm.org/D103678 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format

[PATCH] D103678: [Format] Fix incorrect pointer/reference detection

Nuu marked an inline comment as done. Nuu added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:243 + bool OperatorCalledAsMemberFunction = + Prev->Previous && Prev->Previous->isOneOf(tok::period, tok::arrow); + Contexts.back().IsExpres

[PATCH] D103875: [Fuchsia] Update some of the Fuchsia toolchain flags

phosek created this revision. phosek added reviewers: leonardchan, haowei. Herald added a subscriber: mgorny. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This should make the build more self-contained. Repository: rG LLVM Git

[PATCH] D101873: [clang] Support clang -fpic -fno-semantic-interposition for AArch64

peter.smith added a comment. Doing this on 32-bit Arm would make me nervous as STT_FUNC symbols encode the state of Arm/Thumb in the bottom bit, but STT_NOTYPE symbols do not. In principle it could be done but extra care would have to be taken to make sure no state changes were required. For ex

[clang] b34da6f - [clang] Apply MS ABI details on __builtin_ms_va_list on non-windows platforms on x86_64

Author: Martin Storsjö Date: 2021-06-08T12:14:12+03:00 New Revision: b34da6ff9c1d72816d0c9b87d5f0e879850bc424 URL: https://github.com/llvm/llvm-project/commit/b34da6ff9c1d72816d0c9b87d5f0e879850bc424 DIFF: https://github.com/llvm/llvm-project/commit/b34da6ff9c1d72816d0c9b87d5f0e879850bc424.diff

[PATCH] D103837: [clang] Apply MS ABI details on __builtin_ms_va_list on non-windows platforms on x86_64

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb34da6ff9c1d: [clang] Apply MS ABI details on __builtin_ms_va_list on non-windows platforms… (authored by mstorsjo). Repository: rG LLVM Github Mo

[PATCH] D102689: [C++] Ignore top-level qualifiers in casts

olestrohm updated this revision to Diff 350560. olestrohm retitled this revision from "[C++4OpenCL] Allow address space conversion in reinterpret_cast" to "[C++] Ignore top-level qualifiers in casts". olestrohm edited the summary of this revision. olestrohm added a comment. I've added a check in

[PATCH] D102850: [C++4OpenCL] Fix overloading resolution of addrspace constructors

olestrohm updated this revision to Diff 350561. olestrohm added a comment. I've reverted to using Constructors and prioritizing based on which constructor is the most qualified. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102850/new/ https://reviews.llvm.org/D102850 Files: clang/l

[PATCH] D103678: [Format] Fix incorrect pointer/reference detection

Nuu added a comment. Pre-check failure: the github server is currently down. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103678/new/ https://reviews.llvm.org/D103678 ___ cfe-commits mailing list cf

[PATCH] D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment

kadircet added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4567 if (ParamTy->isPointerType()) ArgTy = ArgTy->getPointeeType(); i think ArgTy becomes null after this operation. e.g. the function requires a pointer param, user provides a

[PATCH] D103241: [OpenCL] Add memory_scope_all_devices

azabaznov added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:113 OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_order_seq_cst, false, 300, OCL_C_30) +OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_scope_all_devices, false, 300, OCL_C_30) OPENCL_OPTI

[PATCH] D103842: NFC: .clang-tidy: Inherit configs from parents to improve maintainability

dblaikie created this revision. dblaikie added reviewers: hokein, aaron.ballman, jyknight, mehdi_amini, kuhnel. Herald added subscribers: dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagain

[PATCH] D103663: [AMDGPU] Add gfx1013 target

bcahoon updated this revision to Diff 350423. bcahoon added a comment. Addressed review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103663/new/ https://reviews.llvm.org/D103663 Files: clang/include/clang/Basic/Cuda.h clang/lib/Basic/Cuda.cpp clang/lib/Basic/Targets/AMD

[PATCH] D103663: [AMDGPU] Add gfx1013 target

bcahoon marked an inline comment as done. bcahoon added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:7341 +if (!Subtarget->hasGFX10_AEncoding()) + emitRemovedIntrinsicError(DAG, DL, Op.getValueType()); + rampitec wrote: > return

[PATCH] D103663: [AMDGPU] Add gfx1013 target

rampitec added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:4700 +B.getMF().getFunction().getContext().diagnose(BadIntrin); +B.buildUndef(MI.getOperand(0)); +MI.eraseFromParent(); rampitec wrote: > Just return false like

[PATCH] D103663: [AMDGPU] Add gfx1013 target

bcahoon updated this revision to Diff 350448. bcahoon added a comment. Changed legalizer to return false for raytracing intrinsics that are not supported by the subtarget. I changed both GlobalISel and regular ISel to work similarly. A crash occurs with a message that the intrinsic cannot be le

[PATCH] D103663: [AMDGPU] Add gfx1013 target

bcahoon added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:4700 +B.getMF().getFunction().getContext().diagnose(BadIntrin); +B.buildUndef(MI.getOperand(0)); +MI.eraseFromParent(); rampitec wrote: > rampitec wrote: > > Jus

[PATCH] D103663: [AMDGPU] Add gfx1013 target

rampitec added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:4701 +B.getMF().getFunction().getContext().diagnose(BadIntrin); +B.buildUndef(MI.getOperand(0)); +MI.eraseFromParent(); You can just omit undef and erase. CHA

[PATCH] D103663: [AMDGPU] Add gfx1013 target

bcahoon updated this revision to Diff 350468. bcahoon added a comment. Addressed review comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103663/new/ https://reviews.llvm.org/D103663 Files: clang/include/clang/Basic/Cuda.h clang/lib/Basic/Cuda.cpp clang/lib/Basic/Targets/AMD

[PATCH] D103663: [AMDGPU] Add gfx1013 target

foad added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPU.td:471 + "true", + "Encoding format GFX10_A" +>; I realise you're just following the precedent set by GFX10_B, but is this terminology actually used in any documentation anywhere? And if not

[PATCH] D103663: [AMDGPU] Add gfx1013 target

foad accepted this revision. foad added a comment. LGTM anyway, with or without any action on my last couple of comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103663/new/ https://reviews.llvm.org/D103663 ___ cfe-commits mailing list

[PATCH] D103842: NFC: .clang-tidy: Inherit configs from parents to improve maintainability

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103842/new/ https://reviews.llvm.org/D103842 ___ cfe-commits mailing li

[clang] d54e7b7 - [OpenCL] Add memory_scope_all_devices

Author: Sven van Haastregt Date: 2021-06-08T11:51:12+01:00 New Revision: d54e7b731e662e3ec19c590172c9827e3e184829 URL: https://github.com/llvm/llvm-project/commit/d54e7b731e662e3ec19c590172c9827e3e184829 DIFF: https://github.com/llvm/llvm-project/commit/d54e7b731e662e3ec19c590172c9827e3e184829.

[PATCH] D103241: [OpenCL] Add memory_scope_all_devices

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd54e7b731e66: [OpenCL] Add memory_scope_all_devices (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D103885: [clang] Suppress warnings for tautological comparison in generated macro code

protze.joachim created this revision. protze.joachim added reviewers: jdoerfert, aaron.ballman, hokein. protze.joachim added projects: clang, clang-tools-extra. Herald added subscribers: usaxena95, kadircet, arphaman, hiraditya. protze.joachim requested review of this revision. Herald added subscri

[PATCH] D103526: [clang][deps] Handle modular dependencies present in PCH

jansvoboda11 added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp:125 + ImportCollectingListener Listener(PrebuiltModuleFiles); + ASTReader::readASTFileControlBlock( + Compiler.getPreprocessorOpts().ImplicitPCHIn

[PATCH] D103678: [Format] Fix incorrect pointer/reference detection

MyDeveloperDay accepted this revision. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:236 +Prev = Prev->Previous; +assert(Prev); + } Do we need to worry about `Prev` ever being null? Does the assert ever

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

MyDeveloperDay added a comment. In D101868#2803670 , @feg208 wrote: > Ok. Given @HazardyKnusperkeks comment I'll make the default be left alignment > and update the tests accordingly You could add `AlignArrayOfStructuresMemberAlignment` `Left:Right` y

[PATCH] D103611: Correct the behavior of va_arg checking in C++

aaron.ballman updated this revision to Diff 350575. aaron.ballman added a comment. Updated the comment and removed a check for C++ mode. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103611/new/ https://reviews.llvm.org/D103611 Files: clang/lib/Sema/SemaExpr.cpp clang/test/SemaCXX/

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

MyDeveloperDay added a comment. Better still how about having ArraryMemberAligmentEnum AlignArrayOfStructures of "None, Left and Right" I find boolean options don't stay boolean for long! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new

[PATCH] D103611: Correct the behavior of va_arg checking in C++

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:15789-15790 +: Context.getCorrespondingUnsignedType(UnderlyingType); +if (Context.typesAreCompatible(PromoteType, UnderlyingType, + /*Compare

[PATCH] D103495: [static initializers] Don't put ordered dynamic initializers of static variables into global_ctors

mstorsjo added a comment. Thanks for looping me in; I don't have any objection to this, as far as I can see, the reasoning seems sensible, and the most brittle testcase I have (from what I remember offhand) seems to run fine with this change. CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D103885: [clang] Suppress warnings for tautological comparison in generated macro code

aaron.ballman added a comment. This sort of diagnostic suppression is not portable and will require checking for `#ifdef __clang__`. Personally, I'm not fond of this style of diagnostic suppression (non-portable and rather distracting due to verbosity), but I don't know that there's a better wa

[clang] 012898b - [clang] p1099 using enum part 1

Author: Nathan Sidwell Date: 2021-06-08T04:40:42-07:00 New Revision: 012898b92cad00e230a960a08a3f418628bec060 URL: https://github.com/llvm/llvm-project/commit/012898b92cad00e230a960a08a3f418628bec060 DIFF: https://github.com/llvm/llvm-project/commit/012898b92cad00e230a960a08a3f418628bec060.diff

[PATCH] D100276: [clang] p1099 3/5: using Enum::member

This revision was automatically updated to reflect the committed changes. Closed by commit rG012898b92cad: [clang] p1099 using enum part 1 (authored by urnathan). Changed prior to commit: https://reviews.llvm.org/D100276?vs=349634&id=350578#toc Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov updated this revision to Diff 350579. ASDenysPetrov added a comment. Added a boolean option `handle-integral-cast-for-ranges` under `-analyzer-config` flag. Disabled the feature by default. @Noq, @steakhal How do you think whether it's neccesory to add any changes in `SMTConstrai

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

curdeius added a comment. In D101868#2805180 , @MyDeveloperDay wrote: > Better still how about having > > ArraryMemberAligmentEnum AlignArrayOfStructures > > of "None, Left and Right" > > I find boolean options don't stay boolean for long! A strong +1

[PATCH] D103678: [Format] Fix incorrect pointer/reference detection

curdeius accepted this revision. curdeius added a comment. LGTM modulo nits. Comment at: clang/lib/Format/TokenAnnotator.cpp:232 if (Left->is(TT_OverloadedOperatorLParen)) { - Contexts.back().IsExpression = false; + // Find the previous kw_operator token + F

[clang] 22875b2 - [NFC] Remove some include cycles

Author: Timm Bäder Date: 2021-06-08T14:00:39+02:00 New Revision: 22875b2ce3fd8a5cf4f615ed7e91950f613ba9d4 URL: https://github.com/llvm/llvm-project/commit/22875b2ce3fd8a5cf4f615ed7e91950f613ba9d4 DIFF: https://github.com/llvm/llvm-project/commit/22875b2ce3fd8a5cf4f615ed7e91950f613ba9d4.diff LO

[PATCH] D103885: [clang] Suppress warnings for tautological comparison in generated macro code

protze.joachim added a comment. I don't think, this needs ifdefs. As I understand, a compiler is supposed to ignore unknown pragmas. I fully agree that the suppression will not be compatible with other compilers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D103885: [clang] Suppress warnings for tautological comparison in generated macro code

aaron.ballman added a comment. In D103885#2805217 , @protze.joachim wrote: > I don't think, this needs ifdefs. As I understand, a compiler is supposed to > ignore unknown pragmas. It does. You can see it produces diagnostics in `-Wall` mode in GCC and

[PATCH] D103888: [ADT] Remove APInt/APSInt toString() std::string variants

RKSimon created this revision. RKSimon added reviewers: nikic, bkramer, craig.topper, dblaikie, rsmith, zturner. Herald added subscribers: ormris, dexonsmith, martong, usaxena95, pengfei, kadircet, arphaman, kbarton, hiraditya, nemanjai. Herald added a reviewer: aaron.ballman. RKSimon requested r

[PATCH] D103894: NarrowingConversionsCheck should support inhibiting conversions of mixed integer and floating point types with WarnOnEquivalentBitWidth=0.

Stephen created this revision. Stephen added a reviewer: hokein. Herald added subscribers: kbarton, nemanjai. Stephen requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Also standardize control flow of handleX conversion functions

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 added a comment. In D101868#2805180 , @MyDeveloperDay wrote: > Better still how about having > > ArraryMemberAligmentEnum AlignArrayOfStructures > > of "None, Left and Right" > > I find boolean options don't stay boolean for long! Yeah once I s

[PATCH] D103605: [analyzer] Introduce a new interface for tracking

vsavchenko added a comment. In D103605#2804421 , @NoQ wrote: > These are not other topics. We're discussing the overall direction into which > this patchset is a large step. I absolutely welcome this step and am > fascinated to see how it turns out but

[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 350599. pmatos added a comment. Fix details requested by @tlively in latest comemnts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95425/new/ https://reviews.llvm.org/D95425 Files: clang/lib/Basic/Targets/We

[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

pmatos marked 6 inline comments as done. pmatos added a comment. Hopefully we are close to landing this. :) Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrTable.td:19 [], "table.get\t$res, $table",

[clang] 054cc3b - [CUDA][HIP] Fix store of vtbl in ctor

Author: Yaxun (Sam) Liu Date: 2021-06-08T10:24:44-04:00 New Revision: 054cc3b1b469de4b0cb25d1dc3af43c679c5dc44 URL: https://github.com/llvm/llvm-project/commit/054cc3b1b469de4b0cb25d1dc3af43c679c5dc44 DIFF: https://github.com/llvm/llvm-project/commit/054cc3b1b469de4b0cb25d1dc3af43c679c5dc44.dif

[PATCH] D103835: [CUDA][HIP] Fix store of vtbl in ctor

This revision was automatically updated to reflect the committed changes. Closed by commit rG054cc3b1b469: [CUDA][HIP] Fix store of vtbl in ctor (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103835

[PATCH] D97085: [OpenMP] libomp: implement OpenMP 5.1 inoutset task dependence type

protze.joachim added inline comments. Comment at: openmp/runtime/src/kmp_taskdeps.cpp:418 if (dep_list[i].base_addr != 0) { + KMP_DEBUG_ASSERT( + dep_list[i].flag == KMP_DEP_IN || dep_list[i].flag == KMP_DEP_OUT || I hit this assertion, when co

[PATCH] D103784: [X86] Support __tile_stream_loadd intrinsic for new AMX interface

LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/X86FastTileConfig.cpp:124 bool X86FastTileConfig::isTileLoad(MachineInstr &MI) { + return MI.getOpcode() == X86::PTILELOADDV || Also add the stream load for X86PreAMXConfig.cpp: isTileLoad().

[PATCH] D103048: [IR] make -stack-alignment= into a module attr

nickdesaulniers added a comment. Thanks for the review! Notified downstream dependents: - https://github.com/llvm-hs/llvm-hs/issues/345 - https://github.com/halide/Halide/issues/6079 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103048/new/ https

[clang] c5d56fe - NFC: .clang-tidy: Inherit configs from parents to improve maintainability

Author: David Blaikie Date: 2021-06-08T08:25:59-07:00 New Revision: c5d56fec502f36a0c994835ca23bc93a6c682d95 URL: https://github.com/llvm/llvm-project/commit/c5d56fec502f36a0c994835ca23bc93a6c682d95 DIFF: https://github.com/llvm/llvm-project/commit/c5d56fec502f36a0c994835ca23bc93a6c682d95.diff

[PATCH] D103842: NFC: .clang-tidy: Inherit configs from parents to improve maintainability

This revision was automatically updated to reflect the committed changes. Closed by commit rGc5d56fec502f: NFC: .clang-tidy: Inherit configs from parents to improve maintainability (authored by dblaikie). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang] 433c8d9 - [IR] make -stack-alignment= into a module attr

Author: Nick Desaulniers Date: 2021-06-08T08:31:04-07:00 New Revision: 433c8d950cb3a1fa0977355ce0367e8c763a3f13 URL: https://github.com/llvm/llvm-project/commit/433c8d950cb3a1fa0977355ce0367e8c763a3f13 DIFF: https://github.com/llvm/llvm-project/commit/433c8d950cb3a1fa0977355ce0367e8c763a3f13.di

[PATCH] D103048: [IR] make -stack-alignment= into a module attr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG433c8d950cb3: [IR] make -stack-alignment= into a module attr (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

MyDeveloperDay added a comment. > Save the name. I should have it rolled up shortly. You an keep the name, just change the type to be an enum Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ https://reviews.llvm.org/D101868 _

[PATCH] D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment

adamcz updated this revision to Diff 350612. adamcz added a comment. added a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103825/new/ https://reviews.llvm.org/D103825 Files: clang/lib/Sema/SemaChecking.cpp clang/test/SemaCXX/recovery-exp

[PATCH] D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment

adamcz updated this revision to Diff 350613. adamcz added a comment. update commit description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103825/new/ https://reviews.llvm.org/D103825 Files: clang/lib/Sema/SemaChecking.cpp clang/test/SemaCXX

[PATCH] D103678: [Format] Fix incorrect pointer/reference detection

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:236 +Prev = Prev->Previous; +assert(Prev); + } curdeius wrote: > MyDeveloperDay wrote: > > Do we need to worry about `Prev` ever being null? Does the assert

[PATCH] D103678: [Format] Fix incorrect pointer/reference detection

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:8283-8286 + // TODO: + // Calling an operator as a non-member function is hard to distinguish + // verifyFormat("void f() { operator*(a & a); }"); + // verifyFormat("void f() { operator&(a

Re: [clang] e6629be - [AIX] Define __STDC_NO_ATOMICS__ and __STDC_NO_THREADS__ predefined macros

On Mon, Jun 07, 2021 at 07:04:36PM -0700, via cfe-commits wrote: > > Author: =Jake Egan > Date: 2021-06-07T22:04:18-04:00 > New Revision: e6629be31e67190f0a524f009752d73410894560 > > URL: > https://github.com/llvm/llvm-project/commit/e6629be31e67190f0a524f009752d73410894560 > DIFF: > https://gi

[PATCH] D103902: [analyzer] Extract NilReceiverHandler

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus, manas, RedDocMD. Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision.

[clang] a596b54 - Revert "[IR] make -stack-alignment= into a module attr"

Author: Nick Desaulniers Date: 2021-06-08T08:55:50-07:00 New Revision: a596b54d471cfde548bdda3925ea2f143f06b964 URL: https://github.com/llvm/llvm-project/commit/a596b54d471cfde548bdda3925ea2f143f06b964 DIFF: https://github.com/llvm/llvm-project/commit/a596b54d471cfde548bdda3925ea2f143f06b964.di

[PATCH] D103905: fix typo in internals manual

jakevossen5 created this revision. jakevossen5 added a reviewer: aaron.ballman. jakevossen5 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. You can see the typo here: https://clang.llvm.org/docs/InternalsManual.html#include-clang-basic-att

[clang] 172fcd9 - [clang-cl] Parse the /external: flags (PR36003)

Author: Hans Wennborg Date: 2021-06-08T18:00:03+02:00 New Revision: 172fcd9600e13d5365f5cf648105891ff6a0e59d URL: https://github.com/llvm/llvm-project/commit/172fcd9600e13d5365f5cf648105891ff6a0e59d DIFF: https://github.com/llvm/llvm-project/commit/172fcd9600e13d5365f5cf648105891ff6a0e59d.diff

[PATCH] D103495: [static initializers] Don't put ordered dynamic initializers of static variables into global_ctors

rnk added a subscriber: asbirlea. rnk added a comment. I think we do need to think about globalopt. Consider this example: extern "C" { int printf(const char *, ...); extern int sharedState; int sharedState = 0; int init1() { asm volatile(""); // block globalopt return ++sharedS

[PATCH] D103905: fix typo in internals manual

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the fix! Do you need me to land it on your behalf? If so, what name and email would you like me to use for patch attribution? Repository: rG LLVM Github Mo

[PATCH] D103905: fix typo in internals manual

jakevossen5 added a comment. Don't think I have permissions to that, so that would be great! Name: Jake Vossen Email: j...@vossen.dev Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103905/new/ https://reviews.llvm.org/D103905 _

[clang] 71fb98e - Fix a typo in the internals manual

Author: Jake Vossen Date: 2021-06-08T12:32:56-04:00 New Revision: 71fb98e0c1de97c8ba2aa3292447b0c5d0f248d5 URL: https://github.com/llvm/llvm-project/commit/71fb98e0c1de97c8ba2aa3292447b0c5d0f248d5 DIFF: https://github.com/llvm/llvm-project/commit/71fb98e0c1de97c8ba2aa3292447b0c5d0f248d5.diff L

[PATCH] D103905: fix typo in internals manual

aaron.ballman closed this revision. aaron.ballman added a comment. In D103905#2805700 , @jakevossen5 wrote: > Don't think I have permissions to that, so that would be great! > > Name: Jake Vossen > Email: j...@vossen.dev Thanks -- I've commit on your be

[PATCH] D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment

adamcz updated this revision to Diff 350629. adamcz added a comment. Added some containsErrors() calls, not sure if that's the right thing to do Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103825/new/ https://reviews.llvm.org/D103825 Files: cl

[PATCH] D103909: [CSSPGO] Emit mangled dwarf names for line tables debug option under -fpseudo-probe-for-profiling

hoy created this revision. Herald added a subscriber: wenlei. hoy requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D103909 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/te

[PATCH] D103885: [clang] Suppress warnings for tautological comparison in generated macro code

ychen added a comment. We could use a table to avoid the warning and speed the build a little bit. https://reviews.llvm.org/D98110 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103885/new/ https://reviews.llvm.org/D103885

[PATCH] D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment

adamcz added reviewers: kadircet, hokein. adamcz added a comment. FYI The ArgTy.isNull() check is sufficient to fix this. The Arg->containsErrors() is not - it's false in this case, since it seems CXXDefaultArgExpr with RecoveryExpr inside seems to not contains errors, according to containsErro

[PATCH] D103911: [OpenCL] Add support of __opencl_c_images feature macro

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: ldrumm, yaxunl. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.o

[clang] ea10a86 - [AMDGPU] Add gfx1013 target

Author: Brendon Cahoon Date: 2021-06-08T12:49:49-04:00 New Revision: ea10a86984ea73fcec3b12d22404a15f2f59b219 URL: https://github.com/llvm/llvm-project/commit/ea10a86984ea73fcec3b12d22404a15f2f59b219 DIFF: https://github.com/llvm/llvm-project/commit/ea10a86984ea73fcec3b12d22404a15f2f59b219.diff

[PATCH] D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. as discussed offline LG from my side. regarding the default arg of a parameter containing an error, it seems to be effecting type information of the parameter even though the type is expli

[clang] 1dba2a0 - [Fuchsia] Update some of the Fuchsia toolchain flags

Author: Petr Hosek Date: 2021-06-08T10:04:19-07:00 New Revision: 1dba2a026956b0f3918dcf8bb1d3f3483db2de8c URL: https://github.com/llvm/llvm-project/commit/1dba2a026956b0f3918dcf8bb1d3f3483db2de8c DIFF: https://github.com/llvm/llvm-project/commit/1dba2a026956b0f3918dcf8bb1d3f3483db2de8c.diff LO

[PATCH] D103875: [Fuchsia] Update some of the Fuchsia toolchain flags

This revision was automatically updated to reflect the committed changes. Closed by commit rG1dba2a026956: [Fuchsia] Update some of the Fuchsia toolchain flags (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103875/new/ https://r

[PATCH] D103495: [static initializers] Emit global_ctors and global_dtors in reverse order when init_array is not used.

wolfgangp updated this revision to Diff 350644. wolfgangp retitled this revision from "[static initializers] Don't put ordered dynamic initializers of static variables into global_ctors" to "[static initializers] Emit global_ctors and global_dtors in reverse order when init_array is not used.".

[PATCH] D103495: [static initializers] Emit global_ctors and global_dtors in reverse order when init_array is not used.

wolfgangp added a comment. In D103495#2804685 , @MaskRay wrote: > > Can you check whether clang/lib/CodeGen/CGDeclCXX.cpp:507 needs any comment > update? > The subject "Don't put ordered dynamic initializers of static variables into > global_ctors"

[PATCH] D103564: [NFC][compiler-rt][hwasan] Move allocation functions into their own file

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: compiler-rt/lib/hwasan/hwasan_interceptors.cpp:171 } // namespace __hwasan +#else // #if !SANITIZER_FUCHSIA +namespace __hwasan {

[PATCH] D103663: [AMDGPU] Add gfx1013 target

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGea10a86984ea: [AMDGPU] Add gfx1013 target (authored by bcahoon). Changed prior to commit: https://reviews.llvm.org/D103663?vs=350468&id=350640#toc

[PATCH] D103663: [AMDGPU] Add gfx1013 target

bcahoon marked an inline comment as done. bcahoon added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPU.td:471 + "true", + "Encoding format GFX10_A" +>; foad wrote: > I realise you're just following the precedent set by GFX10_B, but is this > termin

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

zukatsinadze updated this revision to Diff 350656. zukatsinadze marked 2 inline comments as done. zukatsinadze added a comment. @balazske Thanks for the comments! Updated diff after suggested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97699/new/ https://reviews.llvm.org/D97

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

zukatsinadze marked an inline comment as done and an inline comment as not done. zukatsinadze added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:947 + +} // end "alpha.cert.env" + balazske wrote: > I have multiple issues wi

[PATCH] D103909: [CSSPGO] Emit mangled dwarf names for line tables debug option under -fpseudo-probe-for-profiling

wenlei accepted this revision. wenlei added a comment. This revision is now accepted and ready to land. lgtm, thanks for the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103909/new/ https://reviews.llvm.org/D103909 __

[PATCH] D103885: [clang] Suppress warnings for tautological comparison in generated macro code

aaron.ballman added a comment. In D103885#2805758 , @ychen wrote: > We could use a table to avoid the warning and speed the build a little bit. > https://reviews.llvm.org/D98110 That's an interesting approach, thank you for sharing it! I wonder how use

[PATCH] D103914: [analyzer] Extract ArrayIndexHandler

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus, manas, RedDocMD. Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, arphaman, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this

[PATCH] D103849: Fix undeduced type when instanciating template member

aaron.ballman edited subscribers, added: cfe-commits; removed: rsmith. aaron.ballman added a comment. Adding the mailing lists to the review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103849/new/ https://reviews.llvm.org/D103849 ___ cfe-c

[PATCH] D103048: [IR] make -stack-alignment= into a module attr

nickdesaulniers updated this revision to Diff 350660. nickdesaulniers added a comment. This revision is now accepted and ready to land. Herald added subscribers: atanasyan, sdardis. - fixes for MIPS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1030

[PATCH] D103916: [CMake] Only include LTO on Apple targets

phosek created this revision. phosek added reviewers: haowei, leonardchan. Herald added subscribers: inglorion, mgorny. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We only need libLTO when using ld64. Repository: rG LLVM Gith

[PATCH] D103495: [static initializers] Emit global_ctors and global_dtors in reverse order when init_array is not used.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM. Making the order of constructors independent of UseInitArray seems obviously good in any case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103495/new/ https://reviews.ll

[PATCH] D103916: [CMake] Only include LTO on Apple targets

phosek updated this revision to Diff 350662. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103916/new/ https://reviews.llvm.org/D103916 Files: clang/cmake/caches/Fuchsia-stage2.cmake clang/cmake/caches/Fuchsia.cmake Index: clang/cmake/caches/F

  1   2   >