MyDeveloperDay accepted this revision. MyDeveloperDay added inline comments.
================ Comment at: clang/lib/Format/TokenAnnotator.cpp:236 + Prev = Prev->Previous; + assert(Prev); + } ---------------- Do we need to worry about `Prev` ever being null? Does the assert ever fire? if not why have it in the first place? We'll crash if it is, do we want to guard against that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103678/new/ https://reviews.llvm.org/D103678 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
