vitalybuka accepted this revision.
vitalybuka added inline comments.
This revision is now accepted and ready to land.
================
Comment at: compiler-rt/lib/hwasan/hwasan_interceptors.cpp:171
} // namespace __hwasan
+#else // #if !SANITIZER_FUCHSIA
+namespace __hwasan {
----------------
mcgrathr wrote:
> blank lines around `#else` and `#endif` lines. But here I think you just
> omit this. We can define the empty function in a fuchsia-specific file.
>
+1 to "empty function in a fuchsia-specific file"
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103564/new/
https://reviews.llvm.org/D103564
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
