[PATCH] D98774: [AST] De-duplicate empty node introspection

This revision was automatically updated to reflect the committed changes. Closed by commit rGaee6c86c4dc7: [AST] De-duplicate empty node introspection (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D98774?vs=331300&id=339559#toc Repository: rG LLVM Github Monor

[PATCH] D98774: [AST] De-duplicate empty node introspection

steveire added a comment. In D98774#2701853 , @thakis wrote: > I think it is? https://llvm.org/docs/GettingStarted.html#software lists it at > least. Thanks, I'll look into that soon and see how the buildbots respond. Repository: rG LLVM Github Monor

[PATCH] D101049: [AST] Add DeclarationNameInfo to node introspection

steveire created this revision. steveire added a reviewer: njames93. Herald added a subscriber: mgrang. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D101049 Files:

[PATCH] D101049: [AST] Add DeclarationNameInfo to node introspection

steveire updated this revision to Diff 339563. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101049/new/ https://reviews.llvm.org/D101049 Files: clang/include/clang/Tooling/NodeIntrospection.h clang/lib/Tooling

[PATCH] D100972: [clang-tidy] cppcoreguidelines-avoid-non-const-global-variables: add fixes to checks

mgartmann updated this revision to Diff 339565. mgartmann added a comment. - Renamed `printCleanedType()` to `cleanType()` - Extended `cleanType()` to also remove `(anonymous)` from a type - Made `hasSpaceAfterType()` more error-robust. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] 5e50f47 - [AST] Add clarification comment

Author: Stephen Kelly Date: 2021-04-22T12:51:25+01:00 New Revision: 5e50f473d9597e8d14bda2f8659f512376ed9027 URL: https://github.com/llvm/llvm-project/commit/5e50f473d9597e8d14bda2f8659f512376ed9027 DIFF: https://github.com/llvm/llvm-project/commit/5e50f473d9597e8d14bda2f8659f512376ed9027.diff

[PATCH] D100976: [OpenCL] Simplify use of C11 atomic types

Anastasia added inline comments. Comment at: clang/test/Parser/opencl-atomics-cl20.cl:7-8 -#ifdef EXT -#pragma OPENCL EXTENSION cl_khr_int64_base_atomics:enable -#pragma OPENCL EXTENSION cl_khr_int64_extended_atomics:enable -#pragma OPENCL EXTENSION cl_khr_fp64:enable -#if __OP

[PATCH] D100984: [OpenCL] Remove the need for subgroupd extension pragma in enqueue kernel builtins

azabaznov added a comment. > Btw I am not suggesting removing the pragma. We will still have to parse it > for backward compatibility. I am only dropping the requirement of using it in > order to call get_kernel_max_sub_group_size_for_ndrange or > get_kernel_sub_group_count_for_ndrange when the

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

Anastasia added a comment. In D100980#2708012 , @azabaznov wrote: > Same as for https://reviews.llvm.org/D100984, `cl_khr_fp64` wasn't always > core and thus it requires pragma for OpenCL C < 1.2 versions. > > //9.3 Double Precision Floating-Point, OpenC

[PATCH] D100984: [OpenCL] Remove the need for subgroupd extension pragma in enqueue kernel builtins

Anastasia added a comment. In D100984#2708168 , @azabaznov wrote: >> Btw I am not suggesting removing the pragma. We will still have to parse it >> for backward compatibility. I am only dropping the requirement of using it >> in order to call get_kernel

[clang] 850e01a - [clang][deps] Check extra args in tests

Author: Jan Svoboda Date: 2021-04-22T14:10:08+02:00 New Revision: 850e01a34d47954ed5cebbd4aa98e8efd711cd19 URL: https://github.com/llvm/llvm-project/commit/850e01a34d47954ed5cebbd4aa98e8efd711cd19 DIFF: https://github.com/llvm/llvm-project/commit/850e01a34d47954ed5cebbd4aa98e8efd711cd19.diff L

[PATCH] D101051: [clang][deps] Only generate absolute paths when asked to

jansvoboda11 created this revision. jansvoboda11 added a reviewer: Bigcheese. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add option to `clang-scan-deps` to enable/disable generation of command-line arguments with absolute

[PATCH] D101041: [analyzer] Find better description for tracked symbolic values

vsavchenko updated this revision to Diff 339578. vsavchenko added a comment. Minor fix in comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101041/new/ https://reviews.llvm.org/D101041 Files: clang/lib/StaticAnalyzer/Core/BugReporterVisitor

[PATCH] D101052: [OpenCL] allow pipe as a valid identifier prior to OpenCL 2.0

Anastasia created this revision. Anastasia added reviewers: svenvh, azabaznov. Herald added subscribers: ebevhan, yaxunl. Anastasia requested review of this revision. pipe has not been a reserved keyword in the earlier OpenCL standards https://www.khronos.org/registry/OpenCL/specs/opencl-1.2.pdf

[PATCH] D100972: [clang-tidy] cppcoreguidelines-avoid-non-const-global-variables: add fixes to checks

mgartmann updated this revision to Diff 339574. mgartmann added a comment. Fixed one-off error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100972/new/ https://reviews.llvm.org/D100972 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/Avo

[clang] 5780dbe - [-Wcalled-once] Do not run analysis on Obj-C++

Author: Valeriy Savchenko Date: 2021-04-22T15:20:52+03:00 New Revision: 5780dbeee6480fdceae66fb57dcc7bd1cfcda5c9 URL: https://github.com/llvm/llvm-project/commit/5780dbeee6480fdceae66fb57dcc7bd1cfcda5c9 DIFF: https://github.com/llvm/llvm-project/commit/5780dbeee6480fdceae66fb57dcc7bd1cfcda5c9.d

[PATCH] D100955: [-Wcalled-once] Do not run analysis on Obj-C++

This revision was automatically updated to reflect the committed changes. Closed by commit rG5780dbeee648: [-Wcalled-once] Do not run analysis on Obj-C++ (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100955/new/ https://rev

[PATCH] D101054: [AST] Sort introspection results without instantiating other data

steveire created this revision. steveire added a reviewer: njames93. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Avoid string allocation in particular, but also avoid attempting to impose any particular ordering based on format

[PATCH] D93325: Add srcloc output to clang-query

steveire updated this revision to Diff 339583. steveire added a comment. Herald added a subscriber: mgrang. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93325/new/ https://reviews.llvm.org/D93325 Files: clang-tools-extra/clang-query/CMak

[clang] 6ad7e87 - clang: libstdc++ LWM is 4.8.3

Author: Nathan Sidwell Date: 2021-04-22T05:26:07-07:00 New Revision: 6ad7e87806c0af774cf2f8880694f79259925979 URL: https://github.com/llvm/llvm-project/commit/6ad7e87806c0af774cf2f8880694f79259925979 DIFF: https://github.com/llvm/llvm-project/commit/6ad7e87806c0af774cf2f8880694f79259925979.diff

[PATCH] D100465: clang: Remove __atomic libstdc++ hack

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ad7e87806c0: clang: libstdc++ LWM is 4.8.3 (authored by urnathan). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

ABataev added a comment. Could you check that it does not break the tests from https://github.com/clang-ykt/omptests? IIRC, "ref" was introduced to fix a bug with too early optimizations of the declare target variables defined in other modules. Check `t-same-name-definitions` especially, though

[PATCH] D100776: [clang/Basic] Make TargetInfo.h not use DataLayout again

thakis added a comment. rnk, echristo: can we go ahead here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100776/new/ https://reviews.llvm.org/D100776 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang] 6f48d6a - [AST] Make comment a bit more specific

Author: Stephen Kelly Date: 2021-04-22T13:40:56+01:00 New Revision: 6f48d6a9df69b489a741e3f8f72a4559c033b23c URL: https://github.com/llvm/llvm-project/commit/6f48d6a9df69b489a741e3f8f72a4559c033b23c DIFF: https://github.com/llvm/llvm-project/commit/6f48d6a9df69b489a741e3f8f72a4559c033b23c.diff

[PATCH] D98774: [AST] De-duplicate empty node introspection

thakis added a comment. In D98774#2708108 , @steveire wrote: > In D98774#2701853 , @thakis wrote: > >> I think it is? https://llvm.org/docs/GettingStarted.html#software lists it >> at least. > > Thanks, I'll look i

[PATCH] D101043: [OpenCL] Drop extension pragma handling for extension types/declarations

yaxunl added a comment. Did you check whether this patch will cause regression in OpenCL conformance tests? If not, I am OK with it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101043/new/ https://reviews.llvm.org/D101043 ___ cfe-commits m

[PATCH] D101059: [X86][AMX] Add description for AMX new interface.

LuoYuanke created this revision. LuoYuanke requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D101059 Files: clang/lib/Headers/amxintrin.h Index: clang/lib/Headers/amxintrin.h

[PATCH] D101052: [OpenCL] allow pipe as a valid identifier prior to OpenCL 2.0

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101052/new/ https://reviews.llvm.org/D101052 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D101059: [X86][AMX] Add description for AMX new interface.

LuoYuanke updated this revision to Diff 339597. LuoYuanke added a comment. Fix some descriptions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101059/new/ https://reviews.llvm.org/D101059 Files: clang/lib/Headers/amxintrin.h Index: clang/lib/H

[PATCH] D101043: [OpenCL] Drop extension pragma handling for extension types/declarations

Anastasia added a comment. In D101043#2708358 , @yaxunl wrote: > Did you check whether this patch will cause regression in OpenCL conformance > tests? If not, I am OK with it. This change has no impact on CTS as CTS has never had negative compiler tests

[PATCH] D101060: [Analyzer][StdLibraryFunctionsChecker] Describe arg constraints

martong created this revision. martong added reviewers: steakhal, NoQ, vsavchenko. Herald added subscribers: ASDenysPetrov, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szeleth

[PATCH] D101060: [Analyzer][StdLibraryFunctionsChecker] Describe arg constraints

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1 -//=== StdLibraryFunctionsChecker.cpp - Model standard functions -*- C++ -*-===// // upsz Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D100611: [RISCV] Add new attribute __clang_riscv_builtin_alias for intrinsics.

HsiangKai updated this revision to Diff 339602. HsiangKai added a comment. Add clang attribute `clang_builtin_alias`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100611/new/ https://reviews.llvm.org/D100611 Files: clang/include/clang/Basic/Att

[PATCH] D101060: [Analyzer][StdLibraryFunctionsChecker] Describe arg constraints

martong updated this revision to Diff 339603. martong marked an inline comment as not done. martong added a comment. - Put back first line - Remove wrong comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101060/new/ https://reviews.llvm.org/D10

[PATCH] D101043: [OpenCL] Drop extension pragma handling for extension types/declarations

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101043/new/ https://reviews.llvm.org/D101043 ___ cfe-commits mailing list cfe-

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan added a comment. In D93031#2706660 , @cor3ntin wrote: >>> We should use the original source form of the string literal when >>> pretty-printing a `StringLiteral` or `CharacterLiteral`; there are a bunch >>> of UTF-8 assumptions ba

[PATCH] D99877: [Clang] Allow processing of attributes on statements by plugins

Qix- abandoned this revision. Qix- added a comment. Closing in favor of more complete plugin attribute changes discussed in IRC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99877/new/ https://reviews.llvm.org/D99877 _

[PATCH] D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes

Qix- abandoned this revision. Qix- added a comment. Closing in favor of more complete plugin attribute changes discussed in IRC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99861/new/ https://reviews.llvm.org/D99861 _

[PATCH] D101060: [Analyzer][StdLibraryFunctionsChecker] Describe arg constraints

vsavchenko added a comment. Great job! Thanks! Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:338-339 } +llvm_unreachable("The constraint must be either a concrete value or " + "encoded in an argument.");

[PATCH] D100611: [Clang] Add clang attribute `clang_builtin_alias`.

HsiangKai updated this revision to Diff 339606. HsiangKai added a comment. Update test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100611/new/ https://reviews.llvm.org/D100611 Files: clang/include/clang/Basic/Attr.td clang/include/clan

[PATCH] D100968: Update shebang for clang-format-diff script to python3.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG71e80386d0fe: Update shebang for clang-format-diff script to python3. (authored by PaulkaToast). Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] 71e8038 - Update shebang for clang-format-diff script to python3.

Author: Paula Toth Date: 2021-04-22T06:47:51-07:00 New Revision: 71e80386d0fe7f7a2f997271ce5d492d5e8686c2 URL: https://github.com/llvm/llvm-project/commit/71e80386d0fe7f7a2f997271ce5d492d5e8686c2 DIFF: https://github.com/llvm/llvm-project/commit/71e80386d0fe7f7a2f997271ce5d492d5e8686c2.diff LO

[clang] 4138e7b - [OpenCL] Add missing C++ legacy atomics with generic

Author: Sven van Haastregt Date: 2021-04-22T15:08:36+01:00 New Revision: 4138e7bd7692c27a4959191939bba899b4f240da URL: https://github.com/llvm/llvm-project/commit/4138e7bd7692c27a4959191939bba899b4f240da DIFF: https://github.com/llvm/llvm-project/commit/4138e7bd7692c27a4959191939bba899b4f240da.

[PATCH] D100935: [OpenCL] Add missing C++ legacy atomics with generic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4138e7bd7692: [OpenCL] Add missing C++ legacy atomics with generic (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] 362958a - [C++4OpenCL] Add extra diagnostics for kernel argument types

Author: Anastasia Stulova Date: 2021-04-22T15:28:04+01:00 New Revision: 362958ac7346ba3539f819e9fe93d2529caad1e8 URL: https://github.com/llvm/llvm-project/commit/362958ac7346ba3539f819e9fe93d2529caad1e8 DIFF: https://github.com/llvm/llvm-project/commit/362958ac7346ba3539f819e9fe93d2529caad1e8.d

[PATCH] D100471: [C++4OpenCL] Add extra diagnostics for kernel argument types

This revision was automatically updated to reflect the committed changes. Closed by commit rG362958ac7346: [C++4OpenCL] Add extra diagnostics for kernel argument types (authored by Anastasia). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100471/new/

[PATCH] D100860: [C++4OpenCL] Add missing OpenCL specific diagnostics in templates

svenvh added a comment. > I've left the check during parsing as well, because it provides slightly > better error messages Do you have an example of what error messages get worse if you remove the parsing check? Just wondering if there is an easy way to fix that and avoid having the check twi

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

whisperity updated this revision to Diff 339625. whisperity added a comment. **NFC** Fix the header guard name lint again, hopefully to the proper value this time. I forgot the `CHECK` out of it... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D2068

[PATCH] D68891: Remove unnecessary triple from test

JohnTitor added a comment. Ping @cfe-commits Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68891/new/ https://reviews.llvm.org/D68891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D101070: Make `llvm_install_symlink` robust with respect to absolute dirs.

Ericson2314 created this revision. Herald added a subscriber: mgorny. Ericson2314 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. If `CMAKE_INSTALL_BINDIR` is a different absolute path per project, as it is with NixOS when

[clang] 3a46667 - [PowerPC] Add vec_roundm as alias for vec_floor in altivec.h

Author: Nemanja Ivanovic Date: 2021-04-22T10:30:59-05:00 New Revision: 3a466670595a9d4d41b1e221ac0f76183c5d096b URL: https://github.com/llvm/llvm-project/commit/3a466670595a9d4d41b1e221ac0f76183c5d096b DIFF: https://github.com/llvm/llvm-project/commit/3a466670595a9d4d41b1e221ac0f76183c5d096b.di

[clang] 51692c6 - [PowerPC] Add missing VSX guard for vec_roundm with vector double

Author: Nemanja Ivanovic Date: 2021-04-22T10:30:59-05:00 New Revision: 51692c6c630dfa9521af47b3c0c14d9f05f25375 URL: https://github.com/llvm/llvm-project/commit/51692c6c630dfa9521af47b3c0c14d9f05f25375 DIFF: https://github.com/llvm/llvm-project/commit/51692c6c630dfa9521af47b3c0c14d9f05f25375.di

[clang] 1550c47 - [PowerPC] Add vec_roundp as alias for vec_ceil

Author: Nemanja Ivanovic Date: 2021-04-22T10:30:59-05:00 New Revision: 1550c47c18f05800b20af071da50881ffd996254 URL: https://github.com/llvm/llvm-project/commit/1550c47c18f05800b20af071da50881ffd996254 DIFF: https://github.com/llvm/llvm-project/commit/1550c47c18f05800b20af071da50881ffd996254.di

[clang] a1d325a - [PowerPC] Add vec_roundz as alias for vec_trunc in altivec.h

Author: Nemanja Ivanovic Date: 2021-04-22T10:31:00-05:00 New Revision: a1d325af6708ebd8ac9efb8d2d148f16feeda3fd URL: https://github.com/llvm/llvm-project/commit/a1d325af6708ebd8ac9efb8d2d148f16feeda3fd DIFF: https://github.com/llvm/llvm-project/commit/a1d325af6708ebd8ac9efb8d2d148f16feeda3fd.di

[clang] a0e6189 - [PowerPC] Add vec_xlds to altivec.h

Author: Nemanja Ivanovic Date: 2021-04-22T10:31:00-05:00 New Revision: a0e6189712297fd9a25723384039418bc68e8e9f URL: https://github.com/llvm/llvm-project/commit/a0e6189712297fd9a25723384039418bc68e8e9f DIFF: https://github.com/llvm/llvm-project/commit/a0e6189712297fd9a25723384039418bc68e8e9f.di

[clang] e43963d - [PowerPC] Add vec_load_splats to altivec.h

Author: Nemanja Ivanovic Date: 2021-04-22T10:31:00-05:00 New Revision: e43963db24f68582edba8b227432714c60eac0c9 URL: https://github.com/llvm/llvm-project/commit/e43963db24f68582edba8b227432714c60eac0c9 DIFF: https://github.com/llvm/llvm-project/commit/e43963db24f68582edba8b227432714c60eac0c9.di

[clang] 1cc1d9d - [PowerPC] Add vec_vclz as an alias for vec_cntlz in altivec.h

Author: Nemanja Ivanovic Date: 2021-04-22T10:31:00-05:00 New Revision: 1cc1d9db286c7fbd0ff0a0757c2da2a5a6fc54a8 URL: https://github.com/llvm/llvm-project/commit/1cc1d9db286c7fbd0ff0a0757c2da2a5a6fc54a8 DIFF: https://github.com/llvm/llvm-project/commit/1cc1d9db286c7fbd0ff0a0757c2da2a5a6fc54a8.di

[clang] 7a5641d - [PowerPC] Add missing casts for vec_xlds and vec_load_splats

Author: Nemanja Ivanovic Date: 2021-04-22T10:31:00-05:00 New Revision: 7a5641d651963e91b05f25667df6cc694503248f URL: https://github.com/llvm/llvm-project/commit/7a5641d651963e91b05f25667df6cc694503248f DIFF: https://github.com/llvm/llvm-project/commit/7a5641d651963e91b05f25667df6cc694503248f.di

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

jdoerfert added a comment. What is missing or not working in the IRBuilder impl that prevents us from turning it on by default? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91054/new/ https://reviews.llvm.org/D91054 _

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

AMDChirag added a comment. In D91054#2708873 , @jdoerfert wrote: > What is missing or not working in the IRBuilder impl that prevents us from > turning it on by default? Per the `TODO` in this patch (`CGStmtOpenMP.cpp - 3775`), `PrivatizationCallback` i

[PATCH] D101077: [clang][nfc] Split getOrCheckAMDGPUCodeObjectVersion

JonChesterfield created this revision. JonChesterfield added reviewers: yaxunl, t-tye, kzhuravl, ronlieb, b-sumner, pdhaliwal. Herald added subscribers: kerbowa, tpr, dstuttard, nhaehnle, jvesely. JonChesterfield requested review of this revision. Herald added subscribers: cfe-commits, wdng. Heral

[PATCH] D100981: Delete le32/le64 targets

abadams added a comment. In D100981#2706899 , @dschuff wrote: > Thanks. I had heard in the past that there were some other folks who had used > le32/le64 as a "generic" target (in fact that's why it's named so > generically, rather than being called "pn

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

jdoerfert marked an inline comment as done. jdoerfert added a comment. In D101030#2708277 , @ABataev wrote: > Could you check that it does not break the tests from > https://github.com/clang-ykt/omptests? IIRC, "ref" was introduced to fix a > bug with t

[PATCH] D101077: [clang][nfc] Split getOrCheckAMDGPUCodeObjectVersion

JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1597 + +if (CodeObjArg->getOption().getID() == +options::OPT_mcode_object_version_EQ) { This would probably be more useful if it diagnosed an invalid argumen

[PATCH] D101023: [Driver] Specify -ccc-install-dir for linux-cross test

MaskRay added inline comments. Comment at: clang/test/Driver/linux-cross.cpp:5 // RUN: %clang -### %s --target=x86_64-linux-gnu --sysroot=%S/Inputs/debian_multiarch_tree \ -// RUN: -resource-dir=%S/Inputs/resource_dir --stdlib=platform --rtlib=platform 2>&1 | FileCheck %s --

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

ABataev added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2134-2151 +Sema::DeclareTargetContextInfo *DTCI = +new Sema::DeclareTargetContextInfo(DKind, DTLoc); +if (HasClauses) + ParseOMPDeclareTargetClauses(*DTCI); // Skip the last ann

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

Anastasia added inline comments. Comment at: clang/include/clang/AST/Type.h:493 + // Default is a superset of SYCL address spaces. + (A == LangAS::Default && +(B == LangAS::sycl_private || B == LangAS::sycl_local || bader wrote: >

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 339626. Ericson2314 added a comment. Recombind revisions, need to convert everything at once Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-ex

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 339639. Ericson2314 added a comment. Resplit on @LebedevRI's advice that it's OK if not all patches build alone Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 File

[PATCH] D100826: [Debug-Info][NFC] add -gstrict-dwarf support in backend

dblaikie accepted this revision. dblaikie added a comment. Sounds good - probably only need one test file, rather than two - can put a bunch of strict-dwarf related testing in that one file (& honestly, maybe don't even need to test every DWARF attribute gets the right handling if the handling

[PATCH] D69498: IR: Invert convergent attribute handling

arsenm added a comment. In D69498#2707100 , @sameerds wrote: >>> 1. The meaning of the `convergent` attribute has always been >>> target-dependent. >>> 2. Dependence on TTI is not a real cost at all. We may eventually update >>> every use of isConvergent

[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

xbolva00 added a comment. Ping @arthur.j.odwyer Comment at: clang/include/clang/Basic/DiagnosticGroups.td:158 +def DeprecatedCopy : DiagGroup<"deprecated-copy", [DeprecatedCopyUserProvided]>; +def DeprecatedCopyDtor : DiagGroup<"deprecated-copy-dtor", [DeprecatedCopyDtorUserP

[PATCH] D101037: [clang-tidy] Change shebang from python to python3

keith added a comment. I also have this patch https://reviews.llvm.org/D100692 which changes run-clang-tidy.py this way as well, specifically because it utilizes some python3 features in shutil.which Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D100981: Delete le32/le64 targets

srj added a comment. Any chance that this could be (temporarily) reverted? This will break literally all Halide compilation; we're working on a fix on our side, but it would be nice to have a few days to be sure we have it right, and I suspect there's no urgency to removing this right now. Re

[PATCH] D101043: [OpenCL] Drop extension pragma handling for extension types/declarations

mantognini added a comment. Reasoning and strategy looks sensible to me. I'm not formally approving the patch because I feel I'm not familiar enough with the code base to do that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101043/new/ https://reviews.llvm.org/D101043 __

[PATCH] D100860: [C++4OpenCL] Add missing OpenCL specific diagnostics in templates

olestrohm added a comment. The only ones that change (in the test cases at least) are as follows: Here Old is with the current change, and New is with the call to `diagnoseOpenCLTypes` at parsing removed. In `event_t.cl`, `event_t glb_evt;` in program scope has this difference: Old: the '

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2134-2151 +Sema::DeclareTargetContextInfo *DTCI = +new Sema::DeclareTargetContextInfo(DKind, DTLoc); +if (HasClauses) + ParseOMPDeclareTar

[PATCH] D99741: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions. (vfclass, vfmerge, vfrec7, vfrsqrt7, vfsqrt)

thakis added a comment. In D99741#2701918 , @craig.topper wrote: > In D99741#2701398 , @thakis wrote: > I think maybe reverting is not a good idea if we have a good progress on this slow down issue. >>>

[PATCH] D100985: [OpenCL] Remove pragma requirement for functions from Arm dot extension

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100985/new/ https://reviews.llvm.org/D100985 ___ cfe-commits mailing list cfe-

[PATCH] D100860: [C++4OpenCL] Add missing OpenCL specific diagnostics in templates

svenvh added a comment. In D100860#2709057 , @olestrohm wrote: > The first on explains that `event_t` can't be used in program scope at all, > which is better I think. Agreed, removing the parser check gives a worse diagnostic here. The underlying prob

[PATCH] D100981: Delete le32/le64 targets

MaskRay added a comment. Herald added a subscriber: tmatheson. In D100981#2709044 , @srj wrote: > Any chance that this could be (temporarily) reverted? This will break > literally all Halide compilation; we're working on a fix on our side, but it > woul

[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

Quuxplusone accepted this revision. Quuxplusone added a comment. This revision is now accepted and ready to land. The new individual test files are awesome. :) The name of the `-W` options still aren't perfect IMHO, but maybe it will never be perfect, and meanwhile everything else looks great.

[PATCH] D100981: Delete le32/le64 targets

srj added a comment. In D100981#2709205 , @MaskRay wrote: > In D100981#2709044 , @srj wrote: > >> Any chance that this could be (temporarily) reverted? This will break >> literally all Halide compilation; we're w

[clang] ef5e7f9 - Temporarily revert the code part of D100981 "Delete le32/le64 targets"

Author: Fangrui Song Date: 2021-04-22T10:18:44-07:00 New Revision: ef5e7f90ea4d5063ce68b952c5de473e610afc02 URL: https://github.com/llvm/llvm-project/commit/ef5e7f90ea4d5063ce68b952c5de473e610afc02 DIFF: https://github.com/llvm/llvm-project/commit/ef5e7f90ea4d5063ce68b952c5de473e610afc02.diff

[PATCH] D100124: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX redux.sync instructions

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. In D100124#2707731 , @steffenlarsen wrote: >> Do you know if any existing code already uses the __nvvm_* builtins for >> cp.async? In other words, does nvc

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

davezarzycki added a comment. This change broke multi-stage builds (even if AMDGPU is disabled as a target). The problem is that clang/tools/amdgpu-arch/AMDGPUArch.cpp can't find hsa.h. Is there a quick fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D101087: [OpenCL] Introduce new method for validating OpenCL target

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: ldrumm, jfb, yaxunl, jvesely. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Language options are not available when a targe

[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

xbolva00 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:158 +def DeprecatedCopy : DiagGroup<"deprecated-copy", [DeprecatedCopyUserProvided]>; +def DeprecatedCopyDtor : DiagGroup<"deprecated-copy-dtor", [DeprecatedCopyDtorUserProvided]>; def De

[PATCH] D101000: Coverage: Document how to collect a profile without a filesystem

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. This looks great, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101000/new/ https://reviews.llvm.org/D101000 ___ cfe-commits mailing lis

[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

azabaznov added a comment. Please see https://reviews.llvm.org/D101087. I think unifying with target features requires more effort than it seemed because target features are declared in LLVM (see for example //AMDGPUFeatureKV // in //AMDGPUGenSubtargetInfo.inc//, //llvm/lib/Target/AMDGPU/AMDGPU

[PATCH] D100981: Delete le32/le64 targets

dschuff added a comment. Would it make sense for you to to upstream an LLVM target such as le32-halide? (Or perhaps even arm32-halide or some other?) Then you'd actually have more control over your own codegen, datalayout, etc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101089: [OpenCL] Document legacy atomics with generic address space

Anastasia created this revision. Anastasia added a reviewer: svenvh. Herald added subscribers: ebevhan, jfb, yaxunl. Anastasia requested review of this revision. There were multiple requests from the developers to allow this functionality in OpenCL https://github.com/KhronosGroup/OpenCL-Docs/iss

[PATCH] D101037: [clang-tidy] Change shebang from python to python3

tdl-g accepted this revision. tdl-g added a comment. This revision is now accepted and ready to land. I'll defer to the consensus on https://lists.llvm.org/pipermail/cfe-dev/2021-April/068047.html regarding whether or not there are gotchas for requiring python3,, but assuming tests have confirm

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader marked 2 inline comments as done. bader added inline comments. Comment at: clang/include/clang/AST/Type.h:493 + // Default is a superset of SYCL address spaces. + (A == LangAS::Default && +(B == LangAS::sycl_private || B == LangAS::sycl_local

[clang] 37e1458 - [NFC] Remove reference to file deleted by D100981.

Author: Vitaly Buka Date: 2021-04-22T10:40:18-07:00 New Revision: 37e1458128556ae153313cdb7e085907dff5bb8b URL: https://github.com/llvm/llvm-project/commit/37e1458128556ae153313cdb7e085907dff5bb8b DIFF: https://github.com/llvm/llvm-project/commit/37e1458128556ae153313cdb7e085907dff5bb8b.diff L

[PATCH] D101023: [Driver] Specify -ccc-install-dir for linux-cross test

phosek updated this revision to Diff 339716. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101023/new/ https://reviews.llvm.org/D101023 Files: clang/test/Driver/linux-cross.cpp Index: clang/test/Driver/linux-cross.cpp ===

[PATCH] D98746: [clang][amdgpu] Use implicit code object default

JonChesterfield added a comment. Posted D101077 which is a refactor. Expect to shortly post a replacement for this which implements @yaxunl's suggestion above, i.e. pass the argument to llc whenever the user specified one to clang Repository: rG LLVM Github

[PATCH] D100981: Delete le32/le64 targets

thakis added a comment. maskray: your undelete didn't add back BuiltinsLe64.def so builds are broken atm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100981/new/ https://reviews.llvm.org/D100981 ___ cfe

[PATCH] D100981: Delete le32/le64 targets

MaskRay added a comment. In D100981#2709450 , @thakis wrote: > maskray: your undelete didn't add back BuiltinsLe64.def so builds are broken > atm Fixed by vitalybuka Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D101023: [Driver] Specify -ccc-install-dir for linux-cross test

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. With a nit Comment at: clang/test/Driver/linux-cross.cpp:16 +/// We set explicit -ccc-install-dir ensure that Clang does not pick up extra +/// library directories which ma

  1   2   3   >