Anastasia added a comment. In D100984#2708168 <https://reviews.llvm.org/D100984#2708168>, @azabaznov wrote:
>> Btw I am not suggesting removing the pragma. We will still have to parse it >> for backward compatibility. I am only dropping the requirement of using it >> in order to call get_kernel_max_sub_group_size_for_ndrange or >> get_kernel_sub_group_count_for_ndrange when the extension is supported. >> Because I don't see why this would be needed especially that all other >> functions from subgroups can be called without the pragma >> https://godbolt.org/z/MYavchPT3. > > Oh! I didn't get that! I see another one https://godbolt.org/z/3GPW31W9c, > https://godbolt.org/z/dYasedxjx. This is also fixed with your patch, right? True, I have forgotten about those. :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100984/new/ https://reviews.llvm.org/D100984 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
