[PATCH] D99458: [clang-format] Fix east const pointer alignment of operators

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This LGTM, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99458/new/ https://reviews.llvm.org/D99458 ___ cfe-commits maili

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

bader created this revision. bader added reviewers: Anastasia, keryell, Naghasan. Herald added subscribers: ebevhan, yaxunl. bader requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Repository: rG

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

bader updated this revision to Diff 333780. bader added a comment. Move address space handling section to https://reviews.llvm.org/D99488 to address https://reviews.llvm.org/D89909#2653452. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99190/new/

[PATCH] D99489: [clang] [PR49736] [C++2b] Correctly reject lambdas with requires clause and no parameter list

curdeius created this revision. curdeius added reviewers: aaron.ballman, rsmith. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes http://llvm.org/PR49736 caused by implementing http://wg21.link/P1102 (https://reviews.ll

[PATCH] D99262: [analyzer] Fix dead store checker false positive

vsavchenko updated this revision to Diff 333789. vsavchenko added a comment. Add comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99262/new/ https://reviews.llvm.org/D99262 Files: clang/lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp c

[PATCH] D99262: [analyzer] Fix dead store checker false positive

vsavchenko updated this revision to Diff 333793. vsavchenko added a comment. Add another test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99262/new/ https://reviews.llvm.org/D99262 Files: clang/lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp

[PATCH] D97361: [clang-tidy] Add readability-redundant-using check

nullptr.cpp added a comment. In D97361#2609616 , @nullptr.cpp wrote: > - Restrict to only run on C++ code > - Ignore `using` defined in macro > - Support inline namespace > - Support global namespace Ping. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D99260: [analyzer] Fix false positives in inner pointer checker (PR49628)

vsavchenko added a comment. In D99260#2650201 , @steakhal wrote: > I recommend splitting this into two. I would happily accept the part about > `std::data()`. > > IMO `std::addressof()` should be modelled via `evalCall` as a pure function, > instead of h

[PATCH] D95460: [flang][driver] Add forced form flags and -ffixed-line-length

awarzynski added a comment. Hi @protze.joachim , Interestingly, GCC does not _error_ when using `gfortran` flags: $ gcc -ffree-form file.c cc1: warning: command line option ‘-ffree-form’ is valid for Fortran but not for C I've implemented similar behavior for Clang in https://reviews.llvm

[PATCH] D99320: [RISCV] [1/2] Add intrinsic for Zbb extension

LevyHsu updated this revision to Diff 333798. LevyHsu added a comment. 1. Generated with git format-patch -o patches/ -2 HEAD -U99 2. clang/lib/Sema/SemaChecking.cpp - Rewrote CheckRISCVBuiltinFunctionCall 3. clang/lib/CodeGen/CGBuiltin.cpp - IntrinsicTypes = {ResultType}; 4. llvm/include/

[PATCH] D99152: [AMX] Prototype for vector and amx bitcast.

fhahn added a comment. In D99152#2649520 , @LuoYuanke wrote: > In D99152#2647681 , @fhahn wrote: > >> I can't see any `load <256 x i32>` in the linked example, just a store. >> Could you check the example? > > I cr

[PATCH] D99319: [RISCV] [2/2] Add intrinsic for Zbb extension

LevyHsu updated this revision to Diff 333801. LevyHsu added a comment. 1. Generated with git format-patch -o patches/ -2 HEAD -U99 2. clang/lib/Headers/riscv_zbb_intrin.h - Added corresponding 32/64 orcb intrinsic - include error message when user include this file directly. Repository:

[PATCH] D99152: [AMX] Prototype for vector and amx bitcast.

lebedev.ri added a comment. In D99152#2655274 , @fhahn wrote: > In D99152#2649520 , @LuoYuanke wrote: > >> In D99152#2647681 , @fhahn wrote: >> >>> I can't see any `load <256

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

Anastasia added a comment. Thanks. I am guessing you will address relevant review comments from D99190 in here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99488/new/ https://reviews.llvm.org/D99488 ___

[PATCH] D98616: [RISCV] Add inline asm constraint 'v' in Clang for RISC-V 'V'.

HsiangKai updated this revision to Diff 333806. HsiangKai added a comment. Use 'vr' for vector registers and 'vm' for vector mask registers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98616/new/ https://reviews.llvm.org/D98616 Files: clang/li

[PATCH] D99292: [flang][driver] Add support for `-cpp/-nocpp`

awarzynski updated this revision to Diff 333807. awarzynski added a comment. Address PR comments + updated comments + rebase I refined some comments and added `-fpp` to the list of file extensions. Thank you @kiranchandramohan for pointing this out! Repository: rG LLVM Github Monorepo CHANG

[PATCH] D98146: OpaquePtr: Turn inalloca into a type attribute

ostannard added a comment. I've reverted this (07e46367bae ) because it was causing Bindings/Go/go.test to fail on the buoldbots. Example failure at http://lab.llvm.org:8011/#/builders/107/builds/6075. CHANGES SINCE LAST ACT

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

bader added a comment. In D99488#2655326 , @Anastasia wrote: > Thanks. I am guessing you will address relevant review comments from D99190 > in here? Yes. I'm working on it. I wanted to make it in a separate update, so i

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

Anastasia added a comment. In D99488#2655342 , @bader wrote: > In D99488#2655326 , @Anastasia wrote: > >> Thanks. I am guessing you will address relevant review comments from D99190 >>

[PATCH] D99152: [AMX] Prototype for vector and amx bitcast.

fhahn added a comment. In D99152#2655304 , @lebedev.ri wrote: > In D99152#2655274 , @fhahn wrote: > >> In D99152#2649520 , @LuoYuanke >> wrote: >> >>> In D99152#2647681

[PATCH] D99152: [AMX] Prototype for vector and amx bitcast.

lebedev.ri added a comment. In D99152#2655357 , @fhahn wrote: > In D99152#2655304 , @lebedev.ri > wrote: > >> In D99152#2655274 , @fhahn wrote: >> >>> In D99152#2649520

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 created this revision. Herald added subscribers: libc-commits, libcxx-commits, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, kerbowa, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, csigg, antiagainst, shauheen, rriddle, mehdi_a

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

lebedev.ri added a comment. Thank you! The changes here look about reasonable to me. I have not checked if there are some changes that were missed. Usage of `CMAKE_INSTALL_FULL_` is suspect to me. Are you sure those are correct? Comment at: compiler-rt/cmake/Modules/AddCompiler

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 333810. serge-sans-paille added a comment. Adress final(?) comments from @rsmith and @aaron.ballman : Don't warn on argument (or template argument) of top-level decl. Extra test cases Return an enumeration as part of the test CHANGES SINCE LAST ACT

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille marked 10 inline comments as done. serge-sans-paille added inline comments. Comment at: clang/include/clang/AST/Decl.h:82 +enum ReservedIdentifierReason { + StartsWithUnderscoreAtGlobalScope, + StartsWithDoubleUnderscore, aaron.ballman wrote:

[PATCH] D99456: [C++2b] Support size_t literals

AntonBikineev updated this revision to Diff 333811. AntonBikineev added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99456/new/ https://reviews.llvm.org/D99456 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td

[PATCH] D99402: [AMDGPU][OpenMP] Add /include to the search path

pdhaliwal added a comment. The general problem seems bit more involved. I am not that familiar with how other architectures/systems handle the library/include path. Simplest solution that I can propose right now is to generalise my revision to other architectures for header lookup and similarl

[PATCH] D99495: clang-format: [JS] do not collapse - - to --.

mprobst created this revision. mprobst added a reviewer: krasimir. mprobst requested review of this revision. Herald added a project: clang. In JavaScript, `- -1;` is legal syntax, the language allows unary minus. However the two tokens must not collapse together: `--1` is prefix decrement, i.e. d

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 333812. serge-sans-paille added a comment. Fix typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93095/new/ https://reviews.llvm.org/D93095 Files: clang/include/clang/AST/Decl.h clang/include/clang/Basic/DiagnosticGroups.td clang/i

[PATCH] D99152: [AMX] Prototype for vector and amx bitcast.

fhahn added a comment. In D99152#2655371 , @lebedev.ri wrote: > In D99152#2655357 , @fhahn wrote: > >> snip >> I'm not sure if the loads and store are actually incorrect. `_tile1024i ` is >> defined as `typedef

[PATCH] D99458: [clang-format] Fix east const pointer alignment of operators

curdeius added a comment. Thinking out loud, do we test `volatile` at all? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99458/new/ https://reviews.llvm.org/D99458 ___ cfe-commits mailing list cfe-commit

[PATCH] D91327: [NewPM] Redesign of PreserveCFG Checker

yrouban updated this revision to Diff 333825. yrouban added a comment. just rebased. please review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91327/new/ https://reviews.llvm.org/D91327 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/include/llvm/Passes/StandardInstrumentations.h

[PATCH] D99500: [analyzer] Support allocClassWithName in OSObjectCStyleCast checker

vsavchenko created this revision. vsavchenko added reviewers: NoQ, steakhal, xazax.hun, ASDenysPetrov. Herald added subscribers: martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision. Herald

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

Naghasan requested changes to this revision. Naghasan added a comment. This revision now requires changes to proceed. Added comment for the front end support part. I think the document present to much at once, front-end, driver, tool chains, SPIR-V backend, compiler-runtime bindings etc. It is g

[PATCH] D98798: Produce waring for performing pointer arithmetic on a null pointer.

jamieschmeiser added reviewers: rsmith, efriedma, hfinkel. jamieschmeiser added a comment. Added more reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98798/new/ https://reviews.llvm.org/D98798 _

[PATCH] D98657: [flang][driver] Add options for -Werror

arnamoy10 updated this revision to Diff 333843. arnamoy10 added a comment. Modifying the test cases to: 1. Make it work for `f18` (when `flang-new` is not installed) 2. Adding more options and one test case to check correct functionality with `PrescanAction` and `PrescanAndSemaAction` CHANGES

[PATCH] D99503: Fixes for bug 41870.

Max_S created this revision. Max_S requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Checks for newlines in option Style.EmptyLineBeforeAccessModifier are now based on the formatted new lines and not on the new lines in the file. Repository

[PATCH] D99503: Fixes for bug 41870.

Max_S added a comment. This is patch for a bug reported in 2019 https://bugs.llvm.org/show_bug.cgi?id=41870 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99503/new/ https://reviews.llvm.org/D99503 ___ c

[clang] dcf9617 - [OPENMP]Fix PR49052: Clang crashed when compiling target code with assert(0).

Author: Alexey Bataev Date: 2021-03-29T06:36:06-07:00 New Revision: dcf96178cb3490028d9e2937cd8908b7c8fc75e6 URL: https://github.com/llvm/llvm-project/commit/dcf96178cb3490028d9e2937cd8908b7c8fc75e6 DIFF: https://github.com/llvm/llvm-project/commit/dcf96178cb3490028d9e2937cd8908b7c8fc75e6.diff

[PATCH] D99445: [OPENMP]Fix PR49052: Clang crashed when compiling target code with assert(0).

This revision was automatically updated to reflect the committed changes. Closed by commit rGdcf96178cb34: [OPENMP]Fix PR49052: Clang crashed when compiling target code with assert(0). (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D99344: [Analyzer] Track RValue expressions

martong updated this revision to Diff 333848. martong added a comment. - Remove handling of assignment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99344/new/ https://reviews.llvm.org/D99344 Files: clang/lib/StaticAnalyzer/Core/BugReporterVisit

[PATCH] D99344: [Analyzer] Track RValue expressions

martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1944-1945 +return; + if (!BO->isMultiplicativeOp()) +return; + steakhal wrote: > There are only 3 multiplicative op

[PATCH] D99152: [AMX] Prototype for vector and amx bitcast.

LuoYuanke added a comment. > I think that point was not really clear during the discussion. Using `load > <256 x i32>` to lower `__tile_loadd() ` would indeed be incorrect. But I > don't think that's happening at the moment, at least going from a simple > example https://gcc.godbolt.org/z/KT5rc

[clang] 0858f0e - [SystemZ][z/OS] Set maximum value to truncate attribute aligned to for static variables on z/OS target

Author: Fanbo Meng Date: 2021-03-29T09:44:33-04:00 New Revision: 0858f0e09e33f62fc1dcc45e0bdec47eee1e23ba URL: https://github.com/llvm/llvm-project/commit/0858f0e09e33f62fc1dcc45e0bdec47eee1e23ba DIFF: https://github.com/llvm/llvm-project/commit/0858f0e09e33f62fc1dcc45e0bdec47eee1e23ba.diff LO

[PATCH] D98864: [SystemZ][z/OS] Set maximum value to truncate attribute aligned to for static variables on z/OS target

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0858f0e09e33: [SystemZ][z/OS] Set maximum value to truncate attribute aligned to for static… (authored by fanbo-meng). Repository: rG LLVM Github

[PATCH] D99421: [ASTImporter] Import member specialization/instantiation of enum decls

balazske added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:6239 +TEST_P(ASTImporterOptionSpecificTestBase, ImportEnumMemberSpecializtion) { + Decl *FromTU = getTuDecl( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

bader updated this revision to Diff 333853. bader added a comment. Applied code review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99488/new/ https://reviews.llvm.org/D99488 Files: clang/docs/SYCLSupport.md Index: clang/docs/SYCLSup

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

bader marked 8 inline comments as done. bader added a comment. @Anastasia, I've addressed the comments for the address space section in https://reviews.llvm.org/D99488. Let's move discussion there. Comment at: clang/docs/SYCLSupport.md:861 +space for types with no address spac

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

ABataev added a comment. In D99432#2654025 , @jdoerfert wrote: > In D99432#2653483 , @ABataev wrote: > >> In D99432#2653474 , @jdoerfert >> wrote: >> >>> Can we please alway

[clang] f6f21dc - [OPENMP]Fix PR49636: Assertion `(!Entry.getAddress() || Entry.getAddress() == Addr) && "Resetting with the new address."' failed.

Author: Alexey Bataev Date: 2021-03-29T06:55:57-07:00 New Revision: f6f21dcd6c2fa8e44d8c466c5db190aef42beef2 URL: https://github.com/llvm/llvm-project/commit/f6f21dcd6c2fa8e44d8c466c5db190aef42beef2 DIFF: https://github.com/llvm/llvm-project/commit/f6f21dcd6c2fa8e44d8c466c5db190aef42beef2.diff

[PATCH] D99297: [OPENMP]Fix PR49636: Assertion `(!Entry.getAddress() || Entry.getAddress() == Addr) && "Resetting with the new address."' failed.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf6f21dcd6c2f: [OPENMP]Fix PR49636: Assertion `(!Entry.getAddress() || Entry.getAddress() ==… (authored by ABataev). Repository: rG LLVM Github Mon

[PATCH] D99152: [AMX] Prototype for vector and amx bitcast.

fhahn added a comment. In D99152#2655691 , @LuoYuanke wrote: >> I think that point was not really clear during the discussion. Using `load >> <256 x i32>` to lower `__tile_loadd() ` would indeed be incorrect. But I >> don't think that's happening at the

[PATCH] D99421: [ASTImporter] Import member specialization/instantiation of enum decls

martong updated this revision to Diff 333858. martong marked an inline comment as done. martong added a comment. - Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99421/new/ https://reviews.llvm.org/D99421 Files: clang/lib/AST/ASTImporter

[PATCH] D99421: [ASTImporter] Import member specialization/instantiation of enum decls

martong added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:6239 +TEST_P(ASTImporterOptionSpecificTestBase, ImportEnumMemberSpecializtion) { + Decl *FromTU = getTuDecl( balazske wrote: > Thanks, I fixed the typo now. Repository: rG

[clang] 0411b23 - [OPENMP]Map data field with l-value reference types.

Author: Alexey Bataev Date: 2021-03-29T07:07:09-07:00 New Revision: 0411b2331916cc8c7a8be9dd0eb540b731e6d9ce URL: https://github.com/llvm/llvm-project/commit/0411b2331916cc8c7a8be9dd0eb540b731e6d9ce DIFF: https://github.com/llvm/llvm-project/commit/0411b2331916cc8c7a8be9dd0eb540b731e6d9ce.diff

[PATCH] D98812: [OPENMP]Map data field with l-value reference types.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0411b2331916: [OPENMP]Map data field with l-value reference types. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98812/new/ https://r

[PATCH] D99489: [clang] [PR49736] [C++2b] Correctly reject lambdas with requires clause and no parameter list

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1435 + +WarnIfHasCUDATargetAttr(); } else if (Tok.isOneOf(tok::kw_mutable, tok::arrow, tok::kw___attribute, Rather than add this in both branches, I'd say to hoist it out of

[PATCH] D91327: [NewPM] Redesign of PreserveCFG Checker

kuhar added a comment. Just two nits from me. I think it looks fine, but I'm not familiar with the new pass manager and don't feel confident enough to approve it. Comment at: llvm/include/llvm/Passes/StandardInstrumentations.h:134 public: static cl::opt VerifyPreservedCF

[PATCH] D99506: [OpenMP][NFC] Move the `noinline` to the parallel entry point

jdoerfert created this revision. jdoerfert added reviewers: tianshilei1992, ye-luo, JonChesterfield. Herald added subscribers: guansong, yaxunl. Herald added a reviewer: bollu. jdoerfert requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clan

[PATCH] D99508: [SystemZ][z/OS] Add test of leading zero length bitfield in const/volatile struct

fanbo-meng created this revision. fanbo-meng added a reviewer: abhina.sreeskantharajan. fanbo-meng requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D99508 Files: clang/test/C

[PATCH] D99292: [flang][driver] Add support for `-cpp/-nocpp`

tskeith added inline comments. Comment at: clang/include/clang/Driver/Options.td:4302 +def cpp : Flag<["-"], "cpp">, Group, + HelpText<"Always add standard macro predefinitions">; +def nocpp : Flag<["-"], "nocpp">, Group, This option affects command line macro d

[PATCH] D99456: [C++2b] Support size_t literals

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Thanks for working on this! I think the direction is good in general, but I think we should also add tests for use in the preprocessor (`#if 1z == 1`, etc) as well as t

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

erik.pilkington updated this revision to Diff 333862. erik.pilkington marked 4 inline comments as done. erik.pilkington added a comment. Address @aaron.ballman's review comments. Also, fix a bug where we failed to properly parse an inherited constructor declaration with a trailing attribute. CH

[PATCH] D90188: Add support for attribute 'using_if_exists'

erik.pilkington updated this revision to Diff 333873. erik.pilkington marked 4 inline comments as done. erik.pilkington added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90188/new/ https://reviews.llvm.org/D90188 Files: clang/include/clang/AST/De

[PATCH] D90188: Add support for attribute 'using_if_exists'

erik.pilkington added inline comments. Comment at: clang/test/SemaCXX/using-if-exists.cpp:11 + +using NotNS::x UIE; // expected-error{{use of undeclared identifier 'NotNS'}} +} // test_basic Quuxplusone wrote: > Do you also have a test for `using NS::NotNS::x UIE

[PATCH] D98193: [CUDA][HIP] Allow non-ODR use of host var in device

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98193/new/ https://reviews.llvm.org/D98193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D99152: [AMX] Prototype for vector and amx bitcast.

LuoYuanke added a comment. > Whether to further optimizations are correct is a different problem, but we > need a specification for the builtins, intrinsics and the type before going > any further in that direction. > > I think you need to set the input to `LLVM IR`: > https://gcc.godbolt.org/z

[PATCH] D99506: [OpenMP][NFC] Move the `noinline` to the parallel entry point

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Context in https://bugs.llvm.org/show_bug.cgi?id=49752 is that this resolves a regression in stack usage from D94315 . This change looks goo

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added a comment. @lebedev.ri Those are intentional. I changed `POLLY_INSTALL_PREFIX` and `COMPILER_RT_INSTALL_PATH` to be `""` instead of `${CMAKE_INSTALL_PREFIX}` by default. If if kept it more as it was, the GNU dir outside the prefix (as I needed to do) wouldn't work. I suppose I

[PATCH] D99489: [clang] [PR49736] [C++2b] Correctly reject lambdas with requires clause and no parameter list

curdeius added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1435 + +WarnIfHasCUDATargetAttr(); } else if (Tok.isOneOf(tok::kw_mutable, tok::arrow, tok::kw___attribute, aaron.ballman wrote: > Rather than add this in both branches, I'd say t

[PATCH] D99506: [OpenMP][NFC] Move the `noinline` to the parallel entry point

fhahn added a comment. Is it possible to add a test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99506/new/ https://reviews.llvm.org/D99506 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D99199: Make -fcrash-diagnostics-dir control the Windows (mini-)dump location

probinson updated this revision to Diff 333884. probinson added a comment. Remove ifdefs, tweak descriptions/comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99199/new/ https://reviews.llvm.org/D99199 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/crash-diagn

[PATCH] D99199: Make -fcrash-diagnostics-dir control the Windows (mini-)dump location

probinson marked 2 inline comments as done. probinson added a comment. Addressed comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99199/new/ https://reviews.llvm.org/D99199 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D99508: [SystemZ][z/OS] Add test of leading zero length bitfield in const/volatile struct

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM, have a small nit Comment at: clang/test/CodeGen/SystemZ/zos-alignment.c:26 + long:0; + short a; +} VS0; --

[PATCH] D99297: [OPENMP]Fix PR49636: Assertion `(!Entry.getAddress() || Entry.getAddress() == Addr) && "Resetting with the new address."' failed.

JonChesterfield added a comment. Nice, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99297/new/ https://reviews.llvm.org/D99297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D99506: [OpenMP][NFC] Move the `noinline` to the parallel entry point

jdoerfert added a comment. In D99506#2655948 , @fhahn wrote: > Is it possible to add a test? There is a test for the presence of noinline, let me make it more explicit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

aaron.ballman added a comment. Mostly grammar related review comments, nothing substantive. Comment at: clang/docs/SYCLSupport.md:816 +### Address spaces handling + Comment at: clang/docs/SYCLSupport.md:818 + +SYCL specification uses C++ c

[clang] f1e0c7f - [SystemZ][z/OS] Add test of leading zero length bitfield in const/volatile struct

Author: Fanbo Meng Date: 2021-03-29T12:06:30-04:00 New Revision: f1e0c7fdd72026f62e2c38ee249705fbb9213a30 URL: https://github.com/llvm/llvm-project/commit/f1e0c7fdd72026f62e2c38ee249705fbb9213a30 DIFF: https://github.com/llvm/llvm-project/commit/f1e0c7fdd72026f62e2c38ee249705fbb9213a30.diff LO

[PATCH] D99508: [SystemZ][z/OS] Add test of leading zero length bitfield in const/volatile struct

This revision was automatically updated to reflect the committed changes. Closed by commit rGf1e0c7fdd720: [SystemZ][z/OS] Add test of leading zero length bitfield in const/volatile… (authored by fanbo-meng). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D99506: [OpenMP][NFC] Move the `noinline` to the parallel entry point

jdoerfert updated this revision to Diff 333895. jdoerfert added a comment. Add test for nvptx codegen, including wrapper attribute check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99506/new/ https://reviews.llvm.org/D99506 Files: clang/lib/Co

[PATCH] D99514: [NFC] clang-formatting zos-alignment.c

fanbo-meng created this revision. fanbo-meng added a reviewer: abhina.sreeskantharajan. fanbo-meng requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D99514 Files: clang/test/C

[PATCH] D99297: [OPENMP]Fix PR49636: Assertion `(!Entry.getAddress() || Entry.getAddress() == Addr) && "Resetting with the new address."' failed.

tra added a comment. LGTM for CUDA. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99297/new/ https://reviews.llvm.org/D99297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] 9320ac9 - [Clang] Only run test when X86 backend is built.

Author: Florian Hahn Date: 2021-03-29T17:27:01+01:00 New Revision: 9320ac9b4965d769632398b620ca3e4af9b56b12 URL: https://github.com/llvm/llvm-project/commit/9320ac9b4965d769632398b620ca3e4af9b56b12 DIFF: https://github.com/llvm/llvm-project/commit/9320ac9b4965d769632398b620ca3e4af9b56b12.diff

[PATCH] D99489: [clang] [PR49736] [C++2b] Correctly reject lambdas with requires clause and no parameter list

curdeius updated this revision to Diff 333910. curdeius added a comment. - Hoist common code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99489/new/ https://reviews.llvm.org/D99489 Files: clang/lib/Parse/ParseExprCXX.cpp clang/test/Parser/cx

[clang] d3ff65d - [Clang] Fix line numbers in CHECK lines.

Author: Florian Hahn Date: 2021-03-29T17:37:48+01:00 New Revision: d3ff65dc11d797c39bb44621d64eb679c09207de URL: https://github.com/llvm/llvm-project/commit/d3ff65dc11d797c39bb44621d64eb679c09207de DIFF: https://github.com/llvm/llvm-project/commit/d3ff65dc11d797c39bb44621d64eb679c09207de.diff

[PATCH] D99278: [clang][parser] Allow GNU-style attributes in struct declarations

aaron.ballman added a comment. To be clear, this is expected to be an NFC change that allows D97362 to be applied without breaking bots? If so, it'd be helpful to have the changes as part of D97362 because they're critical to t

[PATCH] D99338: [clang][parser] Allow GNU-style attributes in enum specifiers

aaron.ballman added a comment. To be clear, this is expected to be an NFC change that allows D97362 to be applied without breaking bots? If so, it'd be helpful to have the changes as part of D97362 because they're critical to t

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

Naghasan added inline comments. Comment at: clang/docs/SYCLSupport.md:914-919 +Default address space represents "Generic-memory", which is a virtual address +space which overlaps the global, local and private address spaces. SYCL mode +enables conversion to/from default address s

[PATCH] D98146: OpaquePtr: Turn inalloca into a type attribute

dblaikie added a comment. In D98146#2654598 , @arsenm wrote: > 4fefed65637ec46c8c2edad6b07b5569ac61e9e5 > Please include the "Differential Revision: ..." line in the commit message - i

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman created this revision. haberman added reviewers: rsmith, aaron.ballman. haberman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a Clang-only change and depends on the existing "musttail" support already implemented in LLVM

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman updated this revision to Diff 333914. haberman added a comment. - Updated formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/ https://reviews.llvm.org/D99517 Files: clang/include/clang/Basic/Attr.td clang/include/clan

[PATCH] D99353: [driver] Make `clang` warn rather then error on `flang` options

protze.joachim added a comment. Thank you for working on this! It works for me. As you mentioned in D95460 , this makes the behavior more similar to gcc. I tested with `-Werror`: $ flang -fopenmp test-f77.f -ffree-form -c $ clang -fopenmp test-f77.o -ffree-f

[PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

rnk added a comment. In D99426#2653725 , @MaskRay wrote: > This touches a lot of files. I am a bit worried that it would not be easy for > a contributor to know OF_TextWithCRLF is needed to make SystemZ happy. Right, we need to separate text-ness for Sys

[PATCH] D99514: [NFC] clang-formatting zos-alignment.c

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99514/new/ https://reviews.llvm.org/D99514 ___

[PATCH] D17183: Make TargetInfo store an actual DataLayout instead of a string.

rnk added a comment. I think 1 is OK as long as we can assert that things don't get out of sync. I like the idea of putting the prefix next to the data layout string. In the long run, splitting up Support might be reasonable, and pushing DataLayout down out of IR seems like something that could

[PATCH] D98193: [CUDA][HIP] Allow non-ODR use of host var in device

tra added a comment. I think we also may want to check that we allow `sizeof(host_var)` in the GPU code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98193/new/ https://reviews.llvm.org/D98193 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

mizvekov updated this revision to Diff 333925. mizvekov added a comment. Small update making some invariants more clear, with some simplifications. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99005/new/ https://reviews.llvm.org/D99005 Files: c

[PATCH] D99521: [OPENMP]Fix PR48885: Crash in passing firstprivate args to tasks on Apple M1.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a project: clang. Need to bitcast the function pointer passed as a parameter to the real type to avoid possible problem with calli

[PATCH] D99320: [RISCV] [1/2] Add intrinsic for Zbb extension

craig.topper added inline comments. Comment at: clang/include/clang/Basic/BuiltinsRISCV.def:21 +// Zbb extension +TARGET_BUILTIN(__builtin_riscv_orc_b, "LiLi", "nc", "experimental-zbb") +TARGET_BUILTIN(__builtin_riscv32_orc_b, "ZiZi", "nc", "experimental-zbb") Ca

[PATCH] D98193: [CUDA][HIP] Allow non-ODR use of host var in device

yaxunl added a comment. In D98193#2656326 , @tra wrote: > I think we also may want to check that we allow `sizeof(host_var)` in the GPU > code. We have tests for that at line 94 of test/SemaCUDA/device-use-host-var.cu CHANGES SINCE LAST ACTION https:

  1   2   >