rnk added a comment.

I think 1 is OK as long as we can assert that things don't get out of sync. I 
like the idea of putting the prefix next to the data layout string.

In the long run, splitting up Support might be reasonable, and pushing 
DataLayout down out of IR seems like something that could happen at that time. 
I would like to reduce the set of things that tablgen depends on by making 
Support into a smaller library of just system APIs and data structures, moving 
everything else out. Maybe the right way to do that is to leave Support as the 
ambiguous, kitchen sink library, and make a smaller, more targeted library 
under it. We already have the notion of the ADT library in our header structure 
for data structures. We used to have the System library before it was merged 
with Support. I think the only thing blocking this refactoring is the will to 
disentangle the circular dependencies.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D17183/new/

https://reviews.llvm.org/D17183

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D17183: Ma... Reid Kleckner via Phabricator via cfe-commits

Reply via email to