[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8198d83965ba: [X86] Pass to transform amx intrinsics to scalar operation. (authored by LuoYuanke, committed by yubing). Changed prior to commit: h

[PATCH] D98012: [RFC][doc] Document that RISC-V's __fp16 has different behavior

kito-cheng created this revision. Herald added subscribers: vkmr, luismarques, sameer.abuasal, s.egerton, Jim, PkmX, rogfer01, shiva0217, simoncook. kito-cheng requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. RISC-V has a draft extension fo

[PATCH] D97950: [clangd] Rename Module -> FeatureModule to avoid confusion. NFC

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97950/new/ https://reviews.llvm.org/D97950

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

steakhal added a comment. In D96976#2605313 , @RedDocMD wrote: > Talking on the mailing list, I got a link on reinterpret_casting for > pointer-to-member: > https://timsong-cpp.github.io/cppwp/n4861/expr.reinterpret.cast#10 > The gist is that this sort

[PATCH] D97916: [Driver][RISCV] Support parsing multi-lib config from GCC.

khchen added a comment. Overall LGTM. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1604 + const Arg *A = Args.getLastArg(clang::driver::options::OPT_gcc_toolchain); + if (A) { +GCCPath = findGCCPath(D, A->getValue()); khchen wrote: > if (const Arg *A =

[PATCH] D97928: [AMDGPU] Restore the s_memtime instruction in gfx1030

foad updated this revision to Diff 328429. foad added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add clang changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97928/new/ https://reviews.llvm.org/D97928 Fil

[clang-tools-extra] a60d06d - [clangd] Rename Module -> FeatureModule to avoid confusion. NFC

Author: Sam McCall Date: 2021-03-05T10:04:00+01:00 New Revision: a60d06d8b757b656726b70e83e76417297c7057b URL: https://github.com/llvm/llvm-project/commit/a60d06d8b757b656726b70e83e76417297c7057b DIFF: https://github.com/llvm/llvm-project/commit/a60d06d8b757b656726b70e83e76417297c7057b.diff LO

[PATCH] D97950: [clangd] Rename Module -> FeatureModule to avoid confusion. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa60d06d8b757: [clangd] Rename Module -> FeatureModule to avoid confusion. NFC (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D98018: [Fuchsia] Enable Polly for first stage as well

phosek created this revision. phosek added a reviewer: leonardchan. Herald added a subscriber: mgorny. Herald added a reviewer: bollu. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We want Polly enabled for both stages of the toolc

[PATCH] D97927: [clang-format] Rename case sorting

kentsommer accepted this revision. kentsommer added a comment. LGTM Sorry for the slow response! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97927/new/ https://reviews.llvm.org/D97927 ___ cfe-commits

[PATCH] D98022: [clang] Fix typos in the default logic for CLANG_DEFAULT_UNWINDLIB

mstorsjo created this revision. mstorsjo added reviewers: saugustine, MaskRay, phosek. Herald added a subscriber: mgorny. mstorsjo requested review of this revision. Herald added a project: clang. CLANG_DEFAULT_RTLIB had a typo, and libunwind isn't a valid option for it. This keeps the practical

[clang] fcf75ae - [clang][cli] Fix generation of '-fvisibility' with regards to '-mignore-xcoff-visibility'

Author: Jan Svoboda Date: 2021-03-05T10:57:06+01:00 New Revision: fcf75ae6ce20e3575b1464ce724619f38c43edd2 URL: https://github.com/llvm/llvm-project/commit/fcf75ae6ce20e3575b1464ce724619f38c43edd2 DIFF: https://github.com/llvm/llvm-project/commit/fcf75ae6ce20e3575b1464ce724619f38c43edd2.diff L

[PATCH] D97552: [clang][cli] Fix generation of '-fvisibility' with regards to '-mignore-xcoff-visibility'

This revision was automatically updated to reflect the committed changes. Closed by commit rGfcf75ae6ce20: [clang][cli] Fix generation of '-fvisibility' with regards to '-mignore-xcoff… (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D97552?vs=326676&id=328448#toc

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

nicolasvasilache added a comment. This seems to break the build https://buildkite.com/mlir/mlir-core/builds/12026#91ec4dfe-542f-4312-92db-7d555f05ce06. I could repro locally, reverting locally fixes the build. Please address, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] 4295ae9 - [clang][modules] Use extensible RTTI for ModuleFileExtension

Author: Jan Svoboda Date: 2021-03-05T11:11:05+01:00 New Revision: 4295ae96cdf275cdda8bded9271960a4cac11fb2 URL: https://github.com/llvm/llvm-project/commit/4295ae96cdf275cdda8bded9271960a4cac11fb2 DIFF: https://github.com/llvm/llvm-project/commit/4295ae96cdf275cdda8bded9271960a4cac11fb2.diff L

[PATCH] D97702: [clang][modules] Use extensible RTTI for ModuleFileExtension

This revision was automatically updated to reflect the committed changes. Closed by commit rG4295ae96cdf2: [clang][modules] Use extensible RTTI for ModuleFileExtension (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D97702?vs=327163&id=328453#toc Repository: rG

[PATCH] D98023: [clang] Don't make the g++ driver imply an explicitly shared libunwind

mstorsjo created this revision. mstorsjo added reviewers: mati865, rnk, saugustine, phosek. mstorsjo requested review of this revision. Herald added a project: clang. The logic in getLibGccType, to have the g++ driver mode imply a shared libgcc, originally was to match GCC driver behaviour for li

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

jansvoboda11 added a comment. FYI, this might need rebasing on top of D97552 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89986/new/ https://reviews.llvm.org/D89986 _

[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

jansvoboda11 updated this revision to Diff 328460. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97462/new/ https://reviews.llvm.org/D97462 Files: clang/CMakeLists.txt Index: clang/CMakeLists.txt ==

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

RKSimon added a comment. @yubing I've reverted this as it was failing on a lot of buildbots: http://lab.llvm.org:8011/#/builders/109/builds/9867 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93594/new/ https://reviews.llvm.org/D93594

[PATCH] D98029: [clangd] Introduce a CommandLineConfigProvider

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This enables unifying command line flags wi

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

Anastasia added a comment. In D89909#2600859 , @aaron.ballman wrote: > Just a few minor nits from me, but I'm mostly wondering: where are we at with > this and are there still substantive changes required? (I looked through the > comments, but there's a

[PATCH] D98030: [IR] Add vscale_range IR function attribute

bsmith created this revision. bsmith added reviewers: paulwalker-arm, joechrisellis, peterwaller-arm. Herald added subscribers: dexonsmith, jdoerfert, steven_wu, hiraditya. bsmith requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-comm

[clang] 9b30251 - [AArch64] Add missing intrinsics for vrnd

Author: Jingu Kang Date: 2021-03-05T11:26:12Z New Revision: 9b302513f6d82f0ca989b3bb1f5ffc592ed866b7 URL: https://github.com/llvm/llvm-project/commit/9b302513f6d82f0ca989b3bb1f5ffc592ed866b7 DIFF: https://github.com/llvm/llvm-project/commit/9b302513f6d82f0ca989b3bb1f5ffc592ed866b7.diff LOG: [A

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

davezarzycki added a comment. In D93594#2606157 , @RKSimon wrote: > @yubing I've reverted this as it was failing on a lot of buildbots: > http://lab.llvm.org:8011/#/builders/109/builds/9867 Thanks – I was just about to point out this broke downstream tes

[PATCH] D98032: [clang-format] Improve clang-format-diff.py error message

DavidSpickett created this revision. DavidSpickett requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously if we couldn't run the clang-format command for some reason, you'd get an unhelpful error message: OSError: [Errno 2] No such f

[PATCH] D98012: [RFC][doc] Document that RISC-V's __fp16 has different behavior

SjoerdMeijer added a comment. > However we would like have slight different behavior for __fp16 other than ACLE: The evaluation format of __fp16 set same as _Float16, which means no promotion are performed if there is no hardware half-precision supported. Well, this is really problematic, becaus

[PATCH] D98030: [IR] Add vscale_range IR function attribute

sdesmalen added a comment. Thanks for this patch, it's great to have an IR attribute for this. The mechanics of this patch look mostly fine to me. I added a few more subscribers to give this some wider visibility. Comment at: llvm/docs/LangRef.rst:1998 +function. A value o

[PATCH] D98029: [clangd] Introduce a CommandLineConfigProvider

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Both side-effects seem fine to me. > EnableBackgroundIndex option controls whether the component will be created > at all Do you think we should eventually switch to always setting Cla

[PATCH] D98034: [clang-tidy] Use-after-move: Ignore moves inside a try_emplace.

mboehme created this revision. mboehme added a reviewer: sammccall. mboehme added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We have no way to reason about the

[PATCH] D73363: Verify that clang's max alignment is <= LLVM's max alignment

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGValue.h:18 #include "clang/AST/ASTContext.h" +#include "clang/Sema/Sema.h" #include "clang/AST/Type.h" rnk wrote: > This includes Sema.h into every codegen file that uses CGValue.h (most of >

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

pengfei added a comment. Thanks all for reporting and reverting this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93594/new/ https://reviews.llvm.org/D93594 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D98034: [clang-tidy] Use-after-move: Ignore moves inside a try_emplace.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice! Only substantive suggestion: I think requiring the base type to be exactly a standard map type is too conservative. Comment at: clang-tools-extra/clang-tidy/bugp

[PATCH] D98030: [IR] Add vscale_range IR function attribute

paulwalker-arm added inline comments. Comment at: llvm/docs/LangRef.rst:1998 +function. A value of 0 means unbounded. If the optional max value is omitted +then max is set to the value of min. sdesmalen wrote: > Do you need to say anything about a defa

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

abhina.sreeskantharajan requested review of this revision. abhina.sreeskantharajan added a comment. This issue has been fixed in https://reviews.llvm.org/D97472. @ASDenysPetrov I'm unable to close this revision and the other one https://reviews.llvm.org/D95808. Repository: rG LLVM Github Mono

[PATCH] D97916: [Driver][RISCV] Support parsing multi-lib config from GCC.

jrtc27 added inline comments. Comment at: clang/test/Driver/Inputs/multilib_riscv32_elf_sdk/bin/riscv32-unknown-elf-gcc:1 +#!/usr/bin/env python + Python 3 Comment at: clang/test/Driver/Inputs/multilib_riscv32_elf_sdk/bin/riscv32-unknown-elf-

[PATCH] D98037: [clangd] Add config block for Completion and option for AllScopes

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Depends on D98029

[PATCH] D98032: [clang-format] Improve clang-format-diff.py error message

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. LGTM. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98032/new/ https://reviews.llvm.org/D98032

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

Anastasia added inline comments. Comment at: clang/lib/Sema/Sema.cpp:364 for (auto &I : Atomic64BitTypes) setOpenCLExtensionForType(I, "cl_khr_int64_base_atomics cl_khr_int64_extended_atomics"); azabaznov wrote: > Anastasia wrote: > >

[PATCH] D46443: Add missing cstdalign header

ldionne requested changes to this revision. ldionne added a comment. This revision now requires changes to proceed. In D46443#2566394 , @hubert.reinterpretcast wrote: > The resolution of LWG 2828 > m

[PATCH] D97930: [OpenCL] Fix builtins that require multiple extensions

Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:21 +#if __OPENCL_C_VERSION__ <= CL_VERSION_1_2 +#pragma OPENCL EXTENSION cl_khr_3d_image_writes : enable +#endif You don't seem to be using `write_imagef` for OpenCL ve

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

This revision was automatically updated to reflect the committed changes. Closed by commit rG10264a1b21ae: Introduce noundef attribute at call sites for stricter poison analysis (authored by guiand). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8167

[PATCH] D73363: Verify that clang's max alignment is <= LLVM's max alignment

davezarzycki added inline comments. Comment at: clang/lib/CodeGen/CGValue.h:18 #include "clang/AST/ASTContext.h" +#include "clang/Sema/Sema.h" #include "clang/AST/Type.h" aaron.ballman wrote: > rnk wrote: > > This includes Sema.h into every codegen file that us

[PATCH] D73363: Verify that clang's max alignment is <= LLVM's max alignment

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGValue.h:18 #include "clang/AST/ASTContext.h" +#include "clang/Sema/Sema.h" #include "clang/AST/Type.h" davezarzycki wrote: > aaron.ballman wrote: > > rnk wrote: > > > This includes Sema.h into

[PATCH] D97869: [OpenCL][Draft] Add OpenCL builtin test generator

Anastasia added a comment. In D97869#2603249 , @azabaznov wrote: > That's awesome! > > I'm thinking of how can you track correctness of generated built-ins > according to spec.  Perhaps you can compare the number of distinct > declarations for each  buil

[PATCH] D97869: [OpenCL][Draft] Add OpenCL builtin test generator

Anastasia added a comment. In D97869#2603068 , @svenvh wrote: > In D97869#2602943 , @Anastasia wrote: > >> I was just thinking if we could combine the calls into one function to >> minimize the number of lines to p

[clang] 9c0069d - [clang-format] Improve clang-format-diff.py error message

Author: David Spickett Date: 2021-03-05T13:28:51Z New Revision: 9c0069d836b326f3ae0b92a8f095b0707a944ed0 URL: https://github.com/llvm/llvm-project/commit/9c0069d836b326f3ae0b92a8f095b0707a944ed0 DIFF: https://github.com/llvm/llvm-project/commit/9c0069d836b326f3ae0b92a8f095b0707a944ed0.diff LOG

[PATCH] D98032: [clang-format] Improve clang-format-diff.py error message

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9c0069d836b3: [clang-format] Improve clang-format-diff.py error message (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D73363: Verify that clang's max alignment is <= LLVM's max alignment

davezarzycki added inline comments. Comment at: clang/lib/CodeGen/CGValue.h:18 #include "clang/AST/ASTContext.h" +#include "clang/Sema/Sema.h" #include "clang/AST/Type.h" aaron.ballman wrote: > davezarzycki wrote: > > aaron.ballman wrote: > > > rnk wrote: > > >

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Frontend/FrontendActions.cpp:841 } } amccarth wrote: > The preceding block that detects the type of line separator seems ripe for > factoring out into a separate function. It's a lot

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

abhina.sreeskantharajan updated this revision to Diff 328483. abhina.sreeskantharajan added reviewers: amccarth, MaskRay, jhenderson. abhina.sreeskantharajan added a comment. Fix formatting from lint. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97

[PATCH] D98029: [clangd] Introduce a CommandLineConfigProvider

kadircet updated this revision to Diff 328485. kadircet marked 4 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98029/new/ https://reviews.llvm.org/D98029 Files: clang-tools-ex

[PATCH] D98010: [XCOFF] [DWARF] set default DWARF version to 3

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98010/new/ https://reviews.llvm.org/D98010 ___

[PATCH] D73363: Verify that clang's max alignment is <= LLVM's max alignment

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGValue.h:18 #include "clang/AST/ASTContext.h" +#include "clang/Sema/Sema.h" #include "clang/AST/Type.h" davezarzycki wrote: > aaron.ballman wrote: > > davezarzycki wrote: > > > aaron.ballman wr

[clang] f068656 - [OpenCL] Fix `mix` builtin overloads

Author: Sven van Haastregt Date: 2021-03-05T13:43:30Z New Revision: f0686569cc5789f93d76461143c232882b7ff2e9 URL: https://github.com/llvm/llvm-project/commit/f0686569cc5789f93d76461143c232882b7ff2e9 DIFF: https://github.com/llvm/llvm-project/commit/f0686569cc5789f93d76461143c232882b7ff2e9.diff

[clang] 258ecf5 - [HIP] do not use -mconstructor-aliases for device

Author: Yaxun (Sam) Liu Date: 2021-03-05T08:46:58-05:00 New Revision: 258ecf5f33e7b0b43bc1c7252cd84eea596c39d2 URL: https://github.com/llvm/llvm-project/commit/258ecf5f33e7b0b43bc1c7252cd84eea596c39d2 DIFF: https://github.com/llvm/llvm-project/commit/258ecf5f33e7b0b43bc1c7252cd84eea596c39d2.dif

[clang] 5b3fc71 - [HIP] do not use -munsafe-fp-atomics by default

Author: Yaxun (Sam) Liu Date: 2021-03-05T08:46:58-05:00 New Revision: 5b3fc7180c8e4a2c57946d5e3cc325744a770717 URL: https://github.com/llvm/llvm-project/commit/5b3fc7180c8e4a2c57946d5e3cc325744a770717 DIFF: https://github.com/llvm/llvm-project/commit/5b3fc7180c8e4a2c57946d5e3cc325744a770717.dif

[PATCH] D97959: [HIP] do not use -mconstructor-aliases for device

This revision was automatically updated to reflect the committed changes. Closed by commit rG258ecf5f33e7: [HIP] do not use -mconstructor-aliases for device (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D97967: [HIP] do not use -munsafe-fp-atomics by default

This revision was automatically updated to reflect the committed changes. Closed by commit rG5b3fc7180c8e: [HIP] do not use -munsafe-fp-atomics by default (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D98037: [clangd] Add config block for Completion and option for AllScopes

kadircet updated this revision to Diff 328492. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98037/new/ https://reviews.llvm.org/D98037 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-tools-extra/clang

[PATCH] D98034: [clang-tidy] Use-after-move: Ignore moves inside a try_emplace.

mboehme updated this revision to Diff 328491. mboehme added a comment. Responses to review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98034/new/ https://reviews.llvm.org/D98034 Files: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp clang-tools-extra/docs/cl

[PATCH] D98034: [clang-tidy] Use-after-move: Ignore moves inside a try_emplace.

mboehme marked 5 inline comments as done. mboehme added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp:396 void UseAfterMoveCheck::registerMatchers(MatchFinder *Finder) { + auto StandardMapMatcher = + hasType(hasUnqualifiedDesugare

[PATCH] D98039: [OpenCL] Set calling convention for -fdeclare-opencl-builtins

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added a subscriber: yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. IR produced using TableGen builtin function declarations (`fdeclare-opencl-builtins.

[PATCH] D98034: [clang-tidy] Use-after-move: Ignore moves inside a try_emplace.

njames93 requested changes to this revision. njames93 added a comment. This revision now requires changes to proceed. While `try_emplace` is a special case, it's may not be the only special case in someone's codebase, this should be behind extended with options to let users handle their special

[PATCH] D98034: [clang-tidy] Use-after-move: Ignore moves inside a try_emplace.

njames93 added a comment. In D98034#2606488 , @njames93 wrote: > While `try_emplace` is a special case, it's may not be the only special case > in someone's codebase, this should be extended with options to let users > handle their special containers.

[clang-tools-extra] e67d91f - [clang-tidy] Use-after-move: Ignore moves inside a try_emplace.

Author: Martin Boehme Date: 2021-03-05T15:05:09+01:00 New Revision: e67d91faec2183789b220c15444929fb2efa6ecd URL: https://github.com/llvm/llvm-project/commit/e67d91faec2183789b220c15444929fb2efa6ecd DIFF: https://github.com/llvm/llvm-project/commit/e67d91faec2183789b220c15444929fb2efa6ecd.diff

[PATCH] D98034: [clang-tidy] Use-after-move: Ignore moves inside a try_emplace.

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. mboehme marked 3 inline comments as done. Closed by commit rGe67d91faec21: [clang-ti

[PATCH] D73363: Verify that clang's max alignment is <= LLVM's max alignment

davezarzycki added inline comments. Comment at: clang/lib/CodeGen/CGValue.h:18 #include "clang/AST/ASTContext.h" +#include "clang/Sema/Sema.h" #include "clang/AST/Type.h" aaron.ballman wrote: > davezarzycki wrote: > > aaron.ballman wrote: > > > davezarzycki wro

[PATCH] D97850: Fix PCM read from ModuleCache for ext4 filesystem

ilyakuteev added a comment. @teemperor 's test shows the problem correctly. In my case I am working on a dist-compilation system (similar to distcc) for objective-c with `-fmodules`. Our previous generation used tmpfs for module cache and was ephemeral (Unique temp module cache per compilation)

[PATCH] D98034: [clang-tidy] Use-after-move: Ignore moves inside a try_emplace.

mboehme added a comment. In D98034#2606488 , @njames93 wrote: > While `try_emplace` is a special case, it's may not be the only special case > in someone's codebase, this should be extended with options to let users > handle their special containers. So

[PATCH] D97960: [clang-tidy] bugprone-signal-handler improvements: display call chain

njames93 added a comment. This needs tests demonstrating the notes. The defacto way is to replace all `CHECK-MESSAGES`Directives with `CHECK-NOTES`. This'll for file check to look for lines containing `note`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[clang] afa76fe - [XCOFF][DWARF] set default DWARF version to 3.

Author: Chen Zheng Date: 2021-03-05T09:21:57-05:00 New Revision: afa76fe67a42f6d40d83a4f7d0cb03373045f3f4 URL: https://github.com/llvm/llvm-project/commit/afa76fe67a42f6d40d83a4f7d0cb03373045f3f4 DIFF: https://github.com/llvm/llvm-project/commit/afa76fe67a42f6d40d83a4f7d0cb03373045f3f4.diff LO

[PATCH] D98010: [XCOFF] [DWARF] set default DWARF version to 3

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGafa76fe67a42: [XCOFF][DWARF] set default DWARF version to 3. (authored by shchenz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73363: Verify that clang's max alignment is <= LLVM's max alignment

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGValue.h:18 #include "clang/AST/ASTContext.h" +#include "clang/Sema/Sema.h" #include "clang/AST/Type.h" davezarzycki wrote: > aaron.ballman wrote: > > davezarzycki wrote: > > > aaron.ballman wr

[PATCH] D98034: [clang-tidy] Use-after-move: Ignore moves inside a try_emplace.

njames93 added a comment. In D98034#2606535 , @mboehme wrote: > In D98034#2606488 , @njames93 wrote: > >> While `try_emplace` is a special case, it's may not be the only special case >> in someone's codebase, this

[PATCH] D97960: [clang-tidy] bugprone-signal-handler improvements: display call chain

balazske added a comment. I tried to test the notes but could not get it to work. I think the problem is related to the fact that the notes are displayed at different locations that are past or before the current warning. The solution could be to manually specify line numbers in the CHECK-NOTE

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan updated this revision to Diff 328513. abhina.sreeskantharajan marked an inline comment as done. abhina.sreeskantharajan added a comment. Add assertion, add testcase for multi-line raw string Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:1367 +Converter->convert(StringRef((char *)tmp_out_start), ConvertedChar); +memmove((void *)tmp_out_start, ConvertedChar.data(), 1); + }

[PATCH] D97960: [clang-tidy] bugprone-signal-handler improvements: display call chain

njames93 added a comment. The issue is FileCheck expects its directives to be in order they appear in the file being checked. Notes are always emitted just after the warning they are attached to. So there are a few ways to go: - use CHECK-NOTES-DAG to disregard the ordering and place them next

[PATCH] D46443: Add missing cstdalign header

sbc100 updated this revision to Diff 328522. sbc100 added a comment. Herald added a project: libc++. Herald added a reviewer: libc++. Rebase against mono-repo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46443/new/ https://reviews.llvm.org/D46443

[PATCH] D46443: Add missing cstdalign header

sbc100 updated this revision to Diff 328524. sbc100 added a comment. Herald added a subscriber: mgorny. feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46443/new/ https://reviews.llvm.org/D46443 Files: libcxx/include/CMakeLists.txt libc

[PATCH] D97869: [OpenCL][Draft] Add OpenCL builtin test generator

svenvh added a comment. To be honest, I don't have a concrete picture yet of how to deploy this emitter for testing. So here are a few thoughts about the various options that come to mind: 1. Regenerate the test file every time we run check-clang and use it to validate the `-fdeclare-opencl-b

[clang-tools-extra] 3bca861 - [clang-tidy][NFC] Remove unsupported language version checks from vector

Author: Nathan James Date: 2021-03-05T15:35:34Z New Revision: 3bca86170da0a7cadb4cc13b178ff1edf162ea8e URL: https://github.com/llvm/llvm-project/commit/3bca86170da0a7cadb4cc13b178ff1edf162ea8e DIFF: https://github.com/llvm/llvm-project/commit/3bca86170da0a7cadb4cc13b178ff1edf162ea8e.diff LOG:

[PATCH] D46443: Add missing cstdalign header

curdeius added inline comments. Comment at: libcxx/include/cstdalign:19-22 + alignof + alignas +__alignof_is_defined +__alignas_is_defined You should test that each of these macros is really defined when including `cstdalign`. Comm

[clang] ed95129 - Fix Wdocumentation unknown parameter warning. NFCI.

Author: Simon Pilgrim Date: 2021-03-05T15:58:20Z New Revision: ed951293affca9abd92c886432115f35065cad3c URL: https://github.com/llvm/llvm-project/commit/ed951293affca9abd92c886432115f35065cad3c DIFF: https://github.com/llvm/llvm-project/commit/ed951293affca9abd92c886432115f35065cad3c.diff LOG:

[PATCH] D46443: Add missing cstdalign header

sbc100 added inline comments. Comment at: libcxx/test/libcxx/utilities/any/size_and_alignment.pass.cpp:16 #include +#include curdeius wrote: > This doesn't seem to be necessary. Or? > In C++, `alignof` is a keyword. You are right its not necessary in C++ sin

[PATCH] D46443: Add missing cstdalign header

sbc100 added inline comments. Comment at: libcxx/include/cstdalign:19-22 + alignof + alignas +__alignof_is_defined +__alignas_is_defined curdeius wrote: > You should test that each of these macros is really defined when including > `cstdalign`. Done.

[PATCH] D46443: Add missing cstdalign header

sbc100 updated this revision to Diff 328538. sbc100 added a comment. add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46443/new/ https://reviews.llvm.org/D46443 Files: libcxx/include/CMakeLists.txt libcxx/include/cstdalign libcxx/incl

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen updated this revision to Diff 328533. khchen added a comment. rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95016/new/ https://reviews.llvm.org/D95016 Files: clang/include/clang/Basic/BuiltinsRISCV.def clang/include/clang/Basic/

[PATCH] D98023: [clang] Don't make the g++ driver imply an explicitly shared libunwind

mati865 added a comment. It's clear overlook from D79995 , that part is perfectly reasonable to me. I'm a bit worried about this code though: bool AsNeeded = LGT == LibGccType::UnspecifiedLibGcc && !TC.getTriple().isAndroid() && !TC.getTriple

[PATCH] D97930: [OpenCL] Fix builtins that require multiple extensions

svenvh updated this revision to Diff 328549. svenvh added a comment. > You don't seem to be using write_imagef for OpenCL versions <= 1.2. But > should we be checking that the diagnostic is given? Good point, I have updated the test to check for the diagnostic. CHANGES SINCE LAST ACTION http

[PATCH] D46443: Add missing cstdalign header

ldionne requested changes to this revision. ldionne added inline comments. This revision now requires changes to proceed. Comment at: libcxx/test/std/language.support/cstdalign/cstdalign.pass.cpp:8 +//===--===//

[PATCH] D92363: [HIP] Warn no --offload-arch option

yaxunl added a comment. @tra I got some issue with this patch. There are cases that an expression using a host variable is compile-time constant, e.g. int x; __device__ void fun() { sizeof(x); } Do we want to allow that? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D92363: [HIP] Warn no --offload-arch option

yaxunl added a comment. In D92363#2607072 , @yaxunl wrote: > @tra I got some issue with this patch. There are cases that an expression > using a host variable is compile-time constant, e.g. > > int x; > __device__ void fun() { > sizeof(x); > } >

[PATCH] D91281: [CUDA][HIP] Diagnose reference of host variable

yaxunl added a comment. @tra I got some issue with this patch. There are cases that an expression using a host variable is compile-time constant, e.g. int x; __device__ void fun() { sizeof(x); } Do we want to allow that? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D95458: [PowerPC] Exploit xxsplti32dx (constant materialization) for scalars

amyk added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:1885 +let isReMaterializable = 1, isMoveImm = 1, Predicates = [PrefixInstrs] in { + def XXSPLTI32DX : I think it might be good to add a comment of why the `XXSPLTI32DX` instructi

[PATCH] D46443: Add missing cstdalign header

sbc100 marked 2 inline comments as done. sbc100 added inline comments. Comment at: libcxx/test/std/language.support/cstdalign/cstdalign.pass.cpp:14-28 +#ifdef alignas +#error alignas should not be a macro in C++ +#endif + +#ifdef alignof +#error alignof should not be a macro in C

[PATCH] D46443: Add missing cstdalign header

sbc100 updated this revision to Diff 328557. sbc100 marked 2 inline comments as done. sbc100 added a comment. feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46443/new/ https://reviews.llvm.org/D46443 Files: libcxx/include/CMakeLists.txt

[PATCH] D98055: [ExtVectorType] Support conditional select operator for C++.

fhahn created this revision. fhahn added reviewers: rjmccall, erichkeane, aaron.ballman. fhahn requested review of this revision. Herald added a project: clang. This patch implements the conditional select operator for ext_vector_types in C++. It does so by using the same semantics as for C. D714

[PATCH] D46443: Add missing cstdalign header

sbc100 updated this revision to Diff 328561. sbc100 added a comment. feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46443/new/ https://reviews.llvm.org/D46443 Files: libcxx/include/CMakeLists.txt libcxx/include/cstdalign libcxx/inclu

  1   2   >